- 23 Jul, 2018 40 commits
-
-
Ken MacKay authored
Bug: internal b/111451219 Change-Id: I9ffa8324d3392cf7ced97465c4a65fdcd8c0c00c Reviewed-on: https://chromium-review.googlesource.com/1145793 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577190}
-
Tommy C. Li authored
Seems like a long shot to fix the flakiness of this browser test, but this fixes an error anyways. Bug: 817270 Change-Id: I97bf32f5924f58e0965c80587eedd419a9739ca1 Reviewed-on: https://chromium-review.googlesource.com/1145863 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#577189}
-
Kyle Milka authored
Bug: 858885 Change-Id: I9ea772268411272c86e333ec4041b3e17b38f3af Reviewed-on: https://chromium-review.googlesource.com/1142541 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577188}
-
Aldo Culquicondor authored
Also replacing `app` by `menu` as the platform agnostic button name. This is part of an effort of splitting the monolitic VrShellGl and add tests to each part. Bug: 865486 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7aa916b61d74ddada59c4cd4c8608c1ec25a7e23 Reviewed-on: https://chromium-review.googlesource.com/1145239 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#577187}
-
Trent Apted authored
AppKit runs its sheet animation in UI-thread blocking loop. There is no way to swap in a frame from the compositor while it is running. So failing to wait means we animate a blank window. Fix by restoring the wait that regressed in r574771 Test=Bookmark Star -> More...: Ensure the window does not animate in blank. Bug: 865331 Change-Id: Ifd87944e3ae0d3af5f5b7eb8569e9a7c98e1be0c Reviewed-on: https://chromium-review.googlesource.com/1146136 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577186}
-
Ned Nguyen authored
TBR=xunjieli@chromium.org Bug:728081 Change-Id: I18ac62be4f68fb8501ab6c7064fc273b4ed58ff4 NOTRY=true # webkit_layout_tests flake crbug.com/866520 Change-Id: I18ac62be4f68fb8501ab6c7064fc273b4ed58ff4 Reviewed-on: https://chromium-review.googlesource.com/1146495 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#577185}
-
khmel@google.com authored
This is update for reland crrev.com/c/1145563 TBR=xiyuan@chromium.org Bug: 822488 Test: Manually Change-Id: If3a0ab1ff717b04a3f9c9995c0522c43fc0aba4b Reviewed-on: https://chromium-review.googlesource.com/1145787 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577184}
-
ccameron authored
This reverts commit a8bfbc28. Reason for revert: 70.0.3500.0 still exhibits these crashes Original change's description: > Disable all compositor recycling > > Previous patch to disable compositor recycling only disabled for > BridgedNativeWidget. Now disable for everything. > > TBR=ericrk > > Bug: 863817863817863817863817 > Change-Id: I09fed3b84e7df23d540c4a4db528f43efa8bac15 > Reviewed-on: https://chromium-review.googlesource.com/1146325 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577095} TBR=ccameron@chromium.org,ericrk@chromium.org Change-Id: I3672137e22f8e654192a1bcbace908b0367e7248 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863817863817863817863817 Reviewed-on: https://chromium-review.googlesource.com/1146960Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577183}
-
Ned Nguyen authored
Bug:866261 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af NOTRY=true # layout test flakiness Change-Id: I9958cd37309a866ccedf668a7471aa1e2ec3d2af Reviewed-on: https://chromium-review.googlesource.com/1146330 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#577182}
-
Lily Houghton authored
IPAddressObserver and ConnectionTypeObserver are deprecated in favor of NetworkChangeObserver. This CL replaces a class that subclasses them with an (almost identical) internal class which does not expose them directly. For more details see the design doc linked in the bug below. Bug: 754695 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic65ce6aa4df57893504e9eaf3042fb2deb355115 Reviewed-on: https://chromium-review.googlesource.com/1133325 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577181}
-
John Abd-El-Malek authored
TBR: ericorth@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I27876e432541b30a7c4832bae61e22faa37888b7 Reviewed-on: https://chromium-review.googlesource.com/1145772Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#577180}
-
Henrik Boström authored
Measures usage of the following APIs: - RTCPeerConnection.getTransceivers() - RTCPeerConneciton.addTransceiver() - RTCRtpTransceiver.direction (getter/setter) // The run was green except for unrelated failures with // mac_chromium_rel_ng that have happened on multiple CLs NOTRY=True Bug: 866433 Change-Id: I430680fa3109681c38e82a7b8d2203e7ec18544e Reviewed-on: https://chromium-review.googlesource.com/1146659 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#577179}
-
Henrik Boström authored
Historically, new stats have bypassed stats OWNERs review and made it to Chrome stable. This will cause import breakages if stats are added to the legacy getStats() API in third_party/webrtc assuming: 1. They are present in a normal call setup, i.e. shows up in the scenario modelled by: WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsGetStatsCallback 2. The new stat does not recycle an already existing whitelisted name. // The run was green except for unrelated failures with // mac_chromium_rel_ng that have happened on multiple CLs NOTRY=True Bug: 822696 Change-Id: I2e6735ae6f1b987eb64865cb510eb65a6a1e4126 Reviewed-on: https://chromium-review.googlesource.com/1146726 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#577178}
-
Patrick Monette authored
Bug: 865927 Change-Id: I0ec37849d27eb41e464cd815c8ce744d72a538f5 Reviewed-on: https://chromium-review.googlesource.com/1145134 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#577177}
-
Manu Cornet authored
Bug: 805612 Change-Id: I1ec642dd31a69a00b3c3bc56a5a43ea5f85e2985 Reviewed-on: https://chromium-review.googlesource.com/1144646 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577176}
-
Nicolas Ouellet-payeur authored
The test was missing EXPECT_*() statements on other platforms than Mac/Windows. Bug: 816389 Change-Id: Ib50b315445e810025f403faaad7bd1f288369b7f Reviewed-on: https://chromium-review.googlesource.com/1145623Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#577175}
-
Danyao Wang authored
The SlimNav experiment is hitting the CHECK(_webUsageEnabled) in -ensureWebViewCreatedWithConfiguration when loading placeholder URL while web usage is disabled. One cause for this situation is when clearing website data while an interstitial is presented over a native view. WebInterstitialImpl::DontProceed() is called after web usage is disabled and it triggers the reload of the native view, which in turn triggers the placeholder load. Deferring the load fixes the problem, because the web view is recreated immediately after. Other causes for placeholder load when web usage is disabled exist, but the causes are not fully understood. This CL fixes the crashes in these cases as well. This should uncover behavior changes, that hopefully give us more details to fix the root cause later. A downstream egtest for the interstitial case is added in http://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/654301 Bug: 865985 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I03d928ce82d128c2f67f36e204731576e479d497 Reviewed-on: https://chromium-review.googlesource.com/1145725Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577174}
-
Charlie Andrews authored
A recent bisect in the linked bug shows that it's passing again. NOTRY=true TBR=nednguyen@chromium.org Bug: 803461 Change-Id: If9e240bbb03a7941ae3fe4ea48149bfe606d9ec4 Reviewed-on: https://chromium-review.googlesource.com/1146772Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577173}
-
Jennifer Apacible authored
This change adds in KeyEvent handling to support keyboard usage with the controls buttons. They should be activated when the 'enter' or 'space' keys are used. The previous implementation of OnKeyEvent used an OverlayWindowViews tracking of which control is being focused, which is now obsolete. Bug: 866291 Change-Id: I8a59337aa7aef5c95da081a9b5f33762462eeaef Reviewed-on: https://chromium-review.googlesource.com/1146283Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577172}
-
sebsg authored
Change-Id: Ie5ed5f28bfdc5a7914dac544db17deac45e1f3b0 Reviewed-on: https://chromium-review.googlesource.com/1129044Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577171}
-
Charlie Andrews authored
A recent bisect in the linked bug suggests that they aren't flaky anymore. NOTRY=true TBR=nednguyen@chromium.org Bug: 842163 Change-Id: I79442bf895ff3596f1b1c8ae3db8ccb596041e78 Reviewed-on: https://chromium-review.googlesource.com/1146765Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577170}
-
Ryan Harrison authored
Change-Id: If254e5468f7adbf42d08ce292b0d63a7ebc152c4 Reviewed-on: https://chromium-review.googlesource.com/1145128Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#577169}
-
Chris Mumford authored
This change introduces the ExtensionURLLoaderThrottle which exists in the renderer and replaces ExtensionRequestLimitingThrottle when the network service is both enabled and disabled. Also re-enabled two extension throttle tests to speculatively fix issue 836188. Hopefully now that the throttling is done in the renderer they will no longer be flaky. Bug: 784576,836188 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.linux:linux_mojo Change-Id: Ib0c18f7b3fb17f4fbe47d79bf2f5bd7f1ebd6e06 Reviewed-on: https://chromium-review.googlesource.com/914589Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577168}
-
stkhapugin@chromium.org authored
Adds a histogram action recording on location bar share button tap. It is the same histogram as for the share button in the toolbar. Bug: 866449 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I89cef712fe6488619c88a35b5528924961d4835a Reviewed-on: https://chromium-review.googlesource.com/1146727 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#577167}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kSeparatorWidth in: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc This commit solves the issue by renaming the constants to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Change-Id: I2ae24ce5b67372286a5aa4e48a0bc125606ff778 Reviewed-on: https://chromium-review.googlesource.com/1146641 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577166}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If70c9ef565f4526366e5fc2235534adff2d0ed8a Reviewed-on: https://chromium-review.googlesource.com/1146497 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577165}
-
Jonathan Ross authored
The test WebContentsImplBrowserTest NotifyFullscreenAcquired_Navigate Flakes has been flaking on Android for some time. The owner of the test is currently OOO. So I'm disabling it on Android. TBR=boliu@chromium.org TEST=WebContentsImplBrowserTest NotifyFullscreenAcquired_Navigate Bug: 855018 Change-Id: I1e3f71e696e6186663ee162a81a1f3bed5ad80c5 Reviewed-on: https://chromium-review.googlesource.com/1146261 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577164}
-
Greg Thompson authored
The test was timing out as a result of the first-run dialog appearing. Now, this dialog is suppressed by setting the MetricsReportingEnabled policy to false. BUG=856995 R=pastarmovj@chromium.org Change-Id: Id5ccd5fbda849c586607b3b81d8fc8bef1cadb09 Reviewed-on: https://chromium-review.googlesource.com/1146731Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577163}
-
Noel Gordon authored
Rename the FileManager part of the test fixture to FilesApp since it's all FilesApp these days, and it simplifies --gtest-filter. Bug: 836254 Change-Id: Ibfd29300ced82fec3029864230c4db8f1e3accee Reviewed-on: https://chromium-review.googlesource.com/1146416Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577162}
-
stkhapugin@chromium.org authored
Monitor omnibox focus notification to update the clear button visibility on focus. Bug: 866446, 865019, 865013, 864511 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89 Reviewed-on: https://chromium-review.googlesource.com/1143860 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577161}
-
Farah Charab authored
Refactor code to support using resource fetch priorities (https://chromium-review.googlesource.com/c/chromium/src/+/1127364) in blink scheduler. Change-Id: I0b6eef1ae1d4b3d5f480437a1eac190c17b2fa7c Reviewed-on: https://chromium-review.googlesource.com/1138079 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577160}
-
Alexander Timin authored
This is a reland of 775612b8 Original change's description: > [scheduler] Add task type and queue type to tracing. > > R=skyostil@chromium.org > > Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc > Reviewed-on: https://chromium-review.googlesource.com/1140717 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576201} Change-Id: I8289cc417637e7e605dbb5f9df8cc6ea68fa457f Reviewed-on: https://chromium-review.googlesource.com/1143224Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577159}
-
Jérôme Lebel authored
+ Earlgrey cannot scroll down a scroll view that doesn't bounce. To work around the issue, the unified consent is now always bouncing, even when the content is smaller than the screen. + Whlie selecting an identity to sign-in, EarlGrey finds the right label to find with the right email address, but it also finds the button in the view behind the modal dialog box, with the right email address. To fix that, the matcher is now on the cell using the accessibility identifier. https://screenshot.googleplex.com/bd7p1JtcE0n Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I03d77e0e53bf29dec19d13a535cd08ebe46857c5 Reviewed-on: https://chromium-review.googlesource.com/1145279Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577158}
-
Colin Blundell authored
While preparing a refactoring of AccountTracker, I noticed that this unittest is not doing what its name says it's doing; rather, it's just a copy of the unittest above it. This CL changes the test to match the name (as best as I could infer the intent of the test from the name). Change-Id: I46d809c1fa9d786688ddca82641f3df4d96c5821 Reviewed-on: https://chromium-review.googlesource.com/1142776 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577157}
-
Mark Cogan authored
A small tweak to the spring damping ratio for the new tab animation, which ensures that the spring effect doesn't show a black hairline on an iPhone X. Bug: 851872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b6769f9d4b124e332efddf2f9602b4665d7aca8 Reviewed-on: https://chromium-review.googlesource.com/1146640Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#577156}
-
Alexander Timin authored
Replace an error with a prompt warning to gracefully handle false positives when the patch touches existing code. R=haraken@chromium.org CC=hajimehoshi@chromium.org,farahcharab@chromium.org Change-Id: I979f1b72dd515b30df5aac97e47e6cad8b3400f6 Reviewed-on: https://chromium-review.googlesource.com/1146720Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577155}
-
Tiger Oakes authored
The overall goal is to prevent storing the result of calls to context#getApplicationContext. We previously removed them all, but more have snuck in since. Bug: 846456 Change-Id: I6ff008b75a3980cc2db770ea42a18b9ee3669cae Reviewed-on: https://chromium-review.googlesource.com/1082666Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577154}
-
Timothy Loh authored
This reverts commit 574add02. Reason for revert: network_service_browser_tests / DevToolsFrontendInWebRequestApiTest.HiddenRequests times out most of the time https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=DevToolsFrontendInWebRequestApiTest.HiddenRequests Original change's description: > Reset URLLoaderFactory bindings for web request proxy > > Previously, if a request was made before any web request listeners or > rules were added, the URLLoaderFactory would not be proxied through the > browser process to run the WebRequest code. Now, if it is detected that > WebRequest listeners/rules are added, we reset the bindings so they will > be recreated and proxied through the browser process. > > Observers were added for a few classes so WebRequestAPI can listen to > rule changes. > > Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. > > Bug: 857577 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I7805be86512545b496e30b9693374981fdc2633e > Reviewed-on: https://chromium-review.googlesource.com/1139048 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577036} TBR=kinuko@chromium.org,rockot@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 857577 Change-Id: I1c70daaa63107ac1527755b3d94e0fe61cb49ae8 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1146541Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577153}
-
Yi Gu authored
Change-Id: Ide25550f5db4b0d64edd767059cfd89fb2833d85 Reviewed-on: https://chromium-review.googlesource.com/1145233Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577152}
-
Hiroki Nakagawa authored
Thanks to recent works that make network APIs (fetch, importScripts, WebSocket, etc) off-the-main-thread, the shadow page is now used only for fetching the top-level classic script. Therefore the shadow page no longer needs CSP and referrer policy for subresource fetch. This change is useful for deprecating the shadow page. Bug: 538751 Change-Id: Id192a17068de0e3a20f08cbe9ba2463bc56ffb1f Reviewed-on: https://chromium-review.googlesource.com/1098427 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#577151}
-