GitLab

Bug: 763240
Change-Id: Ibe0ce1f0d44dd947154d231769b53d0eda35dc09
Reviewed-on: https://chromium-review.googlesource.com/702722Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506838}

"using namespace" in a global scope breaks jumbo builds (and
are not allowed in the code style guide). This patch replaces them
with explicit namespaces.

Bug: 771153
Change-Id: If9c4de9e115c5531708cf06f64cb0088daca2d57
Reviewed-on: https://chromium-review.googlesource.com/697370Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#506837}

chrome_user_metrics_extension.proto imports extension_install.proto, but
doesn't need to. This was introduced in
https://crrev.com/e94d484908fa0f9472c580e7fb9c4ec9c9c1bf78.
Remove the unneeded import.

Bug: None

Change-Id: I6cb3490cbb3ba6da31420588994664dd123823fc
Reviewed-on: https://chromium-review.googlesource.com/699058Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506836}

We have not shipped Windows Ash for years. There is a 1:1 mapping
between use_ash and is_chromeos, so consolidate them.

Bug: 673826
Test: compiles, gn check for Chrome OS, Linux, Linux Ozone
Change-Id: Idc459cbca6b8447ce0f7e7aa9772e38835492234
Reviewed-on: https://chromium-review.googlesource.com/702756Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506835}

It is flaky. Error:

[FATAL:profile_destroyer.cc(56)] Check failed: hosts.empty() ||
profile->IsOffTheRecord() ||
content::RenderProcessHost::run_renderer_in_process().
Profile still has 1 hosts

0x7f035e2968ec base::debug::StackTrace::StackTrace()
0x7f035e2bc41c logging::LogMessage::~LogMessage()
0x0000025be6d8 ProfileDestroyer::DestroyProfileWhenAppropriate()
0x0000023da2a0 std::__1::__tree<>::destroy()
0x0000023da1e9 ProfileManager::~ProfileManager()
0x0000023d1ace ProfileManager::~ProfileManager()
0x000002559112 BrowserProcessImpl::StartTearDown()
0x0000022ad6f2 ChromeBrowserMainParts::PostMainMessageLoopRun()
0x000001e0a813 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun()
0x7f035a63837a content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
...

Bug=772072

Bug: 
Change-Id: I91391979088148a9857728f5c7b30d397b8335f2
Reviewed-on: https://chromium-review.googlesource.com/703034Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506834}

ScriptWrappableVisitor knows when wrapper tracing is in progress, so
when an isolate is provided we can look it up from the visitor directly
without trying to access the current ThreadState.

Bug: 
Change-Id: I79ab86ee7ff3774748ba9295b2604de53eaf8db4
Reviewed-on: https://chromium-review.googlesource.com/699067
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506833}

The switch enables blink feature SlimmingPaintV175 which is an
intermediate step between SlimmingPaintV1 and V2.

The command line switch is a short form of
--enable-blink-features=SlimmingPaintV175, which will ease
flag specific layout test expectations and field trials.

Bug: 771643
Change-Id: Iedb050d43380a8a1ab548a649d7f526a8f302066
Reviewed-on: https://chromium-review.googlesource.com/698370
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506832}

BUG=383646

Change-Id: Ia87d2dff787ffc5e4a59aca1af81a0ac9b727b4a
Reviewed-on: https://chromium-review.googlesource.com/702574Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506831}

The original correct baseline got lost in the shuffle of
a series of colliding reverts. This restores the file to its
state prior to the (now reverted) r506693.

TBR=drott@chromium.org
TBR=eae@chromium.org

Bug: 707713
Change-Id: I0f15bc1c4b01ad5972d30e86f3d47b13183fffaa
Reviewed-on: https://chromium-review.googlesource.com/703354Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506830}

BUG=739622
TEST=Build.

Change-Id: I196aea8c5d66c020a22c6eceb899783da3b2cd3a
Reviewed-on: https://chromium-review.googlesource.com/697047
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506829}

Extends the wl_pointer protocol using the wayland upstream
zwp_pointer_gestures protocol to pass information about pinch gestures.

BUG=b:25668308

Change-Id: I9f90ebebec3f8476181e0426401827a3cf1064e4
Reviewed-on: https://chromium-review.googlesource.com/699017
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506828}

This reverts commit 9f9f66ee.

Reason for revert: Broke Windows build - https://build.chromium.org/p/chromium/builders/Win/builds/59636

Original change's description:
> Roll src/third_party/leveldatabase/src/ 09a3c8e74..4a7e7f50d (11 commits)
> 
> This CL also #defines DeleteFile as DeleteFileW on Windows for all
> compilation units that depend on leveldb. This definition impacts
> leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of
> Chromium, because it is introduced by <windows.h>. After this CL, the
> definition is guaranteed to be in effect everywhere, so we don't have to
> reason about #include side-effects.
> 
> https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6
> 
> $ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s'
> 2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols.
> 2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc.
> 2017-10-03 costan Fix FD leak in POSIX Env.
> 2017-10-03 costan leveldb: Add tests for CL 170769101.
> 2017-10-03 costan Remove handling for unused LRUHandle representation special case.
> 2017-10-02 sanjay Fix file writing bug in CL 170738066.
> 2017-10-02 cmumford Fix use of uninitialized value in LRUHandle.
> 2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL).
> 2017-09-26 costan Use portable CRC32C from google/crc32c.
> 2017-09-01 costan Remove confusing and unnecessary if.
> 2017-09-01 costan Simplify Table::Open() flow and remove a delete call.
> 
> 
> Created with:
>   roll-dep src/third_party/leveldatabase/src
> 
> Bug: 
> Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138
> Reviewed-on: https://chromium-review.googlesource.com/699018
> Reviewed-by: Chris Mumford <cmumford@chromium.org>
> Commit-Queue: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506815}

TBR=cmumford@chromium.org,pwnall@chromium.org

Change-Id: Ifb074413f4f02289cee7c2535fde1ed516da9ad6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/703316Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506827}

ResourceBundle became ui::ResourceBundle in r72038 but many callers
still refer to it without the namespace.

Change-Id: I920e21319041cd0e2a2fa671db709a9d8483fb2e
Reviewed-on: https://chromium-review.googlesource.com/701662Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506826}

This is a follow-up to crrev.com/c/667936 which moved MAIN/LAUNCHER
handling into separate .LauncherMain activity alias.

That CL caused existing Chrome app shortcuts to disappear on update.
Turned out that Android launcher creates {MAIN/LAUNCHER, <component>}
intents for app shortcuts (i.e. it bakes in the component), and then
checks that after each update MAIN/LAUNCHER intent for the app resolves
to the shortcut's component. If that check fails, launcher removes the
shortcut.

This means that MAIN/LAUNCHER intents must continue to be handled by
.Main activity alias.

This CL does two renamings:

1. Renames .Main activity alias to .IntentDispatcher alias
2. Renames .LauncherMain alias to .Main

I.e. MAIN/LAUNCHER intents are now handled by .Main alias, making sure
shortcuts won't be removed.

Additionally this CL moves more MAIN categories from .IntentDispatcher
into .Main alias, so that almost all MAIN intents are handled by .Main
(one exception is NOTIFICATION_PREFERENCES, as it needs dispatching).

Bug: 761606
Change-Id: I6cb926c4677758190f743260e11a85129c8863bb
Reviewed-on: https://chromium-review.googlesource.com/700803
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506825}

Explicitly specifying the GPU driver version in the config will allow
us to safely test new driver versions. Because the tests will pick
machines of a particular driver version specified in the json, we
can ask infra to upgrade a few machines, then run a try job using the
new driver version.

This modifies the generate script to allow use of wildcards in test
dimension set specifiers. Wildcards are only supported as the last
character in the dimension. This allows us to more easily match
ranges of driver versions.

Re-land fixes the driver version for Windows 10 bots.

The current NVIDIA driver version used by the bots is 372.54 for the
Windows 7 bots and 376.19 for Windows 10.

R=kbr@chromium.org
BUG=771654

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie06cedefa0e4c4afc598ab7148d192c3f60eca34
Reviewed-on: https://chromium-review.googlesource.com/702855Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506824}

Other possible passwords variable of the password form is currently
holding all possible passwords. See this cl:
https://chromium-review.googlesource.com/c/chromium/src/+/660077

This cl renames the variable accordingly.

Bug: 753806
Change-Id: Id6e19b876392039704d1f23a8b42d1ca18e79ea6
Reviewed-on: https://chromium-review.googlesource.com/693014
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506823}

This change:
1) Moves the MD folder icon into //components
2) Makes the Views TreeView use it in Harmony mode

Note that there is no separate "open folder" icon in MD,
so the open and close icons are identical.

This change was previously reviewed as
<https://chromium-review.googlesource.com/c/chromium/src/+/663405>.

Bug: 610428
Change-Id: Ife816d911bef2a92497bb687c5aa59345359aa74
Reviewed-on: https://chromium-review.googlesource.com/692817
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506822}

This includes:
 - ensuring that symlinks that CIPD creates for files currently
   managed by update_third_party_deps.py get removed by that
   script.
 - changing switching to copy_ex in process_java_prebuilt s.t.
   symlinks are correctly handled by that template.

Bug: 755920
Change-Id: I1a75ae3acd96ce827401d8d58f8f1127ad09eadb
Reviewed-on: https://chromium-review.googlesource.com/701495Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506821}

BUG=771783

Change-Id: Iba58f2ebf19d3deb04cda8e6a4d73c7bfbab1efe
Reviewed-on: https://chromium-review.googlesource.com/701371Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506820}

The flow is:
1. browser requests WindowTreeClient from the RenderWidget of the
  frame to embed.
2. browser send a message to the parent RenderFrameProxy with the
   WindowTreeClient.
3. RenderFrameProxy forwards to RendererWindowTreeClient to create the
   child window and embed the WindowTreeClient in it.

BUG=758387
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I0296e802c0f754e463c65492f38ec5a68df30eba
Reviewed-on: https://chromium-review.googlesource.com/673066Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506819}

https://pdfium.googlesource.com/pdfium.git/+log/38d0449a02f4..4ce4f5f8ab0b

$ git log 38d0449a0..4ce4f5f8a --date=short --no-merges --format='%ad %ae %s'
2017-10-05 dsinclair Cleanup CPDF_RenderStatus
2017-10-04 dsinclair Remove CPDF_Object friends
2017-10-05 dsinclair Remove friends from CXML_Element
2017-10-04 dsinclair Remove CPDF_CMapParser friends

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I2981fe77ca795854246e66ba3a2d1f34063a4de6
Reviewed-on: https://chromium-review.googlesource.com/702639
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506818}

We enable Arc package sync datatype when user enables Arc, and call
StartModels when Arc app instance is ready and Arc packages get
refreshed. But There is a big time gap since we need perform provision
for Arc during opt-in. And this may lead to the high config time-out
rate for Arc packages.

Enable the datatype when provision is successful and reduce the gap
between enabling the sync data type and calling startModels.

Bug: 771838
Test: Manual test and Arc pacakge related integration test.
Change-Id: I4c70c9d7e3c690fc953dac981398424d166ce51f
Reviewed-on: https://chromium-review.googlesource.com/702014Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#506817}

Increase the maximum limit of CCT bottom bar height to display larger
view.

Bug: None
Change-Id: I0b0a8831cbd39f299e0dafd8e0eb314e8fe9b398
Reviewed-on: https://chromium-review.googlesource.com/702687Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#506816}

This CL also #defines DeleteFile as DeleteFileW on Windows for all
compilation units that depend on leveldb. This definition impacts
leveldb's API (leveldb::Env::DeleteFile), and is in effect in most of
Chromium, because it is introduced by <windows.h>. After this CL, the
definition is guaranteed to be in effect everywhere, so we don't have to
reason about #include side-effects.

https://chromium.googlesource.com/external/leveldb.git/+log/09a3c8e74175..4a7e7f50dcf6

$ git log 09a3c8e74..4a7e7f50d --date=short --no-merges --format='%ad %ae %s'
2017-10-04 cmumford Add LEVELDB_EXPORT macro to export public symbols.
2017-10-04 costan leveldb: Include <algorithm> in util/env_test.cc.
2017-10-03 costan Fix FD leak in POSIX Env.
2017-10-03 costan leveldb: Add tests for CL 170769101.
2017-10-03 costan Remove handling for unused LRUHandle representation special case.
2017-10-02 sanjay Fix file writing bug in CL 170738066.
2017-10-02 cmumford Fix use of uninitialized value in LRUHandle.
2017-10-02 sanjay Fix issue 474: a race between the f*_unlocked() STDIO calls in env_posix.cc and concurrent application calls to fflush(NULL).
2017-09-26 costan Use portable CRC32C from google/crc32c.
2017-09-01 costan Remove confusing and unnecessary if.
2017-09-01 costan Simplify Table::Open() flow and remove a delete call.


Created with:
  roll-dep src/third_party/leveldatabase/src

Bug: 
Change-Id: I0096e6b863616d14c20994d6cb9696ebc263f138
Reviewed-on: https://chromium-review.googlesource.com/699018Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506815}

Bug: 612962
Change-Id: Idd15d1639defb4bd3cf56795b57b9f3a4f55379d
Reviewed-on: https://chromium-review.googlesource.com/702676Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506814}

Simplify moving sandbox_mac.mm itself out of content/, as it
no longer includes content headers.

Change-Id: I68e746fb4c003e6a4bc60ee44057b8d1ba0554d1
Reviewed-on: https://chromium-review.googlesource.com/701359Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506813}

For more on JUnit4 migration, please check
src/testing/android/docs/junit4.md

Bug: 640116
Change-Id: I0270db03b98377e50bcbd45ccbc972fe28e4c918
Reviewed-on: https://chromium-review.googlesource.com/699794
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506812}

When force-signin is enabled, profile should be able to removed even all profiles are locked
so that user is able to remove any locked profile that is not able be unlocked due to policy update.

Bug: 
Change-Id: I8c0433eaee76566f76d9a12c5a6f6883dcb94b20
Reviewed-on: https://chromium-review.googlesource.com/701397Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506811}

This reverts commit 5638e72c.

Reason for revert: compile error on bots ...


Original change's description:
> Send Emulation.virtualTimeAdvanced when virtual time advances
> 
> This helps controls scripts get a better idea of the current virtual
> time.
> 
> Bug: 
> Change-Id: I39433f2790cdc51c14a3c02736c9320b0bce7c0a
> Reviewed-on: https://chromium-review.googlesource.com/702374
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506789}

TBR=dgozman@chromium.org,skyostil@chromium.org,alexclarke@chromium.org

Change-Id: Iffebedd5d1c7f303d2e02f9f32e06d750eee29eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/702975Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506810}

This reverts commit 5638e72c.

Reason for revert: Breaking compile on Windows: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/113824

Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc

TBR=dgozman@chromium.org
TBR=skyostil@chromium.org

Change-Id: Ia0ca3f2bf43980eb13418c7c14deb16119d88efc
Reviewed-on: https://chromium-review.googlesource.com/702690Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506809}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58c1372e..4754eed2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I6f673abb4422cbb6d4ee4dcd1b772e4e43397591
Reviewed-on: https://chromium-review.googlesource.com/702516Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506808}

This reverts commit 9f6b2091.

Reason for revert: The timing of the swap_chain_ destruction appears to be wrong. Reverting this until I can sort it out.

Original change's description:
> [vr] Enable 2x MSAA
> 
> This increases the number of samples used in the primary framebuffer.
> 
> Bug: 752085
> Change-Id: I869ae41943db925aff845b3d1da15e8130b14e45
> Reviewed-on: https://chromium-review.googlesource.com/680374
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505811}

TBR=vollick@chromium.org,mthiesse@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 752085, 771663
Change-Id: I6150abf5840fa81cc9ce135c0746d3fd4f8bca7a
Reviewed-on: https://chromium-review.googlesource.com/702517
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506807}

The recent change for using ColorUtils.isUsingDefaultToolbarColor to
decide emphazing htts scheme makes Chrome Home does not emphasize https
properly. This is because ColorUtils.isUsingDefaultToolbarColor does not
check whether BottomSheet is null. For Chrome Home, BottomSheet is not
null so the toolbar should not be populated by brand color and should
emphasize the https scheme.

To fix the problem, revert back to use ToolbarModel.isUsingBrandColor.
And also change CCT to use the same method. However, since
mIsUsingBrandColor also depends of whether there is a tab, make setTab
in ToolbarModelImpl also update mIsUsingBrandColor. This is needed
because CCT setTab after setPrimaryColor.

BUG=771559

Change-Id: Id94c811f2992ecc73b36c08d2537c63949131f2e
Reviewed-on: https://chromium-review.googlesource.com/701455Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#506806}

Changes in how selection and the action mode are triggered seem to
have deflaked these tests. Each of the re-enabled tests passed
60 times on a Nexus 6P running Android O and 60 times on a Nexus 4
running Android J.

Bug: 592428

Change-Id: If774d474df13e9e20e3d714f06358811a941d075
Reviewed-on: https://chromium-review.googlesource.com/701278Reviewed-by: Alexandre Elias <aelias@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506805}

This is a follow-up CL to: https://crrev.com/c/690314

Currently, gpuBenchmarking takes coordinates in the root-frame
coordinate space. Since input events are in the (visual) viewport space,
gpuBenchmarking was trying to convert them in the presence of pinch-zoom
by applying the pageScaleFactor. This is incorrect, as the
transformation must also include the visual viewport offset. However,
it makes a lot more sense for gpuBenchmarking to take coordinates in the
viewport space to begin with, leaving the conversion to the caller.

The above CL converts telemetry to pass these coordinates in viewport
space. It's gated on the presence of the
`gesturesExpectedInViewportCoordinates` attribute so that we can make
the transition without breaking the waterfall.

Bug: 610021
Change-Id: Ic6a4229e230b77427e6f1aa7ef71933c21d93106
Reviewed-on: https://chromium-review.googlesource.com/668376
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506804}

Another test is flaky on telemetry_unittests, skipping it in config.

TBR=sky@chromium.org

Bug: 758065
Change-Id: I49849ca1b271fcceb1976f86f8ed6225a22cc302
Reviewed-on: https://chromium-review.googlesource.com/700797Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506803}

Remove HpackStringDecoder:StartOnly(), StartAndDecoderLength(), and
StartSpecialCaseShort().

This CL lands internal change 170871163 by bnc.

BUG=488484

Change-Id: I5ea3d3650980816d3bd0729a277d5786b5e5e974
Reviewed-on: https://chromium-review.googlesource.com/688714Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506802}

This patch removes a random sources block that was ignored
in normal builds but triggered an assert in jumbo builds.

This also changes the OWNERS file according to presubmit instructions.

Bug: 771153
Change-Id: Ic32f92db25b1b4bd6e2087b95785b4934a94e120
Reviewed-on: https://chromium-review.googlesource.com/702258Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#506801}

This change is needed for the Harmony treeview, but it also looks better in the
non-Harmony treeview, so it's unconditional in this CL.

This change also removes the special background/foreground colors from the
example treeview. While those were useful as a demonstration, they are quite
garish and distracting when screenshotting the treeview :).

Bug: 610428
Change-Id: Icf14b2e1d5b8c20a6d72550cfe57436b3f31cce4
Reviewed-on: https://chromium-review.googlesource.com/695563Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506800}

... in favour of IntrinsicBlockSize(). We weren't using inline overflow
size, and "overflow" was incorrect for how it was being used.

This also moves it to the layout result.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idd6c63dd5e0712c69f81bed21a03ad2be4c9331a
Reviewed-on: https://chromium-review.googlesource.com/701357
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506799}