GitLab

See the attachments of crbug.com/166786#c2 the bubble has border for focus.

BUG=166786
TEST=open the message center bubble when there're no notifications and confirmed no focus borders appear.

Review URL: https://codereview.chromium.org/11737029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175649 0039d316-1c4b-4281-b951-d872f2087c98

This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment.

Related changes in this CL:
  - MouseClampingFilter receives screen size on the proper thread.
  - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change.
  - ClientSession does not expose DesktopEnvironment.
  - InputEventTracker can be re-attached to a different InputStub.

BUG=104544


Review URL: https://chromiumcodereview.appspot.com/11781003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166786
TEST=login and see if the shelf has the notification icon even though there're no notifications.

Review URL: https://codereview.chromium.org/11761032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175647 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg
BUG=168905
NOTRY=True

Review URL: https://codereview.chromium.org/11824014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175646 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the debug crash here:
DCHECK(!wm::IsWindowMinimized(gained_active))

This is testing kShowStateKey that has not yet been changed to the expected value.

As far as I can tell, when called from OnWindowActivated is already from ash::window::Show
when window.cc calls into the delegate:
   delegate_->OnWindowTargetVisibilityChanged(visible);

Which triggers BrowserView::RestoreFocus which triggers a cascade of focus notifications
ending up in aura::FocusManager::FocusWindow which calls ActivationController::ActivateWindow
which calls BaseLayoutManager::OnWindowActivated

In other word we re-enter and as a side effect the kShowStateKey has not yet been set.

Full stack in the bug.

BUG=166952
TEST=see bug
Review URL: https://codereview.chromium.org/11633029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175645 0039d316-1c4b-4281-b951-d872f2087c98

Solution: the popup keeps mouse capture, so that any mouse click closes it (via WebKit's WebPopupMenuImpl.cpp) not just clicks in it or in its browser window.

BUG=161129
TEST=navigate to
http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
Click on the "car name" to bring up the pop-up.
Click outside the browser window to see it close (just as for clicking inside the browser window)


Review URL: https://chromiumcodereview.appspot.com/11675002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175644 0039d316-1c4b-4281-b951-d872f2087c98

SystemMenuModel. I've made it so SystemMenuModel doesn't need it.

This is a precursor to sharing system menu building code among the
frame types.

BUG=none
TEST=none
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11791039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175643 0039d316-1c4b-4281-b951-d872f2087c98

This forces explicit normalization of paths and make path escaping security bugs much harder to exploit. See for example bug 167122

BUG=168890
TEST=included tests
Review URL: https://codereview.chromium.org/11782005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175642 0039d316-1c4b-4281-b951-d872f2087c98

disappeared, so removing debugging code.

BUG=166355
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11775021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175641 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83714
TEST=ViewSourceTest.ViewSourceInMenuDisabledOnAMediaPage


Review URL: https://chromiumcodereview.appspot.com/11775002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175639 0039d316-1c4b-4281-b951-d872f2087c98

Keep only one tab and only one icon animation object. So when
we add more cases we don't expand the class state.

BUG=3541
TEST=none
Review URL: https://codereview.chromium.org/11753021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175638 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=157273

Review URL: https://codereview.chromium.org/11783039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175636 0039d316-1c4b-4281-b951-d872f2087c98

to reflect the way it now works in developer console.

Developers no longer need to email Chrome apps to request their client ID.

Review URL: https://codereview.chromium.org/11761029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175635 0039d316-1c4b-4281-b951-d872f2087c98

This change should stop the HTTP server thread from outputting the
following backtrace, which clutters the logs (and is sometimes
interleaved with other output):

Traceback (most recent call last):
  File ".../tools/browser_tester/browser_tester.py", line 247, in Serve
    server.handle_request()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 262, in handle_request
    fd_sets = select.select([self], [], [], timeout)
select.error: (9, 'Bad file descriptor')

BUG=none
TEST=checked log output on Mac OS X

Review URL: https://codereview.chromium.org/11819005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175634 0039d316-1c4b-4281-b951-d872f2087c98

The switch kUseGpuInTests is used to inform tests that they are running on a GPU bot (instead of a bot which may not have a real GPU in it).

The existing GPU tests which use this flag are chrome tests, so this flag had been happy living in chrome. There exist some content GPU tests that don't use this flag, but the GPU memory manager test is the first content test which uses this flag (it renders some very complicated scenes to stress GPU memory, and we shouldn't count on being able to run all of them on software raster).

BUG=135525

Review URL: https://codereview.chromium.org/11777019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175633 0039d316-1c4b-4281-b951-d872f2087c98

Unit test to catch things like bug 168691

BUG=


Review URL: https://chromiumcodereview.appspot.com/11782026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175632 0039d316-1c4b-4281-b951-d872f2087c98

Also, makes non-badged shortcuts (when deleting down to 1 profile) not have a command-line or custom icon set, to be consistent with (i.e. the same as) the shortcut initially created for the browser when it's installed.

BUG=167981
TEST=With two profiles A and B, with only B having a shortcut, delete profile B. There should be a non-profile desktop shortcut created.

Review URL: https://chromiumcodereview.appspot.com/11785004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175631 0039d316-1c4b-4281-b951-d872f2087c98

This works around flickering on Qualcomm devices when
using virtual contexts. Qualcomm has a bug where switching
to FBO targets of different sizes corrupts the scissor rect.

BUG=165493

Review URL: https://chromiumcodereview.appspot.com/11734037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175630 0039d316-1c4b-4281-b951-d872f2087c98

Since it's only used there. That way we will be able to move
window_open_disposition.h out of webkit/

BUG=146251
R=jam@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/11798003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175629 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to be writing the renderer-side code to interface with the
NetErrorTabHelper, and it will need to understand DNS probe results, so move
that enum to common.

BUG=156415

Review URL: https://chromiumcodereview.appspot.com/11776031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168294
TEST=see the repro steps and the expected behavior in the bug.

Review URL: https://codereview.chromium.org/11759021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175627 0039d316-1c4b-4281-b951-d872f2087c98

The new flag is --enable-new-message-center-popup, due to the discussion of crbug.com/164598
The user code: https://codereview.chromium.org/11773004/

BUG=161052
TEST=None

Review URL: https://codereview.chromium.org/11773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175624 0039d316-1c4b-4281-b951-d872f2087c98

We can not currently try a patch containing a binary blob, so we
submit the binary blob first, then try the rest of the patch
seperately.

NOTRY=true
TBR=binji@chromium.org
BUG=168867

Review URL: https://codereview.chromium.org/11817003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11819015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175622 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11776034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167991


Review URL: https://chromiumcodereview.appspot.com/11788034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175619 0039d316-1c4b-4281-b951-d872f2087c98

This method is required to implement the CapturePicture API in Android WebView.

BUG=167908


Review URL: https://chromiumcodereview.appspot.com/11731002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175618 0039d316-1c4b-4281-b951-d872f2087c98

Shell::SetDisplayWorkAreaInsets (called from ShelfLayoutManager if launcher was set to autohide) applied while some
containers were transform-animated (lock window animation) resulted in incorrect offsets.

BUG=167215


Review URL: https://chromiumcodereview.appspot.com/11682006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153359

Review URL: https://codereview.chromium.org/11787042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11818005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168360

Review URL: https://codereview.chromium.org/11791026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175614 0039d316-1c4b-4281-b951-d872f2087c98

Hot on the heels of r175591, we're now using the centered
asset everywhere.

This moves the mac asset over to common, removes the one in the
root directory (which was used by gtk), and updates the grd file.

BUG=168897
TEST=look at browser actions overflow asset, it's vertically centered.
on all platforms.
TBR=sail

Review URL: https://codereview.chromium.org/11824009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168676 (part 2 of comment 0)
TEST=have enough bookmarks that the overflow chevron shows up.
observer it's now centered vertically.
TBR=sail

Review URL: https://codereview.chromium.org/11820007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175610 0039d316-1c4b-4281-b951-d872f2087c98

- unitialized variables

Example:

[320:320:0108/121207:1124051475207:FATAL:browser_main_loop.cc(175)] Gtk: IA__gtk_widget_set_size_request: assertion `width >= -1' failed
	base::debug::StackTrace::StackTrace() [0xc57eac]
	logging::LogMessage::~LogMessage() [0xc77719]
	content::(anonymous namespace)::GLibLogHandler() [0x33f749c]
	<unknown> [0x7fe62ad7ffa1]
	<unknown> [0x7fe62ad801b2]
	content::Shell::SizeTo() [0x81f69c]
	content::Shell::PlatformResizeSubViews() [0x81f6cc]
	content::Shell::CreateShell() [0x81c3f2]
	content::Shell::CreateNewWindow() [0x81c6fa]
	content::WebKitTestController::PrepareForLayoutTest() [0x829e82]
	content::InProcessBrowserLayoutTest::RunLayoutTestInternal() [0x5790f7]
	content::InProcessBrowserLayoutTest::RunLayoutTest() [0x578d91]
	content::MediaLayoutTest_VideoLoopTest_Test::RunTestOnMainThread() [0x4d93ba]
	content::ContentBrowserTest::RunTestOnMainThreadLoop() [0x573ba2]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() [0x83e5ab]
	base::internal::RunnableAdapter<>::Run() [0x83eb7e]
	base::internal::InvokeHelper<>::MakeItSo() [0x83eb16]
	base::internal::Invoker<>::Run() [0x83eac3]
	base::Callback<>::Run() [0x459f2d]
	content::ShellBrowserMainParts::PreMainMessageLoopRun() [0x838a4e]
	content::BrowserMainLoop::CreateThreads() [0x33f846e]
	content::BrowserMainRunnerImpl::Initialize() [0x326bd64]
	content::BrowserMain() [0x326b96b]
	content::BrowserTestBase::SetUp() [0x83e536]
	content::ContentBrowserTest::SetUp() [0x573a15]

BUG=30715

Review URL: https://codereview.chromium.org/11777028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175608 0039d316-1c4b-4281-b951-d872f2087c98

This patch started out trying to add support for benchmarks that had different
outputs for each page. This is required for benchmarks that report [filtered]
profiling data, for instance something that simply groups timeline data and
reports it. To do csv output in taht situation, we have to hold output until
the end of the benchmark.

Making this work cleanly in the multi page benchmark code turned out to be
easily hacked, but unearthed a pretty hefty amount of deep, branchy code. So,
to make this cleaner, I cleaned up the results object.

We now have:
 - PageBenchmarkResults: all results for the benchmark
 - ValuesForSinglePage: all the results for a page
 - PageBenchmarkValues: a single value from a benchmark

PerfBot benchmark output is managed by PageBenchmarkResults. Csv and Block

terminal-block was renamed to block, but with backcompat to terminal-block.
Nobody could remember terminal-block.

R=tonyg,hartmanng
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11779041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175602 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org
BUG=166818
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11778046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175601 0039d316-1c4b-4281-b951-d872f2087c98

guava and jsr305 libraries are already present in the downstream build,
just need to not use the upstream third_party version and modify the
build script

BUG=
TBR=torne@chromium.org
Android only build fix. Ran through android bots with compile step.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11822002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175600 0039d316-1c4b-4281-b951-d872f2087c98

This change replaces serveral instances of Get(PREV_ID) and Get(NEXT_ID)
with calls to the newly introduced GetPredecessorId() and
GetSuccessorId().

This is done in anticipation of the change that will remove PREV_ID and
NEXT_ID entirely.  By making this change in advance, that patch will be
smaller and easier to review.

BUG=145412,126505


Review URL: https://chromiumcodereview.appspot.com/11637053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175599 0039d316-1c4b-4281-b951-d872f2087c98

The change in render_widget_host_view_aura.cc is to prevent mouse events generated via touch events
on Windows being sent to the renderer. This is necessary as the touch events which are now sent to
the renderer ensure that clicks/moves, etc are handled correctly.

BUG=168427
Review URL: https://codereview.chromium.org/11773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175598 0039d316-1c4b-4281-b951-d872f2087c98

As a prerequisite to supporting window.open, ViewHostMsg_CreateWindow messages need to be handled by BrowserPluginGuest as all guest-related state is accessed and handled there.

This patch handles and forwards ViewHostMsg_CreateWindow messages intercepted on the I/O thread from the guest process prior to reaching RenderMessageFilter and forwards them to BrowserPluginGuest to reject, instead of rejecting them immediately in BrowserPluginMessageFilter.

Future patches will replace the simple reject logic in BrowserPluginGuest with additional logic that will enable creating new windows.

BUG=140316

Review URL: https://codereview.chromium.org/11753030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175597 0039d316-1c4b-4281-b951-d872f2087c98