GitLab

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=garykac@chromium.org

Review-Url: https://codereview.chromium.org/2031083002
Cr-Commit-Position: refs/heads/master@{#398062}

We are looking into a more consistent audio playback on mobile and want
to see whether implementing Safari iOS behaviour in Chrome Android would
break websites.

BUG=616807

Review-Url: https://codereview.chromium.org/2031393003
Cr-Commit-Position: refs/heads/master@{#398061}

values and the overall renderer memory stats.

BUG=617117
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2030343002
Cr-Commit-Position: refs/heads/master@{#398060}

When retrieving getScaledFont() from HarfBuzzFace we were creating a
SimpleFontData and assigning it to the HarfBuzzFontData object that is
kept as the user data pointer for HarfBuzz callbacks. This introduces a
reference counting cycle since SimpleFontData owns the FontPlatformData
it was created from, and harfBuzzFace() is retrieved from
FontPlatformData itself.

Since getScaledFont() is called on a HarfBuzzFace instance that is
retrieved from FontPlatformData and only used for one shaping iteration,
reducing the link to SimpleFontData to a non owning pointer should be
acceptable.

BUG=617637
R=eae,tzik,kojii

Review-Url: https://codereview.chromium.org/2039263002
Cr-Commit-Position: refs/heads/master@{#398059}

The shippingAddress attribute was already added by this issue[1] but current
implementation isn't supporting the attribute yet. So, we should provide the
attribute in PaymentResponse.

[1] https://github.com/w3c/browser-payment-api/pull/139

BUG=617194

Review-Url: https://codereview.chromium.org/2038333002
Cr-Commit-Position: refs/heads/master@{#398058}

Chromoting no longer relies on the sas.dll so we can clean up some of the
build files and remove these variables.

BUG=

Review-Url: https://codereview.chromium.org/2030423002
Cr-Commit-Position: refs/heads/master@{#398057}

https://chromium.googlesource.com/skia.git/+log/38d1adf1f7f4..09f5cd44ae30

$ git log 38d1adf1f..09f5cd44a --date=short --no-merges --format='%ad %ae %s'
2016-06-06 scroggo Prefix png functions
2016-06-06 jvanverth Use intptr_t for onTouch argument.
2016-06-06 scroggo Update pnglibconf.h
2016-06-06 msarett Use SK_TEST_QCMS to mark qcms test code

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2043643003
Cr-Commit-Position: refs/heads/master@{#398056}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see this CL's comments).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2030193003
Cr-Commit-Position: refs/heads/master@{#398055}

Review-Url: https://codereview.chromium.org/2039043002
Cr-Commit-Position: refs/heads/master@{#398054}

R=thakis@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2000413002
Cr-Commit-Position: refs/heads/master@{#398053}

https://pdfium.googlesource.com/pdfium.git/+log/c324646..f7e108b

BUG=427616,616253,616838,613623
TBR=dsinclair@chromium.org

TEST=bots

Review-Url: https://codereview.chromium.org/2046623002
Cr-Commit-Position: refs/heads/master@{#398052}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0c6dbf87bab3..8f31b02e7cdf

$ git log 0c6dbf87b..8f31b02e7 --date=short --no-merges --format='%ad %ae %s'

BUG=552376,617174

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2039933002
Cr-Commit-Position: refs/heads/master@{#398051}

BUG=615825

Review-Url: https://codereview.chromium.org/2036323002
Cr-Commit-Position: refs/heads/master@{#398050}

According to the section 3 and section 5 in
https://tools.ietf.org/html/draft-west-cookie-priority-
00#section-3, the old cookie monster implementation doesn't
maintain priority quotas correctly.

This CL makes sure there will always be at least 30 low
priority cookies, 50 mid priority and 70 high priority
cookies if there had been enough of them before  the eviction.
Please note, secure cookies are more important than non-secure
per https://tools.ietf.org/html/draft-west-leave-secure-cookies-alone.

A small example: if there are 70 cookies:
37 non-secure low priority and 33 secure low priority
cookies, 37 non-secure cookies are deleted during the first
round and other 3 secure low priority cookies are deleted
during the following round preserving 30 low priority
cookies according to the quota of those specific cookies.
For a bigger example that fully complies with the
implementation, check the unittests.

Before the fix, the unittests were just adjusted to the
behavior of cookies eviction.

For example, if we take the following unittest:
Round 1 => 10L; round 2 => 11M, 10L; round 3 => none.
TestPriorityCookieCase(cm.get(), "11HN 10MN 20LN 110MN 20LN
10HN", 20U,109U, 21U, 150U, 0U);
The problem here was that there were only 40 low priority
cookies, but the quota was not preserved for those cookies.
First, 10 low priority cookies were deleted and then more 10
low priority cookies were deleted leaving only 20 of them,
which was less than the quota (30 low priority cookies).
It happened because the eviction algorithm didn't know how
many cookies of a specific priority were deleted and
it had always started to delete all the cookies from the
beginning of the container removing even those cookies
that shouldn't have been deleted.

After we land this CL, we can have cookies in any order and
high priority cookies will be eventually deleted in order
to avoid excess of high priority cookies by some
applications within the same domain. Thus, after the
eviction algorithm runs, we should have at least 30 low, 50
mid and 70 high priority cookies if we had sufficient
amount of them in the beginning.

BUG=609550

Review-Url: https://codereview.chromium.org/1976073002
Cr-Commit-Position: refs/heads/master@{#398049}

Its weird that the rootScroller property on document takes an Element but the
RootScroller object is really a manager class. Rename it to make this more clear
and prevent confusion.

BUG=505516

Review-Url: https://codereview.chromium.org/2040693002
Cr-Commit-Position: refs/heads/master@{#398048}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2029403004
Cr-Commit-Position: refs/heads/master@{#398047}

BUG=616657
R=pfeldman@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2038593002
Cr-Commit-Position: refs/heads/master@{#398046}

BUG=599902

Review-Url: https://codereview.chromium.org/2039943002
Cr-Commit-Position: refs/heads/master@{#398045}

We've branched for 53 now, so the admin policy for enabling RC4 has
expired. Remove it completely.

Farewell, RC4. There was a time when you saved us from the beast and
rabid poodles. By luck, you didn't have triskaidekaphobia, unlike our
other friends who chained blocks together. (Boy are they annoying.
It'd be wonderful if we could ditch them someday.)

But you always had your biases, which made it hard to trust you with
secrets. Now we have new friends who do the cha-cha twenty times a
day and learned counting from some French mathematician. We just
don't have room for you anymore.

BUG=375342

Review-Url: https://codereview.chromium.org/2030263002
Cr-Commit-Position: refs/heads/master@{#398044}

Review-Url: https://codereview.chromium.org/2039723003
Cr-Commit-Position: refs/heads/master@{#398043}

It allows to remove common initialization lists in constructors.

BUG=none

Review-Url: https://codereview.chromium.org/2034303004
Cr-Commit-Position: refs/heads/master@{#398042}

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.

Review-Url: https://codereview.chromium.org/2037073002
Cr-Commit-Position: refs/heads/master@{#398041}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=cpu@chromium.org

Review-Url: https://codereview.chromium.org/2037853002
Cr-Commit-Position: refs/heads/master@{#398040}

Adds an experimental option to enable Ignition for low-end Android
devices.

BUG=v8:4868

Review-Url: https://codereview.chromium.org/2039793003
Cr-Commit-Position: refs/heads/master@{#398039}

R=brettw@chromium.org, inferno@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2006173002
Cr-Commit-Position: refs/heads/master@{#398038}

https://chromium.googlesource.com/skia.git/+log/55fdcccf01d4..38d1adf1f7f4

$ git log 55fdcccf0..38d1adf1f --date=short --no-merges --format='%ad %ae %s'
2016-06-06 liyuqian Allow animation in Android viewer
2016-06-06 msarett Name parametric gamma curve types

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2047433002
Cr-Commit-Position: refs/heads/master@{#398037}

In order to correctly handle report-only, we need to stop thinking of
nonces as a one-time bypass in 'ScriptLoader', and start thinking of it
as an ongoing check associated with a request (as it's specced in
https://w3c.github.io/webappsec-csp/#script-src-algorithms). This patch
moves nonce checking into 'FrameFetchContext::canRequest' by attaching
it to 'ResourceLoaderOptions', and using that new data inside the
'ContentSecurityPolicy::allow*' checks to ensure that each active policy
gets a crack at reporting violations.

To prevent regression, this patch adds a number of unit tests, moves
the existing nonce layout tests to a separate directory, and adds a
few layout tests as well.

BUG=614416,611652,614802

Review-Url: https://codereview.chromium.org/2020223002
Cr-Commit-Position: refs/heads/master@{#398036}

BUG=617142

Review-Url: https://codereview.chromium.org/2037573004
Cr-Commit-Position: refs/heads/master@{#398035}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dbae8a5c..6aed5443

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2043733002
Cr-Commit-Position: refs/heads/master@{#398034}

This flips the remaining Win builders on the chromium, chromium.chrome,
and chromium.perf waterfalls, as well as the matching trybots. The
remaining GYP win builders are FYI bots, memory bots, and the official
builders; the latter should be flipped ASAP after this lands to avoid
any skew.

R=brucedawson@chromium.org
BUG=605319

Review-Url: https://codereview.chromium.org/2030823002
Cr-Commit-Position: refs/heads/master@{#398033}

This CL contains several change to uplift sandwich:

1) Finds Android DeviceUtil object from device serial only once
per command line to speed up sandwich graph generation.

2) Makes SandwichRunner.output_dir mandatory so it can always dumps
error files in case of error or intermittent failures.

3) Lets AndroidChromeController dismiss crash dialogs when browser
or renderer process crashes.

BUG=582080

Review-Url: https://codereview.chromium.org/2040993002
Cr-Commit-Position: refs/heads/master@{#398032}

When SendData/SendvData is called, it might be that OnClose
has been invoked without an error, in which case
BidirectionalStream::Delegate::OnFailed would not have been
invoked. This is theoretically possible, but I am not
aware if such case would exist.

This CL removes the assumption that SendData/SendvData
is only called when stream is alive. If stream is
destroyed, propagate that as an ERR_UNEXPECTED to caller,
instead of crashing with a segfault.

BUG=606394

Review-Url: https://codereview.chromium.org/2032733002
Cr-Commit-Position: refs/heads/master@{#398031}

With the conversion to keyIdentifier there are some issues that need
to be fixed with layout tests. Add the exact string identifiers to
event_sender so that it is clear between the LayoutTests
and the implementation the identifier can be the same.

BUG=607349

Review-Url: https://codereview.chromium.org/2039233002
Cr-Commit-Position: refs/heads/master@{#398030}

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com

Review-Url: https://codereview.chromium.org/2041653002
Cr-Commit-Position: refs/heads/master@{#398029}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f58ecb6416a4..0c6dbf87bab3

$ git log f58ecb641..0c6dbf87b --date=short --no-merges --format='%ad %ae %s'

BUG=617174

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2035403003
Cr-Commit-Position: refs/heads/master@{#398028}

BUG=599327

Review-Url: https://codereview.chromium.org/2046573002
Cr-Commit-Position: refs/heads/master@{#398027}

BUG=none
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2027063002
Cr-Commit-Position: refs/heads/master@{#398026}

for events sending from Windows. Now we use a mouse message from GetMessageExtraInfo to decide
the actual input device type.

GetMessageExtraInfo needs to be mask-checked against 0xFFFFFF00, and then compared
with 0xFF515700. True when this mouse message was generated by a Tablet PC pen or touch
screen. Otherwise it is from a mouse device. Additionally, in Windows Vista or later,
the eighth bit, masked by 0x80, is used to differentiate
touch input from pen input
(0 = pen, 1 = touch).

Reference:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx

BUG=614820

Review-Url: https://codereview.chromium.org/2020143003
Cr-Commit-Position: refs/heads/master@{#398025}

BUG=614452

Review-Url: https://codereview.chromium.org/2034833002
Cr-Commit-Position: refs/heads/master@{#398024}

https://chromium.googlesource.com/skia.git/+log/401e77cfe126..55fdcccf01d4

$ git log 401e77cfe..55fdcccf0 --date=short --no-merges --format='%ad %ae %s'
2016-06-06 robertphillips Remove GrRenderTarget from GrPipelineBuilder

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2037403002
Cr-Commit-Position: refs/heads/master@{#398023}