- 01 Mar, 2019 40 commits
-
-
Yi Gu authored
TBR=peter@chromium.org NOTRY=true See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fbackground-fetch%2Ffetch.https.window.html Bug: 937312 Change-Id: Icef179aa3da1120419c4d59ee0005f871cebccaf Reviewed-on: https://chromium-review.googlesource.com/c/1496477Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636828}
-
Nicolás Peña Moreno authored
This is a reland of ae50f0f0 Original change's description: > Unify input delay computations for UMA, UKM, and EventTiming > > This CL moves the input delay computations for UKM to further down the > pipeline to where they are computed for EventTiming. After this CL, the > same types of events are logged by both UMA/UKM and EventTiming. The > WebViewTest is fixed so that the artificial events move further enough > down the pipeline. The tests checking for pointerCancels are no longer > applicable since these only applied to the UMA/UKM computations, per > issue 924278. > > By unifying input delay computation, this CL also fixes frame > attribution for the UMA/UKM input delays: PageWidgetDelegate does not > know the target frame (before, it would tell the root that an event has > occurred even if it occurred in an iframe. > > Bug: 897656, 925130 > Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78 > Reviewed-on: https://chromium-review.googlesource.com/c/1476070 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635687} TBR=dtapuska@chromium.org, holte@chromium.org Bug: 897656, 925130 Change-Id: Ifa253657428ee7a04d3af7b06257482d7e948b58 Reviewed-on: https://chromium-review.googlesource.com/c/1496336Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#636827}
-
Edin Kadric authored
After selecting an item, the menu disappears. Then if we refocus on the EditableCombobox we expect the filtering to be based on the selected item. Before this CL it would still be based on the last thing we typed (a substring of the selected item), so it could show more items than necessary. This CL fixes the issue, adds a unit test, and refactors a little bit. It moves the ShowDropDownMenu call out of HandleNewContent, which is called inside OnItemSelected to fix the bug. Bug: 923660 Change-Id: Iaf6a713763d9d5dd5b2c96186fe2ea0898eec978 Reviewed-on: https://chromium-review.googlesource.com/c/1493516Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#636826}
-
Yi Gu authored
TBR=pkotwicz@chromium.org Bug: 937109, 937242 Change-Id: Icce1df35be4168053d8e3f22e0f502e56fd9d642 Reviewed-on: https://chromium-review.googlesource.com/c/1495971 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d01c24e5..c4eb13c7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I468fa88ad1f085426a22617566b41d806b6b2292 Reviewed-on: https://chromium-review.googlesource.com/c/1496764Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636824}
-
Sebastien Marchand authored
This will ensure that no observers are being leaked. Change-Id: I41d20eb4105afb894423113029563a548ec8507e Reviewed-on: https://chromium-review.googlesource.com/c/1487361Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#636823}
-
Elly Fong-Jones authored
This change removes third-party-doodles, and adds a comment to the switch it used to control explaining test URLs to use. Bug: None Change-Id: I37e1d90ec6aafa032bc95eac4f670a6b7f1d4cc2 Reviewed-on: https://chromium-review.googlesource.com/c/1494894 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636822}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/859abef68cb5..2997ec9a7a46 git log 859abef68cb5..2997ec9a7a46 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 srte@webrtc.org Removes unused keep-alive from RtpTransportControllerSend. 2019-03-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 24eaf090..8eb8e09f (636660:636762) 2019-03-01 srte@webrtc.org Inject TaskQueueFactory to video streams. Created with: gclient setdep -r src/third_party/webrtc@2997ec9a7a46 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia606fa78fa45fbc17bb18515655e356c8c6f4532 Reviewed-on: https://chromium-review.googlesource.com/c/1496894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636821}
-
Elly Fong-Jones authored
Per email discussions with mpearson and jdonnelly. Bug: None Change-Id: Ide70ace4a2c845f79eb82b311f60830692b802fe Reviewed-on: https://chromium-review.googlesource.com/c/1496917 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#636820}
-
chrome://explore-sites-internalsJustin DeWitt authored
This page is a Mojo-based WebUI page, and it supports the following operations: * Read key/value properties of the system, currently flag state, country code, and server endpoint. * Clear the catalog database. * Override the request country. * Force a network request. Bug: 900673 Change-Id: Iafff7c0b66f37a93bd46e7251ba231823951a513 Reviewed-on: https://chromium-review.googlesource.com/c/1310757Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636819}
-
Tibor Goldschwendt authored
Bug: 870056 Change-Id: I6e1dbf041d0b57a9457eb421cf7a4cc2a9cc7ebc Reviewed-on: https://chromium-review.googlesource.com/c/1494721Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#636818}
-
Elly Fong-Jones authored
Per email discussions with jdonnelly and mpearson. Bug: 936854 Change-Id: I33cf7093df298aab93f4ddeac01a58226f93a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/1496913 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Shao-Chuan Lee authored
Currently we only call SetProfile once during initialization with non-null |profile|. Remove preconditions that allow null |profile| if |profile_| is already set. This simplifies metrics recording logic in upcoming change as we no longer consider null |profile|. Bug: 929583 Change-Id: I68b4ac064ec07984844dc04f92ea46cf36613a21 Reviewed-on: https://chromium-review.googlesource.com/c/1493632Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#636816}
-
Yi Gu authored
This reverts commit 50c337ce. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable flaky test testPendingUpdateFileDeletedAfterUpdateCompletion > > TBR=pkotwicz@chromium.org > NOTRY=true > > Bug: 937109 > Change-Id: I877a311f3256b88a667ff8224904e2fe71acb30b > Reviewed-on: https://chromium-review.googlesource.com/c/1496767 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636812} TBR=pkotwicz@chromium.org,yigu@chromium.org Change-Id: I6d4183a9d42acc43566506e23b863bfd439b8033 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937109 Reviewed-on: https://chromium-review.googlesource.com/c/1496163Reviewed-by:
-
Yi Gu authored
This reverts commit 6c5b9879. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable flaky test testFileDeletedIfStoreWebApkUpdateRequestToFileFails > > TBR=pkotwicz@chromium.org > NOTRY=true > > Bug: 937242 > Change-Id: Ic705e4dcfa5abb1dcd0ff5baa32b51f7f84c6b42 > Reviewed-on: https://chromium-review.googlesource.com/c/1496765 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636805} TBR=pkotwicz@chromium.org,yigu@chromium.org Change-Id: Ib48da2f508e3fd302c5116ca23e2b9fd0030b727 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937242 Reviewed-on: https://chromium-review.googlesource.com/c/1495970Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:907849 Change-Id: I94d4b14b3b7a23e6cc1888c26c0e1f2f16183f4c Reviewed-on: https://chromium-review.googlesource.com/c/1495529Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#636813}
-
Yi Gu authored
TBR=pkotwicz@chromium.org NOTRY=true Bug: 937109 Change-Id: I877a311f3256b88a667ff8224904e2fe71acb30b Reviewed-on: https://chromium-review.googlesource.com/c/1496767Reviewed-by:
-
Alex Clarke authored
When a queue is disabled or blocked it's removed from the WorkQueueSet. It is invalid to call WorkQueueSet::OnQueuesFrontTaskChanged for a queue that is not in the set. Unfortunately RemoveAllCanceledTasksFromFront was doing that in the currently reverted patch to periodicallly reclaim memory. This patch adds a check to see if the queue is in the set before calling WorkQueueSet::OnQueuesFrontTaskChanged. Bug: 936734 Change-Id: Ib4a2e9d85d8360924fdf97f314e32c83a12c5800 Reviewed-on: https://chromium-review.googlesource.com/c/1495541Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#636811}
-
Anna Malova authored
This extra will be moved to CustomTabIntent eventually. Bug: 922969 Change-Id: I510e8c8901758fb9f4a5a009fee20df2e8ed71dc Reviewed-on: https://chromium-review.googlesource.com/c/1496875Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#636810}
-
W. James MacLean authored
At present TouchSelectionController uses |show_touch_handles_| to decide when handles are shown by touch events. It is set to 'true' in TouchSelectionController::WillHandleTouchEventImpl(). But if this value is defaulted to true, then PDFs may show the handles on the first selection, even if initiated by non-touch means. This doesn't show up in non-PDF pages, as there seems to be a mechanism in RenderWidgetHostViewAura that prevents the TouchSelectionController from ever being told about selection changes from non-Touch events. Some tests were fixed, since they relied on the old default value to avoid having to send actual touch events. The CL changes the default to avoid handles showing up for the first mouse selection in PDFs. Bug: 933631 Change-Id: I1d66df070c22481141f68f6085f04878842c9f2b Reviewed-on: https://chromium-review.googlesource.com/c/1491794 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636809}
-
Marc Treib authored
TBR=pwnall@chromium.org No-Try: true Bug: 937170 Change-Id: I6fdb63366939b9a027d327491da61cbda90e7205 Reviewed-on: https://chromium-review.googlesource.com/c/1496880Reviewed-by:
-
Yi Gu authored
See linked bug for details. TBR=einbinder@chromium.org NOTRY=true Bug: 937171 Change-Id: If82006056e04ee829668ad79a22bd1e2ec69e8b1 Reviewed-on: https://chromium-review.googlesource.com/c/1496766Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2dfb3f01e77d..1c92c159adf9 git log 2dfb3f01e77d..1c92c159adf9 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 cwallez@chromium.org Fix overflow in CommandAllocator 2019-03-01 cwallez@chromium.org Implement wrapping IOSurfaces in dawn::Texture. Created with: gclient setdep -r src/third_party/dawn@1c92c159adf9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I08022b2ef038872100a4a65ee964f7eedf52126a Reviewed-on: https://chromium-review.googlesource.com/c/1496893Reviewed-by:
-
Yi Gu authored
TBR=pkotwicz@chromium.org NOTRY=true Bug: 937242 Change-Id: Ic705e4dcfa5abb1dcd0ff5baa32b51f7f84c6b42 Reviewed-on: https://chromium-review.googlesource.com/c/1496765Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d85235292c2c..07a259de1240 Created with: gclient setdep -r src-internal@07a259de1240 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibefa7c9ab56301099ac47b8981d61da215f69280 Reviewed-on: https://chromium-review.googlesource.com/c/1496891Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636804}
-
Daniel Bratell authored
In an effort to reduce or even ban variable shadowing, this renames a variable. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warning this this avoids is: third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1762:40: error: declaration shadows a local variable [-Werror,-Wshadow] EffectPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here ScrollPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1776:40: error: declaration shadows a local variable [-Werror,-Wshadow] EffectPaintPropertyNode::State state; ^ third_party/blink/renderer/core/paint/paint_property_tree_builder.cc:1711:38: note: previous declaration is here ScrollPaintPropertyNode::State state; ^ Bug: 923510 Change-Id: Ia64158f91a8f07cd238e01b1e1e31b35a6b5ac06 Reviewed-on: https://chromium-review.googlesource.com/c/1496874 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#636803}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/328027b6c434..859abef68cb5 git log 328027b6c434..859abef68cb5 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 titovartem@google.com Use DefaultVideoQualityAnalyzer as default, cleanup headers. 2019-03-01 titovartem@google.com Fix namespace for PeerConnectionE2EQualityTestFixture 2019-03-01 mbonadei@webrtc.org Implicitly suppress //build/config/clang:find_bad_constructs. 2019-03-01 mbonadei@webrtc.org Fix peerconnection_quality_test #includes and deps. Created with: gclient setdep -r src/third_party/webrtc@859abef68cb5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1c4888d1f4a39666ee3e69355042183df578605b Reviewed-on: https://chromium-review.googlesource.com/c/1495793Reviewed-by:
-
Yi Gu authored
See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=worklet-animation-with-scroll-timeline TBR=treib@chromium.org NOTRY=true Bug: 915352 Change-Id: I7b1a586a9352fcb8b3a4a7d8ab838f199c0858b4 Reviewed-on: https://chromium-review.googlesource.com/c/1496763Reviewed-by:
-
Lucas Tenório authored
This is only the first step of renaming this feature, the next steps are: - Rename the Contained Shell references in chrome://settings and the rest of the browser. - Rename all occurrences of Contained Home to KioskNextHome. For this change, I'm mostly focusing on code living in ash. We are changing the name of this feature to reflect the refactoring work and ultimate goal. Also considered calling it MojoKiosk, but Mojo team prefers to keep the Mojo name referring specifically to the Mojo library, not uses of the library. Bug: 933530 Change-Id: I717cee439da14d6bbd575c26b9f55805ad4d5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1489272Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#636800}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9ea32aab..d01c24e5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06969b7e5e00125907609c0324545976283366e4 Reviewed-on: https://chromium-review.googlesource.com/c/1496761Reviewed-by:
-
Yi Gu authored
See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=worklet-animation-with-scroll-timeline-and-display-none TBR=treib@chromium.org NOTRY=true Bug: 915352 Change-Id: Ie287d2af0cd7fff9e2393e2918837867dcf4125d Reviewed-on: https://chromium-review.googlesource.com/c/1496762Reviewed-by:
-
Nicolas authored
After both the 'external' and 'IEEM' sitelists have been downloaded, LBS will now write the 'sitelistcache.dat' file with the combined sitelists' contents. Bug: 909878 Change-Id: I789f1e4b59f69af78c3c14a4330d48a50cac94d5 Reviewed-on: https://chromium-review.googlesource.com/c/1468121 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636797}
-
Yuki Shiino authored
Fix the bindings generator so that it won't use variable length arrays with zero sizes, which are forbidden by C++ standard. Bug: 932489 Change-Id: Ife08fe8be4e6b9907c3c97c8047c0432cdddd4bc Reviewed-on: https://chromium-review.googlesource.com/c/1490985 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#636796}
-
Robert Sesek authored
BufferIterator is a bounds-checked container utility to access variable- length, heterogeneous structures contained within a buffer. Bug: 932175 Change-Id: I41f81fca3671bc35fbe65d0dc71c8fd4742453c5 Reviewed-on: https://chromium-review.googlesource.com/c/1481654Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636795}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88ac583e6668..ab0bd92ed40d git log 88ac583e6668..ab0bd92ed40d --date=short --no-merges --format='%ad %ae %s' 2019-03-01 lalitm@google.com Merge "base: add hasher class for hashing data using FNV-1a" Created with: gclient setdep -r src/third_party/perfetto@ab0bd92ed40d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I24e518269fd7c5592bb82d54fb735a83296b9792 Reviewed-on: https://chromium-review.googlesource.com/c/1495791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28586cfa. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" a6d9cfda "[WPT] Changes to generated files by CL 1476144" 4665f96b "RestrictDeviceSensorEventsToSecureContexts by default." 03505df6 "[Origin Policy] Implement error reporting via Reporting API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic6cdce3016510a3e93830ce3f1980f0e41e7a839 Reviewed-on: https://chromium-review.googlesource.com/c/1496760Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636793}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fb02ade1a0b9..727c16174db3 git log fb02ade1a0b9..727c16174db3 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 perezju@chromium.org [Telemetry] Move tracing of agent method calls to TracingAgent Created with: gclient setdep -r src/third_party/catapult@727c16174db3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931236 TBR=sullivan@chromium.org Change-Id: I2793bbe5ada9e7d4601f02d3cb9ce8338f253a1b Reviewed-on: https://chromium-review.googlesource.com/c/1495792Reviewed-by:
-
Anna Malova authored
Add metric to trace how CCT translate feature is used. The usage of the feature is guarded by cct-target-translate-language flag. Bug: 922969 Bug: 931682 Change-Id: Ide16e218ab8f88aa5b7dd0208a0067d5ef1543d3 Reviewed-on: https://chromium-review.googlesource.com/c/1451895 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
-
Zinovy Nis authored
1) MachineLevelUserCloudPolicyManager::Init calls grand-parent Init() instead of parent'. 2) Minor std::move-related optimizations. Bug: <None> Change-Id: If252493c579690f7fe550c7fc2bb0f0188a314f4 Reviewed-on: https://chromium-review.googlesource.com/c/1340801Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#636790}
-
Martin Robinson authored
We calculate text offsets for the AtkText APIs using UTF-16 code units offsets, yet the values that touch the API surface are in Unicode character offsets. This is only an issue when the text contains UTF-16 characters with multiple code units. Use the Adjustments data structure to move between these two offset types. Bug: 866337 Change-Id: I09f81d0934ea1effe597c4c969d20135bbc1937c Reviewed-on: https://chromium-review.googlesource.com/c/1478798 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636789}
-
