- 30 Nov, 2020 40 commits
-
-
Jeffrey Kardatzke authored
This adds encrypted content support to the VAAPI H265 accelerator. This is not implemented in the driver yet, but this will facilitate better testing by Intel if we implement it first and it's fairly straightforward to do it. BUG=b:153111783,chromium:1141237 TEST=Builds, clear HEVC content playback works Change-Id: Ibe468777b663cbc301b6d2c14ab1d2bceeda8e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555544 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#831954}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/media_router Bug: 1113033 Change-Id: Ic399c177758d3fbfefa46b336080ed0091290793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545023 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831953}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dd3be2e78615..c4492956adde 2020-11-30 jacktfranklin@chromium.org Remove component bridges generation 2020-11-30 jacktfranklin@chromium.org Fix regression in keyboard navigation of SoftContextMenu 2020-11-30 pfaffe@chromium.org [wasm debug] Fix propagating debug evaluate errors in language plugins 2020-11-30 yiorsi@gmail.com Add copy css context menu in Styles panel 2020-11-30 raphael.kubo.da.costa@intel.com SensorsView: Set angle input type to "number" in createInput() call. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137514,chromium:1152391,chromium:1153315 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e9162d840acb54175872e3a985c4e7fdf60611f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831952}
-
Jeremy Roman authored
They're cool and efficient. This should be more efficient at runtime but approximately as readable in the source text. Change-Id: Id8b8a2b1c8b869c4a3f22326bfa381fb67b3de13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562819 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#831951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dc75a97b8010..c4fbc8d6cf34 2020-11-30 robertphillips@google.com Stop overflow of windows rects in GrClipStack 2020-11-30 johnstiles@google.com Fix SPIR-V and Metal support for enum types. 2020-11-30 johnstiles@google.com Fix SPIR-V compilation error with arrays of samplers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I7b0d288842aeefc977b942d0db79ad94468332c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565106Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dc7b108da629..eb386eb3d290 2020-11-30 vapier@chromium.org Reland "repo: auto-update depot_tools when used" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148984 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2a488e1e038c34459b27b46f16b162d6d3144bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565107Reviewed-by:
-
Shimi Zhang authored
We are calling Icon#loadDrawable on the UI thread previously, based on the Android doc, we should use Icon#loadDrawableAsync instead. Previously, this is not enforced, but now we encountered a StrictMode violation for this. Since now we are calling Icon#loadDrawableAsync, we need to pre-warm the Drawable before we show the popup menu, otherwise the icon will be set after the popup menu showed for the first time. Bug: 1129211 Change-Id: Iac5127a307d1d2d124a4b2debb7b021a2be2da75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562059Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831948}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/printing... Bug: 1113033 Change-Id: I4f0aeb9552b900c80bec42e9435a49118f4903c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555558Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831947}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I81b1f6a8fb76d2ca7120a12e7fab1a66156aef11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561391 Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#831946}
-
Rushan Suleymanov authored
The removed DCHECK could be violated in case when SendTabToSelfBridge is initialized and DeviceInfoSyncBridge hasn't been initialized yet (and the local cache GUID hasn't been stored in recent cache GUIDs). There are several possible cases when it happens: 1. DeviceInfoSyncBridge::OnReadData is done, however metadata hasn't loaded yet. It means that DeviceInfoSyncBridge::IsSyncing() will return true while the cache GUID is not known. 2. (less likely) Cache GUID has changed and the old metadata of DeviceInfoSyncBridge has been loaded (but OnSyncStarting hasn't been called yet). In both cases if SendTabToSelfBridge is fully initialized (both metadata has been loaded and OnSyncStarting has been called with a new cache GUID), then the DCHECK will fail. Bug: 1023457 Change-Id: I27951f825a7b900b55d8a22b645064c53a056c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563488Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#831945}
-
Aaron Leventhal authored
AddChild() already does two useful things for us: - Null checks, doesn't add child if there isn't one - Recursively adds descendants if the AXObject isn't included in tree Also progresses toward a future change where adding children automatically sets the parent to |this|, rather than needing to compute it and possibly getting different results. See CL:2528573. There are still a couple of remaining cases not addressed, but are addressed in other WIP CL's. Bug: None Change-Id: Id1632732c66bc17173294e62092d8be58cf88873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564465 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831944}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I09ca87f01720518bd5d4cd7972b6de89ff362f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564388Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#831943}
-
John Abd-El-Malek authored
Bug: 987448 Change-Id: I0236f4821f3a13519ef51c0c1825be1bd9c2e8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560813 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#831942}
-
Mustafa Emre Acer authored
This aligns the expiry of Navigation.MainFrameFormSubmission.SiteEngagementLevel with Navigation.MainFrame.SiteEngagementLevel. Bug: 1140053 Change-Id: I36ba7bdf1980f494fb6798e4a9902e45d67366b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561700Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#831941}
-
Xinghui Lu authored
Bug: 1152553, b/173469874 Change-Id: I5eb5ff522c67626fa7edfbefb383f9d25923b2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558785Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#831940}
-
Sorin Jianu authored
This changes also the names of params from first/second to fst/snd to avoid confusion with the std::pair members. Bug: 1153907 Change-Id: I1a9f09b8442f3ed42fb5d02a57fd47b939ed7a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564486Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831939}
-
Mike Reed authored
Having to land this to get tests to pass: https://skia-review.googlesource.com/c/skia/+/338936 Bug: skia:11004 Change-Id: I328c59d91b430744cbf2046f00964f26ec660009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561707Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#831938}
-
Michael Thiessen authored
The CCT doesn't always have a tab by the time the Activity is resumed (not yet with native). Bug: 1153703 Change-Id: I1315d32b8b8ec635b865a9d661a661d3ed3f0061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564690Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#831937}
-
Peter McNeeley authored
When the path for the accelerometer "/dev/cros-ec-accel/" is inaccessible this error reporting will spam the log many times per second. Here we simply add a backoff to throttle how often this logging will occur. The reason for the inaccessibility of this path is likely due to incorrect group setting. Some dev-only specific changes may be required to the file below in order to apply these group settings in a dev/debug specific context. https://source.corp.google.com/chromeos_public/src/third_party/ chromiumos-overlay/chromeos-base/chromeos-accelerometer-init/ files/udev/99-cros-ec-accel.rules?q=mems_setup&ss= piper%2FGoogle%2Fchromeos_public:src%2F&start=31 Change-Id: I12ad7d27e5710c86292ca08dee0f5680a2ddb153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563700Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#831936}
-
Peter Wen authored
When d8 is used for desugaring instead of bazel's desugar, lambdas may not have a .dex suffix. This CL accounts for lambda normalization where apkanalyzer's output does not have .dex suffixes. This CL also fixes output for supersize html_report. Bug: 1015559 Change-Id: I5e81f4b03562047bfcfadcfa91a73339cf21850b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562792 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831935}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41e380345098..e177dd9adffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131960 Tbr: rogerta@google.com Change-Id: I933b5d6a0bdedf184199e62615a1de2d7b89386c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831934}
-
Illia Klimov authored
Bug: 1149393 Change-Id: I185c8e76078af0137d9d82b1dbbb78b67928cd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564762Reviewed-by:
-
Patrick Noland authored
Bug: 1153875 Change-Id: I050d43c1faaa07e21746fa1e0c58f498e18d8593 TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565733Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831932}
-
Akihiro Ota authored
The reason this test was flaking is because the tutorial opens whenever ChromeVox is started in OOBE. As a result, a speech expectation would fail periodically. Out of 10 initial test runs, 2 failed. After this patch, all 10 test runs succeeded. Bug: 1153710 Change-Id: I680ea42859414bd8c94a10a8c1f586c11cb381ce AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563877Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#831931}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/services Bug: 1113033 Change-Id: I77be505bd5f33ee1bd83a594ec09aa64cac21420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831930}
-
Joshua Pawlicki authored
Bug: 1149863 Change-Id: Idd49249653a3b5d845dd4bc9a87601de35cfbc05 Fixed: 1149863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563876 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831929}
-
Regan Hsu authored
ChromeVox will also verbalize the updated tooltip text when the user navigates to the icon. screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/82bd6c8d6f97a440125bbac1610cc42331efeca6 Fixed: 1152778 Change-Id: Iab5de3cb6024f7151aea3c5632de7f6679080763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560996 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#831928}
-
Tamir Duberstein authored
This is a reland of 1bef8501 Original change's description: > [fuchsia] Enable UDPSocketTest.JoinMulticastGroup > > Assert after each send call to better pinpoint future problems. > > The test passes locally. > > Fixed: 1125855 > Change-Id: I30d5c7bd2bc14fbd9547b1eb6d309d7556274891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404483 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Tamir Duberstein <tamird@google.com> > Cr-Commit-Position: refs/heads/master@{#806111} Fixed: 1127298 Change-Id: I8d20c8247d9729511963eff35a6f276e0a82ae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405934Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#831927}
-
Clemens Backes authored
We currently use the existing v8 inspector tests as seed for the inspector fuzzer. They don't work well for a couple of reasons though: 1) The inspector tests use utilities defined in the 'protocol-test.js' file, which is preloaded automatically by the inspector test runner. That file is part of the corpus, so the fuzzer might get lucky and combine 'protocol-test.js' with another corpus file, but in most cases it won't. 2) The inspector fuzzer does not provide all utils that the inspector-test executable provides. In particular, file access is prohibited, i.e. `utils.read` and `utils.load` are not available. 3) Some tests load more files as prerequisite, e.g. all wasm tests load the 'wasm-inspector-test.js' file which defines wasm-specific utilities. 4) The current corpus also includes the '*-expected.txt' files, which is not a big problem, but adds files to the corpus which are not interesting for the fuzzer. This CL fixes all these issues by generating the corpus via a small python script. The script scans the v8/test/inspector directory for '*.js' files, and generates a respective fuzzer corpus file in the output directly. This file includes a copy of the 'protocol-test.js' file, and all `utils.load` calls are resolved as well. R=mbarbella@chromium.org CC=machenbach@chromium.org, szuend@chromium.org Bug: chromium:1142437 Change-Id: I1f15182b7afcc7741c9daf96af8e734af3325f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563552Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831926}
-
Patrick Noland authored
PasswordSettingsTest#testSearchTextInOverflowMenuVisibleWithFeature Bug: 1153707 Change-Id: I75a24aa1600c3625c70b9166886bfd9b88f2f645 TBR: fhorschig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564216Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I5753fffa991af72c48e0ca175a794040b0637b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562144 Commit-Queue: Peter Williamson <petewil@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#831924}
-
Jose Dapena Paz authored
Fix compilation error: ../../base/compiler_specific.h:97:28: error: attributes are not allowed on a function-definition 97 | #define WARN_UNUSED_RESULT __attribute__((warn_unused_result)) | ^~~~~~~~~~~~~ ../../media/gpu/vaapi/vaapi_wrapper.h:322:36: note: in expansion of macro ‘WARN_UNUSED_RESULT’ 322 | const T* data) WARN_UNUSED_RESULT { | ^~~~~~~~~~~~~~~~~~ Bug: 819294 Change-Id: I24e2e10a96182f8705fed96164550357acdb55a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534931 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/gcm_driver Bug: 1113033 Change-Id: Ief65b636329b792885a00dd81201361da28e0ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543585Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831922}
-
David Van Cleve authored
This is a revert of crrev.com/c/2451571, which added short-term logging to propagate resource blocks caused by extensions to the Fetch API surface and expanded the TrustTokens.FetchFailedReason enum to include this case. Now that we've finished the investigation for which we added this instrumentation, we can clean up the logging changes. This is the first of two cleanup CLs; the next CL will remove the remaining FetchFailedReason logging in FetchManager. Bug: 1133944 Change-Id: I24ddbf366eb288f4b3c7cd1dbd3cc324918bc644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561742Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#831921}
-
Maciej Pawlowski authored
Sometimes cursorPosition computed based on mUrlBarEditingTextProvider would be larger than the size of textWithoutAutocomplete given to onTextChanged(). This happened when typing really fast on a slow device, in Debug builds. To ensure this situation doesn't trip a DCHECK within AutocompleteControllerAndroid, use the up-to-date value of mUrlBarEditingTextProvider's text when passing a computed cursor position. Bug: 1142817 Change-Id: Id6ef48d561461fd711cbc9a4abab8851b8406a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503693Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Maciej Pawlowski <m.pawlowski@eyeo.com> Cr-Commit-Position: refs/heads/master@{#831920}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9dff6a3bb595..7cbb98085a26 2020-11-30 bclayton@google.com SpirvShaderDebugger: Fix crash when attempting to display nullptrs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1e4920746a2b6151dbce8a3604c7e81d47e1ae0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565101Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 1023510 Change-Id: Iaa28b3b7eb61add4708a94fdca86e1def919c35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545878Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#831918}
-
Peng Huang authored
libxshmfence has two implementations (futex and pthread), It depends on the build environment and build flags in build time. The Xserver and X clients must use the same implementation to work. So we cannot put libxshmfence in //thrid_party/ and link it in statically. Chrome has to use system provided libxshmfence.so which is used by the Xserver to work. Bug: 1153156 Change-Id: I0c9f9f6d716fa7cd5fc389f887618adc9eea206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563871Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#831917}
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3420b6c260b9fa94847b9b63df0438a9bce0b1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556838 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831916}
-
Robert Kroeger authored
conformance/extensions/s3tc-and-rgtc.html is persistently failing on NVidia Shield on GPU FYI. Suppress the test. Bug: 1153676 Change-Id: Ia7fb0cc2779c3fffd58bf081349e32c55fccc560 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564056Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#831915}
-
