- 03 Oct, 2018 40 commits
- 
- 
Nico Weber authoredIt's now redundant with is_mac. The biggest use of it was that it set the buildflag MAC_VIEWS_BROWSER, but I removed all references to that in the last few days: https://cs.chromium.org/chromium/src/ui/base/BUILD.gn?q=%5CbMAC_VIEWS_BROWSER+case:yes Bug: 832676 Change-Id: I9bd74e26a35ddb4dfec786e4b0a6ada24366c951 Reviewed-on: https://chromium-review.googlesource.com/c/1258295Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596238} 
- 
Shahbaz Youssefi authoredPrior to this commit, the passthrough program cache used EGL_ANGLE_program_cache_control to store binary programs in angle's cache. With support for EGL_ANDROID_blob_cache added to angle, this role is reversed, i.e. the blob cache lives in the application (chrome), with the implementation (angle) storing additional data through callbacks. Bug: angleproject:2516 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I62d5c484580d953013d00e31300285be6b9442ce Reviewed-on: https://chromium-review.googlesource.com/c/1251325Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596237} 
- 
Geoff Lang authoredui/gl initialization is now in a sub library, move the dependencies. Require a flag to use ANGLE on Android, this allows ANGLE and the native driver to both work with a given build so we can test on the bots. BUG=726002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d3e0c4e844dca9e72c363f07e011c710e1a9f57 Reviewed-on: https://chromium-review.googlesource.com/c/1244078Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596236} 
- 
Rouslan Solomakhin authoredBefore this patch, rotating a device with the Payment Handler CCT could result in cutting off the bottom of the CCT, making a part of web content inaccessible. This patch updates the height of the window when configuration changes. The height is never more than the height of the screen available to the activity. After this patch, rotating a device with the Payment Handler CCT will resize the CCT to always fit on the screen, so all web content is accessible to the user. Bug: 890184 Change-Id: I6ddf93f61e08e6a6281192e6a57b703ac18694ce Reviewed-on: https://chromium-review.googlesource.com/c/1252404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596235} 
- 
Boris Sazonov authoredThis CL reimplements SyncAndServicesPreferences.updateDataTypeState to unify configuration of checkboxes. It resolves the issue when all checkboxes become enabled even though requirements for some data types aren't met. Bug: 889015 Change-Id: If9cffded02ce163edd33eaeeba73ddd244b9ce89 Reviewed-on: https://chromium-review.googlesource.com/c/1258007Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596234} 
- 
Lindsay Pasricha authoredBug: 852504 Change-Id: I8599be996f3a556228e4abeda0aedff57b3b49b4 Reviewed-on: https://chromium-review.googlesource.com/c/1258290Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596233} 
- 
Jinho Bang authoredReason for revert: A crash occurs because two animations runs in the same time. In the current implementation, the ViewStack class seems to be able to run only one animation per one time. So, before one animation finishes, if another animation runs, it might cause a crash. The ShowInitialPaymentSheet() doesn't make animation internally but the GoBackToPaymentSheet() do. So, after retry() calls, if shipping address or contact editor runs, it might cause a crash because two animations runs in the same time. To resolve this issue, this CL adds a parameter to GoBackToPaymentSheet() to control whether animation runs or not. If the `animate` parameter is false, just runs without animation. We don't need to run animation when retry() calls because the payment sheet is already hidden and the processing spinner is showing. Original change's description: > In the current implementation, memory leaks occur becuase the internal > view_stack_ for payment sheet grows incrementally whenver calling > retry(). So, this patch uses GoBackToPaymentSheet() instead of > ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to > reduce stack's size internally. > > Bug: 861704 > Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc > Reviewed-on: https://chromium-review.googlesource.com/1255082 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#595644} Bug: 861704 Change-Id: I5ab64423697aa11de97bf68ec9d9f262d7676bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1258813Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#596232} 
- 
Oskar Sundbom authoredBug: 874784 Change-Id: I63e6185605e25bf009de8b319f72a9fd459672c9 Reviewed-on: https://chromium-review.googlesource.com/c/1257915Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596231} 
- 
Stephen McGruer authoredThis test has been flake-crashing on these bots. TBR=mamir@chromium.org Bug: 889505 Change-Id: If527913f0e15f4d298b81c578d17a762f573be0e Reviewed-on: https://chromium-review.googlesource.com/c/1258966Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596230} 
- 
chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/416018d455bf..d136b2884e0d git log 416018d455bf..d136b2884e0d --date=short --no-merges --format='%ad %ae %s' 2018-10-03 oprypin@webrtc.org Prevent NaN and Inf values in webrtc_perf_test 2018-10-03 brandtr@webrtc.org iOS: Add numTemporalLayers to RtpEncodingParameters. Created with: gclient setdep -r src/third_party/webrtc@d136b2884e0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b4329c75e61be31294cbe3a0bdcbc7ebeb38368 Reviewed-on: https://chromium-review.googlesource.com/c/1258876Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596229} 
- 
Xianda Sun authoredThe newly added MainThreadScrollingReasons: kWheelEventHandlerRegion and kTouchEventHandlerRegion cannot be displayed correctly on UMA. This CL updates the histogram enum in order to fix this bug. Bug: 861754 Change-Id: Ibd165ffe477cbc405d047bc820c77056d730ec6e Reviewed-on: https://chromium-review.googlesource.com/c/1257549 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596228} 
- 
Sylvain Defresne authoredReplace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/sync. This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 809610 Change-Id: If489e869a7f9143528ef89411b1a8d7c6e24b79b Reviewed-on: https://chromium-review.googlesource.com/c/1245729Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596227} 
- 
chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/5b2bc879189c..55aea84baa53 git log 5b2bc879189c..55aea84baa53 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 egdaniel@google.com Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN." 2018-10-03 borenet@google.com [infra] Also run install_go_deps.sh during go_deps asset creation Created with: gclient setdep -r src/third_party/skia@55aea84baa53 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:862144 TBR=mtklein@chromium.org Change-Id: Iec08865684a554ae2af371c287ec4fce3c7a3885 Reviewed-on: https://chromium-review.googlesource.com/c/1258875Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596226} 
- 
Paul Wankadia authoredhttps://chromium.googlesource.com/external/github.com/google/re2.git/+log/bfe29206c269..54ca2cd59219 $ git log bfe29206c..54ca2cd59 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 junyer Make the fuzzer check size before computing rsize. 2018-10-02 junyer Make the fuzzer limit reverse program size and fanout. 2018-09-28 junyer Mention (?m) in the comment about posix_syntax == false. 2018-09-20 junyer Add Clang 7 to the Travis CI matrix. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: Ida46ef13d8b73fb30db7894cd3e8a5b6ab8f739c Reviewed-on: https://chromium-review.googlesource.com/c/1258964Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Paul Wankadia <junyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596225} 
- 
Aldo Culquicondor authoredThis reverts commit 31783d1f. Reason for revert: Crash when opening a new tab. Original change's description: > VR: Remove bottom margin from NTP > > Bug: 884803 > Change-Id: I20378649418949c2d00097ff8ca204972c54b2ab > Reviewed-on: https://chromium-review.googlesource.com/1240169 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595884} TBR=twellington@chromium.org,mdjones@chromium.org,acondor@chromium.org Change-Id: Ifef474e5c9183a32934a1eeb401c2a5e7e3e505f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884803 Reviewed-on: https://chromium-review.googlesource.com/c/1258299Reviewed-by: Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596224} 
- 
Reilly Grant authoredWith the network service we are deprecating the concept of a net::URLRequestContextGetter. A content::StoragePartition (which owns a network::mojom::NetworkContext) is the right layer of abstraction for expressing what this function operates on. Bug: 792678 Change-Id: I22caa1f85357c2b482f6973365d52bcfa59d02d5 Reviewed-on: https://chromium-review.googlesource.com/c/1257896Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596223} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6d20f5c09f..b21e4a509d0c Created with: gclient setdep -r src-internal@b21e4a509d0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2892201f3bd103a4438096a7a1dafba8fce561d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258872Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596222} 
- 
Stephen McGruer authoredThis reverts commit 14de2307. Reason for revert: Newly added test WaylandScreenTest.MultipleOutputsAddedAndRemoved fails on ChromeOS ASAN/LSAN; see crbug.com/891718 Original change's description: > [ozone/wayland] Add remove output functionality > > This CL adds a new functionality to the existing WaylandOutputManager > and WaylandScreen classes. Now, it is possible to remove and > change primary displays on hot plugs and removes. > > To test that functionality, a new test has also been added. > > The logic that assigns output ids has also been changed. > Now, we are using numeric names that a Wayland compositor > announces during Global and GlobalRemove calls. That is, > each global object is assigned an unique numeric name, which can > be freely used as an id. > > Bug: 890276, 875161 > Change-Id: I775bdd40a946c9f0c5dde89eba6e36c4615e1f21 > Reviewed-on: https://chromium-review.googlesource.com/c/1254146 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596155} TBR=rjkroege@chromium.org,msisov@igalia.com Change-Id: I8ae1f0fa1df71b464096abd0fcd504c1d4f5f480 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890276, 875161, 891718 Reviewed-on: https://chromium-review.googlesource.com/c/1258914Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596221} 
- 
Dave Tapuska authoredUse wtf_size_t when dealing with WTF types. BUG=879657 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5f7d23ee54ccad62cf42961fec86ad8b4801a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1258047 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596220} 
- 
Aldo Culquicondor authoredThese methods don't affect the BrowserRenderer. The task posting is done in VrGLThread instead. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie43b046c71b7293d33316f4029f0fd7710c19869 Reviewed-on: https://chromium-review.googlesource.com/c/1258283 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#596219} 
- 
Finnur Thorarinsson authoredBug: 860467 Change-Id: I3173492480955a562415bd8885b6b92fb6cbf5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1256782Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#596218} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/607f907d47b0..c3bef3e7b028 git log 607f907d47b0..c3bef3e7b028 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Allow 'defined' in define in non-WebGL. Created with: gclient setdep -r src/third_party/angle@c3bef3e7b028 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9a293a9b4379033c32c047031d5700c7897d31ec Reviewed-on: https://chromium-review.googlesource.com/c/1258874Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596217} 
- 
Bailey Berro authored- Fixes a nullptr dereference crash when SetupKerberos times out. Bug: chromium:891517 Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f Reviewed-on: https://chromium-review.googlesource.com/c/1258216 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596216} 
- 
Stephen McGruer authoredTest appears to be heavily timeout-flaky, unclear as to why it suddenly became flaky at this time. Bug: 891530 Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 TBR=bokan@chromium.org Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1258620Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596215} 
- 
stkhapugin@chromium.org authoredDeletes all the legacy code that is not used in UI Refresh. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99f1ee75475187951b96a037e7874c735e459996 Reviewed-on: https://chromium-review.googlesource.com/c/1235717 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596214} 
- 
Andrew Grieve authoredBug: 860531 Change-Id: I03983ef066185bfc5aa40a34c9ced4fbfd2c97e2 Reviewed-on: https://chromium-review.googlesource.com/c/1258055 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596213} 
- 
Guido Urdaneta authoredWhen the last track from a source is removed, the source is asynchronously stopped. Between the request to stop and the reception of a notification about actual stop it is possible that a new track is added to the source (e.g., by cloning the track being removed). There was a DCHECK asserting that there could be no tracks when the stop notification is received, but as the example above shows, this is not necessarily the case. No further changes are required since the newly added track will start out ended due to being connected to a stopped source. A test that fails with the old DCHECK is added to prevent similar regressions. Drive-by: Replace the |webkit_| prefix with |web_| on the test. Bug: 770908 Change-Id: I7ce01d3f0a2a5f77e161c88eb58c5334fad0aa3b Reviewed-on: https://chromium-review.googlesource.com/c/1258002Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#596212} 
- 
Justin Cohen authoredBug: 883770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2b7a57e57047677304ba572b9648e998563a8d39 Reviewed-on: https://chromium-review.googlesource.com/c/1256442 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#596211} 
- 
Ehsan Chiniforooshan authoredWe would like to deprecate smoothness metrics and replace them with equivalent TBMv2 rendering metrics. To prevent those changes from breaking benchmarks that use legacy smoothness metrics, this CL chanes those benchmarks to compute both legacy and equivalent TBMv2 metrics. After the transition is complete, we can just compute TBMv2 ones. Bug: 890757 Change-Id: I95203ec76a09be2273e4f71fe3e372e1ff04cc6d Reviewed-on: https://chromium-review.googlesource.com/c/1258213Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596210} 
- 
Mythri Alle authoredV8 API will deprecate the non maybe versions of v8::Object::Has and v8::Object::Delete. Updated extensions/ to use maybe versions. Bug: v8:7284 Change-Id: I966abdec0226c5999cacd5bf5daf993747179287 Reviewed-on: https://chromium-review.googlesource.com/c/1254208 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596209} 
- 
Dave Tapuska authoredUse wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: Ic2eec59581223c897b76675a2d7b1fb47a1327da Reviewed-on: https://chromium-review.googlesource.com/c/1257681 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596208} 
- 
Steve Anton authoredTBR=hta@chromium.org,haraken@chromium.org Bug: 864871 Change-Id: I6a2e0dc98efc58e22b33066ee3d37ded3c9b021a Reviewed-on: https://chromium-review.googlesource.com/c/1258503 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596207} 
- 
Hugo Holgersson authoredWith snav-testharness.js, the flakiness seen in Issue 836275 will most probably be gone. Bug: 803086, 836275 Change-Id: If44b1ca5c88af3c0fcc045061cdce50dcc91a276 Reviewed-on: https://chromium-review.googlesource.com/c/1257919Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#596206} 
- 
Tim Volodine authoredThis patch provides an initial implementation of the URLLoaderFactory for Android WebView and hooks it up for usage when the Network Service feature is enabled. At this stage the implementation is pass-through, i.e. it simply forwards requests further to the target factory and eventually the network. Further functionality will be added in subsequent patches such as the ability to intercept/block, error callbacks etc.. BUG=841556 Change-Id: I079b21d4d17b064b2e013f7c5692dea3b02e1a04 Reviewed-on: https://chromium-review.googlesource.com/c/1244458 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596205} 
- 
Nico Weber authoredBug: 845389 Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4 Reviewed-on: https://chromium-review.googlesource.com/c/1258293Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596204} 
- 
Justin Cohen authoredAlso note that -correctMissingSafeArea in content suggestions VC can be bypassed when the BrowserContainerFullscreen feature is enabled. BUG: 849206, 836730 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id876a66b1509cdec64a645b59c296186c31fa8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1255984Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596203} 
- 
Fredrik Söderquist authoredHoist call to ResolveTargetElement() out of HasCycleUseReferencing(), leaving the latter only checking for cycles. Drop the InUseShadowTree() check from BuildShadowAndInstanceTree since its single caller checks it already. Use ToSVGElementOrNull to simplify the code a bit. Bug: 397525 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idb6cbd9e155d6217db77ef97299e77fa57cd0d8d Reviewed-on: https://chromium-review.googlesource.com/c/1257918Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596202} 
- 
Aldo Culquicondor authoredBug: 891495 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6b4aa77dc0c81b79afe681c31ed2b4a06f19dc37 Reviewed-on: https://chromium-review.googlesource.com/c/1257816Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596201} 
- 
Fabio Tirelo authoredThis was requested during UI review for the feature that split the Autofill Settings page into Profiles and Payment methods, so that they will be consistent with the user menu. Screenshots can be found in the bug. Bug: 891454 Change-Id: I2a436d08d2e6bbb9c1f4730cbf43351100006bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1258050Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596200} 
- 
Eric Seckler authoredThe linux jumbo bot is flaking on content nocompile tests due to the nocompilation tests timing out. This patch increases the timeout to twice what it was before. Bug: 882852 Change-Id: Ib2bc0023acd8d677ea77eb2769a5f83da39ed0da Reviewed-on: https://chromium-review.googlesource.com/c/1248601Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#596199} 
 
-