- 10 Mar, 2020 18 commits
-
-
Brian Sheedy authored
Removes expected leftover minidumps from several tests that intentionally crash a Chrome process. This is so that these intentional crashes are not caught as failures once pre/post test minidump checking is enabled with crrev.com/c/2090590. Bug: 1056235 Change-Id: Iad026563b3a7acfc6e2078ffec36a000ed4b2dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080863 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748433}
-
Aran Gilman authored
Bug: 925965 Change-Id: I9f90480657c8ff856555c4d68c687cb7880265e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095411 Commit-Queue: Aran Gilman <gilmanmh@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#748432}
-
Tim Song authored
BUG=1040648 Change-Id: I897158eb5098bd08d36b2a37b0a1731909ae51e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095669Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748431}
-
Weiliang Chen authored
gpu::MemoryTracker is created inside InProcessCommandBuffer and SkiaOutputSurfaceImplOnGpu. Plumb them out to be shared with OverlayProcessor. OverlayProcessor for Android classic only reads the shared image, so it was not required to plumb the memory tracker correctly. This is in preparation for other overlay platforms. TBR=boliu, kylechar R=rjkroege Bug: 979788 Change-Id: I73d6d8e34fd7ef9e0c61df3d25ce4e7af954ef54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042385Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#748430}
-
Joel Hockey authored
Non-tabbed apps (such as settings) now have the same themepack color for frame and active_tab. Previousley, autogenerated theme pack colors always force these colors to have some contrast. In the case of settings, the contrast color is light grey, and it is the color used for NTP_BACKGROUND (bg shown until page loads). Given that there is no need for frame/active_tab contrast for a non-tabbed app, it is better to have them both the same color. Bug: 1053823 Bug: 1059696 Change-Id: Iaf2e6cbf6f3db9fe2c1d98c32692e3e74e8a7ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094484 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#748429}
-
chrome://media-appTrent Apted authored
AbstractFile.overwriteOriginal is implemented in the guest context to send IPC to the privileged host to achieve the file write. To ensure the correct file is written, a token is passed on IPC load requests. Only the file that the privileged context determines is "current" may be written to by the unprivileged guest. Testing - Remove receiver_api.js and depend on receiver.js directly for type checking. - Mock out the native file system on the host side. - Add a test-only IPC to trigger AbstractFile.overwriteOriginal(). Bug: b/146580738 Change-Id: Ie68213e3e1412a2d1fd63d8039d71858f5b4c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090992 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#748428}
-
Victor Hugo Vianna Silva authored
These histograms are still relevant from a UX perspective, so this CL extends their expiry dates to 1 year from now. Fixed: 1053274,1053275 Change-Id: I9449dc9fa7578b977e2ff174b7b11832968f1a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095061Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#748427}
-
Victor Costan authored
https://crrev.com/c/2076423 added new templated methods to base::TaskRunner, which use base::BindOnce and base::Owned. These are declared in //base/bind.h, which is not included. This IWYU omission results in occasional compilation errors. Example in the attached bug. Bug: 1059591 Change-Id: Ia927ec3fac35966793b801059925d7c950319c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094086 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#748426}
-
Torne (Richard Coles) authored
A recent change broke this test's intended purpose by moving the point where it started Chromium. Avoid this happening again in future by better documenting what the test is actually doing and why. Change-Id: I1fc3de0bb3b0d63e3c9063aa733fb200a959336e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095441 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748425}
-
tby authored
Some of the existing file icons look bad in the chips, because the chips have a different background colour that results in them being low-contrast. This CL refactors the file_icon_util.* files to allow either the original or new icons to be retrieved. The main change is to split GetIconResourceIdForLocalFilePath into GetIconTypeForPath GetResourceIdForIconType GetChipResourceIdForIconType The former method took a file path, found correct Icon enum, then found the correct resource ID for the enum. The new methods separate out the enum-finding step from the resource- loading step, so that the Chip function can first try and return a chip-specific icon, and then fall back to the original icons if needed. Bug: 1034842 Change-Id: Ia7c3310c771993909f8d8b535229173bedb528d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089182 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748424}
-
Antonio Gomes authored
This is inspired on [1], by kinuko@. [1] https://crrev.com/c/2016524 BUG=704136 R=dcheng@chromium.org, sky@chromium.org Change-Id: Ic3a503229b346c3236b113804eca0279cff025ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090733 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#748423}
-
Karandeep Bhatia authored
Screenshot: https://screenshot.googleplex.com/gDkAoBBUF28.png BUG=1038831 Change-Id: Iac2f49a7d4af6ad1d4ccee8c445a877ca058b866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088732 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748422}
-
Mitsuru Oshima authored
The test was added to check if the panel produces expected dsf. This CL enahance the test to check if it produces expected size in dp and screenshot size. Bug: None Change-Id: I1112df16156352ed126db968da1427d257395c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094575Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748421}
-
jonross authored
The Mac FYI GPU ASAN bot is currently failing 25% of the time due to flaking failures in the WebGL Conformance tests. This change marks those tests as RetryOnFailure to attempt to recover from the flakes. TBR=ynovikov@chromium.org Bug: 1059760 TEST=webgl_conformance_gl_passthrough_tests webgl_conformance_validating_tests webgl2_conformance_gl_passthrough_tests webgl2_conformance_validating_tests Change-Id: I1f5143422ca02f96cb899f4b9ad175508238ec3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095318 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#748420}
-
Raul Tambre authored
The unicode type no longer exists in Python 3. All UKM data seems to be ASCII, so we can go the easy route and use the str type. Traceback (most recent call last): File "../../tools/metrics/ukm/gen_builders.py", line 16, in <module> import ukm_model File "C:\Google\chromium\src\tools\metrics\ukm\ukm_model.py", line 31, in <module> ('type', unicode, None), NameError: name 'unicode' is not defined Bug: 941669 Change-Id: I54542ea0e6f186432a75b24763486bac2624b163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081813 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8ecb862ae74d..da0658022d4c git log 8ecb862ae74d..da0658022d4c --date=short --first-parent --format='%ad %ae %s' 2020-03-09 bravi@microsoft.com Adding test cases for enter key press on buttons 2020-03-09 bravi@microsoft.com Moving drawing focus rect to class CFX_DrawUtils 2020-03-06 tsepez@chromium.org Remove stray forward declaration of CFXJS_Engine. Created with: gclient setdep -r src/third_party/pdfium@da0658022d4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I847d0624887b02a2b0a9a369fbc0644f1d7d6a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748418}
-
dpapad authored
Specifically moving - clear_browsing_data_dialog/clear_browsing_data_dialog.html - privacy_page/cookies_page.html - privacy_page/security_page.html - site_settings/all_sites.html Which results in 15.4% less JS/HTML code loaded during Settings startup (measured on Linux builds) vulcanized.html: 342K -> 286K (-16.4%) crisper.js: 390K -> 333K (-14.6%) lazy_load.vulcanized.html: 153K -> 209K (+27%) lazy_load.crisper.js: 189K -> 246K (+30%) Also fixing a bug that was revealed as a result of these changes where <settings-ui> was not properly clearing some global state when it was detached from the DOM, causing test failures. Bug: 1026064,1032584 Change-Id: Ibf6ef69916ae7a656b9b2576947294bea87ef5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090840Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748417}
-
Ryan Hansberry authored
Migrate metrics recording from bluetooth_private_api.cc and tray_bluetooth_helper_legacy.cc to bluetooth_utils.cc. Now that all metrics recording is unified under bluetooth_utils, subsequent CLs to flesh out these metrics in question will be easier to understand. Bug: 953149 Change-Id: Icf70d1e439b003f80f1250e4547c8275b77f201f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090295 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#748416}
-
- 09 Mar, 2020 22 commits
-
-
S. Ganesh authored
This reverts commit b99538b3. Reason for revert: The original CL 2092939 was not the cause of the flaky failures, so reverting the revert. Original change's description: > Revert "Better registry cleanup in InstallServiceWorkItemTest." > > This reverts commit b256ed1f. > > Reason for revert: I'm hoping reverting this and your other patch will fix the flake. Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 > > Original change's description: > > Better registry cleanup in InstallServiceWorkItemTest. > > > > mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are > > failing with the following error: > > > > AssertionError: In state 'chrome_user_installed_not_inuse', Registry key > > HKEY_LOCAL_MACHINE\Software\Chromium exists. > > > > This is most likely due to the change I made in change 2086353 to delete > > a value instead of the key. > > > > Now the test will delete the key if the test is the one that created the > > key in the first place. > > > > Bug: 1059314 > > Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939 > > Commit-Queue: Greg Thompson <grt@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Auto-Submit: S. Ganesh <ganesh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748062} > > TBR=ganesh@chromium.org,grt@chromium.org > > Change-Id: I875c730322f5bc4cc9fdfa8b5497e26f2b8b81da > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1059314 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095201 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748256} TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org Change-Id: Ia53b0dae159068f44137e0e8d597d3dd9c2f0428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095766Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748415}
-
S. Ganesh authored
This reverts commit 9e13a828. Reason for revert: The original CL 2086353 was not the cause of the flaky failures, so reverting the revert. Original change's description: > Revert "Fix InstallServiceWorkItemTest deletes Chrome key under ClientState." > > This reverts commit ea173bd3. > > Reason for revert: Still seeing failure of mini_installertests. Hoping this will fix the flake. Bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1059314 > > Original change's description: > > Fix InstallServiceWorkItemTest deletes Chrome key under ClientState. > > > > Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will > > create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96} > > if it does not exist and then delete it. If the test is run on a > > development machine, it will corrupt the stable Chrome install. > > > > Bug: 1057233 > > Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353 > > Auto-Submit: S. Ganesh <ganesh@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Commit-Queue: Greg Thompson <grt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#746738} > > TBR=ganesh@chromium.org,grt@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1057233 > Change-Id: I57c3d50264dcf433a123e2802f04a70af8742935 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094466 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748270} TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org Change-Id: I561963764eae05901f083b9c235cce165e623b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095956Reviewed-by:
-
Brian Cui authored
This CL disables tests that will be broken by the Infobar Improvements CL [1]. These tests will be fixed and re-enabled by [2], after [1] is merged and DEPS is auto-rolled to pick up the commit. The tests have been broken due to a one-character method rename in [1] for ScriptFormatterEditorAction to make the .toggleFormatScriptSource() method public (formerly private). [2] simply fixes the tests by updating the method call names. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1981175 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2091228 Bug: 1981175 Change-Id: I5357c43c7a8256fe28bd0f370d09ba473b5eca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092424Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#748413}
-
Kenichi Ishibashi authored
If caching a service worker script is successfully finished, |size_bytes| should be always >= 0. Using CHECK() because we shouldn't store any invalid data into persistent storage. Bug: 946719 Change-Id: I5b397733fecb0eba49ea12e439efcfc8dcfd279b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094835Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748412}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.31-1583148634-benchmark-82.0.4077.0-r1 to 82-4072.0-1583751487-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia5fde0cddffd5ed65bb8d2626179b8de4537685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095838Reviewed-by:
-
Peter Kasting authored
I believe these were not caught earlier because we previously called MaterialDesignController::Initialize() in every test, which reset the controller state to non-touch mode after the TestAPI scoper had set it to whatever we were trying to check. The most problematic of these is AvatarDisplayOnTeleportedWindow, which is what the bug here is formally about. However, the other tests disabled here should also be checked: perhaps the test can be rewritten in a way that makes sense with the WebUI tabstrip. This also makes a couple other changes for robustness that should have little practical effect: changing an EXPECT to an ASSERT (since if we fail to leave immersive mode when we expect, the test has already timed out, and we might as well abort), and changing a click on the leftmost pixel of a button to a click on the center. Bug: 1059514 Change-Id: I7973e043e462b649cca9b4f25214149dcd6bc41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095855 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#748410}
-
Rakesh Soma authored
Change-Id: I691e445c50acbfd5aa6e5e7ca66395bbc022272f Bug: 1058467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056611 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748409}
-
Josh Nohle authored
The device registry is logged when the v2 device manager is started and after each successful v2 DeviceSync. This will greatly help with v2 DeviceSync debugging. Manually tested to verify formatting. Change-Id: Idfc5892b7d89e619784d8496ba0ead435f1950a2 Bug: 951969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079683Reviewed-by:
-
Ben Joyce authored
BUILD.gn changes not included to reduce files changed. Bug: 1052460 Change-Id: I95a5d6827d5cad9db9d04bf9c811a232a1aa895a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090626 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#748407}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.31-1583145468-benchmark-82.0.4079.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6231c7fc57a128954055b8e27e3dcc33de96e6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095662Reviewed-by:
-
Scott Violet authored
This reverts commit 28cff5e2. Reason for revert: I believe this is causing failures on the mac 64 bot (official) bot: https://ci.chromium.org/p/chrome/builders/ci/mac64-trunk/37658 . I suspect the dependencies are wrong ("schema_org_properties" looks like it should depend upon base). Original change's description: > Add validator for schema org entities and types in doc metadata mojo. > > * Add a validator that removes properties that are not the right type. > * Add double, time, and timedelta types in the document metadata mojo > structure. > * Use the new mojo types in document metadata extractor. > > Downstream clank will not be able to read fields parsed into the new > type, but will just skip over them. We should consider updating support > there. > http://cs/clank/java/src/com/google/android/apps/chrome/icing/AppIndexingReporterInternal.java?l=133 > > Bug: 1044250 > Change-Id: Icfd7f0db74abf7bd1261b30dc416c94a7a23b4c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062907 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#748357} TBR=dcheng@chromium.org,beccahughes@chromium.org,sgbowen@google.com Change-Id: I4e428fb0a5caa37f48a65f67e36db6abb3e9a74f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095670Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583147204-benchmark-82.0.4077.0-r1 to 82-4044.31-1583749230-benchmark-82.0.4079.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2336ca58802815a5b793f6857449f0e0e98645c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095837Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bcc6fa4..34d7ff92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54607e5c3225d478b682ef354c3c985fbaea57e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748403}
-
Mason Freed authored
Bug: 1012108 Change-Id: Ic9a38aaae92ea1592a244283304608b429cf7bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092933 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#748402}
-
Mohsen Izadi authored
Current diagram is a bit outdated and incomplete. The updated diagram: https://drive.google.com/file/d/1HHvLtZYou2-wjEmuwb2DmfVdO_t9PCPd/view Bug: 1055051 Change-Id: Id551cfd79372222af82b0e36a6aae598db24d269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069850 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748401}
-
Cliff Smolinsky authored
GDI patching (inconsistently) results in delayload crashes due to the sandbox restrictions applied to various processes. In an effort to catch all processes which need the patching, we applied it to all utility processes. However, this has proven to be too inclusive, as many of those processes have sandboxes which prevent this code from working properly. This change detects the sandbox type and only executes the patching if the sandbox type is ppapi, PrintCompositor, or PdfConversion. Bug: 1028670 Change-Id: I651f50d073a94bf3a7c1cfa9f01aa21761c68132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083384Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#748400}
-
Tao Bai authored
Bug: 1059071 Change-Id: I6020bb00f73b402fb9a2ea95c11ed656d4aa9b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092122Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748399}
-
Hazem Ashmawy authored
Use "Via-WebView-DevTools" label alongside "User-Submitted" label to explicitly track bugs filed using WebView DevTools. Fixed: 1057167 Test: Try open a crash report via the UI and see the labels fields in monorail Change-Id: Ib5efe130e7b08e444317c2f0774f3ed76e01ec98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095307 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Justin Cohen authored
This feature was dropped in lieu of the KeepRenderProcessAlive flag. TEST=Does not regress any of the WKWebView hidden test cases. Bug: 943569, 930123 Change-Id: Ia6ab0e83e808477d6dbc7498607036ac05a31899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094468Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#748397}
-
Manu Cornet authored
Bug: 1009638 Change-Id: I2f0671524fb3d0be94a5c2123b3273f738ffefb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093222Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#748396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6190ec8363a0..85edfc8c8341 git log 6190ec8363a0..85edfc8c8341 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 jalyn@microsoft.com Fix 'Add custom device' focus regression 2020-03-09 petermarshall@chromium.org [styles] Make radio button focus ring circular 2020-03-09 jalyn@microsoft.com Update module.schema.json and add missing action titles 2020-03-09 tvanderlippe@chromium.org Sort generated property values on keys 2020-03-09 jacktfranklin@chromium.org Move `self.mod` into `NumberUtilities` Created with: gclient setdep -r src/third_party/devtools-frontend/src@85edfc8c8341 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039620,chromium:1050549,chromium:1052248,chromium:174309,chromium:920154 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3382d4e1642b465e7f49a301c5486445c8f9c7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095424Reviewed-by:
-
sauski authored
Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. Bug: 1032584 Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Auto-Submit: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748394}
-
