GitLab

This makes tilt get populated per the Pointer Events spec with a Wacom
Intuos Pro M Pen.

BUG=557952
TEST=Wacom Intuos Pro M Pen on Chromebook Pixel with
  --enable-blink-features=PointerEvent
  & http://rbyers.github.io/eventTest.html

Review URL: https://codereview.chromium.org/1456063003

Cr-Commit-Position: refs/heads/master@{#360587}

- Removes the Context argument from places it isn't needed.
- Removes everything related to about://sync as there are now better
  ways to access sync state.
- Have just TIMEOUT_MS and INTERVAL_MS.
- Some other misc cleanups.

BUG=556621

Review URL: https://codereview.chromium.org/1451813002

Cr-Commit-Position: refs/heads/master@{#360586}

Fetching metadata is heavy, and it may cause calling stat() even though
it's not needed (is_directory is obtainable without stat()).

This CL adds the option. Backends will be updated to reflect it separately.
Also, as another step base::File::Info will be replaced with storage::Entry
or something similar with scoped_ptr's as members, to avoid reading
a member which was not requested in |fields|.

TEST=All current tests pass. But not really used yet, as backends ignore it.
BUG=558191

Review URL: https://codereview.chromium.org/1455403003

Cr-Commit-Position: refs/heads/master@{#360585}

Revert of More regular Platform implementations in unit tests. (patchset #12 id:220001 of https://codereview.chromium.org/1456873003/ )

Reason for revert:
Compile break on Win x64 Builder (dbg):

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj.rsp /c ..\..\third_party\WebKit\Source\platform\testing\TestingPlatformSupport.cpp /Foobj\third_party\WebKit\Source\platform\testing\blink_platform_test_support.TestingPlatformSupport.obj /Fdobj\third_party\WebKit\Source\platform\blink_platform_test_support.cc.pdb
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(188) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\heap\heappage.h(202) : warning C4267: '=' : conversion from 'size_t' to 'uint32_t', possible loss of data
c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(654) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\wtf\vector.h(644) : while compiling class template member function 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38) : see reference to function template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
        c:\b\build\slave\win_x64_builder__dbg_\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(55) : see reference to class template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled

Original issue's description:
> More regular Platform implementations in unit tests.
>
> R=haraken,jbroman
> BUG=
>
> Committed: https://crrev.com/3e197be3a60195ac2267f3293084fa36c5706503
> Cr-Commit-Position: refs/heads/master@{#360583}

TBR=jbroman@chromium.org,haraken@chromium.org,tkent@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1464493002

Cr-Commit-Position: refs/heads/master@{#360584}

R=haraken,jbroman
BUG=

Review URL: https://codereview.chromium.org/1456873003

Cr-Commit-Position: refs/heads/master@{#360583}

Cr-Commit-Position: refs/heads/master@{#360582}

This logic in documents diverge from CHromeActivity behavior for
archaic reasons (crbug.com/451672). Making documents show/hide
in the same time as all other ChromeActivities with this change.
Verified that the previous bug that caused the bheavior divergence
no longer exists after this CL.

BUG=546182

Review URL: https://codereview.chromium.org/1455343002

Cr-Commit-Position: refs/heads/master@{#360581}

Use form signatures to look up forms in |form_structures_|, which is
guaranteed to be valid.

BUG=557713,557740,557800
TEST=Existing

Review URL: https://codereview.chromium.org/1457793002

Cr-Commit-Position: refs/heads/master@{#360580}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/88939fd8..767df2b5

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1459863002

Cr-Commit-Position: refs/heads/master@{#360579}

That way, we can delete the private values on the listener in the right
context

R=haraken@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1419313003

Cr-Commit-Position: refs/heads/master@{#360578}

This CL addresses the comments reported in:
https://codereview.chromium.org/1391583002/
https://codereview.chromium.org/1391583002/#msg62

BUG=537138

Review URL: https://codereview.chromium.org/1455113002

Cr-Commit-Position: refs/heads/master@{#360577}

Also a few minor fixes reported by cpplint.

BUG=502346

Review URL: https://codereview.chromium.org/1415223002

Cr-Commit-Position: refs/heads/master@{#360576}

Revert of Roll WebRTC 10685:10707, Libjingle 10671:10707 (patchset #1 id:1 of https://codereview.chromium.org/1456393002/ )

Reason for revert:
Reverting since there are still build warnings in the output.

Original issue's description:
> Roll WebRTC 10685:10707, Libjingle 10671:10707
>
> WebRTC 10685:10707
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..0f714d5
>
> Libjingle 10671:10707
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3ecea8a..17fe6f9
>
> TBR=
> BUG=
>
> Committed: https://crrev.com/e8af106460019f9cf7c96d9122f0c214be6066ec
> Cr-Commit-Position: refs/heads/master@{#360568}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1462013002

Cr-Commit-Position: refs/heads/master@{#360575}

+ Add deadbeef@ as owner.
+ Remove hellner@ as owner.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/app/webrtc/mediastreamsignaling.h&l=28

Review URL: https://codereview.chromium.org/1460933003

Cr-Commit-Position: refs/heads/master@{#360574}

Don't try to show the focus ring on other platforms than Chrome OS.

R=dtseng@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1453133002

Cr-Commit-Position: refs/heads/master@{#360573}

Review URL: https://codereview.chromium.org/1459853002

Cr-Commit-Position: refs/heads/master@{#360572}

* a11y: TalkBack still says things like "Settings button" when tapped, as the Button is the view on top
* RTL is handled, the icon is placed on the right when the system is in RTL mode

BUG=554073

Review URL: https://codereview.chromium.org/1441723002

Cr-Commit-Position: refs/heads/master@{#360571}

What we want to do is to instantiate some templates of
<T> with T's full definition, in Member<T>::get() and
Member<T>::checkPointer().
To guarantee that template instantiations come after
T's definition, we put static_assert() in Member<T>.
See the change in platform/heap/Handle.h.

To achieve the condition, this CL does either of
1) move implementation of methods using Member<T> from .h to .cpp
2) include necessary .h
(1) can change inline definitions to outline definitions,
and it may regress performance a bit.

BUG=556947

Review URL: https://codereview.chromium.org/1455943002

Cr-Commit-Position: refs/heads/master@{#360570}

The type name in the |USING_FAST_MALLOC| macro is currently not used,
which allowed a few typos to sneak in. This fixes those to prevent
compile errors in case the type name is used in the future.

Review URL: https://codereview.chromium.org/1461743004

Cr-Commit-Position: refs/heads/master@{#360569}

WebRTC 10685:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/82cc96f..0f714d5

Libjingle 10671:10707

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3ecea8a..17fe6f9

TBR=
BUG=

Review URL: https://codereview.chromium.org/1456393002

Cr-Commit-Position: refs/heads/master@{#360568}

https://html.spec.whatwg.org/#document

After this change, setting document.cookie to null will stringify to
"null", so it's simply like setting a cookie by that name. This matches
Firefox Nightly and Edge.

BUG=497307

Review URL: https://codereview.chromium.org/1458753003

Cr-Commit-Position: refs/heads/master@{#360567}

BUG=558341
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1462873002

Cr-Commit-Position: refs/heads/master@{#360566}

BUG=545480
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1453293003 .

Cr-Commit-Position: refs/heads/master@{#360565}

https://chromium.googlesource.com/chromium/src/+/6546ae27

BUG=128055
TBR=davve@opera.com

Review URL: https://codereview.chromium.org/1461023002 .

Cr-Commit-Position: refs/heads/master@{#360564}

cricket::CapturedFrame.elapsed_time is deprecated since
https://codereview.webrtc.org/1324263004/.

BUG=544125
R=perkj@chromium.org,sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1456083002

Cr-Commit-Position: refs/heads/master@{#360563}

CSP's matching algorithm has been updated to make clever folks like Yan
slightly less able to gather data on user's behavior based on CSP
reports[1]. This matches Firefox's existing behavior (they apparently
changed this behavior a few months ago, via a happy accident[2]), and
mitigates the CSP-variant of Sniffly[3].

On the dashboard at https://www.chromestatus.com/feature/6653486812889088.

[1]: https://github.com/w3c/webappsec-csp/commit/0e81d81b64c42ca3c81c048161162b9697ff7b60
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218524#c2
[3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1218778#c7

BUG=544765,558232

Review URL: https://codereview.chromium.org/1455973003

Cr-Commit-Position: refs/heads/master@{#360562}

BUG=553425, 545480
R=akuegel@chromium.org

Review URL: https://codereview.chromium.org/1460723002 .

Cr-Commit-Position: refs/heads/master@{#360561}

Revert of Add noBarrierStore to WTF and use it for spinlocks (patchset #2 id:20001 of https://codereview.chromium.org/1461743002/ )

Reason for revert:
This CL broke compilation on the TSan bot.
Please consider using the linux_clang_tsan trybot or building locally with GYP_DEFINES=tsan=1 next time.

Original issue's description:
> Add noBarrierStore to WTF and use it for spinlocks
>
> This will eliminate TSAN warnings on some benign races,
> and help ensure that they remain benign.
>
> BUG=556469
>
> Committed: https://crrev.com/12678ed8e9f993cbe343ddd3d08ee174244b6552
> Cr-Commit-Position: refs/heads/master@{#360481}

TBR=haraken@chromium.org,jschuh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=556469

Review URL: https://codereview.chromium.org/1457843003

Cr-Commit-Position: refs/heads/master@{#360560}

BUG=550407

Review URL: https://codereview.chromium.org/1456783004

Cr-Commit-Position: refs/heads/master@{#360559}

Before this patch, one SVGImageForContainer object is saved in
ImageResource for each corresponding use of SVGImage.

<img style="width: 1000px" src="image.svg">
...
<img style="width: 500px" src="image.svg">

This example would give one ImageResource (for image.svg) and within
it two SVGImageForContainer, one for each <img>. SVGImageForContainer
contains the unzoomed container size along with the zoom level,
indexed on the layout object of the container in
SVGImageFor*Container*.

There were at least three problems with this approach:

1. It's racy. setContainerSizeForLayoutObject is called sometimes from
   layout(), sometimes during paint(). Users of APIs such as
   imageForLayoutObject or imageSizeForLayoutObject that depend on
   setContainerSizeForLayoutObject would get different results
   depending on when they are called. Basically the only "safe" time
   to call these methods are right before paint.

2. It limits the number of associations between layout object and
   SVGImage to one. Consider an element/layout object having one
   SVGImage as content and another SVGImage as background. The
   container size for those two SVGImages in this case isn't
   necessarily the same and strictly speaking we should need two
   SVGImageForContainer objects. Only one SVGImageForContainer can be
   stored per layout object.

3. It breaks layering. ImageResource lives in fetch and having fetch/
   depend on svg code is undesirable. DEPS for fetch/ states
   "core/fetch/ shouldn't depend on anything else in core/".

After this patch, these three problems have been
addressed. SVGImageForContainer is now only allocated when it's
needed, to be passed through the GraphicsContext layer as a wrapper to
get the correct size and zoom level to avoid pixelated rasterization.

There are risks with this patch. In some cases code may rely on having
the container size saved inside ImageResource.cpp. However, such code
is most often already brittle and unreliable due to (1) above.

One quirk is the added BackgroundImageGeometry::imageContainerSize()
containing the tile size before 'background-repeat: round' has been
applied. Before this patch, this size was the one kept for the
respective container in ImageResource (since
setContainerSizeForLayoutObject were called before tile size
adjustments for background-repeat: round). It turns out this is
important to get the stretching correct, i.e. makes the underlying
drawing code ignore the intrinsic ratio of the background
image. svg/as-background-image/background-repeat.html exercises this
behavior.

BUG=128055, 306222

Review URL: https://codereview.chromium.org/1427943002

Cr-Commit-Position: refs/heads/master@{#360558}

This is the fix for regression introduced by
https://codereview.chromium.org/1344783002

After the CL, SWProviderContext::ControllerDelegate::AssociateRegistration()
wrongly set its |installing_| field to the active worker and |active_| field
to nullptr. These messed fields eventually show up as
ServiceWorkerGlobalScope.registration's version attributes.

This CL fixes the wrong field assignment and adds layout tests.

BUG=532098, 557551

Review URL: https://codereview.chromium.org/1460653002

Cr-Commit-Position: refs/heads/master@{#360557}

This is a follow-up CL for http://crrev.com/1397073002
static_assert in HashTable ignored this case because
HTMLPlugInElement is forward declared in this file and
we cannot know it is GCed class.

BUG=515524

Review URL: https://codereview.chromium.org/1459473005

Cr-Commit-Position: refs/heads/master@{#360556}

The new behavior is reasonable because tooltips can disturb text editing
with keyboards, and is compatible with Firefox.

BUG=557660
TEST=automated

Review URL: https://codereview.chromium.org/1454363002

Cr-Commit-Position: refs/heads/master@{#360555}

MediaStreamCenter::didCreateMediaStream is called from here.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp&sq=package:chromium&type=cs&l=146&rcl=1447771613

Before that, the tracks have already been created.

Review URL: https://codereview.chromium.org/1462473002

Cr-Commit-Position: refs/heads/master@{#360554}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f931913e..88939fd8

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1457253002

Cr-Commit-Position: refs/heads/master@{#360553}

Port all targets required to build "ios_chrome_unittests" from gyp to gn,
adding reference to the GN target in the gyp files. The targets links but
does not runs as resources bundles are still unsupported with gn.

The resources are also not packed, but this will be done in a follow up
CL in order to reduce the size of this already large CL.

BUG=459705

Review URL: https://codereview.chromium.org/1452593002

Cr-Commit-Position: refs/heads/master@{#360552}

View::Layout is not invoked if only origin has been changed.
R=sadrul@chromium.org,sky@chromium.org
BUG=none
TEST=See unittest.

Review URL: https://codereview.chromium.org/1442683002

Cr-Commit-Position: refs/heads/master@{#360551}

This involved changing how we get the client handle to the renderer. In the first iteration I was passing this on the command line but that turns out not to work with the sandbox. So instead I an approach used by the Mojo-in-Chrome MojoApplication class and pass the primordial handle via Chrome IPC.

I had to twiddle a bunch of BUILD.gn files in content to get this to work without crashing due to inconsistencies in how MOJO_SHELL_CLIENT was defined.

R=jam@chromium.org,tsepez@chromium.org
http://crbug.com/551253

Committed: https://crrev.com/3edb97198bc5fbc22c5cf13286e8af80449ddfb9
Cr-Commit-Position: refs/heads/master@{#360293}

Committed: https://crrev.com/2c716f9d5ebff610641f4506c17ec81d4b89b7bb
Cr-Commit-Position: refs/heads/master@{#360396}

Review URL: https://codereview.chromium.org/1452823003

Cr-Commit-Position: refs/heads/master@{#360550}

Before this CL, strings and container types were passed to callback
method by const reference. Dictionary types should also be passed
by const ref to avoid unnecessary copying.

BUG=557590

Review URL: https://codereview.chromium.org/1455883003

Cr-Commit-Position: refs/heads/master@{#360549}

This patch makes following tests to use w3c test harness to simplify tests
and avoid to compare pixel results.

Pixel results aren't essential for tests changed in this patch and when
we enable asynchronous spell checking, pixel result contains red wave lines for
miss spelled. These read wave lines aren't related what we want to test.

This patch is a preparation of getting rid of synchronous code path for
spellcheck to enable asynchronous spell checking always.

BUG=295722
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1456333002

Cr-Commit-Position: refs/heads/master@{#360548}