- 11 Apr, 2019 40 commits
-
-
Ahmed Mehfooz authored
Add Highlight Path for Collapse Button Focus Bug: 922423 Test: Manual Test on PixelBook Change-Id: If37e818714ccbd5248e2257e346378b3d848bbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542562 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649802}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d657d5e894a..80eff54147f2 git log 4d657d5e894a..80eff54147f2 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f39b4f0280ef..e6b23e45b380 (7 commits) 2019-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 1b121674..f8764798 (366 commits) Created with: gclient setdep -r src/third_party/skia@80eff54147f2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I9ac067efd5f3656117739e4cf1e97c7cec692e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563715Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649801}
-
Noel Gordon authored
Referring to self works but confuses some; just say window. And these one would use globalThis, but it's not shipped everywhere yet. Bug: 935285 Change-Id: If70c05a35563a4545376eeea85dcebd3ae2c09fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563532Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649800}
-
Ahmed Mehfooz authored
Add Highlight Path for Sign out Button Focus Change ConfigureTrayPopupButton to always draw focus on highlight path Bug: 922423 Test: Manual Test on PixelBook Change-Id: I34751c84ed06933d81bc77062ac9eca8f20f3ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542468 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649799}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc0c991440db..aaccc8a44bdb git log dc0c991440db..aaccc8a44bdb --date=short --no-merges --format='%ad %ae %s' 2019-04-11 benjhayden@chromium.org Migrate cp-input to es6 module Created with: gclient setdep -r src/third_party/catapult@aaccc8a44bdb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=skyostil@chromium.org Change-Id: I72104d7ffa4179b8f08f64e60c9bd7a823b0c6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649798}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/408a3c63d37b..71ec39e355a8 git log 408a3c63d37b..71ec39e355a8 --date=short --no-merges --format='%ad %ae %s' 2019-04-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bc377d9b..ca726156 (649669:649772) 2019-04-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 19364ba5..bc377d9b (649524:649669) Created with: gclient setdep -r src/third_party/webrtc@71ec39e355a8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I35cd82f67601f3da39143baa226b81c2017cee7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649797}
-
liberato@chromium.org authored
When analyzing the learning results, it's helpful to see the effect of the amount of training data on the quality of the predictions. However, DistributionReporter only reports the results as one confusion matrix per LearningTask. This merges the predictions from models with potentially wildly different amounts of training data, making it hard to see how the model's ramp up time differs from its steady state performance. This CL lets DistributionReporter report confusion matrices that are split up by the total weight of the training data used to train the model that made the prediction. The UMA x-axis is divided into buckets, numbered 0 to 15. The bucket number is provided in the label name for the ByTrainingWeight histogram. Which bucket is used is based on the total weight of the training set used to train the model. By default, bucket 0 will report the confusion matrix for models trained on [0, 9] examples. Bucket 1 will report [10, 19] examples, etc. Bucket 9 will report [90, 99]. The overflow bucket, bucket 10, will report 100 and up. This was chosen to match the default maximum training set size of 100, if each example in the set has the default weight of 1. This CL also modifies LearningHelper to report the weighted task results in buckets of 50000 frames each, such as [0-49999] for all tasks that weight examples by the number of frames. Last, this CL renames the histograms to: Media.Learning.BinaryThreshold.Aggregate.$LEARNING_TASK_NAME for the total, aggregate confusion matrix from all predictions (i.e. this is the same as it reported before). Media.Learning.BinaryThreshold.ByTrainingWeight.$LEARNING_TASK_NAME for the bucketed-by-weight matrices described above. Change-Id: I75953747b62ebefd9d7fa4f427489f683e608117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557077 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649796}
-
Mikel Astiz authored
Prior to this patch, the SendTabToSelf bridge leveraged the LocalDeviceInfoProvider interface offered (and owned) by DEVICE_INFO. However, all the bridge is interested in is knowing about the name of the local device, which can be done with a simple function call to GetSessionNameBlocking(). Bug: 922971 Change-Id: I6e5cda32028f36239c80f6448180d9d9d6bfc17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561124 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649795}
-
Jeevan Shikaram authored
Change the host URL of App Management from chrome://apps to chrome://app-management. Bug: 949397 Change-Id: I84679310872fd1d74ceef20b58f335e99f81aaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556863Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#649794}
-
Marc Treib authored
instead of just the ServerConnectionCode and the net error code. For now, this makes sure that the connection code and the net error are always updated together and thus remain consistent. Later, it will also allow us to expose the http error code as well. Bug: 842096 Change-Id: I41b2dfae80b55c69ae3693ac2a8c6d6b8fa2547e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560195 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649793}
-
Marc Treib authored
Previously, the actual .proto files in /protocol/ were already in their own build file and target, but the .h/.cc files next to them were in the main sync target. This CL creates a new /protocol:util target and moves those files there. Bug: 947443 Change-Id: If20d8021b61c482af30f5ff60bff7614d94bfab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561106 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649792}
-
Hirokazu Honda authored
CreatePlatformVideoFrame in video_frame_helpers.h almost delegates CreatePlatformVideoFrame in media/gpu/linux/platform_video_frame_utils.h. We remove the function in media/gpu/test to reduce the code size Bug: None Test: video_decode_accelerator_unittest w/wo video_frame_validator Test: video_decode_accelerator_tests w/wo video_frame_validator Change-Id: Ice7ed5b099104d613456692c43ae8df65e67a5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563531Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649791}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/99d792276740..4d657d5e894a git log 99d792276740..4d657d5e894a --date=short --no-merges --format='%ad %ae %s' 2019-04-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f0aa9d5ab738..3954a0bafb8a (42 commits) Created with: gclient setdep -r src/third_party/skia@4d657d5e894a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ie984863d2dd3fe499b57568da3fc0948104b0e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649790}
-
Ramin Halavati authored
ObfuscatedFileUtil unittest is updated to run tests in regular mode, incognito mode with disabled in memory implementation and enabled. Bug: 93417 Change-Id: I3833160b8ac781cbbcbb6d3a1dd69d2ca77e463b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495552 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#649789}
-
Kurt Horimoto authored
This CL adds kkhorimoto@ (author of code) and michaeldo@ (reviewer) as OWNERS for OverlayService. Bug: 941745 Change-Id: I95ce0fc2e8eebeb894cd2905204c54dba25e72b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562851 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649788}
-
li authored
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome Bug: b:129715312 Test: Manual Change-Id: Ie7d9eab6c7e9d7191ffc1260b5bcc4c73b11b6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553664Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649787}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 948dc61f. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id3e025bf872dacb1e17b9460eaf3877989948c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563450Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649786}
-
Abhijeet Kandalkar authored
Locker class is a thin wrapper of lock() and unlock() and only used in RecursiveMutexLocker and MediaElementAudioSourceHandler, Hence it should be dropped form WTF primitive. The primary motivation of this CL is to 1. Add a helper class in media_element_audio_source_node.cc to remove dependency of Locker. 2. Remove unused RecursiveMutexLocker. Bug: 950143 Change-Id: Id69059777c8780fc654c0fb672463614c7a0f396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562310Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#649785}
-
Alice Boxhall authored
Bug: 835455 Change-Id: Icc4a25874d949a54c87a7a8f53d510cc423c2740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559411 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#649784}
-
Yashar Dabiran authored
This CL is part of the efforts to add |RuntimeEnabled| IDL attribute support for origin trial features. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q The purpose of renaming the feature names is to be able to distinguish runtime features from origin trial features. All runtime features will be defined in "bindings/tests/idls/runtime_enabled_features.json5" afterwards in the next CL. Bug: 934451 Change-Id: I77ec33ed94eba8469292c5e4ff44dc488a03765a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558332 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#649783}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3635a1295b12..5d64ec4c2dcd git log 3635a1295b12..5d64ec4c2dcd --date=short --no-merges --format='%ad %ae %s' 2019-04-11 bclayton@google.com Fix windows build. 2019-04-11 bclayton@google.com SpirvShader: Document ops requiring capabilities 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450FindILsb 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Find[U,S]Msb 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Determinant 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450NClamp 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450NMax 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450NMin 2019-04-11 bclayton@google.com SpirvShader: Mark GLSLstd450IMix as unreachable. 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450InverseSqrt 2019-04-11 bclayton@google.com SpirvShader: Handle DecorationRelaxedPrecision decorations 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Sqrt 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Log2 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Exp2 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Log 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Exp 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Pow 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Atan2 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Atanh 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Acosh 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Asinh 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Tanh 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Cosh 2019-04-11 bclayton@google.com SpirvShader: Stub all the remaining GLSLstd450 unimplemented cases 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Sinh 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Atan 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Acos 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Asin 2019-04-11 bclayton@google.com SpirvShader: Implement GLSLstd450Tan 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Cos 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Sin 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Degrees 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Radians 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Ldexp 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Fma 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Frexp 2019-04-10 chrisforbes@google.com Implement pack/unpack extended instructions 2019-04-10 chrisforbes@google.com SpirvShader: Implement GLSLStd450ModfStruct 2019-04-10 bclayton@google.com SpirvShader: Implement GLSLstd450Modf Created with: gclient setdep -r src/third_party/swiftshader@5d64ec4c2dcd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I8ba88e86be6fdff64731443a9af29ee5455084b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649782}
-
Henrique Grandinetti authored
Bug: 936938 Change-Id: I4a2b67f7e98859c055b38666807fb1fb2369cb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562114 Auto-Submit: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649781}
-
Joel Hockey authored
Modified export/import handling from CrostiniManager to take a CrostiniResultMessageCallback which receives both a CrostiniResult and a base::string16 error message which can be displayed in the notification. Strings from https://docs.google.com/spreadsheets/d/1paVaVV2azeuAHnxHT4jQ402VvaZ7Z8btZ5e_y7rPRnE/edit#gid=0 Bug: 933948 Change-Id: I2451492d85cd8263a8914a31b82162d4e93a77de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558559 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649780}
-
Yashar Dabiran authored
This CL is part of the efforts to add |RuntimeEnabled| IDL attribute support for origin trial features. Design doc for the overall change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q This CL writes all runtime features (defined in runtime_enabled_features.json5) to a file to be able to access them during the bindings generation. Bug: 934451 Change-Id: I839d7893af89e0e687feaf5888e699c1efb15c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557868 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#649779}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/4ebef283ecc4..cbd8851734d8 $ git log 4ebef283e..cbd885173 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 luum system_api: Add DBus service constants for CupsProxyDaemon 2019-03-11 joelhockey system_api: validate container architecture when importing Created with: roll-dep src/third_party/cros_system_api Bug: 933948 Change-Id: Id2346c605f6e387cea1b13a977c152336a50c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563231 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649778}
-
Gyuyoung Kim authored
This CL finishes annotating the rest of the classes of //third_party/blink/renderer/bindings with the macros of Allocator. After some analyzes, it was concluded that for the case of NodeBuilder, State, WorklistItemBase classes, they makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. Lastly, the rest of the classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I8590c31702d34ccdadf4d079c8123a192b36aeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#649777}
-
Nicolas Ouellet-payeur authored
linux64 Bug: 949382 Change-Id: Id6e865cc6ae2848a4cbe8d39c5e3020c94f74461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561965 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#649776}
-
David Black authored
This reverts commit 0ee09a04. Reason for revert: Regresses Assistant UI. Original change's description: > views: removal of dead code in NativeViewHost > > NativeViewHost has code to deal with being clipped by an ancestor. This logic > dates back to when we used NativeViewHost more often, and in particular when > NativeViewHost was contained in a ScrollView. AFAIK we no longer have this > scenario, so, this removes the unnecessary logic. > > BUG=none > TEST=covered by tests > > Change-Id: I7b1a9ba047bd7c4abab68f9fe49c651bf50209d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560130 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649355} TBR=sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:130305523 Change-Id: Ib0b5dba24bb4e376f3cdad11d19d59e318fd1b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563031Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#649775}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ec288d4..3304bd02 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c6764d5b222cbd7a2d1ef9e012a8636bfb81629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563150Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649774}
-
Xiaocheng Hu authored
This reverts commit 33b5c673. Reason for revert: Adding production CHECKs to collect LayoutNG failures for the 3rd time. Original change's description: > Revert "Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG"" > > This reverts commit 26ca019a. > > Reason for revert: Crash data already collected > > Original change's description: > > Reland "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > This reverts commit ec11fe81. > > > > Reason for revert: Try to catch more crashes in the wild after > > a fix (crrev.com/c/1546713) has been landed. > > > > Original change's description: > > > Revert "[LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG" > > > > > > This reverts commit bade42c5. > > > > > > Reason for revert: New crashes already caught. Reverting CHECKs > > > back into DCHECKs to reduce noises. > > > > > > Original change's description: > > > > [LayoutNG] Turn AssertLaidOut into a CHECK for LayoutNG > > > > > > > > Bug: 946004 > > > > Change-Id: I9e2aa69a32f7a0373196d57e629256dbc7d78d2a > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540305 > > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > > Reviewed-by: Emil A Eklund <eae@chromium.org> > > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#644907} > > > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > > > Change-Id: I15fb43370f58757e09e7b7abc7c40d4af4a6101a > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 946004 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544156 > > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#645407} > > > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 946004 > > Change-Id: Iccb8c2b998d28f659381c3f89a1686614600860c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548248 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#646516} > > TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 946004 > Change-Id: I9794539b39bc6a0053a7229b03bce7db402ecb5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551440 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647418} TBR=eae@chromium.org,kojii@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946004 Change-Id: I973ccf65be78d4632f67b945614f1a4ee091134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562500Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649773}
-
Wei Lee authored
similar method This CL fixes the wrong buffer size that is used in CreateGpuMemoryBufferHandle(). And it also removes a similar method in VaapiPictureNativePixmap. Bug: None Test: None Change-Id: I870e540975e13a21a4262bdb7f54b7ee45808eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538268 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649772}
-
Christopher Lam authored
This CL removes the 'Open as tab/window' and 'App Info' options for System PWAs in the App Launcher and Shelf. Bug: 836128 Change-Id: I80dd5046d49e709c766a893d581298eb176e4bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557478Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#649771}
-
Pavel Feldman authored
All these rule definitions operate CSS variables now. Bug: 935286 Change-Id: I9cdd4883e0c07e1040da06af8db3ef36f64ebc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562893Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#649770}
-
Pavel Feldman authored
Bug: 947458 Change-Id: I117238860ade9c6fb86c4310c07c501306201196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562575 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#649769}
-
John Abd-El-Malek authored
Reland "Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service." This is a reland of b5e1969b Original change's description: > Ensure header modification for a redirect's onBeforeSendHeaders is applied with network service. > > This currently worked if 'extraHeaders' was specified, but not without it. > > Bug: 942062 > Change-Id: Ic962ad256d89384082e25a5983181bf563021ffb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548673 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647160} TBR=rockot@chromium.org Bug: 942062, 949478 Change-Id: I11889f6c2973548b28e3ea8029f1516626c950f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559013Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649768}
-
James Darpinian authored
conformance/textures/misc/texture-active-bind.html was fixed on Windows in https://github.com/KhronosGroup/WebGL/pull/2819 LUMINANCE/ALPHA emulation fixes in http://crrev.com/c/1545512 fixed these tests on Android Qualcomm: conformance2/textures/misc/tex-new-formats.html conformance2/textures/misc/copy-texture-image-luma-format.html deqp/functional/gles3/textureformat/unsized_2d_array.html deqp/functional/gles3/textureformat/unsized_3d.html TBR: kbr@chromium.org Bug: 931006, 906740, 947236 Change-Id: I5c3a79c17b6a263b1a52f0a9fa646de591e370b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559756Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#649767}
-
Alex Kalugin authored
Fix possible calls on null pointer. Change-Id: I5899e0debfba13afc330a88d6d2eaec29275fa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533907 Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649766}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie1ab823189bac7a60148e918e4f65a8aa4c57a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649765}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3e80ed4d. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" 8659792f "[WPT] Move wrapResult to common.js and clarify requestVia*() return values" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I177bba2baaf566cfa17eae5de9dfaa40dc09e174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562925Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649764}
-
Charles Zhao authored
High discard count also means high reload count, which indicates the user is more likely to come back to this tab. Therefore it should have higher scorer. Changed how discard count is scored. Bug: 948915 Change-Id: Ifea930bfb3aab6bb4eb86a05e4ae949631d55e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560931Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649763}
-