- 18 Sep, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/151945a7459c..748e4927773d git log 151945a7459c..748e4927773d --date=short --no-merges --format='%ad %ae %s' 2018-09-18 bhthompson@google.com Make skylab chrome PFQs experimental Created with: gclient setdep -r src/third_party/chromite@748e4927773d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0c9b8bfafc2de7576d7f4ae2f846799ed89ed04d Reviewed-on: https://chromium-review.googlesource.com/1230638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592075}
-
Moe Ahmadi authored
Adds tests to ensure UMA metrics are correctly logged and user data is saved as expected after user interaction with the credit card save infobar. Bug: 867106 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4966f694cfb02878f98af2fed324cda7a6f10058 Reviewed-on: https://chromium-review.googlesource.com/1228979 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592074}
-
Liquan(Max) Gu authored
The test LastTextPaint_ReportFirstPaintTime is flaky because it used EXPECT_GT for time comparison. This is an issue because time is clamped. We should use EXPECT_GE instead. Bug: 885123 Change-Id: I519eeb23dcd9a1376cf91ecdc288fbf6d7b40daa Reviewed-on: https://chromium-review.googlesource.com/1230436Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ec77b5574b4..1d6281d4bb47 git log 9ec77b5574b4..1d6281d4bb47 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Reland "implement SkPixmap::getPixel() with this->readPixels()." 2018-09-18 fmalita@chromium.org [skottie] Fix NaN |t| in CompTimeMapper::onTick 2018-09-18 fmalita@chromium.org [skottie] UBSAN divide-by-zero workaround 2018-09-18 mtklein@google.com centralize RP loads and stores Created with: gclient setdep -r src/third_party/skia@1d6281d4bb47 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Id64db95e4de86b7220fa8c5698ef42335a6edc9f Reviewed-on: https://chromium-review.googlesource.com/1230639Reviewed-by:
-
Nicolas Pena authored
This CL ensures that the first call to MaybeUpdate() results in calling Update() so that MemoryInfo is populated. Technically the monotonic clock could be initialized to a small value and in this case the first time this check occurs it could fail, whereas we want it to pass: "now - last_update_time_ >= delta_allowed" Bug: 883490 Change-Id: I7143d453709db38068919cff9585c50e06e789ac Reviewed-on: https://chromium-review.googlesource.com/1228886Reviewed-by:
-
Mike Klein authored
Writing non-opaque pixels to a bitmap tagged opaque breaks the contract for tagging bitmaps opaque, and can lead to nonsense later inside Skia. Change-Id: I60abf381f091a3699939f4327c7029555bc9ce39 Reviewed-on: https://chromium-review.googlesource.com/1231053Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#592070}
-
Asanka Herath authored
This reverts commit 9c6ad309. Reason for revert: Tests added in this CL are failing on mac-cocoa-rel since landing. Original change's description: > Fix inconsistent hosted app title bar text color readability algorithm > > This CL updates the title text color for Linux and Windows 7 hosted > app windows to be more consistent with Windows 10, Chrome OS, Android > and text colors used by Gmail and Inbox. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1 > See bug for more screenshots. > > Bug: 883177 > Change-Id: Ic24e1cf0b445251ebfdcd1aa0ae74c9343b1ff8e > Reviewed-on: https://chromium-review.googlesource.com/1218186 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591279} TBR=jamescook@chromium.org,msw@chromium.org,alancutter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883177 Bug: 885164 Change-Id: I22a52611a5478ee1d430ccd8ca1a507f7237d4f7 Reviewed-on: https://chromium-review.googlesource.com/1230435Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592069}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f0a8877a213..0cd3e599ae3b git log 7f0a8877a213..0cd3e599ae3b --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jaebaek@google.com Validator: correct out of bound check for OpMemberDecorate (#1881) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0cd3e599ae3b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3e43eebc2b28019f3db1e0d8961379779d3ba432 Reviewed-on: https://chromium-review.googlesource.com/1230635Reviewed-by:
-
Max Moroz authored
This reverts commit f37f3783. Reason for revert: broke fuzzing builds: crbug.com/885205 Original change's description: > Roll src/third_party/webrtc d574123c5035..6d800030ab7e (12 commits) > > Note: force submitting because of borked mac archive trybot. > All other bots are green so we should be good. > > https://webrtc.googlesource.com/src.git/+log/d574123c5035..6d800030ab7e > > > git log d574123c5035..6d800030ab7e --date=short --no-merges --format='%ad %ae %s' > 2018-09-17 mbonadei@webrtc.org Revert "Compile frame analyzer for the host machine on perf tests." > 2018-09-17 mbonadei@webrtc.org Add RTC_EXPORT macro to export WebRTC symbols. > 2018-09-17 mbonadei@webrtc.org Compile frame analyzer for the host machine on perf tests. > 2018-09-17 buildbot@webrtc.org Roll chromium_revision 1d75f6fc..0eb6b522 (591373:591627) > 2018-09-17 mbonadei@webrtc.org Rename RTC_EXPORT to RTC_OBJC_EXPORT. > 2018-09-17 mbonadei@webrtc.org Introduce GN arg rtc_exclude_runtime_enabled_features_default. > 2018-09-17 danilchap@webrtc.org Register video rtp header extensions in rtp_rtcp by uri > 2018-09-17 sprang@webrtc.org Add ability to throttle VideoBitrateAllocation updates. > 2018-09-17 mbonadei@webrtc.org Remove obsolete comments. > 2018-09-17 saza@webrtc.org Reland "Remove APM internal usage of EchoCancellation" > 2018-09-15 mbonadei@webrtc.org Merge field_trial and field_trial_default in a unique target. > 2018-09-15 mbonadei@webrtc.org Merge system_wrappers:metrics and system_wrappers:metrics_default. > > > Created with: > gclient setdep -r src/third_party/webrtc@6d800030ab7e > > The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng > > BUG=chromium:None > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: Id68bba413d71cbfb8cb52522b530e440249e459d > Reviewed-on: https://chromium-review.googlesource.com/1229778 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#591975} TBR=phoglund@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: I939c09c751590bef70e7bd6cf85b9089fc4a986f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:None Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1231273Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592067}
-
David Bienvenu authored
With VC++ marking a function as non-optimized with MSVC_DISABLE_OPTIMIZE would prevent it from being inlined, however with clang-cl that does not work, leading to confusing crash stacks. The fix is to use NOINLINE instead of MSVC_DISABLE_OPTIMIZE, which is more explicit and specific anyway. Bug: 873359 Change-Id: Idaaf11fb0807990fb72ec3b12515b46a5814356c Reviewed-on: https://chromium-review.googlesource.com/1228973Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592066}
-
John Delaney authored
Record how videos are loaded specifically within ad subframes. This data can be used to better assess how much impact different interventions would have. These metrics will not capture videos created by ad scripts or top-level videos whose source URL is identified as an ad. Change-Id: Icaca094781eb805b7ce1e12e11a79094d4b483c9 Reviewed-on: https://chromium-review.googlesource.com/1217783 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592065}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/18b4479cee3f..0639cbc44de0 git log 18b4479cee3f..0639cbc44de0 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 machenbach@chromium.org [buildbucket] Print build url on command line with buildbucket.py Created with: gclient setdep -r src/third_party/depot_tools@0639cbc44de0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:711249 TBR=agable@chromium.org Change-Id: Id00fee2487aa50513bd58e111fe366d853ff53e3 Reviewed-on: https://chromium-review.googlesource.com/1230633Reviewed-by:
-
Fredrik Söderquist authored
These two cover the same specification (CSS Masking), so merge the smaller corpus into the larger one (also preferring non-fast over fast.) The following tests are converted to testharness.js: css3/masking/clip-path-selection.html css3/masking/parsing-clip-path-shape.html css3/masking/parsing-mask-source-type.html css3/masking/parsing-mask.html and additionally css3/masking/clip-path-selection.html is converted away from using eventSender. Bug: 885137 Change-Id: I36607239ec37c69095632fe409f8a315ceb3e31e Reviewed-on: https://chromium-review.googlesource.com/1230027Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592063}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1bce3d27..d89bb9de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3572b0704356c41ef2e39ba1d61ededd7568c0b5 Reviewed-on: https://chromium-review.googlesource.com/1230573Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592062}
-
rbpotter authored
Refactor the other options settings to make adding a policy icon for them simpler, and consistent with the icons for other settings sections. Bug: 853877 Change-Id: I0abfc3ede4be65647d3645b6a572182b668cd674 Reviewed-on: https://chromium-review.googlesource.com/1225294 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592061}
-
James Hawkins authored
This reverts commit d3433075. With this change in place, if an auth error occurs after the user attempts the Smart Lock sign-in/unlock operation, the user is unable to enter their password because the 'Signing in...' text is still displayed in the password input field. Rolling this forward requires handling that auth error state. Original change's description: > LoginAuthUserView: Display "Signing in..." when the user activates SmartLock. > > This change also animates the ellipses while the operation is executing. > > R=jdufault@chromium.org > > Bug: 845313 > Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled > Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf > Reviewed-on: https://chromium-review.googlesource.com/1072804 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561932} R=jdufault@chromium.org Bug: 873723 Test: none Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5 Reviewed-on: https://chromium-review.googlesource.com/1227293 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#592060}
-
Jesse McKenna authored
Add atomic int |num_tasks_run_| to TaskTracker, which keeps track of the total number of tasks run. Add methods GetNumTasksRun() and IncrementNumTasksRun() to interact with |num_tasks_run_|. Add method RecordLatencyAndTasksRunHistograms(...) to record histograms for tasks run while queuing (one per combination of priority and may_block) in addition to the existing behavior of recording a latency histogram. Change-Id: Ic1ffd915ffe00a4d7866a48723696bee18fe6e42 Reviewed-on: https://chromium-review.googlesource.com/1219768 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#592059}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a146dc589d8..6003ae575d57 git log 9a146dc589d8..6003ae575d57 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 lalitm@google.com trace_processor: split registration from schema generation 2018-09-18 lalitm@google.com trace_processor: add idle slices to the sched table 2018-09-18 lalitm@google.com Merge "trace_processor: collapse sched slice table to a flat table" Created with: gclient setdep -r src/third_party/perfetto@6003ae575d57 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4d7096b9e2bde8d185620d3b75a0c1b3290aaecb Reviewed-on: https://chromium-review.googlesource.com/1230636Reviewed-by:
-
Bence Béky authored
This reverts commit 130902aa, reviewed at https://crrev.com/c/1073192, and also adds a comment that the expectation of DhcpPacFileFetcher::Fetch is violated. Bug: 882996 Change-Id: I127d582dd0fa4a68942c2a005bd543ad8efbd161 Reviewed-on: https://chromium-review.googlesource.com/1230442 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592057}
-
Peter Kasting authored
This also does a few other things, e.g. SkPath -> gfx::Path, cleaning up pre-refresh stuff in tab_unittest.cc, etc. Bug: none Change-Id: I880b950d0432a463c8f2a79c776a5e563d99a07e Reviewed-on: https://chromium-review.googlesource.com/1229368Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592056}
-
Jan Krcal authored
This CL fixes a minor omission from a previous patch. It has minor impact on recording the metric Sync.ModelTypeOrphanMetadata but since this metric is out only for 5 days so far, this CL does not rename it. While adding a new test, this CL also simplifies one existing test. Bug: 1219615 Change-Id: Ie8af1da1d2bac49f087584350df59c1b8ce917e8 Reviewed-on: https://chromium-review.googlesource.com/1230030 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592055}
-
Stephen McGruer authored
Bug: 834314 Change-Id: Ib4fc26eea22bf8a84e2810dbf20f05e552f1fe18 Reviewed-on: https://chromium-review.googlesource.com/1228940Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592054}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc38544e3562..2b7150b9323e git log cc38544e3562..2b7150b9323e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 wangge@google.com Add utility functions for running the swarming task. 2018-09-18 perezju@chromium.org [soundwave] Refactor request and chrome_perf_auth out of api handler Created with: gclient setdep -r src/third_party/catapult@2b7150b9323e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390,chromium:879526 TBR=sullivan@chromium.org Change-Id: Ibac8decd7c07093a2ea8cf415ebc4e2eb3283903 Reviewed-on: https://chromium-review.googlesource.com/1230637Reviewed-by:
-
Tarun Bansal authored
The experiment is already enabled for 50% Canary and Dev channel. Bug: 871795 Change-Id: Ida2f4cfb6a1f5a1b4d3b06bb688891b76fff8e61 Reviewed-on: https://chromium-review.googlesource.com/1226550Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#592052}
-
danakj authored
RenderWidgets sometimes have a LayerTreeView created for them by the time Init() is run, sometimes they do not, and sometimes they never create one. This subtle indirect state is used to determine if the RenderWidget should use a compositor thread input task runner or not. We make this explicit instead of depending on ordering. Further, we note that the initialization of WebPagePopupImpl has boolean return values which can never be false, and tests null cases which do not occur, so we remove those return values and branches. Analysis #0: RenderViewImpl-attached RenderWidget. 1. RenderViewImpl::Initialize() makes a WebViewImpl, which does create a LayerTreeView from its constructor. 2. Then RenderViewImpl::Initialize() calls RenderWidget::Init(). This means RenderWidget::Init() does see a compositor present here. Analysis #1: Popups. 1. WebPagePopupImpl is created from WebViewImpl::OpenPagePopup(). It does RenderViewImpl::CreatePopup(), which makes the WebPagePopupImpl, via RenderWidget::CreateForPopup(). 2. CreateForPopup() also calls RenderWidget::Init(). 3. Then the stack unwinds to WebViewImpl which calls Initialize() on WebPagePopupImpl, which creates the LayerTreeView in RenderWidget. This means the RenderWidget::Init() call happens before the LayerTreeView exists, and there is no compositor present yet. Analysis #2: CreateForFrame() when |local_root| has a parent (making a non-main-Frame RenderWidget) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When there is a parent to the |local_root|, a WebFrameWidgetImpl is created. 3. A WebFrameWidgetImpl does not make a compositor in its constructor, but does later in its Initialize() method. The Initialize() call comes from WebFrameWidgetbase::BindLocalRoot() that is called from WebFrameWidget::Create() before returning to RenderWidget. This means RenderWidget::Init() does see a compositor present here. Analysis #3: CreateForFrame() when |local_root| has no parent (setting up the main Frame) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When for a main Frame, it makes a WebViewFrameWidget. 3. WebViewFrameWidget depends on being attached to a pre-existing WebViewImpl (and RenderViewImpl/RenderWidget) which has already set up a LayerTreeView, and thus does not set up another LayerTreeView on the new RenderWidget. 4. RenderWidget::CreateForFrame() does not make a new RenderWidget, it returns the existing one on the WebViewImpl. This means RenderWidget::Init() does not occur. R=awong@chromium.org, dcheng@chromium.org, piman@chromium.org TBR=jochen Change-Id: I84cc1c875245b755bd39f6890a839ecda71a20e4 Reviewed-on: https://chromium-review.googlesource.com/1227473 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592051}
-
Mugdha Lakhani authored
1. A check for state needs to be removed from a WPT test, since we've removed this attribute from the BackgroundFetchRegistration object. 2. Update calls in matchImpl() from resolver->Reject to ScriptState::RejectWithDOMException. Change-Id: Ie979ad3675ac7d093ae908604e683802db8115a0 Reviewed-on: https://chromium-review.googlesource.com/1230713Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592050}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6bdfebeb1594..9ec77b5574b4 git log 6bdfebeb1594..9ec77b5574b4 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Revert "implement SkPixmap::erase() with draws" 2018-09-18 caryclark@skia.org fix bookmaker 2018-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a49f60fee74d..95277a300f52 (3 commits) 2018-09-18 bsalomon@google.com WEBGL_video_texture : sharing texture prototype in skia 2018-09-17 mtklein@google.com Revert "implement SkPixmap::getPixel() with this->readPixels()." 2018-09-17 mtklein@google.com simplify src->dst matrix init 2018-09-17 herb@google.com Make atomic lists list for bitmaps and paths 2018-09-17 brianosman@google.com Revert "Add Short4 vertex attributes, and benchmark them as 4.12 colors" 2018-09-17 brianosman@google.com Add Short4 vertex attributes, and benchmark them as 4.12 colors 2018-09-17 bsalomon@google.com When merging into an already chained op update the head's op bounds. 2018-09-17 bungeman@google.com Use onOnceBeforeDraw instead of constructor for glyphs. 2018-09-17 kjlubick@google.com Make fuzz::next overloads more consistent 2018-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 017bda429667..a49f60fee74d (3 commits) 2018-09-17 chinmaygarde@google.com Allow users of Skia to optionally link against X11 and GL on Linux. 2018-09-17 mtklein@google.com implement SkPixmap::getPixel() with this->readPixels(). 2018-09-17 mtklein@google.com implement SkPixmap::erase() with draws Created with: gclient setdep -r src/third_party/skia@9ec77b5574b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:776222 TBR=reed@chromium.org Change-Id: I36aaa492376dfc5ad8663c5d5f1b7cdc305148d2 Reviewed-on: https://chromium-review.googlesource.com/1230318Reviewed-by:
-
Matthew Jones authored
This patch only propagates swipe end and fling events to the toolbar swipe layout if it is showing. Previously all touch events to interact with the modified swipe handler would be processed regargless of which layout was showing. The result was incorrect events being triggered and, in this case, showing incorrect buttons in the bottom toolbar. Bug: 884615, 882508 Change-Id: Id791624d1505a18c6fd16bf6a64544a049503d16 Reviewed-on: https://chromium-review.googlesource.com/1228936Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592048}
-
Anne Lim authored
Added skeleton framework for AutofillStrikeDatabase. It will be used to store data about the number of times a user refuses to save their info. Bug: 884817 Change-Id: Iaffac0ab45785e4c0ff261ecb9bbde31e270e00a Reviewed-on: https://chromium-review.googlesource.com/1228774Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#592047}
-
Albert J. Wong authored
ViewHostMsg_ShowWidget and ViewHostMsg_ShowFullscreenWidgetresult in a ViewMsg_SetBounds_ACK message sent to the shown widget. However these messages are handled by RenderViewHostImpl with the routing_id of the widget taken as a data parameter. Since it's easy to get confused about which routing ID is going where this CL renames the local variables to widget_route_id making it clearer which object is being targeted by each message. Bug: 545684 Change-Id: Iba00a3bf8bcd52b43a42a6b49be4275a22ff54f9 Reviewed-on: https://chromium-review.googlesource.com/1228988Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#592046}
-
Dan Zhang authored
Merge http2 part of internal change: 210537018 R=rch@chromium.org Change-Id: Ia31231c598b3d7d8cb79e7b5ebd6f035d3d7b1fa Reviewed-on: https://chromium-review.googlesource.com/1227838Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592045}
-
Andrew Grieve authored
Also tweaked flag to have files be public by default. Change-Id: Ia1bfe6801e1cde24c428bf86e46582f608d97cb1 Reviewed-on: https://chromium-review.googlesource.com/1229509Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#592044}
-
Samuel Huang authored
Previously the script to upload HTML Viewer statics to the script already exists in depot_tools. This CL renames the script. gs: //chrome-supersize was called "gsutil.py", which is confusing since Change-Id: I6aaf2a45943d3664d04f870095e8f33b17817127 Reviewed-on: https://chromium-review.googlesource.com/1230695Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592043}
-
Matthew Jones authored
This reverts commit 27d290e8. Reason for revert: Breaks tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23892 Original change's description: > Fix startup grey status bar on < M devices > > This patch moves the white status bar theme to a version specific > v23 directory to prevent L and below devices from using the flashing > between colors. Logic has also been added to ChromeActivity to prevent > these devices from using the grey (darkened version of white) color on > startup. > > Bug: 881239 > Change-Id: I41e5d959fab96623d254f4ff2dd0ea15cb6f9abc > Reviewed-on: https://chromium-review.googlesource.com/1228496 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591857} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: Idbd15b881ffe2652aaea6a0a86faf02872256337 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881239 Reviewed-on: https://chromium-review.googlesource.com/1230697Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592042}
-
Mikel Astiz authored
After a long debugging session, we haven't yet found an explanation as per why the processor enters an inconsistent state, where apparently OnSyncStarting() is received twice without OnSyncStopping() in between. As a last resort to continue the investigation, we add even more CHECKs to understand which layer is violating the API contracts. Bug: 876490,885019 Change-Id: Ia15fa29d8bd128730bd79b4760ea233f09d9862e Reviewed-on: https://chromium-review.googlesource.com/1230733Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592041}
-
Jacobo Aragunde Pérez authored
Bug: 884306 Change-Id: Ibeff0b4c01007d9cfa0fbed3115a4acd5c3c8586 Reviewed-on: https://chromium-review.googlesource.com/1230019Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#592040}
-
Hans Wennborg authored
This is already inside an if (is_clang) scope. Bug: none Change-Id: I893f21598d4bc0e26c8d52fae44a48b6767f3eed Reviewed-on: https://chromium-review.googlesource.com/1230043 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592039}
-
Nicolas Ouellet-Payeur authored
Bug: 884221 Change-Id: Iaee4d979888e3bc5acf55f88c3618fd33810adf6 Reviewed-on: https://chromium-review.googlesource.com/1226025Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45b9bc919502..cc38544e3562 git log 45b9bc919502..cc38544e3562 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 pasko@chromium.org androidStartupMetric: remove request_start_time from comments Created with: gclient setdep -r src/third_party/catapult@cc38544e3562 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:883290 TBR=sullivan@chromium.org Change-Id: I237765b77a49da001cbb1ef19f147e4638f5f093 Reviewed-on: https://chromium-review.googlesource.com/1230320Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Environment variables on the command-line (alternative browser path and parameters) are expanded before being passed to the external program. On Windows, this means strings like '%HOME%' are expanded. On Linux, this means strings like '$VAR' and '${VAR}' are expanded. Also, a '~' at the beginning of a command-line argument is expanded to the HOME environment variable. Bug: 882520 Change-Id: I9822b465999b3515d37e882f18a19df39b3e64d6 Reviewed-on: https://chromium-review.googlesource.com/1225854Reviewed-by:
-
