- 18 Nov, 2020 40 commits
-
-
Peter Kasting authored
This is primarily to address the case of "inf / inf", which in terms of doubles is 1, but in terms of TimeDeltas is a checkfailure. Bug: 1148774 Change-Id: Iee4d80a721915ab2251535585153d9f6e2eb7f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545026Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828863}
-
John Lee authored
Fixed: 1145715 Change-Id: I2b5a6660b2dd09a05c24e252df384f01fe3ee49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541746 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828862}
-
Renato Silva authored
Fix compile error: comparison of integers of different signs: 'const unsigned long' and 'const int' in certificate_provider_apitest.cc:658 EXPECT_EQ(GetAllProvidedCertificates().size(), 1); Change-Id: Iddfb3b8b4015b0f99c337e91a11ddcc92fd9e881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547108 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828861}
-
Nina Satragno authored
Disable PaymentRequestShippingAddressEditorTest.AsyncData. It's Flaky. Change-Id: I468a82a404ebd93b78f6e4160577d3b690d6d5e3 Tbr: danyao@chromium.org Bug: 1150496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547386Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828860}
-
James Forshaw authored
This CL removes support for the SANDBOX_EXPORTS compile option. The feature is not tested or officially supported. It's common practice to removed unused code where possible. Bug: 610499 Change-Id: I357e8a0a531dc0cbbd263baa77441bb7f97c5585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544878 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828859}
-
Xida Chen authored
This CL moves the paint of the background color off the main thread. Here is the design doc: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit In particular, we follow the infra of paint worklet. When main thread paints, we create a PaintDeferredImage, which is a place holder that does nothing. And then we create a NativePaintWorkletInput that captures necessary info and pass it to the compositor thread. After commit, we ask the compositor thread to use the information from the NativePaintWorkletInput and paint the background color. Once the paint is done, we activate the pending tree. There is no need to add new test, as long as the current test are passing because this CL should not cause any behavior change. Bug: 1139004 Change-Id: Id487ca3c8511e620bcc652e75199f893227a50e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466140 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d14436f82285..2e4ad365f6e4 2020-11-18 tvanderlippe@chromium.org Remove bridge files from inline_editor 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in inline_editor/ 2020-11-18 tvanderlippe@chromium.org Typecheck inline_editor/Swatches.js with TypeScript 2020-11-18 tvanderlippe@chromium.org Remove bridge files in elements/ 2020-11-18 bmeurer@chromium.org [bindings] Fix breakpoint not hit upon first reload. 2020-11-18 jacktfranklin@chromium.org Fix heuristic for determining external bundles in Release If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1150259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc477a04776447848d11ecef8bd23af00f2f0639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828857}
-
Chris Sharp authored
Users can change it, so it isn't always 3 Change-Id: I71b9cb834ba79414b7590a07601b58d2edb49f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547305Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#828856}
-
Steven Bingler authored
The ordering of columns in the SQL access statements was different from the initial schema. This CL reorders them to match. While it is possible to omit the column names and only reference them by number the code is easier to read/confirm correct by using the names. Fixed: 1149659 Change-Id: Ia60848f5d3b5940b5f283448911ce426271c7328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542943 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828855}
-
Moe Ahmadi authored
crrev.com/c/2531654 made deletion of queries from the in-memory URL DB asynchronous by posting the deletion task to a sequenced task runner on the UI thread. The said CL was later reverted in crrev.com/c/2532543 for making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. This CL fixes the flakiness by providing a way for the tests to flush the scheduled tasks after deletion from the in-memory URL DB and TearDown() Bug: 1148612 Change-Id: I3f5c7b598a5d6907794b9d6ca1598626156516c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536355Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828854}
-
Omar Morsi authored
This CL handles cases when TPM initialization fails and system token certificate database was requested. It handles this case by introducing a five-minutes-timeout for the database request. Bug: 1068548, 844022 Change-Id: If738218f7816aa9af931fa23c85da39012b86b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410377Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=danakj@chromium.org, jochen@chromium.org, majidvp@chromium.org Bug: 1113033 Change-Id: I819cce1cfa2d16cafb61b963b26e54647eee61ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543696 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828852}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/262a64839ac8..b61a10d6bd1f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com,nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142932 Tbr: dmazzoni@google.com,nsatragno@google.com Change-Id: I6c05680e05728254120c517ed5dd1ccae04543cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547560Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828851}
-
Mark Yacoub authored
Remove useless modesetting tracing from HDC that don't mean much. Add tracing to Screen Manager where modeset test and commit are being orchestrated. BUG: N/A TEST: modeset and unplug connectors while recording on chrome://tracing Change-Id: If6e30326551a47bf22d2acfd530678cc73396cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544444 Auto-Submit: Mark Yacoub <markyacoub@google.com> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#828850}
-
James Cook authored
Lacros does not support multi-signin (aka "Chrome OS multi-profile"). Don't add the Lacros icon to the shelf for secondary accounts in multi-signin session. Likewise, don't add LacrosApps to AppServiceProxy for secondary accounts, which prevents the Lacros icon from appearing in the app launcher. Update the related unit tests so they create a primary user, which is needed for ProfileHelper::IsPrimaryProfile() to return true in tests. Bug: 1142507 Test: unit_tests Change-Id: I8e11b6834500f7da3d2642c087aac31b1e4b2f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542678 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828849}
-
Vasilii Sukhanov authored
The foreign key is gonna be used for the table of compromised passwords. The CL just - activates the feature for the database file (no migration is happening) - Makes SQLTableBuilder aware of it for proper version migrations. Bug: 1137775 Change-Id: Ia891184575094bb6eef4e699db2b5dc2737af994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543155 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#828848}
-
Dirk Pranke authored
Apparently the test() template had a special-case branch for a linux-chromeos build that was not generating bin/run_* wrappers like every other build configuration was. This CL fixes that omission. Bug: 816629 Change-Id: I30852d040675efc62159120b0d2396f2e22ea3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545777Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#828847}
-
Patrick Brosset authored
In the DevTools flex tooling project, we want to be able to control how the empty space (created by justify-content, align-content and gap properties) look. We want to do so in a way that allows to highlight just one, or several of them. So this CL simply adds the required properties to the corresponding CDP types as well as handling of this data so it goes to the overlay frontend. Bug: 1139949 Change-Id: Ibfbd33531f3f2018447d113807f3878b823cfd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539742 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#828846}
-
Kevin Marshall authored
Handles the crasher in which the metrics recorder channel is disconnected while additional metrics are being gathered. Test: cr_fuchsia_base_unittests Bug: 1147146 Change-Id: Iff987933233bd1565ed052b1ca1e1225b30e782d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538331 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#828845}
-
Wez authored
Publishing the fuchsia.web.FrameHost introduces the possibility that it causes the main web.Context to be created before the list of CORS- exempt headers has been fetched. This can prevent headers being applied based on UrlRequestRewriteRules, breaking later users of that Context. StartComponent() is split into the public API which verifies arguments and triggers fetch of the CORS exempt headers list, if necessary, and a separate internal part called when the headers are available, which actually creates the FrameHostComponent, or PendingCastComponent. Bug: 1150488 Bug: b/173386485 Change-Id: I2f294e9f0acbf43c971004882461c0f38a4c37b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547580 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828844}
-
Stephen McGruer authored
The lack of __init__.py was failing the import in resource-timing/SyntheticResponse.py, which then caused external/wpt/resource-timing/resource-timing-level1.sub.html to timeout. Bug: None Change-Id: I8dc2c9f9d439c7c2c1cbaad9225f24563eb0e99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546993 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#828843}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dda9c164cb3b..d361e6028c27 2020-11-18 primiano@google.com Merge "test data: Add chrome_memory_snapshot.pftrace" 2020-11-18 treehugger-gerrit@google.com Merge "metrics: Add camel-case mapping for modified RAIL mode names" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icdc6cf1da231cde2786ac9462c92f581a934ab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547382Reviewed-by:
-
David Tseng authored
It is generally bad practice to send the tts engine an empty string. This change will try to identify all call sites or scenarios where this occurs. If many such instances occur, a allow list (for now) with bugs filed against owners should be added. R=dmazzoni@chromium.org Change-Id: Ie08dd07e07bf43419aadde83786e5724dd196f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538035 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828841}
-
Nina Satragno authored
It's flaky. Tbr: masonfreed@chromium.org Bug: 1150475 Change-Id: I772bf0577ba5d2772340731e7384779238e6734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547383 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This reverts commit d5f58580. Reason for revert: A CL this depends on got reverted Original change's description: > [WebLayer] Create FragmentHostingRemoteFragmentImpl > > This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl > and MediaRouteDialogFragmentImpl, replacing them with a Context that > hosts the fragments instead. This is possible now that we've landed > the bytecode rewriting that changes the return type of > Fragment.getActivity() from FragmentActivity to Activity. > > Bug: 1123216 > Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828649} TBR=sky@chromium.org,finnur@chromium.org,estade@chromium.org,rmcelrath@chromium.org Change-Id: I2b83becfef2a92bd878bf32ae3aa5b750853a752 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547783Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#828839}
-
Anton Bikineev authored
Layout partition is not thread safe. Bug: 11297512 Change-Id: I4c5f7e5a8c181bd1dc9781d1e79ee9101f61c15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547442 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The case where a LocalFrame (A1) had an intermediate LocalFrame (A2) owning a RemoteFrame (B1) wasn't covered. The notification was sent only to the LocalFrame root's remote frame descendants. Iterate the frame tree going over LocalFrame but stopping when we encounter a LocalFrame root. BUG=1149775 Change-Id: I1d9f3d51685fd08794335fb93b103db930b24cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543130 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
By mistake, I added a selection_clipboard_buffer_available member to the end of the IPC struct traits for blink::RendererPreferences, but such member was already present a few lines above, which is a mistake. Looking into the issue today, I realized that the reason I didn't see was that it was guarded by defined(OS_LINUX) || defined(OS_CHROMEOS), along with system_font_family_name, which is not exactly correct since the right guard would have been defined(USE_X11) || defined(USE_OZONE). This CL simply removes the declaration from the original place and leaves the one added in the CL that introduced the duplication [1], which has the member added inside the right guards. [1] https://crrev.com/c/2445499 Bug: 1102442 Change-Id: I9f02705ce1e07ca76f7581cbb8b2b37034650b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544947Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#828836}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iae6d832f2fec2f0a146fb08828fa077f4846162d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547462Reviewed-by:
-
Chan Li authored
Bug: 1108016 Change-Id: If209efabc72acd684ce2a34100844d6fc6dda8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542823 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#828834}
-
Yi Xie authored
DiskMountManager depends on dbus calls to cros-disks. A recent change crrev.com/c/2422018 blocked access to internal disks through cros-disks. BUG=b:173102552 Change-Id: I4c368f3f934371bbb3d5a777a82fdf3721d67eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537535Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Yi Xie <yixie@chromium.org> Cr-Commit-Position: refs/heads/master@{#828833}
-
Nancy Wang authored
There are other app icon badgings, e.g. pause badge, block badge, the current UpdateAppBadging is used to update the notification badging only, so rename the related function names. BUG=1144384 Change-Id: I7ec07dc7687bd55cb3566b423665cded9714b95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545336 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828832}
-
edchin authored
This reverts commit cac286db. Reason for revert: This should have been landed after the CL to move the password_store_signin_notifier_impl. Original change's description: > Revert "[ios][PhishGuard] Port code to ios_chrome_password_store_factory" > > This reverts commit 8d720de8. > > Reason for revert: Compile failure on ios-device > > 'components/password_manager/core/browser/password_store_signin_notifier_impl.h' file not found > > https://ci.chromium.org/p/chromium/builders/ci/ios-device/172358 > > Original change's description: > > [ios][PhishGuard] Port code to ios_chrome_password_store_factory > > > > Design doc: go/bling-phishguard > > > > The password_store_factory had already been forked between > > //chrome and //ios. This CL ports password reuse detection code > > from //chrome into the //ios implementation. > > > > Runtime changes are behind the kPasswordReuseDetectionEnabled > > feature flag. > > > > Bug: 1147962 > > Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748 > > Commit-Queue: edchin <edchin@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828562} > > TBR=vasilii@chromium.org,edchin@chromium.org > > Change-Id: I2286176790447a0dc192c01a6f4a888699f77c70 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546302 > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828566} TBR=vasilii@chromium.org,edchin@chromium.org,qjw@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1147962 Change-Id: I5771528c764e83a7ce50f382eb65b93097283c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546172Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828831}
-
Erik Språng authored
Bug: 1143271 Change-Id: I1b24f23d1e3749bf4a4283b38f79a607129180cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544547 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#828830}
-
Xianzhu Wang authored
Bug: 936906 Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828829}
-
Andrey Zaytsev authored
Since the downstream code uses PrivacyPreferencesManager, left a class with a single getInstance() method. Bug: 1132805 Change-Id: Ia1d2d9861c5a4782bb374d09fd36107d0ee2580c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543936 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#828828}
-
Kyle Horimoto authored
When a NearbyConnectionBrokerImpl object is deleted, invoke DisconnectFromEndpoint() if a connection had been established during the lifetime of the object. Specifically, if OnConnectionInitiated() has been called but OnDisconnected() has not, we disconnect. Bug: 1149770, 1106937 Change-Id: I1c805475400d84d87092fbfafae20f0c48b7208c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545670Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828827}
-
Kent Tamura authored
- Remove DEFINE_DOCUMENT_TYPE_CASTS() macro It's not used. - Remove DEFINE_TRACK_TYPE_CASTS() macro It's not used. - Remove DEFINE_TYPE_CASTS() for PresentationConnectionAvailableEvent The code generated by this DEFINE_TYPE_CASTS() are not used. This CL has no behavior changes. Bug: 891908 Change-Id: I8a60227c042f85c7d25184258e105b1ba2a9eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546393 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Luke Zielinski authored
This is the first stage of replacing the existing linux-wpt-payments-fyi-rel builder with this new 'input' builder. The next set of CLs will switch to using 'input' instead of 'payments' in wpt-importer smoketests. Bug: 1127055 Change-Id: I2f3aab01e99991733cc2f936d729dbb21e666b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545286Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828825}
-
Michael Checo authored
- Will be updated to adhere to the spec in the future. Screenshot: http://shortn/_17jazhYXnr Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: I55770ae52546b055f77766eb31644d3218ec8658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530452 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828824}
-
