GitLab

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874853
Change-Id: I4d141e987d48df3ee4b4332c8341e5e5c7883301
Reviewed-on: https://chromium-review.googlesource.com/1177683
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583631}

R8 doesn't parse the "" version, but is fine with ''.

Bug: 872904
Change-Id: I827798ac9b29031138397dcadde38567e3df63bb
Reviewed-on: https://chromium-review.googlesource.com/1176631Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583630}

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874851
Change-Id: I83cc51e272b418a942f324f3e0a408f7b05961d3
Reviewed-on: https://chromium-review.googlesource.com/1177629Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583629}

Flakiness dashboard shows that it is flaky on all platform

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 859169
Change-Id: I5c9193cb1e36962c02b6c8d33739bc1687728ac1
Reviewed-on: https://chromium-review.googlesource.com/1177628Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583628}

This CL removes the TabGrid implementation of BrowserCommands. This is
done such as the -openNewTab: method of BrowserCommands can be removed
in UI Refresh, merged away in the -openURL: method in
ApplicationCommands.

Bug: 861729
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I001e387a3f4668ff2291c49ef83354888ea81a03
Reviewed-on: https://chromium-review.googlesource.com/1127898Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583627}

We mark nodes as needing a layout tree rebuild pass to reconsider the
need for whitespace LayoutText objects if we remove any of its children.
However, we don't need that if all children were removed, if the node no
longer has a LayoutObject, or if the node was already marked for
re-attachment.

Change-Id: I74310936372320599b24f2d5146df855455bce1e
Reviewed-on: https://chromium-review.googlesource.com/1177381
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583626}

https://webrtc.googlesource.com/src.git/+log/4eb4b05556ff..e9721f2f0830


git log 4eb4b05556ff..e9721f2f0830 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 titovartem@webrtc.org Move SimulatedNetworkConfig on top level.
2018-08-16 danilchap@webrtc.org Remove deprecated fields from RtcpStatistic struct
2018-08-16 nisse@webrtc.org Refactor voe::Channel to not use RtpReceiver.


Created with:
  gclient setdep -r src/third_party/webrtc@e9721f2f0830

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic6e1d945bb71aeb629d95e66a294bf7974b29ed8
Reviewed-on: https://chromium-review.googlesource.com/1177582Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583625}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

We are hoping to get rid of execute() entirely, since it is often
assumed to be a parallel operation.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: I51f22e371ec1e0d0e5114f4b211c934e214f5784
Reviewed-on: https://chromium-review.googlesource.com/1174900Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583624}

This CL adds support for I420A VideoFrames in GMBVideoFramePool. These
VFrames are turned into BGRA or RGBA depending on the preferred platform
swizzling (spolier: BGRA is Mac).

Canvas Capture test is changed to premultiplied to follow up the Skia
convention.

Bug: 873345
Change-Id: I20d1f9f59e47a55b67763b2cb7884387f99118a5
Reviewed-on: https://chromium-review.googlesource.com/1174949
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583623}

FirstChild did not include pseudo elements and some PseudoAware* methods
were already duplicated in the traversal methods.

Change-Id: I002384693edb188eda9ee6388aa191c4727fbc84
Reviewed-on: https://chromium-review.googlesource.com/1177393Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583622}

This mitigation shipped to stable in M61.
https://chromium-review.googlesource.com/518156
https://www.chromestatus.com/feature/5735596811091968

BUG=680970

Change-Id: I827ca161ecc7e3d7b75fc2774cee8e6d0ea04ed3
Reviewed-on: https://chromium-review.googlesource.com/1164967Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583621}

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874837
Change-Id: I1025816a10ffcc261a9fb21c434bf86b1f9a4dde
Reviewed-on: https://chromium-review.googlesource.com/1177625Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583620}

This reverts commit e2c55011.

Reason for revert: Causes ash_unittests regressions. This is NOT
a speculative revert, as I've bisected to this commit and reproduced
it locally. Please do not reland as is.
Failing build: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28629

Original change's description:
> Reland "cros: Enable touchable app context menus by default."
> 
> This reverts commit 32cd8fcf.
> 
> Reason for revert: Reverting the revert because this change was proven to not have caused the issue.
> 
> Original change's description:
> > Revert "cros: Enable touchable app context menus by default."
> > 
> > This reverts commit b58ccf6d.
> > 
> > Reason for revert: Possibly introduced a use-after-free bug.
> > 
> > This is a speculative fix for a use-after-free bug in two ash_unittests:
> > 
> > 1. OverflowButtonInkDropTest.MouseContextMenu
> > 2. OverflowButtonActiveInkDropTest.MouseContextMenu
> > 
> > [ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
> > =================================================================
> > ==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
> > READ of size 8 at 0x613000031f68 thread T0
> >     #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
> >     #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
> >     #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
> >     #3 0x8c82105 in HasObserver base/observer_list.h:267
> >     #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
> >     #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
> >     #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
> >     #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
> >     #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
> >     #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
> >     #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
> >     #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
> >     #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
> >     #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
> >     #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
> >     #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
> >     #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
> >     #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
> >     #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     #24 0x72b9892 in Run base/callback.h:99:12
> >     #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     #27 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > 0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
> > freed by thread T0 here:
> >     #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
> >     #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
> >     #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
> >     #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
> >     #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
> >     #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
> >     #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
> >     #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     #13 0x72b9892 in Run base/callback.h:99:12
> >     #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     #16 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > previously allocated by thread T0 here:
> >     #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
> >     #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
> >     #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
> >     #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
> >     #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
> >     #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
> >     #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
> >     #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
> >     #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
> >     #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
> >     #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
> >     #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
> >     #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
> >     #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
> >     #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
> >     #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
> >     #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
> >     #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
> >     #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
> >     #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
> >     #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
> >     #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
> >     #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
> >     #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
> >     #25 0x72b9892 in Run base/callback.h:99:12
> >     #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
> >     #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
> >     #28 0x178df94 in main ash/test/ash_unittests.cc:37:10
> >     #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287
> > 
> > SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
> > Shadow bytes around the buggy address:
> >   0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >   0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> >   0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
> >   0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> >   0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> > =>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
> >   0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
> >   0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> >   0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
> >   0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
> >   0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
> > Shadow byte legend (one shadow byte represents 8 application bytes):
> >   Addressable:           00
> >   Partially addressable: 01 02 03 04 05 06 07 
> >   Heap left redzone:       fa
> >   Freed heap region:       fd
> >   Stack left redzone:      f1
> >   Stack mid redzone:       f2
> >   Stack right redzone:     f3
> >   Stack after return:      f5
> >   Stack use after scope:   f8
> >   Global redzone:          f9
> >   Global init order:       f6
> >   Poisoned by user:        f7
> >   Container overflow:      fc
> >   Array cookie:            ac
> >   Intra object redzone:    bb
> >   ASan internal:           fe
> >   Left alloca redzone:     ca
> >   Right alloca redzone:    cb
> >   Shadow gap:              cc
> > ==28149==ABORTING
> > 
> > Original change's description:
> > > cros: Enable touchable app context menus by default.
> > > 
> > > This will enable:
> > >  - New context menu UI for:
> > >   - Application icons
> > >   - Shelf context menus
> > >   - Desktop context menus
> > > 
> > > Note:
> > >  - Removed tests whose functionality were already being tested.
> > >    - MouseContextMenu already tests whether the ink drop is being
> > >      shown, so there is no need for
> > >      ShelfButtonShowsInkDropHighlightOnMenuShow.
> > > 
> > > Bug: 871843
> > > Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> > > Reviewed-on: https://chromium-review.googlesource.com/1170985
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#582978}
> > 
> > TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org
> > 
> > Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 871843
> > Reviewed-on: https://chromium-review.googlesource.com/1174641
> > Reviewed-by: Chris Mumford <cmumford@chromium.org>
> > Commit-Queue: Chris Mumford <cmumford@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583088}
> 
> TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org
> 
> Change-Id: I4edeef479d40e1e591ac906aa89ede363668b6a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 871843
> Reviewed-on: https://chromium-review.googlesource.com/1174777
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583310}

TBR=xiyuan@chromium.org,sky@chromium.org,cmumford@chromium.org,newcomer@chromium.org

Change-Id: I8398745c9037fb5be605069646b3a655519d023e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1177482Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583619}

This cl fixes threading model: the proxy object is created on
a gpu main thread, whereas mojo ptr for a WaylandConnection is
set on a IO child thread. ScheduleSwap is also called on GpuMainThread,
but other methods can be called from IO threads.

To make a consitency, always use GpuMainThread's task runner.
This is also needed for a frame callback, which will be passed during
ScheduleSwap calls in a follow up cl.

Bug: 859012, 820047
Change-Id: I6833f3722cb4531da375387a7d443c1835f3c870
Reviewed-on: https://chromium-review.googlesource.com/1170827
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583618}

The zip unpacker NaCl plugin compilation fails too often on ASAN; that
causes persistent time-out flakes. Disable these tests on ASAN only.

Bug: 867738
Change-Id: Ib370b0896afe13a3ebbd33b3d93db2d9f39b39b5
Reviewed-on: https://chromium-review.googlesource.com/1177401
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583617}

It broke find-in-page.

Change-Id: Ic78f5efab61f1b4032fc549cee08e58daf1de7a8
Reviewed-on: https://chromium-review.googlesource.com/1176833
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583616}

Makes the omnibox_util implementation file an Objective-C++ file and
provides better utils (reducing boilerplate at call sites).

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7f8d42fbe19f9fa65b8697d6d668e861d3b81671
Reviewed-on: https://chromium-review.googlesource.com/1148204
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583615}

input[type=file]: Move responsibility for PopupOpeningObserver registration from FileInputType to FileChooser.

We saw a DCHECK failure when a user dropped a directory to <input
type=file webkitdiretorty> because FileInputType::FilesChosen()
tried to unregister PopupOpeningObserver though
FileInputType::SetFilesFromDirectory() didn't call
ChromeClient::RegisterPopupOpeningObserver().

This CL moves the registration code from FileInputType to
FileChooser. It's difficult for FileInputType to know exact
timing of showing/hiding FileChooser dialogs because we have a
FileChooser queue in ChromeClientImpl. FileChooser knows it.
Because the FileChooserClient implementation is also a
PopupOpeningObserver implementation, this CL merges them into one
for code simplicity.

Bug: 637639
Change-Id: Ia9f64c212db635b3438431b4c61f06d257300839
Reviewed-on: https://chromium-review.googlesource.com/1177212Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583614}

This allows long inline suggestions to not have an ellipsis, instead
they are clipped.

Bug: 439779
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia6c47fd901eea2d5fcd04bcfcbc242f3a56bad01
Reviewed-on: https://chromium-review.googlesource.com/1148338Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583613}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I91de1f9e056bac35139c76e10dc48b7969a239c3
Reviewed-on: https://chromium-review.googlesource.com/1177622
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583612}

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 874831
Change-Id: I00c5be680cf61bf967aef7eced380637bf23e1da
Reviewed-on: https://chromium-review.googlesource.com/1177623Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583611}

This reverts commit 24e19835.

Reason for revert: <INSERT REASONING HERE>
Causes a bunch of unittest to fail:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28633

Original change's description:
> De-flake SAMLOfflineSigninLimiterTest
> 
> Without this, its tests fail when conceptually unrelated code such as
> https://chromium-review.googlesource.com/c/chromium/src/+/1170145 calls
> content::BrowserThread::PostAfterStartupTask
> 
> Change-Id: I7433719ee9721e224db955669b3c8d079cf780dc
> Reviewed-on: https://chromium-review.googlesource.com/1174577
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Nigel Tao <nigeltao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583465}

TBR=xiyuan@chromium.org,nigeltao@chromium.org

Change-Id: I573f27fbd7bfc5b5fe933cd8e293248d43b742ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1177641Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583610}

https://webrtc.googlesource.com/src.git/+log/b336c2784f5e..4eb4b05556ff


git log b336c2784f5e..4eb4b05556ff --date=short --no-merges --format='%ad %ae %s'
2018-08-16 nisse@webrtc.org Delete unused method VideoReceiver::SetMinReceiverDelay
2018-08-16 tzik@chromium.org Remove a static initializer in default_temporal_layers.cc
2018-08-16 kthelgason@webrtc.org Activate initial framedrop when first BW estimate arrives
2018-08-16 kthelgason@webrtc.org Add RTCCertificate to framework headers.
2018-08-16 peah@webrtc.org Hooks up more AEC3 parameters to be read by the AEC3 configuration file
2018-08-16 asapersson@webrtc.org Remove unused members in rtp_rtcp tests and make some members const.
2018-08-16 mbonadei@webrtc.org Change the default behaviour rtc_builtin_ssl_root_certificates.
2018-08-16 oprypin@webrtc.org Revert "Remove linux_internal_compile_lite from CQ."
2018-08-16 buildbot@webrtc.org Roll chromium_revision 636e4e8c..7e9f692e (583445:583557)
2018-08-16 buildbot@webrtc.org Roll chromium_revision 858c0de5..636e4e8c (583305:583445)
2018-08-15 lliuu@webrtc.org Revert "Optimize execution time of RTPSender::UpdateDelayStatistics"
2018-08-15 tarekh@google.com Update multiplex encoder to support having augmenting data attached to the video
2018-08-15 buildbot@webrtc.org Roll chromium_revision 60eb76e6..858c0de5 (583181:583305)
2018-08-15 terelius@webrtc.org Optimize execution time of RTPSender::UpdateDelayStatistics
2018-08-15 tzik@chromium.org Add a missing #include from jsepicecandidate.cc to absl/memory/memory.h
2018-08-15 nisse@webrtc.org In (new) estimator of encoder cpu load, count max per input frame.
2018-08-15 saza@webrtc.org Add APM config flag for legacy moderate suppression level in AEC2
2018-08-15 srte@webrtc.org Makes treatment of received reports of packets lost signed.
2018-08-15 aleloi@webrtc.org Gain metrics for digital adaptive AGC.
2018-08-15 titovartem@webrtc.org Use NetworkSimulationInterface instead of SimulatedNetwork.
2018-08-15 sprang@webrtc.org Refactor vp8 temporal layers with inferred sync and search order
2018-08-15 nisse@webrtc.org Delete class voe::RtcEventLogProxy
2018-08-15 danilchap@webrtc.org Inline one-line RtpPacket getters
2018-08-15 asapersson@webrtc.org Clear encoded frame map on gap in timestamp.
2018-08-15 aleloi@webrtc.org Fine-grained limiter metrics.
2018-08-15 aleloi@webrtc.org Atomically increment GainControl instance counter.
2018-08-15 nisse@webrtc.org Delete unneeded forward declares of vcm::VideoReceiver.
2018-08-15 buildbot@webrtc.org Roll chromium_revision 5edb31a0..60eb76e6 (582911:583181)
2018-08-14 benwright@webrtc.org Adds the custom TLS certificate verifier pointer to the reconfigure option as
2018-08-14 ouj@fb.com Video bitrate allocator factory interface for custom video bitrate allocator
2018-08-14 buildbot@webrtc.org Roll chromium_revision 690394a8..5edb31a0 (582511:582911)
2018-08-14 mbonadei@webrtc.org Revert "Add initial support for RtpEncodingParameters max_framerate."
2018-08-13 michael@kapsulate.com Add certificate generate/set functionality to bring iOS closer to JS API


Created with:
  gclient setdep -r src/third_party/webrtc@4eb4b05556ff

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:752720,chromium:None,chromium:None,chromium:816819,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id37f277d7a7f512b4b141eca2821f14d0294fd4c
Reviewed-on: https://chromium-review.googlesource.com/1177581Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583609}

instance here:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4726

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 827209
Change-Id: I1e9a0143372200ffd2a84f95739ad93abc55fd02
Reviewed-on: https://chromium-review.googlesource.com/1177621Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583608}

This CL fixes the failing TabGridMediator unittests.
The TabRestoreService is a dependency that is needed
in the TabGridMediator, but that requires a valid
browserState.
This CL properly passes in the TabRestoreService
dependency, instead of allowing the TabGridMediator
to grab it using the browserState.

Other dependencies should also be passed in, but
this CL is intentionally kept small.

Bug: 873632, 873633
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie262f283b35c5a8cf5299d00e0a8cf680628cf53
Reviewed-on: https://chromium-review.googlesource.com/1176966Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583607}

This CL adds all remaining tests from
https://github.com/abarth/http-state/tree/master/tests.
Not all of them pass, but all of them run consistently
with the same results.

This also adds a lot of documentation - in code and
when running a server.
By navigating to
<server>/cookies/http-state/resources/cookie-setter.py
All tests are gathered and run. The shown document
explains the usage of the server for debugging purposes.

Change-Id: I4a75655704dddc213a3f3b6fa26beeb14acf3338
Reviewed-on: https://chromium-review.googlesource.com/1021577Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583606}

This patch removes the 'target' attribute by replacing it with a new
'destination' value that distinguishes between top-level and nested
navigations.

Spec: https://github.com/mikewest/sec-metadata/commit/de7530709176c56956a5f696b52244f25f86e4fd

Bug: 861678, 843478
Change-Id: I2bf5df1b93fb2c7c341cbe6da30d99bb19d40626
Reviewed-on: https://chromium-review.googlesource.com/1172137Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583605}

Bug:867379
Change-Id: I28e93d20ffc8540768074c5145eecd7d3c198bf6

TBR=sullivan@chromium.org, simonhatch@chromium.org

Change-Id: I28e93d20ffc8540768074c5145eecd7d3c198bf6
Reviewed-on: https://chromium-review.googlesource.com/1177279Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583604}

This CL adds a new attribute "invisible" and event "activateinvisible"
behind the flag "InvisibleDOM". When an element has the kuma attribute,
it is treated as if its display value is "none", meaning all of its
inclusive flat-tree descendants are not rendered.

When an invisible element needs to be shown for anchor-link navigation,
a DOM event of type “activateinvisible”  will be sent to all of its
flat tree inclusive ancestors that have the invisible attribute.
The event is cancelable and bubbles but is not composed.
If the event is not canceled, UA will remove the invisible attribute
from all the flat tree inclusive ancestors that originally have
the invisible attribute.

See design doc at https://goo.gl/sEJt3e
I2I: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Icw_sU6PqVA/8hwXw0jTDwAJ

Bug: 873057
Change-Id: I0ba108789d5ddaa6227b1488f088cd10113fdc58
Reviewed-on: https://chromium-review.googlesource.com/1163052Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583603}

TBR=sullivan@chromium.org, tdresser@chromium.org
NOTRY=true

Bug: 874803
Change-Id: I4b2d1f362fb2d6c19b66447e56bd1d23c0fcee8d
Reviewed-on: https://chromium-review.googlesource.com/1177541Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583602}

It's been flaky for a long time.

TBR=nasko@chromium.org

Bug: 874782
Change-Id: I04bda849d623ab108229781a7a4d26d6520b8ebc
Reviewed-on: https://chromium-review.googlesource.com/1177389Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583601}

It's flaky.

TBR=rockot@chromium.org

Bug: 874719
Change-Id: I2846001a08f8b56a90d9a9ec592953d1df97d8e0
Reviewed-on: https://chromium-review.googlesource.com/1177391Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583600}

Bug: chromium:851421
Change-Id: I931316701bbd406ddca8f4fad9222bfc7752c126
Reviewed-on: https://chromium-review.googlesource.com/1174432Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583599}

ListModel is shorter and more consistent with PropertyModel. Rename
other classes correspondingly.

Bug: 847420
Change-Id: Id8459c21197d4e01879703325c0142508091246d
Reviewed-on: https://chromium-review.googlesource.com/1172582Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583598}

Previously, not all extensions could be installed in a Public Session since the
API they were using was deemed too powerful.  After the switch to Managed
Sessions, remove this restriction.

Bug: 865947
Change-Id: I536d24d2858fe1c1d5b517538a8f918eeb6756d9
Reviewed-on: https://chromium-review.googlesource.com/1174442
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583597}

Bug: 872569
Change-Id: Ic52ccdaa24f447bca72b8bba3eb734923584fac2
Reviewed-on: https://chromium-review.googlesource.com/1175504
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583596}

For accounts with many team drives, startup can be slow so wait longer.

Bug: 845388
Change-Id: Id3e62651a29a1b217f6085da8b2e1d43e95b44af
Reviewed-on: https://chromium-review.googlesource.com/1177299Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583595}

WPT test for window.event checks global event with nodes moving.
Global event is set to invoked event before calling listener only if
global is a Window and tuple's item-in-shadow-tree is false.
(See 2-8: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke)
This item-in-shadow-tree is saved before calling listener, so nodes
moving inside listener does not affect it.
(See 2: https://dom.spec.whatwg.org/#concept-event-path-append)

Current test assumes that global event is set to invoked event even if
the EventTarget where the event is invoked at is in shadow tree before
calling listener, but it should not be set as mentioned above.
With this reason, window.event should be undefined if EventTarget is in
shadow tree. This CL correct it.

Also, chromium does not support this operation now, so I created a
issue for this:
https://bugs.chromium.org/p/chromium/issues/detail?id=874770

Change-Id: Ic068bcbde8fc2f128515be7c24f8829deb77d64a
Reviewed-on: https://chromium-review.googlesource.com/1177406Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#583594}

This CL fixes the order of path_.pop_back() and AddValidationIssue() on
multiple occasions. The path is used in AddValidationIssue() and
therefore, the current field name should only be removed from the path
after the call to AddValidationIssue().

Bug: 794848, 855057
Change-Id: I94f0cb67501fdf7625b6ae1820d8c602d462598a
Reviewed-on: https://chromium-review.googlesource.com/1174115Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583593}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7bd3faeaf797..937745b81606


git log 7bd3faeaf797..937745b81606 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 lannm@chromium.org Add repo_util.NotInRepoError
2018-08-16 tbrindus@chromium.org cros_oobe_autoconfig: Add option for plaintext enrollment domain


Created with:
  gclient setdep -r src/third_party/chromite@937745b81606

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8cce1dbbcc6ac7ae4d0af27f39b26821340fbb45
Reviewed-on: https://chromium-review.googlesource.com/1176944Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583592}