- 23 May, 2019 40 commits
-
-
Evan Stade authored
This re-lands db977c4b Change to original: LoginUserInfo::fingerprint_state is default initialized Original change's description: > Mash cleanup: begin converting login mojo to C++ > > This patch moves types implemented in login_user_info.mojom to > //ash/public/cpp/login_types.h. The handful of methods on > mojom::LoginScreen which used these types are moved to C++ > interfaces. > > There are two new public-facing C++ interfaces: > 1. ash::LoginScreen, which is a direct translation of the mojom. > This is implemented by ash::LoginScreenController. > 2. ash::LoginScreenModel, which is used for the methods that > were simple thunks in LoginScreenController. > (LoginDataDispatcher implements this interface.) > > Bug: 958206 > Change-Id: I329d606b234556bf05aee40849f3aa5ccc6c0be0 TBR=tsepez@chromium.org,xiyuan@chromium.org Bug: 958206 Change-Id: I9567af3331638e38590f143f1b43e55d4b609c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626700Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#662757}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/943bf7fdf620..6e073100d205 Created with: gclient setdep -r src-internal@6e073100d205 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I155c739e9ef42f4652a055dc878dc95c9d25815d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626706Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662756}
-
Mike Dougherty authored
The |NSURL resourceValuesForKeys| is the current recommended way to obtain available disk space. Additionally, using the value of NSURLVolumeAvailableCapacityForImportantUsageKey excludes caches and temporarily files which can automatically be removed by the system when saving data. This provides a more accurate value which represents how much storage is available to the app. Change-Id: Ie954105d5ea0bb4dfa96b72df65adde572144dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624826 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#662755}
-
Scott Violet authored
This isn't necessarily a problem right now, but without this it's entirely possible that WidgetSlideAnimationDelegate is holding a reference to a deleted view, which makes me nervous. I came across this when looking at a crash that was the result of a UAF that I suspect was in this code. I believe you've since fixed it. BUG=940322 TEST=none Change-Id: Icfacdb7533ab9d1e8b2d99cbb29b459e2a21445a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627654Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#662754}
-
Anne Lim authored
Remove AutofillSaveCreditCardUsesStrikeSystemV2 since it's been rolled out 100%. Bug: 884817 Change-Id: I9df9a2c7bfafafd8a1d1568b8b1527569c15377b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623599 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#662753}
-
Mohammad Refaat authored
The only remaining observer is didChangeTab and it wasn't part of that bridge. Bug: 911350 Change-Id: Ibc058d467294ce056979c730a8742ac9436d57b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627006Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#662752}
-
Xing Liu authored
This CL fixed a typo in DownloadMediaParserBridge. Bug: 826021 Change-Id: Ied207ea958a0302e09e244466221e6f67b150771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625961Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662751}
-
Vladimir Levin authored
This patch ensures that we don't paint composited layers when display locked. This is similar to how we block non-composited layers as well. The reason for this is that they may not be laid out, and the display locking implemention (for now) ensures that nothing is painted. In the future this will change to paint just the self-element, not the subtree. R=chrishtr@chromium.org, rakina@chromium.org Bug: 966310 Change-Id: I8d5e557d833e0757e68bb5467224c0c74619e389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627550Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662750}
-
Kevin Bailey authored
This implements an experimental feature (behind a flag) to group Omnibox suggestions by type, search results first, followed by other types, after the default match, which does not move. Bug: 966462 Change-Id: I6870652be8f733b185ad1dcca946fb3091db0b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625811Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662749}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b40be11..bffe9927 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8c8f5b28180f7dff28c9728fd33b8594adba0e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627730Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662748}
-
Lan Wei authored
In ProcessInputActionSequence function, we now check if both of the actions' ids and types match with the ones in session, so we should remove the check error for type. Bug: 606367 Change-Id: Id6306433155ba3087212ec27437d1209a25d19c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627632Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#662747}
-
siyua authored
Sorry missed these changes in previous CL. There are three new descriptions introduced.(The two store variations use the same one). mock: https://docs.google.com/presentation/d/1gBmqaamD_5QbEFo8KY03Ihi5LZ99kdCazd6Bb5khQ6M/edit#slide=id.g4de53d9b13_0_182 Will make sure these are translated for M76 Bug: 961082 Change-Id: I98ffec78c4d9cfcdba648647d8074558bed172af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626652Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#662746}
-
Eric Karl authored
This reverts commit e0c4b6ad. It turns out we needed image decode cache to support multiple colorspaces, so reverting this patch as we no longer need the complexity. Bug: 955161 Change-Id: I7394f048b5a9659d9c4ca4fd65dc480c7f04b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595016 Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662745}
-
Sammie Quon authored
More details about crash in bug. Seems like multiple stacks which lead to OverviewController::OnAttemptToReactivateWindow. My guess is that there is a race between OnAttemptToReactivateWindow and the DELETE_SOON for overview_session_, so do not run OnWindowActivating when overview session is shutting down. Test: none Bug: 953437 Change-Id: Idb0aebc640f20aad8df3e10545e6c3f41c63d5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625962Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#662744}
-
Natalie Chouinard authored
Remove some workarounds and unnecessary checks now that we no longer support Jelly Bean. Bug: 923477 Change-Id: Ib8ed81b29b2ded7fab33b3a006f02735edb2a7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625958Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#662743}
-
Elly Fong-Jones authored
Bug: 965999 Change-Id: Ica5fb02f000171714ce40b670b2de532ad46503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625245 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#662742}
-
Ehsan Karamad authored
HTMLPlugInElement::PluginWrapper() can be called for a plugin element that does not have a document node frame. This causes a crash in MimeHandlerViewContainerManager::Get() which expects the passed |render_frame_| to be nullptr. Bug: 966371 Change-Id: I6ba558efdf416f421d1a540f947d79203b0bc985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627267Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662741}
-
Jenny Zhang authored
Bug: 963448 Change-Id: Ib1d140f23d04353371158879aaf984306e585420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625459Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662740}
-
Navid Zolghadr authored
Change-Id: I6b3a1bb41b8fd01217347c20e8bbd59367084112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625390Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662739}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/344ecaa6755d..d9fa0744e82b git log 344ecaa6755d..d9fa0744e82b --date=short --no-merges --format='%ad %ae %s' 2019-05-23 jgilbert@mozilla.com Emit OVR_multiview2 on ESSL/GLSL outputs. Created with: gclient setdep -r src/third_party/angle@d9fa0744e82b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I21f0cd8a58a94452fb77ccec3354c72dccf542f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662738}
-
Andrew Grieve authored
TBR=agrieve # Trivial refactor in remoting Change-Id: I33da8ab9f2585b0c15f978f5b6a0870240b83e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627650 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662737}
-
John Budorick authored
Bug: 861509 Change-Id: I96d7fc00331b25361a26d59fd68d4eb300e12c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626799 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#662736}
-
Gayane Petrosyan authored
light mode: https://screenshot.googleplex.com/PWCNx1XrTBK.png dark mode: https://screenshot.googleplex.com/86rWXw8u4bM.png Bug: 963793 Change-Id: Ie6981aab2482190f74ea75d3e950045373f234ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625855Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#662735}
-
Maksym Onufriienko authored
After downstream switched to new API, it is safe to remove these methods Downstream cl: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284395 Bug: 922813 Change-Id: Ic813d77bfc6f6ad192300ced1dee8e8b2f69f36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623543 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662734}
-
Daniel Libby authored
Surface has the context of the frame_token from the active_frame_data_ pointer, so it can supply the callback that the Display aggregates during DrawAndSwap. When the Display gets notified of presentation feedback, it'll call through the Surface, which then calls a new SurfaceClient API with the same information. R=sadrul@chromium.org Bug: 965537 Change-Id: I0d275ad0f37fb212c3fd7e7460aaef1db9734373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623167 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#662733}
-
Wez authored
These tests were flakily hanging, with unsufficient diagnostic output for us to diagnose the issue. Now that we have per-Run() timeouts we can re-enable these tests to get diagnostic call-stacks when they hang. Bug: 913037 Change-Id: I718c3bcbad2f21b4fe061d88a4b1daf53fd7e56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627213Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#662732}
-
Katie D authored
The ink drop was the default tray buttons size instead of the larger size of the menu button. Updates the ink drop calculation to ensure the size is set properly, fixing the ink drop's appearance on the switch position menu button. Bug: 966151 Change-Id: I4e65932dc9b2e90e81746454e084feaac1148956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626014Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#662731}
-
Wei-Yin Chen (陳威尹) authored
Android Studio creates a folder src/AndroidStudioDefault for the libraries, and this can lead to false alarms in PRESUBMIT.py. Bug: None Change-Id: I7b2e1de119086a2bc22c8ad202ff0c590b6a7392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625902 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#662730}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1d6ef8a04840..2491ddef9616 git log 1d6ef8a04840..2491ddef9616 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 nednguyen@google.com Update webpagereplay OWNER 2019-05-23 perezju@chromium.org [Telemetry] Fix default build_path in GetStackTrace Created with: gclient setdep -r src/third_party/catapult@2491ddef9616 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960794 TBR=eyaich@google.com Change-Id: Ifbd3e1cb92d0519cf6cf69af159c99304d16fcf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662729}
-
Alexandre Frechette authored
This reverts commit 84466676. Reason for revert: Introduced flakiness to `sync_integration_tests`'s `SingleClientSessionsSyncTest.NavigationChainAlteredDestructively`. https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODQ0NjY2NzZlZDA2ZGM1NzViZmY1ZDEwYTU0NzY0OTNjYjI2MTY2Nww Original change's description: > Adding page language to sync data. > > Bug: 957657 > Change-Id: I3e03e000c3c377fbf1417bf8a9a63e52d71af965 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613789 > Commit-Queue: Alexandre Frechette <frechette@chromium.org> > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662649} TBR=anthonyvd@chromium.org,mastiz@chromium.org,frechette@chromium.org Change-Id: If7c671ccd8912ab53169d1647c96c17319bd8fab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627455Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#662728}
-
Vlad Tsyrklevich authored
Previously the caller to gwp_asan::EnableFor* would pass in various bools to indicate if sampling should be increased because this is an interesting process/release channel. This doesn't work well in a world where GWP-ASan hooks multiple allocators, instead have the caller simply indicate that process sampling should be boosted or not--not the specific conditions that led to increased process sampling. In doing so also change the previous ProcessSamplingBoost feature name/semantics to ProcessSamplingBoost2 since the boost is no longer cumulative. Bug: 956824 Change-Id: I70f646b15df5f002857c08bb104ffd881b5f2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626031 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#662727}
-
behdad authored
Checking this pinpoint task: https://pinpoint-dot-chromeperf.appspot.com/job/1484ef632c0000 Before this change only one frame_time was recorded and the value is not normal (~3ms) And by updating the story more than 700 frame_times are recorded and the value is (~26ms) Bug: chromium:965578 Change-Id: I2646755c138f33618da32f6ac5a02e8534dd7459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622505 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#662726}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8458639991d4..6779e5e01b13 git log 8458639991d4..6779e5e01b13 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 bclayton@google.com Reimplement VkFence using sw::WaitGroup and sw::Event. 2019-05-23 bclayton@google.com Add sw::WaitGroup to System/Synchronization.hpp 2019-05-23 bclayton@google.com Move sw::Event to System/Synchronization.hpp Created with: gclient setdep -r src/third_party/swiftshader@6779e5e01b13 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133127573,chromium:b/133135427,chromium:b/133127573,chromium:b/133127573 TBR=swiftshader-team+autoroll@google.com Change-Id: I8ee371f886fae57bda68f79af100c52c067da568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626675Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662725}
-
danakj authored
It is only called once so it should be one. This removes a use of old base::Bind() from content/. R=liberato@chromium.org Bug: 953861, 751838 Change-Id: I019bfdde75755866ef8760b1fc4dfd20ad532ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625829Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#662724}
-
Brian Sheedy authored
Fixes and re-enables the three tests in WebXrVrDeviceTest that were disabled due to failing 100% of the time. The cause as a string in the HTML file that they all load that was missing its closing quote, which was causing issues when trying to load and run JavaScript on the page. TBR=billorr@chromium.org Bug: 966254 Change-Id: I89bb21bea7f539c976f9c90f63635951418d64a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626743Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#662723}
-
Klaus Weidner authored
gsutil uses Python "mimetypes" to map file suffixes to Content-Type, and this uses local configuration and/or registry settings on Windows. Check that the mapping appears correct, and fix types if a mismatch is found. Also adds a type check for the --force-destination-cr-position to enforce that it's numeric only (no 'r' prefix). Change-Id: Ib4f8a6824e2e339dd309670169143345557cc832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627215 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662722}
-
Henrique Nakashima authored
This reverts commit 648e59b2. Reason for revert: Broke chromium.android/android-jumbo-rel (crbug.com/966508) Original change's description: > Use ProfileKey instead of Profile in JNI_PrefetchBackgroundTask. > > Now that the task may run in Reduced Mode, there is not necessarily a > Profile anymore. > > Bug: 933358 > Change-Id: I58d3d69e724ca058b676cc4ff0b2b7ef24c7792e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625392 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662650} TBR=carlosk@chromium.org,hnakashima@chromium.org Change-Id: Ie9ceefbc06f930745fd20b3005c49a801a799a7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626962Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#662721}
-
Scott Graham authored
122363ccaea7 Fix compile for Linux 32b fuzz target Bug: 966292 Change-Id: I07aba00aa266572fe54b545600e831f27cb1857a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625875Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662720}
-
Eric Stevenson authored
This reverts commit 8209b4f7. Reason for revert: http://crbug.com/966491 Original change's description: > Reland "Trichrome Proguard: Fix locale pak selection." > > This is a reland of beea44ce > > Fixed the package name of the generated file being incorrect for Webview in > chrome_public_apk_tmpl.gni. > > Original change's description: > > Trichrome Proguard: Fix locale pak selection. > > > > This CL moves the arrays of locale pak files out of BuildConfig.java > > into a new file, LocaleConfig.java. > > > > This file is generated with a unique package which allows Chrome > > and Webview to have different versions in Trichrome. > > > > Bug: 960025 > > Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255 > > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Richard Coles <torne@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662209} > > TBR: dtrainor@chromium.org, torne@chromium.org > Bug: 960025 > Change-Id: Id8ffe2e02c461ccff1b23d5328972c893415f05b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625375 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662324} TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: I2518621d193276d32d06cfd96464cb1a775fbe5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627216Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662719}
-
Rakina Zata Amni authored
It's possible to call RebuildLayoutTree on a locked element with a set ChildNeedsStyleRecalc flag, because we are blocking child style recalc but not self style recalc on that locked element. This CL modifies the DCHECK in Element::RebuildLayoutTree to expect that case. Bug: 966310 Change-Id: I53338285df4d51d04ff5e92e41be5e928b0ac154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627272Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#662718}
-