GitLab

It should only open the learn more link.

R=tommycli@chromium.org
BUG=621702
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2575743002
Cr-Commit-Position: refs/heads/master@{#438710}

In some cases, Mac still uses old assets, so those are included on
just that platform.

BUG=522168

Review-Url: https://codereview.chromium.org/2575733002
Cr-Commit-Position: refs/heads/master@{#438709}

Previously we were hiding the paste menu even when the page didn't
scroll at all. Moving the hiding to update ensures that the menu
is only cleared if we actually scrolled.

BUG=673209

Review-Url: https://codereview.chromium.org/2580583002
Cr-Commit-Position: refs/heads/master@{#438708}

No one is using the code any more.

BUG=None
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2568723006
Cr-Commit-Position: refs/heads/master@{#438707}

Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS
ifdefs.

BUG=666773,665960
TEST=ash_unittests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576133002
Cr-Commit-Position: refs/heads/master@{#438706}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b55ff5c9..2644e367

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2579553002
Cr-Commit-Position: refs/heads/master@{#438705}

BUG=645667
TEST=virtual/spinvalidation/fast/dynamic/static-to-relative-with-absolute-child.html etc.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2574293003
Cr-Commit-Position: refs/heads/master@{#438704}

BUG=667236
TBR=keishi@chromium.org

Review-Url: https://codereview.chromium.org/2572993002
Cr-Commit-Position: refs/heads/master@{#438703}

BUG=673678

Review-Url: https://codereview.chromium.org/2580513002
Cr-Commit-Position: refs/heads/master@{#438702}

DesktopWindowTreeHostMus needs WindowTreeHost::window() to only be
shown when Show is called. This is important as the visibility of
window() is mirrored in the server. To enable that this patch moves
the responsibility of calling InitHost() and Show from DesktopNativeWidgetAura
to DesktopWindowTreeHost.

InitHost() must be called before Show(), hence the need to move
InitHost in addition to Show().

BUG=672932
TEST=covered by tests
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2575243002
Cr-Commit-Position: refs/heads/master@{#438701}

More stuff left over from mac pre-MD code.

BUG=648281, 522168

Review-Url: https://codereview.chromium.org/2572983002
Cr-Commit-Position: refs/heads/master@{#438700}

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2570263002
Cr-Commit-Position: refs/heads/master@{#438699}

This is currently behind a feature flag and not enabled by default.

- The lock screen webview will be saved and reused across lock sessions.
- The lock screen webview will be preloaded after the user has not generated any input events for 8 seconds.

See https://codereview.chromium.org/2512473004/ for additional context.

BUG=669638

Review-Url: https://codereview.chromium.org/2553863002
Cr-Commit-Position: refs/heads/master@{#438698}

There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to
ensure we aren't scheduling the next check unreasonably soon (<= 1
second). But we serialize the "scheduled next check time" in prefs and
read that on next startup, and use it as long as it isn't in the past or
too far in the future, but if you get unlucky it can be < 1 second in
the future, and you'll hit this DCHECK.

BUG=654804

Review-Url: https://codereview.chromium.org/2562963003
Cr-Commit-Position: refs/heads/master@{#438697}

BUG=259297

Review-Url: https://codereview.chromium.org/2570673005
Cr-Commit-Position: refs/heads/master@{#438696}

There is no longer a link to the DevTools security panel in the url bar.

BUG=646465

Review-Url: https://codereview.chromium.org/2570423002
Cr-Commit-Position: refs/heads/master@{#438695}

BUG=522168

Review-Url: https://codereview.chromium.org/2576583003
Cr-Commit-Position: refs/heads/master@{#438694}

BUG=522168,672669

Review-Url: https://codereview.chromium.org/2573903003
Cr-Commit-Position: refs/heads/master@{#438693}

These are not needed because the pre-MD find bar code was removed.

BUG=648281,522168
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2571143002
Cr-Commit-Position: refs/heads/master@{#438692}

When a user scrolls we need to generate fake mouse moves since the cursor is moving
relative to the page (for example you might scroll over an element that has an
mouseover event listener). Currently Android and blink have separate code-paths for
generating these fake mouse moves. This CL removes the Android specific code-path
and makes Android use the Blink code-path.

In order to make the Blink codepath activate on Android, delete the deviceSupportsMouse
websetting which was exclusively used to disable this fake-mouse-move codepath.
It's sufficient to rely on mousePositionUnknown instead, which disables the
codepath if no mousemove event was ever received.

BUG=492738

Review-Url: https://codereview.chromium.org/2536723007
Cr-Commit-Position: refs/heads/master@{#438691}

After the changes, the generated code
(e.g. out/gn/gen/blink/core/dom/TouchInit.h)
will contain a comment similar to:

    // This file has been generated from the Jinja2 template in
    // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

BUG=673936

Review-Url: https://codereview.chromium.org/2569923003
Cr-Commit-Position: refs/heads/master@{#438690}

The CL implements sticky section header rows in VPN page. Care is taken
to stack the rows with child controls that have layers below the sticky
section header rows.

BUG=664244
TEST=Run with --material-design-ink-drop-animation-speed=slow
     Touch a Wi-Fi connection row and while ripple is growing
     drag-scroll the list of connections up.
     Verify that the ripple is stacked below the Wi-Fi header row.

Review-Url: https://codereview.chromium.org/2557333003
Cr-Commit-Position: refs/heads/master@{#438689}

Revert of Give automation extension api owners ownership of externs (patchset #2 id:20001 of https://codereview.chromium.org/2576053002/ )

Reason for revert:
Manually editing generated files is not the right way to change things in this folder.

https://codereview.chromium.org/2563013003/
https://codereview.chromium.org/2544203004/

Please either fix the tools, report bugs, or remove generation steps (or move these externs to somewhere else), then resubmit this CL.

Original issue's description:
> Give automation extension api owners ownership of externs
>
> BUG=
>
> Committed: https://crrev.com/484e132178179990a45f6c74c218d12bee61f094
> Cr-Commit-Position: refs/heads/master@{#438680}

TBR=redevlin.cronin@chromium.org,dtseng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2579603002
Cr-Commit-Position: refs/heads/master@{#438688}

Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of https://codereview.chromium.org/2536313003/ )

Reason for revert:
Tests on Android's Marshmallow Tablet Tester started failing. See crbug.com/674335

Original issue's description:
> Implement GetDisplayed on android M+
>
> BUG=
>
> Committed: https://crrev.com/6cfe928c1b1b7fda6c4b1ae07df28bb924037961
> Cr-Commit-Position: refs/heads/master@{#438527}

TBR=peter@chromium.org,miguelg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2579513003
Cr-Commit-Position: refs/heads/master@{#438687}

Merge internal change: 142062136

Review-Url: https://codereview.chromium.org/2577773002
Cr-Commit-Position: refs/heads/master@{#438686}

https://pdfium.googlesource.com/pdfium.git/+log/6597391975cd..c7739322e5cd

$ git log 659739197..c7739322e --date=short --no-merges --format='%ad %ae %s'
2016-12-14 dsinclair Remove unused flags in CFWL_PushButton
2016-12-14 tsepez Return unique_ptr from GetAlphaMask.
2016-12-14 dsinclair Cleanup CFWL_MonthCalendar flags
2016-12-14 tsepez Remove some usage of |return XXX.release()| anti-pattern.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2573273002
Cr-Commit-Position: refs/heads/master@{#438685}

Adjust expectations, and parameterize test for RLS.

BUG=490942
R=skobes@chromium.org,pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2575663002
Cr-Commit-Position: refs/heads/master@{#438684}

54/74 tests had the annotation and more flaky tests needed the annotation.
Annotate the class rather than each individual test.

BUG=
TBR=donnd@chromium.org

Review-Url: https://codereview.chromium.org/2576173002
Cr-Commit-Position: refs/heads/master@{#438683}

https://skia.googlesource.com/skia.git/+log/e305cc1f2a44..56ff9a1c9dfd

$ git log e305cc1f2..56ff9a1c9 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 kjlubick Add Galaxy Tab3 Test
2016-12-14 herb Remove tombstones from SkTHash.
2016-12-14 liyuqian Change FLAGS_analyticAA's default to true
2016-12-14 reed remove PLAIN_ENUM flag for SkClipOp
2016-12-14 bsalomon Update rect ops to use "op" in their name and return sk_sp.
2016-12-14 mtklein switch to libstdc++ for standalone Android builds.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2576033002
Cr-Commit-Position: refs/heads/master@{#438682}

currently it's impossible to build clang packages due to this.

BUG=674274
R=hans@chromium.org

Review-Url: https://codereview.chromium.org/2579573002 .
Cr-Commit-Position: refs/heads/master@{#438681}

BUG=

Review-Url: https://codereview.chromium.org/2576053002
Cr-Commit-Position: refs/heads/master@{#438680}

Replace Android pause and pending images with UX-provided ones.

BUG=671686,671130

Review-Url: https://codereview.chromium.org/2570403002
Cr-Commit-Position: refs/heads/master@{#438679}

Although the value gMapBlendOpsToXfermodeModes[WebBlendModeNormal] is never
used by WebCoreCompositeToSkiaComposite() with an early branch. As a matter
of principle we should not allow such footgun. This CL doesn't change behavior.

Review-Url: https://codereview.chromium.org/2571953003
Cr-Commit-Position: refs/heads/master@{#438678}

Configure the ClipRectsContext for the root layer to treat it as a
composited scrolling layer by not applying an overflow clip.

BUG=490942
R=chrishtr@chromium.org,skobes@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2576883002
Cr-Commit-Position: refs/heads/master@{#438677}

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2573993003
Cr-Commit-Position: refs/heads/master@{#438676}

This patch adds some perftests to measure RTree performance.
Sample run (on z620):

[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from RTreePerfTest
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 346091.53125 runs/s
*RESULT rtree_construct: 1000= 36854.61328125 runs/s
*RESULT rtree_construct: 10000= 3392.330322265625 runs/s
*RESULT rtree_construct: 100000= 369.79052734375 runs/s
[       OK ] RTreePerfTest.Construct (8040 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 2992395.5 runs/s
*RESULT rtree_search: 1000= 507624.9375 runs/s
*RESULT rtree_search: 10000= 32956.60546875 runs/s
*RESULT rtree_search: 100000= 3477.254638671875 runs/s
[       OK ] RTreePerfTest.Search (8020 ms)
[----------] 2 tests from RTreePerfTest (16060 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (16060 ms total)
[  PASSED  ] 2 tests.

R=danakj@chromium.org, dskiba@chromium.org
BUG=674169
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2576793002
Cr-Commit-Position: refs/heads/master@{#438675}

Windows versions after 10.0.14393.0 have EnableNonClientDpiScaling,
performing the same function as EnableChildWindowDpiMessage for us.

EnableChildWindowDpiMessage was also removed in 10.0.14393.0 if not
earlier.

This change also allows delegates to handle the WM_NCCREATE message,
required to properly call EnableNonClientDpiScaling.

BUG=642956, 658787

Review-Url: https://codereview.chromium.org/2574933002
Cr-Commit-Position: refs/heads/master@{#438674}

[Mojo Video Capture] Replace method OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt()

In interface media:VideoCaptureDevice::Client, replaced the method
OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt(). Compared to
method OnIncomingCaptureBuffer(), the VideoFrame parameter in
OnIncomingCapturedVideoFrame() was only used for passing along a bit of extra
information, namely a custom |visible_rect| as well as some
|additional_metadata|. The new method makes the intent clear and eliminates the
need for passing a media::VideoFrame that is partly redundant with the also
passed media::VideoCaptureDevice::Client::Buffer.

This CL breaks the video_capture_unittests, because current implementation of
the video_capture service wants to use VideoCaptureDeviceClient with buffers
that are backed by MojoSharedMemoryBufferTracker instances instead of the "regular" shared memory buffers. With this CL, VideoCaptureDeviceClient is
dropping support for this. We are working towards making the video_capture
service work with the regular buffers. To keep CLs small, we defer changes
to the service to after refactorings of VideoCaptureController and
VideoCaptureManager are complete and deactive the video_capture_unittests
temporarily. This is acceptable for the time being, since they are not run on
the bots yet. The CL that re-enables them is currently labeled CL1.9.22 in the
design doc.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.9

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*",
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2566983007
Cr-Commit-Position: refs/heads/master@{#438673}

Setting use_drm_atomic to true and compiling chrome is broken.
|gfx| namespace is not defined in hardware_display_plane_atomic.h.

This CL fixes that.

TEST=use_drm_atomic=true and compile.

Review-Url: https://codereview.chromium.org/2575213002
Cr-Commit-Position: refs/heads/master@{#438672}

BUG=673031

Review-Url: https://codereview.chromium.org/2569783002
Cr-Commit-Position: refs/heads/master@{#438671}