GitLab

* Safety check buttons are now either normal (white background)
  or action buttons (blue background).
* This synchronizes the safety check UI with the latest UI mocks,
  which differentiate different levels of calls-to-action by their
  importance.

Bug: 1015841
Change-Id: I5c4b4444033b041735656ed58eceb34cfb036942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080249Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746716}

This patch makes it possible to emulate various vision deficiencies,
including color vision deficiencies and blurry vision, in the Blink
Renderer. The various deficiencies can be triggered by the new
Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools
Protocol.

Design doc: https://goo.gle/devtools-cvd

Bug: chromium:1003700
Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746715}

This is a repeated callback because it's called from a while loop:
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=db95e8ed4d10f4770b37e265ca78c906e344c6ef&l=212
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_h264.cc?rcl=db95e8ed4d10f4770b37e265ca78c906e344c6ef&l=361

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

TBR=danakj@chromium.org

Bug: 714018
Change-Id: Ifb0f1119c2ed834bdfa4328afce0931c7776a626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080354
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746714}

The experiment is now over and needs to be disabled.

Bug: 1021013
Change-Id: I90b835de241c0692bd8b12a8a22bc7b6113ffaed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074639Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746713}

This reverts commit 76648dac.

Reason for revert: As described in crbug.com/1056527, Android WebView still relies on this. An upstream fix is too risky so I'll revert this CL for now.

Bug: 1056527

Original change's description:
> Remove redundant OnEndEditingTextfield event
>
> The event OnEndEditingTextField seems to be redundant (esp. with focus
> changes) and isn't correct in all cases: If users interact with native
> UI like an autofill dropdown, the event will try to close this piece of
> UI although this isn't always necessary.
>
> This CL therefore removes the event which allows dropdowns to remain
> open after interaction if they require it (e.g. see use case in linked
> bug).
>
> Bug: 1043963
> Change-Id: I5c7a6ede34fb574bd3f91d4b16fbb4e2a78a8d24
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034527
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738105}

TBR=vasilii@chromium.org,dvadym@chromium.org,fhorschig@chromium.org,ajgo@chromium.org

Bug: 1043963
Change-Id: I3bf88ec43fa6ae9bf0d11f295bc1b0debbba71ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087331Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746712}

Renames no credential illustration imageset to fix extension
compilation.

Bug: NA
Change-Id: I05e34571871255d907b7476a8f123dd6ab506f77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085252Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746711}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f92fd4849f47..393efd6d94e4

git log f92fd4849f47..393efd6d94e4 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 jacktfranklin@chromium.org Remove `String.isDigitAt`

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@393efd6d94e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8131a19b8f49597dd928af45654f99b4bbcac5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087174Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746710}

https://android.googlesource.com/platform/external/perfetto.git/+log/024aa8877850..0fd4f5cda74d

git log 024aa8877850..0fd4f5cda74d --date=short --first-parent --format='%ad %ae %s'
2020-03-04 eseckler@google.com Merge "protos: Add support for counters in TrackEvent"

Created with:
  gclient setdep -r src/third_party/perfetto@0fd4f5cda74d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I05718732cc24b49940d0c7971223d7524d52e309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087172Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746709}

This reverts commit e19d9ff7.

Reason for revert: broke virtual/web-bluetooth-new-permissions-backend/external/wpt/bluetooth/idl/idlharness.tentative.https.window.html

Original change's description:
> bluetooth: Implement FakeBluetoothDelegate
> 
> This change implements FakeBluetoothDelegate which fakes the behavior of
> the new Web Bluetooth permissions implemented behied the
> WebBluetoothNewPermissionsBackend flag. Therefore, the
> web-bluetooth-new-permissions-backend virtual test suite runs the Web
> Bluetooth tests with this flag enabled.
> 
> Design doc:
> https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/
> 
> Bug: 577953
> Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813
> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Vincent Scheib <scheib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746429}

TBR=peter@chromium.org,scheib@chromium.org,reillyg@chromium.org,odejesush@chromium.org

Change-Id: I32caff48eb12c6bc1c0517a897e996f0d9276c1b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 577953, 1058319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087332Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746708}

This reverts commit 8698d875.

Reason for revert: causes AutofillAssistantFormActionTest#testFormAction fail on Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24483

Original change's description:
> [Autofill Assistant] Hotfix for radio buttons in FormAction.
> 
> Without this CL, UI and model can go out-of-sync when tapping the radio
> button directly (see screenshots in linked bug). This is a hotfix for
> this issue. A proper fix requires a refactoring of the FormAction to
> make the selection state part of its model (same as was done for the
> T&C selection state in the CollectUserDataModel).
> 
> Bug: b/150201921
> Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489
> Commit-Queue: Clemens Arbesser <arbesser@google.com>
> Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#746539}

TBR=mcarlen@chromium.org,arbesser@google.com,marianfe@google.com

Change-Id: Ie495ee0ae938de693dd9b5667086dca05b5d9d32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/150201921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087571Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746707}

This is a repeating callback because it's called from a while loop:
  * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_adapter_video.cc?rcl=2d18a6603bb1f5bbe784dad83e7cad005808686a&l=166

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I3b7dfb4b58ec6918ebc4dc504b839bddd115c64a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080261
Commit-Queue: Jose Lopes <jabolopes@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746706}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fdaf67e5529..f1fe4488c8cf


Created with:
  gclient setdep -r src-internal@f1fe4488c8cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I8d2a986c634a7e4ad45487d7adb1e2eae88876e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086995Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746705}

A navigation might start but not commit, that is the navigation fails
and the page will not change. A good example thereof is a navigation that
returns a 204. Still in this case some state will have been cleared in
the DidStartNavigation method. Which means the state shows does no
longer correspond to the page we are on.

There is really no reason to not wait until DidNavigationFinish to reset
all this state, so this patches does so. The only exception are cookies,
as these might get accessed during the navigation. A follow up patch will
take care of these.

Bug: 998171
Change-Id: I6146986a8b146128fad388da88f4fd2238571822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895512Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746704}

This is a reland of e78513d7

Original change's description:
> Migrate authenticator.js and it's dependencies to JS modules
> 
> Bug: 1054394
> Change-Id: I106bd0edc547dc6eb2d680b409d1348d5b964079
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066548
> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745762}

Bug: 1054394
Change-Id: Ie1a63f522f5e29b2af327010236f962836a36074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083317Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746703}

Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org>

This CL starts converts the message that kills the renderer, on
top of the infrastructure already laid out by crrev.com/c/1991446.

In addition to that, this CL implements the required changes to move
to a model where the mojo pipe for RenderAccessibility is only valid
while a kWebContents-compatible accessibility mode is enabled, in order
to address some security-related concerns. And it also adds a new unit
test to check that this new logic works as expected (i.e. that the mode
changes in the renderer when the pipe is closed from the browser side).

Bug: 1010831
Change-Id: Ic71c33f654af9fbc1c453d2aa04c858e8285c1a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015045Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#746702}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e1688b60caf7..a6d3a2dd41d4

git log e1688b60caf7..a6d3a2dd41d4 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 andreperezmaselco.developer@gmail.com Refactor FuzzerPass::ApplyTransformation code duplication. (#3206)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@a6d3a2dd41d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com
Change-Id: Ie83162057831184bf50b5ba5eba19e4b2c9c090d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087171Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746701}

https://chromium.googlesource.com/angle/angle.git/+log/9e9493f29dbf..028a7a725cc6

git log 9e9493f29dbf..028a7a725cc6 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 ancheng.qiao@arm.com Skip if GL_EXT_texture_compression_dxt1 isn't supported

Created with:
  gclient setdep -r src/third_party/angle@028a7a725cc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: I4b79ec813633c06b5dd08481b4a0f1ebd9a5d355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086991Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746700}

- DidDetachLayoutTree()
- DidRecalcStyle()
- DidSetSuggestedOption()
- PopupDidHide()

Move parts of the contents of DetchLayoutTree(), DidRecalcStyle(),
SetSuggestedOption(), and PopupDidHide() of HTMLSelectElement to them.

We need to call SelectType::DidDetachLayoutTree() in |HTMLSelectElement
::ChangeRendering()| before replacing select_type_. When a SELECT
changed its type from MenuList to ListBox, DetachLayoutTree() in this
function triggered the popup-disconnecting code after switching to
ListBox. After this CL, select_type_->DidDetachLayoutTree() in
DetachLayoutTree() doesn't trigger the popup-disconnecting code because
select_type_ is a ListBoxSelectType.

This CL has no behavior changes.

Bug: 1052232
Change-Id: Iaff5691a670bd7570c7c47334f548cc84c4dc0bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084332Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746699}

This CL implements new API in order to determine metrics of stretchy
math operators and shape them, following the algorithm of [1]. This
will be used to implement stretchy MathML symbols (for radicals and
operators). It relies on information from the OpenType MathVariants
table [2] and corresponding iterators implemented in [3].

[1] https://mathml-refresh.github.io/mathml-core/#the-glyphassembly-table
[2] https://docs.microsoft.com/en-us/typography/opentype/spec/math#mathvariants-table
[3] https://chromium-review.googlesource.com/c/chromium/src/+/2074678

Bug: 6606
Change-Id: I362edd91fa0ff7f1d2da4381dac1e731be1e0858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051923Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#746698}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8985fc91089f..c40c4bc38a76

git log 8985fc91089f..c40c4bc38a76 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 johnkslang@users.noreply.github.com Add "news" section and component status.

Created with:
  gclient setdep -r src/third_party/glslang/src@c40c4bc38a76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com
Change-Id: Ide6e636cc97c1529aee89a1e590c8a1781523b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087031Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746697}

We're breaking the SplitSettingsSync project into two milestones:

SplitSettingsSync is now:
1. The new OS sync settings section
2. The new OS prefs data model type
3. Toggles for Apps, OS prefs, Wallpaper and Wi-Fi in the new section
4. OS data types use the sync transport layer

The new "SplitSyncConsent" feature is:
A. New out-of-box consent dialog for OS sync
B. Browser sync opt-in flow on Chrome OS
C. Unconsented primary account on Chrome OS

This CL adds the new base::Feature and moves the appropriate parts
of the code to the new flag.

Bug: 1013466
Test: updated browser_tests and unit_tests

Change-Id: I5439b7dbac29a3a242e82ff63e099512e2aac655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073161
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746696}

Bug=1054761
Test=build and pass CQ

Merge-With: eureka-internal/367058
Change-Id: I64e33d87398eab09704ea63b6eaf8e3922e3f98d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066397
Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746695}

All known data races in HashTable based collections have been resolved.

Bug: 986235
Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746694}

Change-Id: I23074a6dbc88cc10aa5b6067377fd73d67e6b739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087051
Auto-Submit: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746693}

This change adds an accessibility page that can be shown by clicking a
link on the marketing opt in screen. The link to show the accessibility
screen is only shown if the user was shown the gesture navigation screen
before getting to the marketing opt in screen.

The accessibility page contains a toggle for changing the
kAccessibilityTabletModeShelfNavigationButtonsEnabled pref.

Bug: 976949
Change-Id: Ibbb1568389b86cd336d8c4b65fe275ca2b256ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078740
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746692}

This CL updates the web app manifest update checker to check the
contents of icons specified in the latest manifest for differences
against the locally installed icons. If there are any differences it
will trigger the web app to update with the latest manifest data.

Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=435726&signed_aid=__Gv5ahpYIVLkTCEKEXscA==&inline=1

Bug: 926083
Change-Id: If5d0229b41931cad305a164e420ba4b917df02d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072344
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746691}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/779e58d10e2f..2fdaf67e5529


Created with:
  gclient setdep -r src-internal@2fdaf67e5529

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I3943626768e6b54a6eade1741c074795787c980a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086190Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746690}

Multiple places in the code check for Quick View being open
after performing a series of actions that should open it. These
have been refactored in a single helper function.

Bug: 1058289
Change-Id: I8a55d141895395637d6679fe7ad22df3c50baf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086469
Commit-Queue: Josh Simmons <simmonsjosh@google.com>
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746689}

https://pdfium.googlesource.com/pdfium.git/+log/57b83355c515..a40862f237fc

git log 57b83355c515..a40862f237fc --date=short --first-parent --format='%ad %ae %s'
2020-03-03 nigi@chromium.org Remove the prefix in BaseFont when trying to find a substitute font.
2020-02-29 nigi@chromium.org Enable RenderManyRectanglesWithExternalMemory for SkiaPaths/Skia.
2020-02-28 thestig@chromium.org Add dsymutil to DEPS for Mac builds.

Created with:
  gclient setdep -r src/third_party/pdfium@a40862f237fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I2cace5a1262f00b82c47cc2429e6170930bb43fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086953Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746688}

https://skia.googlesource.com/skia.git/+log/64a3f8fcb749..c6d0fdfb4098

git log 64a3f8fcb749..c6d0fdfb4098 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 13184a2d..2f96e324 (443 commits)
2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b84969ad69c3..9e9493f29dbf (7 commits)
2020-03-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 176f3a3dbbc9..126720bd2e57 (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@c6d0fdfb4098

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: Ie3f871db69e66b34785230212e10480a1afd3c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086951Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746687}

This CL fixes the theme service to be able to toggle native increased
contrast support.
We were not considering IncreasedContrastThemeSupplier as a default
theme and were not removing it when native increased contrast was
disabled.

Bug: 1056335
Change-Id: I42b59e58912de8224b3d7d4e84fb355cd7851dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078376
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746686}

https://chromium.googlesource.com/catapult.git/+log/f6edc90900fe..bbd4f3e6052c

git log f6edc90900fe..bbd4f3e6052c --date=short --first-parent --format='%ad %ae %s'
2020-03-04 dberris@chromium.org Pinpoint: Add logging to results2 generation

Created with:
  gclient setdep -r src/third_party/catapult@bbd4f3e6052c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1050740
Tbr: skyostil@google.com
Change-Id: I29ede5d35c19b58cfff0fe76dfe0c753353590d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746685}

All tests using SystemWebAppIntegrationTest are now parameterized,
and run with both bookmark and web app backend implementations.


Bug: 1058274
Change-Id: Iffd8f1bf1242bab126de70d36fb4683981915ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086461Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746684}

The test suite SystemWebAppManagerBrowserTest is now parameterized,
and runs with both bookmark and web app backend implementations.

Not yet updated:
SystemWebAppManagerAdditionalSearchTermsTest.AdditionalSearchTerms
and SystemWebAppManagerNotShownInLauncherTest.NotShownInLauncher
currently fails with web apps. Tracked in crbug.com/1054195

In system_web_app_manager_browsertest.cc, helper methods
EvalJs and ExecJs are retired as they have no clients.

TBR=pkasting@chromium.org

Bug: 1054195
Change-Id: Ib76ed1e2b14f42bf81138c61f5c263652dbe1ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086355
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746683}

The directory structure before:

<ProfileDir>
    WebApps
        Sync Data
            LevelDB
        Temp
            <temp_name>
        <app_id>
    Web Applications
        _crx_<app_id>

After:

<ProfileDir>
    Web Applications
        _crx_<app_id>
        Sync Data
            LevelDB
        Temp
            <temp_name>
        Manifest Resources
            <app_id>

This is breaking change, all local BMO profile icons will be
clean. We should land it now to avoid file migrations in the
future.

Note: "Sync Data/LevelDB" directory is created only if
kDesktopPWAsSharedStoreService feature is off.
We use shared <ProfileDir>/Sync Data/LevelDB/ otherwise.

This code is disabled behind kDesktopPWAsWithoutExtensions feature.
It introduces no behavior changes.

Bug: 877898
Change-Id: I96af88386f3ce6031881d713b330eff2e32f33e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084215
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746682}

Bug: 992822
Change-Id: I0a5cbd7f2233a9079065fe9d85dffe4b39462007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086352
Commit-Queue: Noel Gordon <noel@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746681}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/18eac1a4..56ff573a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iec678ba39cecd98fee1cf96603d78d1afcdffd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086880Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746680}

Bug: 1049056
Change-Id: I45bfba484c6d8c99190568a5965a33e996c37bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078520Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Tal Pressman <talp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746679}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/40dd59329abe..f92fd4849f47

git log 40dd59329abe..f92fd4849f47 --date=short --first-parent --format='%ad %ae %s'
2020-03-04 szuend@chromium.org [utilities] Use Map instead of Array in TestFileSystem.Entry

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@f92fd4849f47

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I1de31644754ce6983612c47cdc1f736b3f7fe3f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086189Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746678}

Example failed run:

https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16572

TBR=altimin@chromium.org

Bug: 1054194
Change-Id: I955aa5674f3b5896b5360d1b9be6d450820f4b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086383Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746677}