- 25 Apr, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a8f039c4833..07d424c4e530 Created with: gclient setdep -r src-internal@07d424c4e530 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: Ifa781a1c7e4fb6a74256314bb67f367dd52d889a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762669}
-
Rune Lillesveen authored
Always consider subtree-visibility: hidden as hidden for accessibility. This avoids making elements with out-of-date ComputedStyle objects visible for accessibility. all-expected-blink.txt is reverted back to the expectation before https://crrev.com/c09717ac13c9339bc54b086785fb0d0d0d410b0e Slightly more tests passing in css-subtree-visibility/subtree-visibility-032.html Let subtree-visibility-51.html use an expectation file instead of a TestExpectations line to be able to detect if its failures changes or if it starts passing. Bug: 1072447 Change-Id: I8988d5d580577c6e38f5d6b95c5c735fec54491a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164886 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#762668}
-
Roman Aleksandrov authored
This is a reland of 8cd221ee Original change's description: > SyncConsentScreen: Skip screen properly. > > Use new MaybeSkip method for skipping screen. Add tests for UMA stats. > > Bug: 1064561 > Change-Id: I9ddfa0fb5c994f1cb6d6c7abf5e61ca42fd065a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146900 > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762370} Bug: 1064561 Change-Id: Ic9f6be0ea98423614d0ed2a524313679dd99baa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166163 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762667}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c2f2cfca. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie2aa0606520444f4e20ce87e5107e53334f1bb13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166425Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762666}
-
Kyle Horimoto authored
This CL migrates Printing UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I69d261b65b3003305f608997e85a3d92d4f93b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165672 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762665}
-
Kent Tamura authored
This CL implements 'ruby-position' CSS property, which is a property independent from the existing '-webkit-ruby-position', but these properties share a single ComputedStyle field. We apply neither legacy name alias [1] nor legacy shorthands [2] because - Acceptable keyword sets are different in ruby-position and -webkit-ruby-position. - Avoid behavior changes with |element.style.webkitRubyPosition = 'after'|. * core/css/css_computed_style_declaration.cc Add 'ruby-position' to getComputedStyle() enumeration. * core/css/parser/css_parser_fast_paths.cc Add setting for fast-path parsing * core/css/properties/longhands/longhands_custom.cc Add CSSValueFromComputedStyleInternal() to translate a ComputedStyle:: GetRubyPosition() value to 'over' or 'under'. * core/css/resolver/style_builder_converter.{h,cc} Add a function to convert a parsed CSS keyword to a blink::RubyPosition value. * web_tests/external/wpt/css/css-ruby/ruby-position.html New test to check ruby annotation position. * web_tests/fast/ruby/ruby-position-om.html New test to check relationship between ruby-position and -webkit-ruby-position. Approved intent: https://t.co/nmCPv0Onhk [1] https://drafts.csswg.org/css-cascade/#legacy-name-alias [2] https://drafts.csswg.org/css-cascade/#legacy-shorthand Bug: 196690 Change-Id: I2f00099f90a2222b7ddba8b58c3a532f3b997744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152569Reviewed-by:Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#762664}
-
Kyle Horimoto authored
This CL migrates Files UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I7a412af20335dc76d7a2303349e19a6937570574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165670 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
MakeCredentialRequestHandler::HandleResponse() was incorrectly rejecting responses with a googleAndroidClientData extension output whenever a corresponding input had been sent. This CL fixes that by inverting the check. Also add tests exercising solicited and unsolicited googleAndroidClientData extension responses. Further, add a test ensuring that we are not sending any unsolicited extensions in requests, since that has happened recently (see crrev.com/c/2165567). Bug: 1002262 Change-Id: Idc827dd3312f3fb914987615277f7f88575fd743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166583 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#762662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00d1f9a24d08..0a8f039c4833 Created with: gclient setdep -r src-internal@0a8f039c4833 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I0c0cf35431855ff43dc24616401c617103aa846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166315Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ac65d4531798..209319c1bf57 $ git log ac65d4531..209319c1b --date=short --no-merges --format='%ad %ae %s' 2020-04-23 junyer Compute first_byte_ eagerly. 2020-04-23 junyer Remove unused flags_ member from Prog class. 2020-04-23 junyer Replace some uses of "LL" and "ULL" suffixes. 2020-04-21 junyer Explain the need for double backslashes. 2020-04-20 junyer Remove memrchr() and the logic that calls it. 2020-04-19 junyer Use 64-bit integers for the BitState bitmap. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I50a94c2d43f3e67b5d905395de864e4dadd05935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166639 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#762660}
-
Doug Arnett authored
This will be used to compare how much content is used with subframe language detection vs. just with main frame. Bug: 797328 Change-Id: I30ce39cd119e3b04941e1a6d89c467872e40ea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163726Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#762659}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I6eb9eefe062daf345a8376919dfa86b7ed2a72a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166621Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762658}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ba2c4fdcd1b..423b86696dce git log 6ba2c4fdcd1b..423b86696dce --date=short --first-parent --format='%ad %ae %s' 2020-04-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@423b86696dce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02270c165e6379b4f208e04b3108e44cd92ecfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762657}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c34d237c. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3550ad9bb1f3ef148ee578e198cf0ee15038942d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166424Reviewed-by:
-
Stephen McGruer authored
These files are auto-generated by reffy, and we have seen cases where Chromium developers edit them and then are surprised (or worse, never notice) when reffy reverts their changes upstream. The added PRESUBMIT is an upload error, but is not checked during commit time as on occasion it may be ok to change these files. We just want people to loop us in when they are doing so. Bug: 1016354 Change-Id: Ie2c0c36add56140a90dade56db5783c96cc8a5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164569 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#762655}
-
Wez authored
Enabling ANGLE causes AEMU to flakily crash with an ASSERT() failure. TBR=sergeyu Bug: 1074600, 766360 Change-Id: I44393eef9a9971d4487fcc886f011b9ab6c40cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165786Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#762654}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ccc4d96. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6d36e845 "Migrate pointerevents/mouse-on-object.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6acca103f742c8743cfef0e884f2679b3946f438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165913Reviewed-by:
-
Istiaque Ahmed authored
With recent removal of all usages of ChromeAsyncExtensionFunction, it's time to say goodbye to ChromeAsyncExtensionFunction. This CL removes files for the class. Bug: 634140, 648275 Change-Id: I66a7b2eb1346ef4c7244eadada778bfad6474bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164565 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762652}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d011b980..0d2d6cca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a18b292be94520c35a0dc6476bdbbd97cd13f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165912Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762651}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icf772aa0f2d34f9c79243f4c8b5d61ba1ac6c017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166666Reviewed-by:
-
Istiaque Ahmed authored
This CL adds SERVICE_WORKER to BackgroundPageType enum that is used to record "Extensions.BackgroundPageType" histogram for installed extensions from installed_loader (on startup). This change also fixes typo in comment "Extension.BackgroundPageType" Bug: None Change-Id: I6f2364b7d3af4ae388750f44e6d3e76b7d707f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164250Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#762649}
-
Yuki Shiino authored
https://html.spec.whatwg.org/C/#the-formdataevent-interface defines the constructor as constructor(DOMString type, FormDataEventInit eventInitDict); and the 2nd argument is not "optional". Since FormDataEventInit has a required dictionary member, it doesn't make sense to make the argument "optional". Change-Id: Ib2caa6bf64d351c4da06123fa6142b62739fae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164925 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#762648}
-
Yuki Shiino authored
The state argument has the default value of {}. https://w3c.github.io/mediasession/#mediasession Bug: 839389 Change-Id: Ia7e1e87d7ce39b52665453408a6a8bee04fd7e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165165 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40cb0b2a809e..00d1f9a24d08 Created with: gclient setdep -r src-internal@00d1f9a24d08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I3277a03848cf9092fb987b04181bc23c47e5a0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166708Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f45d1f80..d011b980 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibfa3a58ddaa1ffe9b1e63500e4a459979c64e840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165911Reviewed-by:
-
Gang Wu authored
Add support for native side that can commit the image to Android system clipboard. Before https://crrev.com/c/2071287, clipboard_android stored image data in local cache, and when clipboard_android receive a request for images, clipboard_android will return the image data from local cache. BTW, Only tests used this code path. The CL https://crrev.com/c/2071287 changed the request path, when clipboard_android receive the request for images, it will retrieve the image from Android system clipboard, and return to the request. This CL will allow clipboard_android commit the image data to Android System clipboard. Bug:1071324 Change-Id: If3c91bf6ff62371081787e48fe65e1ae440fc77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147890 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762644}
-
Daniel Cheng authored
Bug: 1059157 Tbr: reillyg@chromium.org Tbr: tguilbert@chromium.org Tbr: thestig@chromium.org Tbr: tommycli@chromium.org Change-Id: If97030e8e8b18bc2317187f6ebd15b37c82a54a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165451 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762643}
-
Nektarios Paisios authored
Assistive software cannot readily distinguish between various user or page actions when it receives an accessibility event. For example, if a text change or a selection change event is raised, the AT will not know if the text changed because the user has typed something, if a script has written something to the page, or if the user has pasted something. This will affect the way that the AT might choose to verbalize the newly added text, including choosing not to verbalize the text at all. On the Mac, VoiceOver needs to be told the cause of selection change and text change events, AKA the event intents. On Windows, the AT currently relies on monitoring the keyboard in order to identify such intents. On Chrome OS, we currently rely on heuristics. This patch creates a new class, AXEventIntent, which describes the cause of an accessibility event, e.g. "cut to the end of word". Code in Blink should use instances of ScopedAXEventIntent to place information about which intents are active on the stack. This patch modifies the accessibility event dispatch mechanism to include all active intents with each event that is sent to the browser. Relnotes: N/A R=dmazzoni@chromium.org Change-Id: I547e1c8cd980c1ec7b3a265d085317aae27c86f2 Bug: 989156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031047Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76b3969cd89a..6ba2c4fdcd1b git log 76b3969cd89a..6ba2c4fdcd1b --date=short --first-parent --format='%ad %ae %s' 2020-04-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6ba2c4fdcd1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I78abfd86077e742e615361e26939abfa12ad7743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166706Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b1aabd4d10a..6a5a91e1643a git log 6b1aabd4d10a..6a5a91e1643a --date=short --first-parent --format='%ad %ae %s' 2020-04-25 egdaniel@google.com Revert "Make compiling the amd vulkan memory allocator optional." 2020-04-24 jcgregorio@google.com Add Galaxy S20 to the tree. 2020-04-24 jvanverth@google.com Some more minor fixes for D3D tests. 2020-04-24 herb@google.com Reland "fix crbug 1073670" 2020-04-24 mtklein@google.com Revert "Add Abseil to third_party." 2020-04-24 brianosman@google.com Remove support for reading old serialized SkVertices 2020-04-24 jcgregorio@google.com Revert "fix crbug 1073670" 2020-04-24 johnstiles@google.com Add Abseil to third_party. 2020-04-24 egdaniel@google.com Rename GrSpirv* files to GrSPIRV. 2020-04-24 herb@google.com fix crbug 1073670 2020-04-24 mtklein@google.com skx matches hsw now 2020-04-24 scroggo@google.com Reland "Move SkFrontBufferedStream into Android-only dir" 2020-04-24 egdaniel@google.com Make compiling the amd vulkan memory allocator optional. 2020-04-24 mtklein@google.com stack hint 2020-04-24 fmalita@chromium.org Fix skottie2movie build Created with: gclient setdep -r src/third_party/skia@6a5a91e1643a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1073670 Tbr: jcgregorio@google.com Change-Id: I23b2951004b2bec5acb6c9bf6be654042c3e8369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166705Reviewed-by:
-
Nigel Tao authored
Bug: 1070409 Change-Id: If13342c6f2240d73c6e0a083adf5ade14c2b0fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160668Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#762639}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I01c7629eafcce600f15a80eaa48d07dc40e56b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166704Reviewed-by:
-
Bartek Nowierski authored
CheckedPtr is meant to be a pointer wrapper, that will crash on Use-After-Free (UaF) to prevent security issues. This is very much in the experimental phase. For now, landing a no-op wrapper to aid local testing. More context: https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg Bug: 1073933 Change-Id: I9fee61dda5c436880653f58feae1a5c7b0f188d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158433Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#762637}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a98e9a6ff531..40cb0b2a809e Created with: gclient setdep -r src-internal@40cb0b2a809e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588 Tbr: jianli@google.com,mmoskvitin@google.com,yoichio@google.com,nicolaso@google.com Change-Id: I2cf3da96c4b2de506e1ce7f696575c7551ca7d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166702Reviewed-by:
-
Kyle Horimoto authored
This CL migrates Languages UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I4f7ff55f5ef3ec17769354acd73c906f6a2925a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165666 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8368d4a5..f45d1f80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If62255c2fabec52fe32ebb22b5f59dcf57ad9aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166564Reviewed-by:
-
rajendrant authored
When an image is cleared (src='' or img element moved) lazyload state should be reset. This allows proper lazyload handling to happen when src is set again. TBR=hiroshige@chromium.org Fixed: 10019689 Change-Id: I6f5a2500d63db4e82b3400f49592e183244b12e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164106 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#762633}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I249b2b4e895d7a8f6d94e34fad95a778f2caaaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166612Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762632}
-
Gauthier Ambard authored
This CL updates the way the navigation handler is getting the item used to determine which user agent should be used. Using GetVisibleItem() allows to take the restoration item if a restoration is occurring. Fixed: 1070593 Change-Id: If99a1ec4b8815616b81ef4f48cdf962e5c1a5dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150428 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762631}
-
Jeongwoo Park authored
Specify parameter as unsigned when calling SetSize with int. Bug: 954190 Change-Id: I5d3ecb5ac0531cb5a826b1485eaf4a17854c286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158209Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#762630}
-
