GitLab

This replaces all uses of WTF::Optional and its helpers with
direct uses of base/optional.h.

Generated by:
  git grep -l Optional third_party/blink/renderer | xargs perl -pi -e 's/\b(WTF::|(?<!::))Optional\b(?=<)/base::Optional/g'
  git grep -El 'nullopt|in_place|make_optional|OptionalOrNullptr' third_party/blink/renderer | xargs perl -pi -e 's/\bWTF(?=::(nullopt|in_place|make_optional|OptionalOrNullptr))\b/base/g'
  git grep -l wtf/optional.h third_party/blink/renderer | xargs perl -pi -e 's|third_party/blink/renderer/platform/wtf/optional.h|base/optional.h|'
  git grep -l an\ base::Optional third_party/blink/renderer | xargs perl -pi -e 's/an(?= base::Optional)/a/g'
  git checkout third_party/blink/renderer/platform/wtf/{README.md,optional.h,optional_test.cc}
  git cl format

with a manual change to audit_non_blink_usage.py.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id344582fd52ac72d0c9c65bfa83063c9c19d295f
Reviewed-on: https://chromium-review.googlesource.com/1023015
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553140}

This CL fixes layering for the heap profiling end to end tests.
//components/heap_profiling now exposes two targets:
heap_profiling_java_test_support and test_support. Instrumentation tests for
both Chrome and Android WebView must include heap_profiling_java_test_support as
a dependency in the apk being tested, and test_support as a dependency of the
C++ shared library in the apk being tested.

Bug: 827545
Change-Id: I02e12ff1a435ecd4529108e07dc9c00ede1af64b
Reviewed-on: https://chromium-review.googlesource.com/1024698Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553139}

When you focus the omnibox, the scroll of the NTP should be stopped.
If it is not stopped, the focus is immediately lost as scrolling the
NTP unfocuses the omnibox.

Bug: 834277
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I452c459d7c9b009afabd487003a3826f304191f5
Reviewed-on: https://chromium-review.googlesource.com/1025695Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553138}

This feature was approved for launch in M65.

Bug: 787067
Change-Id: I1327a793206748537d4efeecf706c967635f17af
Reviewed-on: https://chromium-review.googlesource.com/1017901Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553137}

This was originally used for the first iteration of the bisect script,
which was turned down in 2015. Looks like the chromium side was cleaned
up but not the WebKit side.

Bug: 835724
Change-Id: I45c862a967cb32fd522be01d162af54cb2ea8ee2
Reviewed-on: https://chromium-review.googlesource.com/1024200Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553136}

The NEL spec recently changed the spelling of the `includeSubdomains`
header field to `include-subdomains`, to better match all of the other
header fields.  This patch updates Chrome's NEL reporter implementation
to look for the new spelling in response headers.  No one had started
including NEL headers yet (using the previous spelling), so there's no
need for any backwards-compatibility logic to look for both spellings.

Bug: 834791
Change-Id: I13449aa324eb80f0978f2649b44721022617383f
Reviewed-on: https://chromium-review.googlesource.com/1019842Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#553135}

Changes in patch set 1 were scripted as part of the effort to restrict exposure
of the raw MessageLoop*.

In the latest patch set I manually cleaned it up further to get rid of raw MessageLoop*
and deprecated MessageLoop::QuitWhenIdleClosure() usage altogether.

This CL was uploaded by git cl split (initially).

R=mastiz@chromium.org

Bug: 825327
Change-Id: Ide7ce6794797611d47cebf7a1d448f0a464ac295
Reviewed-on: https://chromium-review.googlesource.com/1024442
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553134}

https://chromium.googlesource.com/catapult.git/+log/93b7358c3cf0..921cf8305ce5

$ git log 93b7358c3..921cf8305 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 simonhatch Dashboard - Update linux-perf name and add new mac.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:779618


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: If2de8f5b2c13a28bf0ec014428d05498aba17ab0
Reviewed-on: https://chromium-review.googlesource.com/1025125
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553133}

Patch set 1 was a scripted change but it turned out to be wrong
because it was assigning into a MessageLoop* variable.

ThreadCheckerImpl and ThreadTaskRunnerHandle are better suited for
what the MessageLoop* was used for. As such, its usage was removed
entirely in patch set 3.

R=mmenke@chromium.org

Bug: 825327
Change-Id: I619c27f15c7c51e7f4211398eefaa2b5475681f1
Reviewed-on: https://chromium-review.googlesource.com/1024314
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553132}

Bug: 825190
Change-Id: I5765b97568ce62ac0431aacfd6dbf01e7e5cd26a
Reviewed-on: https://chromium-review.googlesource.com/1025654Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553131}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 825327
Change-Id: I01cd1c312062bf618b74d65587d13843ba316a93
Reviewed-on: https://chromium-review.googlesource.com/1024765Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553130}

This adds value to web::ErrorRetryState enum, which will be used to
display HTML error page in WKWebView if kWebErrorPages feature flag is
enabled.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iefaa75626477dc0d810b85b8d7726325a0fe217b
Reviewed-on: https://chromium-review.googlesource.com/1025011
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553129}

TBR=smut

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib3b548aba9a038183326a31085f6729ef867d92e
Reviewed-on: https://chromium-review.googlesource.com/1024820
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553128}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=derat@chromium.org

Bug: 825327
Change-Id: I5cc912669a0733a1ac7b89942042c2957ba022f7
Reviewed-on: https://chromium-review.googlesource.com/1024391
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553127}

The 1st patch set triggers the flaky failure reliably and adds a fix.
The proposed fix inits display work areas with BOTTOM_LOCKED insets.
(prevents test flakes on async shelf alignment init and bounds changes)

The 2nd patch set removes the trigger and re-enables autofill tests.

This may cause window movement on left/right alignment user login?
(if windows from a prior session are restored before shelf alignment)

Alternative fix ideas:
1) Always initialize the primary display's shelf to BOTTOM alignment?
   (matches login appearance, keep secondary display shelves hidden)
2) Have InProcessBrowserTest init the alignment synchronously?
   (limits the workaround's scope to tests, where symptoms are felt)
3) Make (tests) wait for shelf init before loading user windows?

Bug: 834369, 834768
Test: No AutofillInteractiveTests flakes on Chrome OS.
Change-Id: Ibb8ea879a81ff198a1a29e6c8de73cb5e8acd3c4
Reviewed-on: https://chromium-review.googlesource.com/1020195Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553126}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1e164941fe2a1a6e51bb33f816fdb8ffb6b11d54
Reviewed-on: https://chromium-review.googlesource.com/1024238Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553125}

The root surface needs to be snapped if the shell surface uses chrome side caption.

This CL also removes "!allow_set_bounds_direct" check when
snapping the window in WindowState. This should have been removed
when we switched to relative surface hierarchy.

Bug: 836076
Test: manually tested with fractional scale factor.

Change-Id: Iadc06572279dec42f8d792424cee76481a94fd55
Reviewed-on: https://chromium-review.googlesource.com/1025371
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553124}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 825327
Change-Id: I1ad5896d82d6b03cff3a481e6898b054157c1ab4
Reviewed-on: https://chromium-review.googlesource.com/1024659
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553123}

TBR=thestig@chromium.org
NOTRY=true

Bug: 836248
Change-Id: I3664a670dd4b794b4a5a595988542336a8d9957b
Reviewed-on: https://chromium-review.googlesource.com/1025643Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553122}

Bug: 831123
Change-Id: I2e955be1390ad381cfda68b2aac2acafa0637b60
Reviewed-on: https://chromium-review.googlesource.com/1025655
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553121}

Use TARGET_AND_DESCENDANTS for event targeting policy to ensure
that frame view hit testing works correctly.

Bug: 836177
Test: window frame for xdg surfaces receive events in X11 cros build
Change-Id: I8a9cae6af24253c9611035353ea6120639f7b1c6
Reviewed-on: https://chromium-review.googlesource.com/1025633Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553120}

The WebKit History API bug only affects push/replaceState calls that
change the URL path and query from file:// scheme. It turns out that
changing URL fragment is still allowed. This CL reimplements restore
session behavior by encoding all data in URL fragment and removes the
iOS11.3 guard for WebClient::IsSlimNavigationManagerEnabled().

Bug: 814803
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib26734b2d62cbcfc1d8f8844e317fdb5842b6b16
Reviewed-on: https://chromium-review.googlesource.com/1024929
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553119}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=yoshiki@chromium.org

Bug: 825327
Change-Id: I7b0019ea81c06367e407c92196fb55bd57504250
Reviewed-on: https://chromium-review.googlesource.com/1024759Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553118}

HasUnsyncedItems() now honors USS workers.

Bug: 836139
Change-Id: Id46bcae5a8ed66474e13da3cafba5ef32560cfbe
Reviewed-on: https://chromium-review.googlesource.com/1025713
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553117}

On ChromeOS, IdentityManager::GetPrimaryAccountInfo DCHECKs that its
view of the primary account info matches the one in SigninManagerBase.
However, if the primary account's refresh token gets revoked, then the
account gets removed from the AccountTrackerService, and
SigninManagerBase will only remember the account's ID, but not the
full AccountInfo.
This CL updates the DCHECKs so that they only verify the account ID in
this case.

Bug: 825190, 806775
Change-Id: I6cbde518e064b590109ef8ca165a1106c7ebda83
Reviewed-on: https://chromium-review.googlesource.com/1025094
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553116}

TBR=clamy@chromium.org
NOTRY=true

Bug: 836242
Change-Id: I7699ca7b26abafd04ac31c3dd5750122509db6cd
Reviewed-on: https://chromium-review.googlesource.com/1025963Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553115}

Widget::GetMinimumSize should return the size including the window
frame. Remove ShellSurfaceWidget override of this function in order
to have the frame view calculate this correctly.

Bug: 827736
Test: exo_unittest --gtest_filter=ShellSurface.SetMinimumSize
Change-Id: I25b59f1e2273364a5579e273b952c15590c744d0
Reviewed-on: https://chromium-review.googlesource.com/1024821Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553114}

This CL updates the voice search button guide when being triggered from
the omnibox voice search button.

Bug: 825396
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia0aeb04340966bbdf96715af56dbc334152598d0
Reviewed-on: https://chromium-review.googlesource.com/1025570
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553113}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=rockot@chromium.org

Bug: 825327
Change-Id: I17d3542e3e7b2e1f6f53c52a7f985a64bf2d076c
Reviewed-on: https://chromium-review.googlesource.com/1024713Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553112}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=hashimoto@chromium.org

Bug: 825327
Change-Id: Ifa839d59418b7a637c228a337b49bbbc811ed494
Reviewed-on: https://chromium-review.googlesource.com/1024251Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553111}

The previous CL that tried to disable this forgot to put MAYBE_ prefix,
this CL does it.

TBR=clamy@chromium.org
NOTRY=true

Bug: 836200
Change-Id: Iaa946acf3631f61cbc30e6f4a14f6aa0fce9ca76
Reviewed-on: https://chromium-review.googlesource.com/1025966Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553110}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=haraken@chromium.org

Bug: 825327
Change-Id: I0d98633558525902e6ab91c21ec03e505817ce4f
Reviewed-on: https://chromium-review.googlesource.com/1024755Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553109}

These expected files are the same as the one under platform/mac/, so
this CL removes them.

Bug: None
Change-Id: Iafae856cfd0ccac6fc7261d754f0935bba0ea6a7
Reviewed-on: https://chromium-review.googlesource.com/1025129Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553108}

TBR=clamy@chromium.org
NOTRY=true

Bug: 665296
Change-Id: I538e83666a06e8e385c79f339f9089f4ee293242
Reviewed-on: https://chromium-review.googlesource.com/1025964Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553107}

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I4496464db436553d1a969a80a148062e6a1bdfaf
Reviewed-on: https://chromium-review.googlesource.com/1023975Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553106}

Also fix a parameter mismatch in the Close function.

Bug: 834101, 826817, 734095
Change-Id: I94bef0defae6c7179605db23bfc8ff0020433f75
Reviewed-on: https://chromium-review.googlesource.com/1023231
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553105}

TBR=thestig@chromium.org
NOTRY=true

Bug: 836241
Change-Id: Idfe38c1419121cbf99295d54aa3bf059a84a0359
Reviewed-on: https://chromium-review.googlesource.com/1025957Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553104}

Fixes walmart.com

To test, go to https://rsolomakhin.github.io/autofill/ and autofill the
form with default value attributes.

Also cleans up __gCrWeb.autofill.fillForm and
__gCrWeb.autofill.clearAutofilledFields for better readability.

Change-Id: I800e82cc67dd3e1c3300186d0df3b3a36dda88cf
Reviewed-on: https://chromium-review.googlesource.com/1025135Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553103}

Switches mojom maps to use base::flat_map for C++ bindings instead of
std::unordered_map.

Bug: 830040
Change-Id: Ifcc4ed6a4a76745940aaa5fb75afc61eae243763
Reviewed-on: https://chromium-review.googlesource.com/1000393
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553102}

Bug: 755840
Change-Id: Ib992197eb21d4705e8911c9ded73dfa7197b329d
Reviewed-on: https://chromium-review.googlesource.com/1024499
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553101}