- 25 Aug, 2014 16 commits
-
-
wtc authored
Includes the following CLs: Don't use <(DEPTH) in the argument to the -include flag. Review URL: https://codereview.chromium.org/493213002 nss: Remove two files from sources that were removed in all conditionals. Review URL: https://codereview.chromium.org/482353002 R=kjellander@chromium.org BUG= Review URL: https://codereview.chromium.org/501873002 Cr-Commit-Position: refs/heads/master@{#291647}
-
hashimoto authored
Move TestingSearchTermsData from template_url_unittest.cc to a new file. Stop using UIThreadSearchTermsData for tests BUG=387985 TEST=unit_tests Review URL: https://codereview.chromium.org/492963005 Cr-Commit-Position: refs/heads/master@{#291646}
-
mtomasz authored
Reading may be slow. We should be able to abort it to avoid unnecessary consumption of resources such as network, cpu and memory. TEST=browser_test: *FileSystemProvider*ReadFile* BUG=400574 Review URL: https://codereview.chromium.org/496953003 Cr-Commit-Position: refs/heads/master@{#291645}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#291644}
-
benchan authored
The new MessageReader::GetSignature() method returns the DBus signature of the value at the current iterator position, which is needed for implementing automatic de-serialization of complex DBus messages. BUG=None TEST=dbus_unittests Review URL: https://codereview.chromium.org/502793002 Cr-Commit-Position: refs/heads/master@{#291643}
-
shuchen authored
Check the IME component extension's availability on linux_chromeos, so that system fallback VK can be showed. BUG=405042 TEST=Verified on linux_chromeos. Review URL: https://codereview.chromium.org/495593004 Cr-Commit-Position: refs/heads/master@{#291642}
-
szager authored
BUG=406935 R=cmp@chromium.org,iannucci@chromium.org Review URL: https://codereview.chromium.org/502863002 Cr-Commit-Position: refs/heads/master@{#291641}
-
noms authored
1. The text is blurry because we use a transform: scale3d(), which on non-retina desktop Chrome is blurry. I assume there is a reason why CrOS chose a scale3d() so I only made this change for the desktop. 2. This leads to a webkit bug (crbug.com/406529) where transforms and opacity transitions do not play well together, so I've removed the opacity transition on the action-area-box. Also: 3. Fixed the focus style on the "remove user" button to not be the ugly blue default but match the gmail style. BUG=399683, 403784 TEST=Start Chrome with -enable-new-avatar-menu. Click on "Switch person". The profile names in the user manager should not be blurry, and hovering over the pods should not be janky. Review URL: https://codereview.chromium.org/476193003 Cr-Commit-Position: refs/heads/master@{#291640}
-
Chase Phillips authored
Cr-Commit-Position: refs/heads/master@{#291639}
-
Chase Phillips authored
Cr-Commit-Position: refs/heads/master@{#291638}
-
yoshiki authored
The branch point has passes so, this patch enables the feature again. This patch is the revert of r289621. BUG=305511 TEST=Confirms the cast icon appears when cast is available. TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/496493003 Cr-Commit-Position: refs/heads/master@{#291637}
-
raymes authored
This includes some minor changes which allow tests to when NPObject is replaced by gin in pepper: -Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in tests. -Add gin as a dependency to content_unittests for use in host_var_tracker_unittest -Change TestInstanceDeprecated so that it doesn't execute a script from the ScriptableObject upon destruction. The reason for this is that the garbage collector is manually run from the destructor of the plugin Instance object. This results in destruction of the ScriptableObject and then javascript is re-entered via ExecuteScript. This should never happen outside tests because the garbage collector won't be run synchronously. Instead of running ExecuteScript, which just set a variable in the Instance object to verify that the ScriptableObject was correctly destroyed. BUG=351636 Review URL: https://codereview.chromium.org/472693002 Cr-Commit-Position: refs/heads/master@{#291636}
-
owenlin authored
BUG=391641 TEST= Run the test on lumpy Review URL: https://codereview.chromium.org/465293002 Cr-Commit-Position: refs/heads/master@{#291635}
-
nduca authored
TBR=dsinclair Review URL: https://codereview.chromium.org/486373004 Cr-Commit-Position: refs/heads/master@{#291634}
-
hirono authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/491223002 Cr-Commit-Position: refs/heads/master@{#291633}
-
calamity authored
This CL removes the white TileItemBackground from the tiles on the experimental app list start page. BUG=349727 Review URL: https://codereview.chromium.org/492153002 Cr-Commit-Position: refs/heads/master@{#291632}
-
- 24 Aug, 2014 19 commits
-
-
leecam authored
Adds support for Arm64 to 'sandbox/'. This can be used by future CLs to provide Arm64 policy for Chrome. BUG=355125 TEST=sandbox_linux_unittests Review URL: https://codereview.chromium.org/487143003 Cr-Commit-Position: refs/heads/master@{#291631}
-
vadimsh authored
Both are valid since depot_tools r291592. TBR=agable@chromium.org NOTRY=true BUG=406934 Review URL: https://codereview.chromium.org/488313003 Cr-Commit-Position: refs/heads/master@{#291630}
-
dgozman authored
BUG=404631 Review URL: https://codereview.chromium.org/493213004 Cr-Commit-Position: refs/heads/master@{#291629}
-
dtseng authored
Adds whitelist to commands API to relax restrictions on: - global accelerator keys - maximum number of commands - override previously taken accelerators This cl also involved fixing the use of the search key while using the global commands listener. The 'command' modifier was being dropped while making its way to the renderer and back. BUG=404768 TEST=With a sample extension binding "Search+Shift+L" and "global": true press and verify callback when focus is inside of web content focus is on the status tray Review URL: https://codereview.chromium.org/399783002 Cr-Commit-Position: refs/heads/master@{#291628}
-
achaulk authored
Selects one on top overlay, if possible, from a main plane + single overlay combination BUG=370522 Review URL: https://codereview.chromium.org/489193002 Cr-Commit-Position: refs/heads/master@{#291627}
-
agable authored
Even the 40-character hash causes problems when the pieces of the string before it push the length to >64 characters. Truncating it is a temporary fix until we discuss ways to accept strings longer than 64 chars. R=cmp@chromium.org, scottmg@chromium.org NOTRY=True BUG=406783 Review URL: https://codereview.chromium.org/499133003 Cr-Commit-Position: refs/heads/master@{#291626}
-
atwilson authored
No longer need this change on trunk now that it has been tested and merged to M37 branch. This reverts commit fd85a93b. BUG=405983 TBR=bartfab@chromium.org Review URL: https://codereview.chromium.org/499923002 Cr-Commit-Position: refs/heads/master@{#291625}
-
reillyg authored
HID report sizes are unsigned values. In addition they should (because of the limited size of USB control transfers) never be larger than 64k. In reality that would be an absolutely enormous report and unlikely to ever been seen in the wild. By limiting the storage size for report lengths to a uint16_t we therefore also limit our exposure to being convinced to allocate unreasonably large buffers by a malicious device. The Windows HID parser already limits report sizes to a USHORT value. BUG= Review URL: https://codereview.chromium.org/492963007 Cr-Commit-Position: refs/heads/master@{#291624}
-
jinho.bang authored
It makes presubmit error: The test file path has been changed by the following CL. - https://codereview.chromium.org/477153005 TBR=mtklein@chromium.org,caryclark@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/497403002 Cr-Commit-Position: refs/heads/master@{#291623}
-
mukai authored
BUG=403813 R=oshima@chromium.org TEST=athena_unittests Review URL: https://codereview.chromium.org/498823002 Cr-Commit-Position: refs/heads/master@{#291622}
-
ericzeng authored
- Add the extension's icon to the header - Add a drop shadow below the header to differentiate the extension content from the WebUI overlay BUG=405796 Review URL: https://codereview.chromium.org/488293003 Cr-Commit-Position: refs/heads/master@{#291621}
-
tfarina authored
This is the set of tests that do not require any change to run as part of extensions_unittests suite. BUG=397165 TEST=extensions_unittests R=jamescook@chromium.org TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/504593002 Cr-Commit-Position: refs/heads/master@{#291620}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#291619}
-
derat authored
Make ExtensionFunctionDispatcher::DispatchOnIOThread() return early if the extension that was passed to it doesn't exist anymore. BUG=406062 Review URL: https://codereview.chromium.org/489033003 Cr-Commit-Position: refs/heads/master@{#291618}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#291617}
-
chrome-tpm authored
This reverts commit 1d8498da. This didn't need to bump because the earlier, failed branching run never got far enough to create 2134 branch. Cr-Commit-Position: refs/heads/master@{#291616}
-
Daniel Cheng authored
The tool has trouble handling substitutions for these macros, since the macros wrap helper functions that perform the actual comparison. This causes the tool to emit replacements for the code inside the helper functions, when the proper fix is to emit replacements for the macro arguments. This patch adds matchers to catch calls to these helper functions with a raw T* and a scoped_refptr<T>, so the main matcher can ignore these replacements and let a logging/gtest specific MatchCallback process these results instead. BUG=110610 R=rsleevi@chromium.org Review URL: https://codereview.chromium.org/488933002 Cr-Commit-Position: refs/heads/master@{#291615}
-
mseaborn authored
This pulls in the following Native Client changes: db60e9b: (sbc@chromium.org) Update glibc revision in tools/REVISIONS (9b15f6a->150657d) c64c70d: (mseaborn@chromium.org) PNaCl dynamic loading: Add ELF dynamic loader 90f0c78: (jvoung@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS 6850127: (mseaborn@chromium.org) Use uint32_t for untrusted pointer args: fstat() and some other syscalls f128665: (dschuff@chromium.org) Build PNaCl target libraries on mac and run SCons tests on the toolchain bot 9151ed1: (petarj@mips.com) [MIPS] Change output-format to elf32-tradlittlemips-nacl 6ef6c97: (petarj@mips.com) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS 9ae0959: (mseaborn@chromium.org) Use uint32_t for untrusted pointer args: gettimeofday() syscall a2d9190: (yyanagisawa@chromium.org) Re-enable use of goma on Windows. b9da09f: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS 3637eb0: (zhenyu.liang@intel.com) Support Android x86 platform 328c7552: (jvoung@chromium.org) Update revision for PNaCl r13625->r13647 b17c53c: (dyen@chromium.org) Pre-Submit script no longer depends on cwd being in NaCl root. 47107a8: (mseaborn@chromium.org) Reduce bot cycle time: Don't run the "noragel" Gyp build 6ab1ae1: (kschimpf@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS c81a09f: (mcgrathr@chromium.org) toolchain_build: Update binutils revision bb09389: (mseaborn@chromium.org) Revert r13646: "Re-enable use of goma on Windows." 3f998aa: (mseaborn@chromium.org) Fix regression in loading of mmap()'able nexes on Windows BUG=406632 TEST=browser_tests and nacl_integration Review URL: https://codereview.chromium.org/471173004 Cr-Commit-Position: refs/heads/master@{#291614}
-
iannucci authored
TBR=maruel@chromium.org R=szager@chromium.org BUG=362394 Review URL: https://codereview.chromium.org/484393003 Cr-Commit-Position: refs/heads/master@{#291613}
-
- 23 Aug, 2014 5 commits
-
-
kalyan.kondapally authored
This CL changes the platform check from Linux to X11. Review URL: https://codereview.chromium.org/500713002 Cr-Commit-Position: refs/heads/master@{#291612}
-
Michael Moss authored
Cr-Commit-Position: refs/heads/master@{#291611}
-
sgurun authored
BUG=406854 Bug: b/17177684 Enabling channel ID causes problems for apps that use multiple network stacks (such as httpurlconnection and webview) or multiple webviews and want to share cookies. Disable until we provide some solution. Review URL: https://codereview.chromium.org/497963002 Cr-Commit-Position: refs/heads/master@{#291610}
-
thestig authored
Review URL: https://codereview.chromium.org/497083004 Cr-Commit-Position: refs/heads/master@{#291609}
-
danakj authored
We used to test the state of the occlusion tracker by making queries for various input rects to try and guess what its occlusion state must be. This is bad. Instead, we can query the state directly. This removes all state queries from tests that are verifying the occlusion tracker's internal state changes correctly. And adds some new tests that just set internal state and verify the query methods work correctly. R=enne Review URL: https://codereview.chromium.org/497493004 Cr-Commit-Position: refs/heads/master@{#291608}
-