GitLab

Modifications to layout test framework so that it can work with browsertests. This is for end to end testing for print preview.

BUG=388517

Review URL: https://codereview.chromium.org/378113003

git-svn-id: svn://svn.chromium.org/blink/trunk@178486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Expose deviceScaleFactor on GraphicsContext and use to selectively
enable subpixel text regardless of the system font hinting settings for
high-dpi systems.

BUG=373441
R=derat@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/407553002

git-svn-id: svn://svn.chromium.org/blink/trunk@178485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

main_unittest was relying on the original sys.argv and passing that
to the arg-parsing code. If somehow you had something in argv that
wasn't a valid argument to test-webkitpy (e.g., by testing w/
unittest directly), the test would fail and raise SystemExit.

This was an unnecessarily fragile design, so I fixed to preserve
the original sys.argv and replace it for the test w/ something predictable.

R=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397723004

git-svn-id: svn://svn.chromium.org/blink/trunk@178484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

test-webkitpy tests running the -c flag for coverage; this would cause
us to leave a .coverage file in Tools/Scripts. This patch cleans that up

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/399193006

git-svn-id: svn://svn.chromium.org/blink/trunk@178483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't run these by default, so they bitrotted at some point.

In particular, it looks like svn 1.7 changed behavior so that if
you call

svn add foo
svn add foo/bar

the second call errors out with bar already having been added;
in svn 1.6, this was just a warning.

This comes up in our code because when adding a file we recursively
add the parent directories to ensure the whole path is versioned; we
need to change this so that we do not implicitly recurse down when
adding a parent directory.

Less importantly, it looks like the semantics for git svn clone -T 
change in Git v2, so the branch names are slightly different and 
we need to account for the remote branch refs differently as a result.

R=eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397383002

git-svn-id: svn://svn.chromium.org/blink/trunk@178482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a SmoothScrollInterruptionTest class and tests using
this class.

BUG=243871

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178387

Review URL: https://codereview.chromium.org/398043005

git-svn-id: svn://svn.chromium.org/blink/trunk@178481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/403013002

git-svn-id: svn://svn.chromium.org/blink/trunk@178480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On flex items, specifying a flex shorthand with a flex basis in the
middle of two flex factors, e.g. flex: 1 0% 1 is getting accepted in
blink.

According to http://www.w3.org/TR/css3-flexbox/#flex-property, the
grammar of the flex shorthand is as follows:

Value:	none | [ <‘flex-grow’> <‘flex-shrink’>? || <‘flex-basis’> ]

It means that flex-grow and flex-shrink must appear together. Therefore flex
basis in the middle of two flex factors is invalid.

Currently blink consider flex: 1 0% 1 as valid, mapping the values as
 <flex-grow> <flex-basis> <flex-shrink>, i.e. flex: 1 0% 1 is equivalent
to flex: 1 1 0%.

This patch fixes this bug by adding an additional condition checking
if flex-basis is in the middle or not in flex argument list
while setting values for flex basis.

BUG=380984

Review URL: https://codereview.chromium.org/396263003

git-svn-id: svn://svn.chromium.org/blink/trunk@178479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394669

Review URL: https://codereview.chromium.org/396213010

git-svn-id: svn://svn.chromium.org/blink/trunk@178478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/400543004

git-svn-id: svn://svn.chromium.org/blink/trunk@178475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Update the fast/text/decomposed-after-stacked-diacritics.html test to
support subpixel text.

BUG=378610
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/359463002

git-svn-id: svn://svn.chromium.org/blink/trunk@178474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/400143002

git-svn-id: svn://svn.chromium.org/blink/trunk@178473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL follows https://codereview.chromium.org/392783003 and
https://codereview.chromium.org/393653002.

BUG=350531

Review URL: https://codereview.chromium.org/396753002

git-svn-id: svn://svn.chromium.org/blink/trunk@178472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added error message with stack trace and exception details if exception happened when command in console evaluate.

Review URL: https://codereview.chromium.org/369333002

git-svn-id: svn://svn.chromium.org/blink/trunk@178471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename the linux specific FontPlatformData implementation file from
FontPlatformDataLinuxHarfBuzz.cpp to FontPlatformDataLinux.cpp as all
platforms use HarfBuzz now.

R=jbroman@chromium.org

Review URL: https://codereview.chromium.org/404653004

git-svn-id: svn://svn.chromium.org/blink/trunk@178469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=302024

Review URL: https://codereview.chromium.org/399423006

git-svn-id: svn://svn.chromium.org/blink/trunk@178468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It doesn't need anything particular to block flows, and is used by other
kinds of renderers.

Review URL: https://codereview.chromium.org/397723006

git-svn-id: svn://svn.chromium.org/blink/trunk@178467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop the aging yellow popover and match the tooltip style in Chrome.

TBR=sergeyv
BUG=181703

Review URL: https://codereview.chromium.org/401013002

git-svn-id: svn://svn.chromium.org/blink/trunk@178466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=394359

Review URL: https://codereview.chromium.org/397073006

git-svn-id: svn://svn.chromium.org/blink/trunk@178464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=ericu@chromium.org

Review URL: https://codereview.chromium.org/403793002

git-svn-id: svn://svn.chromium.org/blink/trunk@178463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Earlier this method returns class name for errors objects, now it returns className + ':' + error.message.

R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/401843002

git-svn-id: svn://svn.chromium.org/blink/trunk@178462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/397313003

git-svn-id: svn://svn.chromium.org/blink/trunk@178461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While rendering, scrollOffset was taken into account. This lead to wrong points for creation of the shape.

Patch proposes removing of scrollOffset to avoid the behavior.

BUG=392857
R=pfeldman
TEST=Circle should render similarly, inspite of a scroll.

Review URL: https://codereview.chromium.org/396803010

git-svn-id: svn://svn.chromium.org/blink/trunk@178460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having "config" reference "non_test_config" does nothing. I'm
fixing the warning that will flag this. I checked and a bunch of
targets already add non_test_config, so it isn't obviously
broken otherwise.

TBR=eseidel

Review URL: https://codereview.chromium.org/403653002

git-svn-id: svn://svn.chromium.org/blink/trunk@178459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, it was the clients' responsibility to build raw locations
based on DebuggerAgent.Location.

R=vsevik

Review URL: https://codereview.chromium.org/402873002

git-svn-id: svn://svn.chromium.org/blink/trunk@178457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are two renderers in html/shadow/
RenderSliderContainer and RenderSliderThumb.
They moved into rendering/ so that they are tracked like any other
renderers.

BUG=346445

Review URL: https://codereview.chromium.org/403523003

git-svn-id: svn://svn.chromium.org/blink/trunk@178456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395137
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/397243005

git-svn-id: svn://svn.chromium.org/blink/trunk@178453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixes incorrect marking as flaky in
https://codereview.chromium.org/398423005, which forgot that the
FlakyTests file is auto-generated.

BUG=395127
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/400223003

git-svn-id: svn://svn.chromium.org/blink/trunk@178452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/407493005

git-svn-id: svn://svn.chromium.org/blink/trunk@178450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now we try to build a string representation of a V8 value without causing side
effects. In 99% cases this will be the same result as before, but we won't crash
or hang any more in 99% reported cases.

The crash still possible if redefined, for example, function.toString().
Would have been ideal if V8 also exposed FunctionProtoToString, RegExpProtoToString and etc.

We use V8's ObjectProtoToString on almost all Objects and mimic V8's ArrayToString on small
arrays. For other types we call ToString.

BUG=391475
R=yurys

Review URL: https://codereview.chromium.org/388093002

git-svn-id: svn://svn.chromium.org/blink/trunk@178449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The former implementation asked the current SkCanvas, in all cases now a
SkPictureRecord, for a new SkSurface. The SkPictureRecord always returned null for
the SkSurface. Now we just return a new bitmap surface regardless.

There are two pieces of code that depend on this: cross-fade and SVG
buffered-rendering (which apparently is going away, see crbug.com/395766).
For some reason the cross fade code worked anyway, maybe due to some
fallback path, but the SVG caching didn't.

Note we don't want any of this rasterization during recording. But for
now it stays.

R=fmalita@chromium.org,reed@google.com
BUG=394765,394768

Review URL: https://codereview.chromium.org/399213002

git-svn-id: svn://svn.chromium.org/blink/trunk@178448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/400633003

git-svn-id: svn://svn.chromium.org/blink/trunk@178447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Original patch by Eric Seidel, after a discussion with Behdad.
I rebased it on top of my font fallback fix in r176765, without
which this caching logic would regress (see crbug.com/272006).

Quoting Eric's initial changelog entry:

"The old code used to query FontConfig with the
char and locale for every time Blink needed
a fallback font for a character.

The new code only queries FontConfig once for each
locale, saves the resulting FcFontSet.  When we need
to know the correct font for a char, we walk the
fonts in the set asking each if they have a glyph for
that character.

The existing logic had a bunch of code to work around
bugs where FontConfig would return invalid fonts.
To avoid walking invalid fonts for each lookup
we create a Vector of FontCache objects at CachedFontSet
creation time and only walk valid CachedFonts at
lookup time."

For the list of page_cycler.intl_ja_zh sites,
I locally get the following speedups in warm_times results:
(full data attached to the bug):

3.8397612488521577 www.baidu.com 2090.750000ms 544.500000ms
3.447672499174645 www.yahoo.co.jp 2610.750000ms 757.250000ms
3.268197920237687 cn.yahoo.com 7150.000000ms 2187.750000ms
2.5949379270522566 zol.com.cn 6741.000000ms 2597.750000ms
2.2926255669410383 goo.ne.jp 3412.000000ms 1488.250000ms
2.2606811489527194 www.sina.com.cn 10172.500000ms 4499.750000ms
2.218289901154351 www.qq.com 8023.000000ms 3616.750000ms
2.1029045643153528 2ch.net 633.500000ms 301.250000ms
1.9500301628795496 kakaku.com 4848.750000ms 2486.500000ms
1.844571008634944 fc2.com_ja 2510.000000ms 1360.750000ms
1.8037104522113632 www.google.com.hk 2722.250000ms 1509.250000ms
1.79902755267423 jugem.jp 4162.500000ms 2313.750000ms
1.778485665278118 www.taobao.com_index_global.ph 3629.000000ms 2040.500000ms
1.7573505120581434 ruten.com.tw 5319.500000ms 3027.000000ms
1.7528028651510432 dtiblog.com 5628.250000ms 3211.000000ms
1.5707825244286522 udn.com_NEWS_mainpage.shtm 4862.750000ms 3095.750000ms
1.517787031528852 hatena.ne.jp 3189.250000ms 2101.250000ms
1.5078812316715542 www.amazon.co.j 2056.750000ms 1364.000000ms
1.4083924349881796 mixi.jp 1191.500000ms 846.000000ms

BUG=266214
R=behdad,eae,eseidel

Review URL: https://codereview.chromium.org/342823005

git-svn-id: svn://svn.chromium.org/blink/trunk@178446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395127
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/398423005

git-svn-id: svn://svn.chromium.org/blink/trunk@178445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Should an empty LocalFrame be used, handle this gracefully.

R=
BUG=395032

Review URL: https://codereview.chromium.org/392223003

git-svn-id: svn://svn.chromium.org/blink/trunk@178444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/401743004

git-svn-id: svn://svn.chromium.org/blink/trunk@178442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/399643002

git-svn-id: svn://svn.chromium.org/blink/trunk@178441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

webkit_unit_test_support.h's functions are just thin wrappers that just
call the functions from webkit_support.h. So instead of having this
unnecessary indirection, just call the functions from webkit_support.h
directly.

This is a two side patch. After this lands, Chromium will be update to
remove webkit_unit_test_support.*

BUG=None
TEST=webkit_unit_tests
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/393123005

git-svn-id: svn://svn.chromium.org/blink/trunk@178440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With http://crrev.com/406523002 making GarbageCollectedMixin a non-abstract
class, MSVC elicits a warning that DLL exported GCMixin classes have a
base class that isn't DLL exported.

Add the needed annotation to GarbageCollectedMixin to address (as warnings
are considered as errors.)

R=haraken@chromium.org,wibling@chromium.org
BUG=382557
NOTRY=true

Review URL: https://codereview.chromium.org/396153003

git-svn-id: svn://svn.chromium.org/blink/trunk@178439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=johnme@chromium.org
BUG=395103
NOTRY=true

Review URL: https://codereview.chromium.org/400983002

git-svn-id: svn://svn.chromium.org/blink/trunk@178437 bbb929c8-8fbe-4397-9dbb-9b2b20218538