GitLab

BUG=b/8627864
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23458014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220652 0039d316-1c4b-4281-b951-d872f2087c98

The mini_installer test framework used the psutil module to find process IDs and paths, but this module was not available on the buildslave. Remove psutil and call Windows API directly instead.

NOTRY=True
BUG=264859
1) Uninstall Chrome (if it's installed.)
2) Put mini_installer.exe in the same folder as test_installer.py
3) Use Python 2.6.x. Make sure that psutil is not installed. Run "python test_installer.py config\config.config". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23814002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220650 0039d316-1c4b-4281-b951-d872f2087c98

If a PageAction inherits another PageAction class, then DiscoverClasses() 
might mess up the map from simple module name to class object name. See 
bug for more details.

BUG=281568

Review URL: https://chromiumcodereview.appspot.com/23602015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220649 0039d316-1c4b-4281-b951-d872f2087c98

This CL should fix this issue that we are experiencing(note it is not always reproducible):
- In a maximized window, clicking button may not take any effect due to immediate
keyboard relayout
(go to http://unixpapa.com/js/testkey.html and try hit reset button after typed
a bunch of keys)

It also workarounds the other two issues:
1. keyboard flicking when quickly switch from one input field to another field
2. In webdev javascript console, the input feild temoporary lost focus when
candidate popup window shows and it may try to hide and relayout keyboard, which
makes the console unuseable with virtual keyboard.
The root problem for the above two issues are tracked in issue 281493.

BUG=

Review URL: https://chromiumcodereview.appspot.com/22831045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220648 0039d316-1c4b-4281-b951-d872f2087c98

make sense.

The use of NUM_BIN_PRIORITIES was confusing, but actually it
looks like that was simply old code and shouldn't even exist
anymore.

Also deleting some unused variables and functions.

Review URL: https://chromiumcodereview.appspot.com/23802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220647 0039d316-1c4b-4281-b951-d872f2087c98

Send cancel request to printer when registration is canceled.

BUG=245375

Review URL: https://chromiumcodereview.appspot.com/23780002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281038

Review URL: https://chromiumcodereview.appspot.com/23514006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220645 0039d316-1c4b-4281-b951-d872f2087c98

permissions by automatically generated ones for declare_permissions.html.
Add docs for the tabs permission. Remove the unused tabCapture docs.
Fix some missed cases where we didn't change "module" terminology to "API".

R=jyasskin@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23494015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220644 0039d316-1c4b-4281-b951-d872f2087c98

The operations are mapped to "Children: insert" and "Children: delete" on
Drive API v2. To adapt the API more, renames and changes the style.

BUG=277253
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23757004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280695
TEST=none
TBR=miguelg

Review URL: https://codereview.chromium.org/23836002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220641 0039d316-1c4b-4281-b951-d872f2087c98

This is only a problem on Windows.

When the page closes itself while the color chooser dialog is open,
ColorChooserDialog::DidCloseDialog was called after the listener has been destroyed.

ColorChooserWin::End() will not actually close the color chooser dialog (because we can't) but act like it did so we can do the necessary cleanup.

BUG=279263
R=jschuh@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/23785003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123444

Review URL: https://chromiumcodereview.appspot.com/22797008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220638 0039d316-1c4b-4281-b951-d872f2087c98

This CL separates the solid-color scrollbar functionality into its own class structure, resulting in the following hierarchy:

ScrollbarLayerInterface (pure-virtual)
 |
 --------  PaintedScrollbarLayer (for outer-viewport)
 |
 --------- SolidColorScrollbarLayer (for inner-viewport)            
                                    (Android, pinch-zoom)

ScrollbarLayerImplBase
 |
 ----- PaintedScrollbarLayerImpl (for outer-viewport)
 |
 ----- SolidColorScrollbarLayerImpl (for inner-viewport)
                                    (Android, pinch-zoom)

In this architecture, solid-color scrollbars can live side-by side with regular desktop scrollbars, and no longer require a WebScrollbar in order to be created. The scrolling LayerImpl's only know about ScrollbarLayerImplBase, and the TreeSynchronizer & LTI only deal with *Base layer types.

The ScrollbarLayerImplBase layer is not pure virtual, but rather attempts to collect any common functionality, and the result is much simpler classes for SolidColorScrollbarLayerImpl.

Work remaining:

1) Once the pinch-viewport layers are in place in CC, we can get rid of vertical adjust (I think), and so LTI::UpdateSolidColorScrollbars() can go away. When this goes away, some of the interface for ScrollbarLayerImplBase can be simplified as well.

Review URL: https://chromiumcodereview.appspot.com/18341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220637 0039d316-1c4b-4281-b951-d872f2087c98

> Update chrome://newtab checks in browser tests to use chrome::IsNTPURL().
> 
> BUG=229009
> TEST=none
> TBR=sky@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/22403003

TBR=kmadhusu@chromium.org

Review URL: https://codereview.chromium.org/23475011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220636 0039d316-1c4b-4281-b951-d872f2087c98

OZONE event factory should be a bit more verbose on error.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23438002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220632 0039d316-1c4b-4281-b951-d872f2087c98

Only the controller-side changes for now. The Views will have to implement the linkification, for now they just show the text with no linkifying.

BUG=266130, 266131, 260940
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/23495006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224793
TEST=Added unittests.

Review URL: https://chromiumcodereview.appspot.com/23517002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23445021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280147

Review URL: https://chromiumcodereview.appspot.com/23534021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220628 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23531017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220626 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220625 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=156964:156995&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23496026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229009
TEST=none
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220623 0039d316-1c4b-4281-b951-d872f2087c98

We were missing some expected calls which caused noise in the
test output about unexpected function calls happening.

R=piman
BUG=263389

Review URL: https://chromiumcodereview.appspot.com/23621015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220621 0039d316-1c4b-4281-b951-d872f2087c98

The loop to remove entries seemed a bit silly going through both lists;
it's a bit more clear to do it on the merged set.

R=rdsmith,pliard
BUG=None

Review URL: https://chromiumcodereview.appspot.com/22430014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220618 0039d316-1c4b-4281-b951-d872f2087c98

and check them to see if audio processing should be applied.
Previously this check was just being based on a device id being
empty or not, which doesn't do the right thing for WebAudio.

BUG=277134

Review URL: https://chromiumcodereview.appspot.com/23171026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23583023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220616 0039d316-1c4b-4281-b951-d872f2087c98

Fixes memory leaks.

BUG=278187
R=gavinp

Review URL: https://chromiumcodereview.appspot.com/22882009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/19579005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220612 0039d316-1c4b-4281-b951-d872f2087c98

The example code in the comments in this header file doesn't compile. This CL
corrects the sample code to actually work.

Review URL: https://chromiumcodereview.appspot.com/23494012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220611 0039d316-1c4b-4281-b951-d872f2087c98

-also allow extensions to be loaded via --load-extension
-change useExistingBrowser to debuggerAddress
BUG=chromedriver:488

Review URL: https://chromiumcodereview.appspot.com/23643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282303

Review URL: https://chromiumcodereview.appspot.com/23820003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220609 0039d316-1c4b-4281-b951-d872f2087c98

Move AlterEnvironment to base/environment.h, implement on Windows. This re-implements the Posix version to be more like the Windows version and to share some parsing code. The new version will be somewhat slower due to some extra mallocs, but is shorter and more clear. I didn't want to implement a super optimized version on Windows, and the alternative would be to keep the new Windows version and the old Posix version in parallel which seemed less desirable.

This changes the input from a vector to a map and just adds the map on the LaunchOptions rather than requiring the caller to set a pointer. This cleans up the callsites somewhat.

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/22750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220608 0039d316-1c4b-4281-b951-d872f2087c98

If we have no image decode tasks, we don't need to do all the tile
and layer management to identify which are unnecessary. 200% speedup
on manage_tiles_*_0, 25% speedup on manage_tiles_*_100.

Thanks to Sami for the suggestion.

BUG=282412
R=reveman@chromium.org,vmpstr@chromium.org
CC=skyostil@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23495013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23112028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220606 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220605 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23602017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220604 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces three new private APIs, which will be used to replace
Files.app's current copy implementation.
Currently, the copy operation is implemented in JavaScript layer, because
FileSystem API's copyTo method doesn't support progress update and cancelling.
To let Files.app focus on UI, the copy implementation is being moved to
C++ layer, and these private APIs will be used for it.
This CL just adds manifest entries, so no behavior change is expected.

BUG=279287
TEST=Tested manually.

Review URL: https://chromiumcodereview.appspot.com/23537002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220603 0039d316-1c4b-4281-b951-d872f2087c98

The next step in moving towards the DataSourceRegistry architecture
(see bug).

The SidenavDataSource is the first DataSource to rely on the contents of
a request and the DataSourceRegistry had to change. Now DataSources are
given both a ServerInstance and a Request when created. Strings and
Manifest DataSources have been updated.

SidenavDataSource contained some very old code and was in need of
refactoring. The Factory had to be stripped out because it is now
unneeded and doesn't work with the registry.

CreateDataSource was moved into the RenderServlet and is added to the
template data source in Create to give the DataSources access to 
a Request.

BUG=275039
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22824042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220600 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220599 0039d316-1c4b-4281-b951-d872f2087c98