- 02 Aug, 2018 40 commits
-
-
Andrew Grieve authored
Bug: 857001 Change-Id: Id4eebe86e34e30edfda8fa5825ceb1e3e303dd95 Reviewed-on: https://chromium-review.googlesource.com/1148929Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#580071}
-
Shakti Sahu authored
Added a setting to enable/disable prefetch in downloads settings. This settings will not be visible if prefetching feature is not enabled. UX: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZa-WKS_VfBWp/files/MCHtA7U1iMGr6yF79JTTnBdio_aEa3M5pNg Bug: 850588 Change-Id: Icb1f4a504c88878ada36c9e642819669e9ee7409 Reviewed-on: https://chromium-review.googlesource.com/1139590 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580070}
-
Alex Moshchuk authored
RenderProcessWillExit is dispatched to observers from RPHI::ShutdownRequest during renderer-initiated process shutdown, when the renderer process is allowed to continue shutting down but before it does actually shut down. This is routed through SiteInstanceImpl::RenderProcessWillExit, which calls RenderFrameHostManager::RenderProcessGone() to mark all proxies living in that process as non-live. Unfortunately, this might lead to duplicate routing ID crashes if one of these proxies is reused and recreated before the process goes away completely. See https://crbug.com/794625#c14 for full details. This CL fixes these races by completely removing RenderProcessWillExit. The affected RenderFrameProxyHosts will still be marked as non-live later when the process actually goes away, as part of SiteInstanceImpl::RenderProcessExited(), called from either RPHI::Cleanup() or RPHI::ProcessDied(). That is, today we try to mark proxies as non-live twice, and arguably only the second path is really needed. RenderProcessWillExit also used to trigger RenderFrameHostImpl::RenderProcessGone() to perform some navigation cleanup work, but the same cleanup will still happen via the RenderProcessExited path. Bug: 794625, 575400 Change-Id: I6b6c776e179a1048c9634ad323d45302423246f1 Reviewed-on: https://chromium-review.googlesource.com/1155790Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580069}
-
Joel Hockey authored
This will be used in a followup CL for CrostiniManager unit tests. Bug: 846917 Change-Id: I4938a4bf75b986adb4a2dc283ffac7d0509e1c5c Reviewed-on: https://chromium-review.googlesource.com/1158319Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#580068}
-
Kyle Milka authored
Add the selected label to a tile when it is selected. Make the back button usable with the space bar. Bug: 858885 Change-Id: Ib84de79a84034805869e58e1d07c4f7891e8fecd Reviewed-on: https://chromium-review.googlesource.com/1157168 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580067}
-
Christopher Cameron authored
Change zero-copy to specify IOSurface color profiles using SetColorSpaceMetadataCHROMIUM rather than calling SetColorSpace on the GpuMemoryBuffer directly. The SetColorSpaceMetadataCHROMIUM path ends up calling gl::GLImageIOSurface::SetColorSpace, which uses the gfx::DisplayICCProfiles structure to ensure that we use low power profiles when possible. This removes the need for - gfx::ICCProfile::FromCacheMac - Sending gfx::ICCProfiles from the browser to the renderer in the content::ScreenInfo - Note that content::ScreenInfo::icc_profile was not ever actually read - Sending it over IPC would result it being added to the cache read by gfx::ICCProfile::FromCacheMac - mojo and IPC support of gfx::ICCProfile Bug: 869570 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I814496a5fffc8da38b4b59d7d2cc055dc47cd52b Reviewed-on: https://chromium-review.googlesource.com/1159233 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#580066}
-
Antoine Labour authored
This is a servce-side class that can create shared images in the form of mailboxes. This is the service-side implementation of the upcoming SharedImageInterface, which is a stateless and thread-safe API to create such shared images from the client side (introduced in a follow-up). Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id0db4300a57e02ccbd46b5b328b534d8cd3f2dc8 Reviewed-on: https://chromium-review.googlesource.com/1159384Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580065}
-
Johannes Henkel authored
This lets an agent clear all its fields, by calling agent_state_.Clear(); And now all the methods are called just Clear, a bit like STL calls different erase methods (range, iterator, value, ...) just erase. What's being cleared will be distinguished by the context only, e.g. method parameters and the receiver. There's pros / cons to this but it's also kinda neat in a way. I do need to do something about ClearAll either way so that I can have a virtual method, so this choice felt both convenient and principled. Hoping to get away with it. :-) Change-Id: I439b77052e110968f196a21ae63020646a9ba23b Reviewed-on: https://chromium-review.googlesource.com/1159822Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580064}
-
John Abd-El-Malek authored
This adds support for: 1) Safe Search 2) YouTube restricted mode 3) restricting consumer accounts through Group Policy. The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1152507 with a fix for the CFI failure in unit_tests. TBR=kinuko Bug: 841313 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iedb413e4cb2837d71d380e5df74d7f80305181cd Reviewed-on: https://chromium-review.googlesource.com/1159821Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#580063}
-
Kinuko Yasuda authored
This reverts commit f61df6f9. Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. Sample builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 failures: BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 BluetoothTestWinrt.GetPrimaryServices/1 BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 BluetoothTestWinrt.GetPrimaryServicesByUUID/1 BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 BluetoothTestWinrt.GetGattServices_and_GetGattService/1 BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 Original change's description: > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > This change implements reading and writing of Remote Gatt Descriptors > for WinRT. Furthermore, it enables corresponding tests. > > Bug: 821766 > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > Reviewed-on: https://chromium-review.googlesource.com/1156703 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579838} TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766 Reviewed-on: https://chromium-review.googlesource.com/1159961Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580062}
-
Nikhil Athreya authored
Recognizes a request for process usage data from ProcessDataCollector when an IPC message from the render (invoked from Javascript) is invoked and passes the information in the ProcessDataCollector::ProcessUsageData struct's to the JS code. requestProcessUsageData from the JS console. BUG: crbug.com/851767 TEST: On a Chrome OS device, go to chrome://power and call Change-Id: Ief597fd97032254c3675371d6a0419cdea0e49f1 Reviewed-on: https://chromium-review.googlesource.com/1157133 Commit-Queue: Nikhil Athreya <nathreya@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#580061}
-
Kinuko Yasuda authored
TBR=jamescook,nick Bug: 671891 Change-Id: Ic0c49bfb7f012fa6f8bd3e5150f57274d439d073 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1159927 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Ken Rockot authored
A few of these tests have some subtle scheduling issues which are hit when we attempt to turn on more granular Mojo bindings message dispatch. This CL adds some synchronization via FlushForTesting calls where appropriate to avoid such issues. TBR=sky@chromium.org Bug: 869553 Change-Id: I8d4d5be6f670db3b3e369f70dfd987dc0b1f1ff2 Reviewed-on: https://chromium-review.googlesource.com/1159591 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580059}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a1917f0efb7..c99a49a615e8 git log 0a1917f0efb7..c99a49a615e8 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 treehugger-gerrit@google.com Merge "UI: Simplify Animation class" Created with: gclient setdep -r src/third_party/perfetto@c99a49a615e8 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I387c6ace847bcdbf11d722c524ccebff2cfbf351 Reviewed-on: https://chromium-review.googlesource.com/1159881 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580058}
-
Adam Rice authored
Apply standard changes to ReadableStream up to standard version 51227372cc84846bdcf68312724c4cac6a4b9e58. With this change, Blink's implementation once again passes all non-byte-stream ReadableStream tests. Update test expectations to match. Changes: * Use null prototypes for the objects returned by ReadableStreamDefaultReaderRead when they consumed internally by pipeTo(), tee() or fetch. This is the fix for standard issue https://github.com/whatwg/streams/issues/933 "Setting Object.prototype.then permits interfering with pipeTo() internals". * In pipeTo() complete all pending writes when readable stream is errored. * Change ordering of accessing strategy parameters to match standard. Non-user visible changes: * Use Object.assign() to be more concise when modifying the binding object in ReadableStream.js and WritableStream.js. WPT changes: * Update the expectations in response-stream-with-broken-then.any.js since interference is no longer possible. * Add extra tests to response-stream-with-broken-then.any.js for the arraybuffer -> text case which should have been broken in Chrome but wasn't, and the arraybuffer -> stream case. * Fix bugs in streams/piping/then-interception.js which are only apparent when it passes. In particular, delete Object.prototype.then even when it is not called. BUG=866388 Change-Id: I82c8ac2c2b7d71ccbf331388014e8cec847e1b65 Reviewed-on: https://chromium-review.googlesource.com/1149678Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580057}
-
Findit authored
This reverts commit a2bae731. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 579967 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EyYmFlNzMxOTRiOGRlYjFiYTJlNTMzYzIzNWMzMjhiYTgwOWZjMDcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8101 Sample Failed Step: browser_tests Original change's description: > Make SearchBoxView Search Box have the functionality to autocomplete > user queries. > > Current iteration: > 1. Autocomplete queries will only autocomplete if it is confident in a > url or text query (no apps or answer cards). > 2. Autocomplete is based off of the first result view in the > SearchResultPageView. > 3. Up/Down/Left/Right/Tab keys all trigger autocomplete. > > Bug: 865543 > Change-Id: I8be9ba36f4bb79bc250b64d289919bd898144862 > Reviewed-on: https://chromium-review.googlesource.com/1141118 > Commit-Queue: Daniel Zhang <oxyflush@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579967} Change-Id: I069a412d061460bd83025292b583eefcd58c469f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865543 Reviewed-on: https://chromium-review.googlesource.com/1159852 Cr-Commit-Position: refs/heads/master@{#580056}
-
Pavol Marko authored
This reverts commit 521a221d. Reason for revert: Reported to cause crashes - https://crbug.com/870147 Original change's description: > Set SequenceToken for SequenceLocalStorageMap destructor > > Ensure that the SequenceLocalStorageMap and consequently objects still > stored in the sequence-local storage are destroyed while the owning > Sequence's SequenceToken is set for the current thread. > This makes sure that objects stored in the sequence-local storage which > expect to be destroyed on the same Sequence they've been created on do > not (D)CHECK in their destrutor. > > Bug: 869272 > Test: base_unittests && browser_tests --gtest_filter=*UserAffiliation* > Change-Id: I8c76b274a746a35c4ad038e7d8f04ea212ef1514 > Reviewed-on: https://chromium-review.googlesource.com/1156510 > Commit-Queue: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579834} TBR=gab@chromium.org,pmarko@chromium.org Change-Id: Iece11abba0b755a05bbafcd89046a4921354703c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869272 Reviewed-on: https://chromium-review.googlesource.com/1159941Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580055}
-
Yutaka Hirano authored
- Decrement |cors_redirect_limit_| even when IsAllowedRedirect(...) returns true. - Redirect count logic is not applied when |out_of_blink_cors_| is set. - Take the return value of a call of client_->WillFollowRedirect introduced at [1] into account. 1: https://chromium-review.googlesource.com/c/chromium/src/+/1150695 Bug: 736308, 353768 Change-Id: I5c251881902a66429d7c601e62786bd20890eb95 Reviewed-on: https://chromium-review.googlesource.com/1156120 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#580054}
-
Adam Rice authored
Replace the use of zero-length timers in blink::DOMWebSocket with direct use of the PostTask API. This slightly improves clarity and efficiency. BUG=856651 Change-Id: Ib6003fb9861a59513477eafcaa07e02eacef1271 Reviewed-on: https://chromium-review.googlesource.com/1151045 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
This reverts commit 3d248fc5. Reason for revert: SuggestedTextTouchBarControllerBrowserTest constantly failing after this. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28381 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28382 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14729 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14730 Original change's description: > [Mac] Re-Generate Text Suggestions on WebContents Update > > Previously, each tab had its own SuggestedTextTouchBarController. Now, > because of http://crrev/c/1151613, there is only one > SuggestedTextTouchBarController per window. Because the controller does > not maintain the state of each tab, as a user switches tabs, the > controller needs to update its state to match the tab. When the > controller's WebContents change, new suggestions should be generated > for the selected text in the current tab. > > The methods -webContentsTextSelectionChanged:range: and > -webContentsFinishedLoading were combined into a singular method, > -updateTextSelection:range:, because they had very similar > functionality. > > The parameters for -requestSuggestionsForText:inRange: were removed > because they were always |text_| and |selectionRange_|. > > A new method was created, -webContentsChanged, to get a tab's current > text and selected range and then call -updateTextSelection:range: with > the proper parameters. > > When the controller gets a new pointer to a WebContents, the pointer > may be null. To avoid calling WebContents::IsFocusedElementEditable() > on a null pointer, a method -isTextfieldFocused was created to check > that |webContents_| is not a null pointer and that an editable element > is focused. > > A new SuggestedTextTouchBarControllerBrowserTest was written, > SetWebContentsTest, to test that the SuggestedTextTouchBarController > properly updates its current text selection based on the new > WebContents. > > Bug: 717553 > Change-Id: I356a548bbdf33b51484fd7c55a1aa5ea37be4bae > Reviewed-on: https://chromium-review.googlesource.com/1153728 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Cr-Commit-Position: refs/heads/master@{#579851} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: I043f5352f43f9ee5eaeff6c7f5a0a9c64b067d26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1159902Reviewed-by:
-
Tetsui Ohkubo authored
This CL updates ethernet icon in UnifiedSystemTray to the one specified in spec. Also, size of an icon in Unified's default view is 24. TEST=manual BUG=842079 Change-Id: I988d9449855201ba9f1ec096c11aacabc12d8dc4 Reviewed-on: https://chromium-review.googlesource.com/1123959Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#580051}
-
tzik authored
This contains a similar fix to the reverted previous attempt at http://crrev.com/556813c93fa177cd VEAEncoder is ref counted, and its first reference used to be retained in its constructor through base::Bind(). The reference is passed to the other sequence, and released when the callback instance is destroyed. If the PostTask there failed or the posted task ran soon, the VEAEncoder instance can be destroyed before another reference is retained on the original sequence. That is, `new VEAEncoder` may return a stale pointer. This CL adds a static cosntructor to VEAEncoder, and keeps the first reference before calling PostTask. Bug: 866456 Change-Id: Icbb430bebbfa5c800f3c0248b5afd10f2c2de271 Reviewed-on: https://chromium-review.googlesource.com/1158316Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#580050}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4eef1493c910e28742f97bc512d3547b6ffde798 Reviewed-on: https://chromium-review.googlesource.com/1159593Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580049}
-
mrefaat authored
There seems to be some headers that was stuck in crw_web_delegate.h during several past refactors. This CL remove the crw_web_delegate.h file and import/include these headers in their required places. Bug: 674991 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4d4b20ed21df4e7b9586bce966d6c27a09cb55a5 Reviewed-on: https://chromium-review.googlesource.com/1147489 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580048}
-
Yu-Hsuan Hsu authored
The change is related to CL:1148178. Add histogram infomation in histograms.xml to make the histogram visible on chromedashboard. BUG=b:77485214 Change-Id: I4cc97b06038b5736eb42bf169a8e91e2674ea4ad Reviewed-on: https://chromium-review.googlesource.com/1154742 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580047}
-
Scott Violet authored
Remove '2' from a bunch of test names. This was necessary as ws1 had similar test names. Now that ws1 has been removed, the names no longer need '2' in them. Also fixes minor misspelling in event.h. BUG=none TEST=test only/documentation changes Change-Id: Id8133edf1d1f398157a3fb00279bc1418f58b036 Reviewed-on: https://chromium-review.googlesource.com/1159469Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580046}
-
Alan Cutter authored
This CL is a refactor and has no behavioural changes. OpaqueBrowserFrameView::trailing_button_start_ is an x coordinate relative to the right edge of the window title bar. This CL replaces trailing_button_start_ with available_space_trailing_x_ where available_space_trailing_x_ == host->width() - trailing_button_start_. available_space_trailing_x_ represents the same x position as trailing_button_start_ except it's relative to the left edge of the titlebar (0). The name "button_start" has been replaced with "available_space_*_x" as it's used for more than just button elements and now represents a typical x co-ordinate. This refactor is intended to support https://chromium-review.googlesource.com/c/chromium/src/+/1156117 by making HostedAppButtonContainer::LayoutInContainer() less cumbersome to use in OpaqueBrowserFrameViewLayout. Bug: 854479 Change-Id: Iff1c29139cd4c8c66286db85fce85b99c94c5261 Reviewed-on: https://chromium-review.googlesource.com/1158313 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#580045}
-
Pavel Feldman authored
Change-Id: I28d083c3dbb6bacb7d8252eaa32c033a310a4124 Reviewed-on: https://chromium-review.googlesource.com/1157212 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
Trent Apted authored
The shared, unittest_util.js optionally overwrites some vars specified by externs that may or may not exist in the unit test. Suppress the warnings around these. Bug: 867700, 860355 Change-Id: I461ed7921e7d454869d8e64de8c0eeeb626e4af7 Reviewed-on: https://chromium-review.googlesource.com/1154774Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580043}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3c868f436bc0..0a1917f0efb7 git log 3c868f436bc0..0a1917f0efb7 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 treehugger-gerrit@google.com Merge "Fix scoped metatrace events" Created with: gclient setdep -r src/third_party/perfetto@0a1917f0efb7 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iffc859ebf2856d589a4b82ce0f61a3bd3ba90174 Reviewed-on: https://chromium-review.googlesource.com/1159422 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580042}
-
Hiroshige Hayashizaki authored
This CL checks worker global scopes' URLs (self.location) in the cases where worker top-level scripts are intercepted by ServiceWorkers. The test failure introduced in this CL will be fixed by https://chromium-review.googlesource.com/1153598. Bug: 861564 Change-Id: Ia92e1de697b5b9c6a61ab8e5c5abcaaf6dcee777 Reviewed-on: https://chromium-review.googlesource.com/1157220Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#580041}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a9c4581..e41c89b3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33021dad9a07ab61cffbcee9f8826db2be5c79ea Reviewed-on: https://chromium-review.googlesource.com/1159322Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580040}
-
Johannes Henkel authored
This consolidates the fields a bit; enabled_, suspend_, and show_size_on_resize are now used directly. Change-Id: I900203ee912946945e5242c667bd3ed8976c61a3 Reviewed-on: https://chromium-review.googlesource.com/1159472Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 860069 Change-Id: Ifa72a55db0f15050bb115a6f50c319124ec367ed Reviewed-on: https://chromium-review.googlesource.com/1155929 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580038}
-
mrefaat authored
Created CRWWebStatePolicyDecider delegate. Created WebStatePolicyDeciderBridge. Created CRWTestWebStatePolicyDecider (fake test class). Added unit tests for the newely created delegate/bridge. This will be required by PreloadController as it's an objective-c class and i'm going to make it a WebStatePolicyDecider (as part of effort to move any logic related to app launching out of the CRWWebController. Bug: 674991, 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e17d4d23fc4960609a19708148baa73381983c8 Reviewed-on: https://chromium-review.googlesource.com/1157135Reviewed-by:
-
Shu Chen authored
Bug: 867084 Change-Id: I1a667b8c54d8f111dbe00a2b398fb99f1527aa0b Reviewed-on: https://chromium-review.googlesource.com/1157741Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580036}
-
Yutaka Hirano authored
With out-of-blink CORS, CORS errors for XHR are displayed in ResourceLoader, which brings flakiness to open-in-body-* tests, because Resource and ResourceLoader continue working a while after ThreadableLoader::Cancel is called, because of the async cancellation mechanism in ResourceLoader. These tests make ill cross-origin requests, and then abort them (by calling open() of the same XMLHttpRequest object) after that. When a response arrives befor the cancellation is performed but after async cancellation is started, then we see a console log of a CORS error for an aborted XHR. Let's have such tests use testharness.js instead of js-test.js so that such console errors don't affect the test results. Bug: 736308 Change-Id: I680ce2997a6c10e06368db8a89d789534c47097d Reviewed-on: https://chromium-review.googlesource.com/1156329 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3b7ec2e911a..f5cf02ac2c4a git log d3b7ec2e911a..f5cf02ac2c4a --date=short --no-merges --format='%ad %ae %s' 2018-08-01 qingsi@google.com Use randomly generated IDs for candidate pairs in ICE event logs. Created with: gclient setdep -r src/third_party/webrtc@f5cf02ac2c4a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6104e504fe4e42b17832e6611f8fa676e02e6a24 Reviewed-on: https://chromium-review.googlesource.com/1159243Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580034}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 920c0ed0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox jsbell@chromium.org: external/wpt/resources TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6433e90e488c393e62a31da83513b0a5080bcd9e Reviewed-on: https://chromium-review.googlesource.com/1159331 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580033}
-
Avi Drissman authored
NSPopUpButtonCell in Mojave calls through the parent view at all times, even during destruction. Work around this by properly scoping the lifetime of the NSPopUpButtonCell in MenuButton, which is something we weren't able to do in 10.5 but that was fixed in 10.6 but that we never got around to updating. BUG=869844 Change-Id: Iaecd978bc410810f02276f21ba13dd20ca73b195 Reviewed-on: https://chromium-review.googlesource.com/1159191 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580032}
-
