- 12 Apr, 2018 40 commits
-
-
Koji Ishii authored
Following bot results are included. 4732 4734 4735 4739 4741 4744 4747 4749 4750 4751 2 lines were removed and 5 lines were deflaked by consecutive results since 4675. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iee39d2d76cdf36b7f36646f7734de5f49809b740 Reviewed-on: https://chromium-review.googlesource.com/1006236 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#550053}
-
Kurt Horimoto authored
This is patch 3 of a 3-way patch, and must be landed after crrev.com/c/981777 and crrev.com/i/595643. Additional cleanup occured downstream in crrev.com/i/602658 Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iae4ce1a4d9055fa6e8f7a328872be1ca51fcf49e Reviewed-on: https://chromium-review.googlesource.com/998444Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#550052}
-
bsheedy authored
Replaces a flaky check in xr_frame_provider with an early return since it's a valid state to be in, e.g. when exiting presentation. Bug: 831243 Change-Id: Ie506095b5b5a1083ad669a000857a70b40f42a60 Reviewed-on: https://chromium-review.googlesource.com/1007622Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550051}
-
Marina Ciocea authored
This implementation is not use yet, the start_recording_callback constructor parameter will be passed from ContentAudioStreamFactoryClient to enable tab UI recording indicator. The connection_erorr_callback will notify ContentAudioStreamFactoryClient when the stream is destructed. Design: http://drawings/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk Bug: 803102 Change-Id: Ic57324f761389fa38e2618f541024e5caf49ff82 Reviewed-on: https://chromium-review.googlesource.com/980977Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#550050}
-
Hirokazu Honda authored
BUG=b:76445849, chromium:828119, chromium:828482 TEST=jpeg_decode_accelerator_unittest and video_encode_accelerator_unittest on StoneyRidge device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifa61026390fe31e88e0929257a521745e9a72fad Reviewed-on: https://chromium-review.googlesource.com/983334 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#550049}
-
Illia Martyniuk authored
Moving observer calls a bit up in the code so we don't miss hierarchy events. We could miss them if |parent_source| is nullptr and we return from the function earlier than events are sent. Sorry for not catching this earlier. Bug: 816802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic72e1b1553df6883540c97ff2cead2240fef7c13 Reviewed-on: https://chromium-review.googlesource.com/1008404Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Illia Martyniuk <illiam@google.com> Cr-Commit-Position: refs/heads/master@{#550048}
-
https://pdfium.googlesource.com/pdfium.git/+log/6bebd2e3cfb7..87b67f842fe5 $ git log 6bebd2e3c..87b67f842 --date=short --no-merges --format='%ad %ae %s' 2018-04-11 tsepez Remove CFX_DIBAttribute::m_strAuthor 2018-04-11 hnakashima Fix crash when ColorSpace references itself directly. 2018-04-11 tsepez Fix issues with PDFium third_party/base/span.h 2018-04-11 tsepez Remove use of GetBuffer()/ReleaseBuffer() when c_str() is sufficient. 2018-04-11 tsepez Make cxfa_fmlexer.cpp resilient to null strings 2018-04-11 tsepez Fix trailing whitespace handling in CPDF_StreamParser::ReadInlineStream() 2018-04-11 rharrison Reserve space to reduce memory operations while encoding barcode 2018-04-11 rharrison Add documentation about Valgrind LLD workaround Created with: roll-dep src/third_party/pdfium BUG=chromium:828206,chromium:831498,chromium:802242,chromium:830706 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7134510b37a0aab373bdff663020825afe63436f Reviewed-on: https://chromium-review.googlesource.com/1008962Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550047}
-
Sarah Hu authored
Add utility method FilterDeviceList in device/bluetooth/chromeos to filter the devices before updating in bluetooth UI. Extension change is in a separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/1004414/ Design doc: http://go/cros-bluetooth-filtering Bug: 817599 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a5cfb2ecdacbbe633770bb0c59b2e914b4e4b1f Reviewed-on: https://chromium-review.googlesource.com/999014 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550046}
-
Alan Cutter authored
This CL updates the way hosted app windows pick title bar colors while a theme color is set on chromeOS. This aligns the behaviour with Android, see: https://codereview.chromium.org/1956803002. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=329991&signed_aid=3q0FM93vRJrPJV7kMinOTw==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=333012&signed_aid=VNXQQhjxyzYYyg36S3nnOQ==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=330203&signed_aid=DoC1IRqCuP659D2dMoL1_Q==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=333244&signed_aid=J5yNTnY4-7RqGeYu32N8OA==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=333245&signed_aid=VOf6afQMQJbCApYu21wmyw==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=333257&signed_aid=OJzGQyVnXzCfXF6bZ16TCg==&inline=1 https://bugs.chromium.org/p/chromium/issues/attachment?aid=333258&signed_aid=jygsmXqxXfoPsPZXb_gqfg==&inline=1 Bug: 814121 Change-Id: I10a2e837d0c8a938072171715119a04c28e4f36a Reviewed-on: https://chromium-review.googlesource.com/999213 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#550045}
-
Tom Anderson authored
Verdana is NOT metrically-compatible with Arimo, but it is chosen as the replacement since they are both from the Sans family. In all of the layout test deltas, it appears the choice of Verdana was purely coincidental, so it should be safe to switch to Arimo. BUG=787020 Change-Id: Id8c82888b2e844e35200d20532b88d87066792bc Reviewed-on: https://chromium-review.googlesource.com/1006221Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550044}
-
Xiaoqian Dai authored
Bug: 825034 Change-Id: Iba0493cdf2b0edc1c52c919f2e13ba62f2ed1487 Reviewed-on: https://chromium-review.googlesource.com/1008415Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#550043}
-
Yuri Wiitala authored
Adds the new audio::GroupMember implementation to provide muting and snooping functionality to audio::OutputController. Bug: 824019 Change-Id: Ib21eccf43d4f6994657731545ceb3f4218c18cbe Reviewed-on: https://chromium-review.googlesource.com/1001512 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#550042}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5888d6f67672..7e9e2c82bdf1 $ git log 5888d6f67..7e9e2c82b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ica9d5e07ba3b181009f0c2581a682097cadba89f Reviewed-on: https://chromium-review.googlesource.com/1008418Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550041}
-
Tsuyoshi Horo authored
After this CL, SignedHTTPExchange related errors will be shown in DevTool's console. Screenshot: crbug.com/830505#c3 Bug: 830505 Change-Id: Icfc184d98ca2bb1f83e378c596b8b73f4da8a1b6 Reviewed-on: https://chromium-review.googlesource.com/1004880 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#550040}
-
Michael Thiessen authored
This reverts commit 30b94a8a. Original change's description: > Revert "VR: Clean up WebVR headset insertion." > > This reverts commit f2ccbfd1. > > Reason for revert: Speculative revert for crbug.com/831589 > > Original change's description: > > VR: Clean up WebVR headset insertion. > > > > This CL makes it explicitly clear when we care about whether the page > > was listening for activate before pause, and when we should autopresent > > on entering VR (for headset insertion). > > > > This also removes the workaround in vr_display_impl that allowed pages > > without focus to handle displayActivate, favoring handling this case > > more correctly in VrShellDelegate. > > > > Bug: 829513 > > Change-Id: Ie19c55305d0c59ec3f576010ded0f61ae906a084 > > Reviewed-on: https://chromium-review.googlesource.com/1004927 > > Reviewed-by: Yash Malik <ymalik@chromium.org> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#549736} > > TBR=mthiesse@chromium.org,ymalik@chromium.org > > Change-Id: I92a56254e933381770a56495553facfbcb2e5c59 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 829513 > Reviewed-on: https://chromium-review.googlesource.com/1007374 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549886} TBR=bajones@chromium.org Change-Id: I84fa5bd2f187859770166c1a3c79387492b50df1 Bug: 829513 Reviewed-on: https://chromium-review.googlesource.com/1007922Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#550039}
-
David Reveman authored
This adds two new events to aura_output interface that makes it easier for clients to calculate an ideal contents scale. This also adds a new request that can be used to set a unique application ID for a surface. The application ID identifies the general class of applications to which the surface belongs. The compositor can use this to group multiple surfaces together. For example, "org.chromium.FooViewer". Note that the application ID set here takes precedence over the app id set through XDG shell interface. To keep it simple, we just remove the implementation of xdg surface set_app_id. If that turns out to be useful in the future, then we can always re-implement that and make it available as an alternative ID. Bug: 824449, 791672 Test: wayland_client_info Change-Id: I3219cedbd7d9ce65e73ca33127ea976acc8c4163 Reviewed-on: https://chromium-review.googlesource.com/1008664Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550038}
-
Sadrul Habib Chowdhury authored
UpdateRootWindowSizeInPixels() should always use the pixel-bounds it already knows about. So it does not need to take any input params. Fix extension-shell to use SetBoundsInPixels() instead, because that's the correct way to set the size of the host (which would automatically update the size of the root-window etc.). BUG=821987 Change-Id: I31d0e5fa21471192aab5c462f79a1b1906ec23ac Reviewed-on: https://chromium-review.googlesource.com/1006491 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#550037}
-
https://chromium.googlesource.com/catapult.git/+log/a22719853354..cc64c0d81aab $ git log a22719853..cc64c0d81 --date=short --no-merges --format='%ad %ae %s' 2018-04-10 simonhatch Dashboard - Fix stats being generated in some cases 2018-04-11 eakuefner [TBMv2] Add HAD_FAILURES diagnostic and use it to avoid merging 2018-04-11 agrieve device_utils.PushChangedFiles: Fix caching logic when pushing files 2018-04-09 ulan Reduce noise of memory metric. Created with: roll-dep src/third_party/catapult BUG=chromium:831388,chromium:826384 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I4216dad219b5d0fdaf0af49063866dae9fe9bba8 Reviewed-on: https://chromium-review.googlesource.com/1007325Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550036}
-
Mitsuru Oshima authored
*) remove zero_top_border_height_ hack. a) Always use fullscreen_visible_fraction_ in HeaderView::GetPreferredOnScreenHeight Cleanup the debug code that I accidentally included in other CLs. NonClientFrameController doesn't have use immersive in tablet behavior, os I left it as is. Browser frame already uses immersive condition to compute the height, so no changes in browser frame code. BUG=b/33693796 TEST=no functional change except for a) above. a) is covered by unittests. Change-Id: Iae7c236426216a3c251de8e40a5ecd69831c0635 Reviewed-on: https://chromium-review.googlesource.com/999967Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550035}
-
Fumitoshi Ukai authored
Bug: 831451 Bug: 831046 Change-Id: I6d48e0e245c0d8c3fd3a505b9eaa6f542192457e Reviewed-on: https://chromium-review.googlesource.com/1006455Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#550034}
-
rbpotter authored
Add GDPR text to the local discovery and Print Preview flows for registering and accepting cloud printers, respectively. Bug: 826591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4ed895c9b5db992dcd64cdcfc86206860d896739 Reviewed-on: https://chromium-review.googlesource.com/1005571 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550033}
-
Marina Ciocea authored
Cleanup double StopMonitor and unnecessary condition, leftover from mouse listener removal in https://crrev.com/2577573002. Bug: 828864 Change-Id: Ia19c5bf4f81897f49b1c0eaf0f6d85a9cfff4984 Reviewed-on: https://chromium-review.googlesource.com/1007194Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#550032}
-
Sadrul Habib Chowdhury authored
Reset the size of the viz::Display directly to the original size, instead of triggering a size-change in the layer-compositor (cc) too, when a resize operation ends without actually resizing the window on Windows. BUG=821987 Change-Id: I97c6e76fd52b46d782a172fc54bb7cf9a0e0a1d6 Reviewed-on: https://chromium-review.googlesource.com/1006518Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#550031}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fc27a8d6..12316632 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Notry=true Change-Id: I6c9f652575f7874eb67c82d56eb864a3a14dc7df Reviewed-on: https://chromium-review.googlesource.com/1007762 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#550030}
-
Jialiu Lin authored
In case enterprise admin forgets to set the enterprise name, Chrome will show generic warning text without specific enterprise name. String doc: https://docs.google.com/document/d/1A4vVFzhdW3HKyE2uFQIPBy12cpYBxdaW3_rbh9vZxyM Bug: 824500, 824502 Change-Id: I0917c7ca90d63a2a8746bffd2c4beeeab4f61106 Reviewed-on: https://chromium-review.googlesource.com/1008737 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550029}
-
Jialiu Lin authored
Bug: 804490 Change-Id: Iddcabbbd50a7a37da4bdc4d2df8fddc1a25fad0b Reviewed-on: https://chromium-review.googlesource.com/1005812Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#550028}
-
dpapad authored
Previously the code assumed that just listening on the 1st occurrence was enough, but it turns out that later occurrences can happen and need to be handled. Bug: 831489 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic06287ca755a32a86e5bd0429c0695073753cefe Reviewed-on: https://chromium-review.googlesource.com/1008064Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550027}
-
Robert Sesek authored
This should make the parser more robust by joining the can-consume checks with the actual input byte consumption, preventing the internal parser state from becoming inconsistent. Bug: 489301 Change-Id: I33a0f5d9c5daa0b0ad186570393ceaf8fdba8a70 Reviewed-on: https://chromium-review.googlesource.com/1005675 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#550026}
-
James Darpinian authored
Bug: 696345,818383,820639 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaacb3bbaf738e994ea6caaad7b83c5a8bbf8e964 Reviewed-on: https://chromium-review.googlesource.com/993393Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#550025}
-
Xiaocheng Hu authored
We should use "bidi" as abbreviation of "bidirectional", but mistakenly used "BiDi" in some senarios. This results in LocalCaretRectBiDiTest.cpp being renamed into local_caret_rect_bi_di_test.cc in the great Blink mv. This patch fixes the naming issues. Change-Id: I391c1ffa7feca9fd78974669f082effb1195c043 Reviewed-on: https://chromium-review.googlesource.com/1008608 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#550024}
-
Devlin Cronin authored
ChromeManifestTest.StorageAPIManifestVersionAvailability tests that the chrome.storage API is not available to manifest v1 extensions. This behavior is now enforced (and much more thorouhgly tested) through the features unittests. Remove the test. Bug: 816679 Change-Id: I8e313127cd43885fab8b49a9a3acfb58dbf2d4c9 Reviewed-on: https://chromium-review.googlesource.com/1007624 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550023}
-
Matt Giuca authored
Caused by r549433, which swapped the initialization order of the AppMenu and AppMenuModel. By constructing the AppMenuModel first, the old one was being destroyed, being outlived by its AppMenu (holding a raw pointer). Adds a reset(), ensuring the AppMenu is destroyed first. Bug: 831504 No-Try: true Change-Id: I3d155b11aa2490537fc6baa9fbbf2bdb057e8090 Reviewed-on: https://chromium-review.googlesource.com/1006739 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#550022}
-
Ken Rockot authored
Switches ArrayBuffer and raw encoded message data mojom representations to use BigBuffer instead of array<uint8>. This avoids large message data exceeding hard size limitations. Also introduces BigBufferView as a traits helper to avoid redundant copies when a deserialized BigBuffer is using inline array storage. Bug: 829659 Change-Id: I8b62d4bcd7458db1d6aff9e22dcb7c13999f0bf0 Reviewed-on: https://chromium-review.googlesource.com/1004594 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550021}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, there are some UI specific variables that have to be stored (across tray bubble lifetime). * The tray bubble should keep the expanded/collapsed state when it's reopened. * Brightness slider's value have to be cached. This CL creates UnifiedSystemTrayModel to store these variables, which is owned by UnifiedSystemTray. TEST=manual BUG=825670 Change-Id: I56a285d4fa6c334ccafe114c9664ac42900a6696 Reviewed-on: https://chromium-review.googlesource.com/1006134 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550020}
-
Istiaque Ahmed authored
CL d06a2579 stopped using populating |params_| and started using local variables instead. However, one reference to |params_| still remained that is causing null pointer access. Fix this and also remove all bluetooth APIs' params_ where they are currently never used. Add a regression (unit) test as well, along with a small sanity test. Bug: 831651 Test: See bug for repro steps. Change-Id: Ic2df916bb7175563e21c816890bac1c8624d334f Reviewed-on: https://chromium-review.googlesource.com/1008065Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550019}
-
dpapad authored
Bug: 771795 Change-Id: Ie6aa2ede841a29f1e68e29ae1e3bd832abdb28b8 Reviewed-on: https://chromium-review.googlesource.com/1008069Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550018}
-
Chris Hamilton authored
Upcoming session restore changes will defer loading tabs that are beyond a certain age. This will inform the choice of that threshold. BUG=749785 Change-Id: Ic114ee156d69373eda0fee4ccfd46570883320a2 Reviewed-on: https://chromium-review.googlesource.com/1002994 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#550017}
-
Wenzhao Zang authored
Because the factory already adds 7 days to the actual date, the threshold should only add 7 days to rlz_embargo_end_date. Bug: 820783 Change-Id: I97a599b2f893493ac91910f449051ec5a0ea7807 Reviewed-on: https://chromium-review.googlesource.com/1007962Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550016}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iebc614d457e93e7ce4abbac6fb11f92313525ea4 Reviewed-on: https://chromium-review.googlesource.com/1006522 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550015}
-
Xianzhu Wang authored
If an overflowing visual effect has sub-pixel geometry and is painted with anti-aliasing along pixel-snapped border box, the pixel-snapping may cause the anti-aliased edge overflow the calculated visual rect. Let LayoutBox::VisualRectOutsetForRasterEffects() return 1 if there are any sub-pixel visual effect outsets to ensure the visual rect covers all pixels. Bug: 827516 Change-Id: I48f8350fb2124d002333a4cc76486c63ca55f8c9 Reviewed-on: https://chromium-review.googlesource.com/1003492Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#550014}
-