- 23 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91ad80de0e11..1315d1d2d5a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bsep@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bsep@google.com,mohsen@google.com Change-Id: I74c32f2f93ab8660ff15ee6f8116a9639b746be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495381Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820323}
-
Lukasz Anforowicz authored
Bug: 1080832 Change-Id: I4ff90e0040dfba8a2432d51f4f3dcdd7aa2e7f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495505 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#820322}
-
Mohamed Adel authored
On macOS versions running versions below 10.10 images did not conform to NSSecureCoding protocol. Now that Chrome only supports macOS 10.10+ this check is unnecessary. Bug: None Change-Id: Ief414b6e6e7f183b2e9e2b5065231579b92578e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494873Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#820321}
-
Jonathan Ross authored
On Linux AMD ES3MapBufferRangeTest.ReadPixels has begun failing consistently reporting errors from the drivers. A device reboot did not resolve this. This change skips the test on that configuration while we look into the root cause. TEST= gl_tests_passthrough ES3MapBufferRangeTest.ReadPixels Bug: angleproject:5213 Change-Id: I8a25c357d8eeea7bd6dc17023402bc84a6309e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495042Reviewed-by:Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#820320}
-
danakj authored
a.Then(b) will return a new callback that when Run() will 1) run |a| 2) run |b|, passing it the return value from a 3) return the result from |b| OnceCallbacks must be destroyed when joining them together with Then(), so the method is rvalue-qualified. This means it is used in the same way as Run(), for example, this function posts two callbacks to run together as a single task: void PostTwoTasks(base::OnceClosure c1, base::OnceClosure c2) { PostTask(std::move(c1).Then(std::move(c2))); } RepeatingCallback can be joined destructively via the rvalue-qualified overload, or non-destructively otherwise. The latter is allowed for a RepeatingCallback because it is meant to have multiple callers and therefore having both the original callbacks and the joined callback pointing to the same underlying functor is not problematic. R=chrisha@chromium.org, gab@chromium.org Bug: 1140582 Change-Id: Ie147f01d1c8adeb5ed34e4933f211e7d247e3c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485642 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820319}
-
chrome://webapksElla Ge authored
The page does not load because failing the trusted type policy. Removing import "strings.m.js" since we are not using it. Bug: 1141097 Change-Id: Ief36638834ac481f1da6ce98c94c6c60308f54c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492890Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#820318}
-
Patrick Monette authored
Bug: 1077217 Change-Id: Ie0081edc73c8b8ed0669c0aacaad9ccbb2ead003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490800Reviewed-by:
-
Vikas Soni authored
Bug: 1037760 Change-Id: Ie4043cc704a59da892638d07335080f47fe26ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469217 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#820316}
-
Muyao Xu authored
This CL moves mock_logger.* from chrome/browser/ to components/ so that it can be reused by mirroring service tests in components/ directory. Mirroring service tests will be changed in a later CL. Bug: b/165366974, 1117673 Change-Id: I225de779b0caa476fd253b56e0ecc10f16e13688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482092Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#820315}
-
Bailey Berro authored
This change creates the DiagnosticsManager class which is responsible for managing the lifetime of the various services used by the Diagnostics SWA. DiagnosticsManager will be owned by the SWA's MojoWebUIController and is brought up and torn down when the app is opened/closed. Bug: 1128204 Change-Id: Ie9be65e3d6ab74aa4037cc1e916cdbd3f2981da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492641Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820314}
-
Lindsay Pasricha authored
Bug: 1121185 Change-Id: I7f4d0a0517f7286c120c0dd114d48da90488bd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493047Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#820313}
-
Tim Volodine authored
The test is flaky on Lollipop, i.e. on the "Lollipop Phone Tester" bot. BUG=1141889 TBR=arbesser@chromium.org Change-Id: I7bf333a73e5af9a46fcac6ac8f12e72cf76954a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494890Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#820312}
-
arthursonzogni authored
There are no real reasons for COEP not to be enforced on Android WebView. See also: [PSA-COEP-expanded-to-webview]: https://groups.google.com/a/chromium.org/g/blink-dev/c/Wc_uYYkcviw [Updated chrome-status entry]: https://chromestatus.com/features/5642721685405696 [original-intent-to-ship-coep]: https://groups.google.com/a/chromium.org/g/blink-dev/c/XBKAGb2_7uA/m/ajpc6_9zAAAJ [crossOriginIsolated spec to be updated]: https://github.com/whatwg/html/issues/6060 Bug: 1140432 Change-Id: I9a7c44671846f20bd0ac2a06b181ed584ad606eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485507Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820311}
-
Chong Gu authored
Keep bounds we are given instead of only keeping the size. Allows tests requiring this information to pass. Create allow_null_view_token_for_test, which allows tests to create a view themselves. Change-Id: Icab59c3d622537d5651c128a6c9572c667187338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462241Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#820310}
-
Avi Drissman authored
macOS Big Sur lies about its version number to apps built with SDKs earlier than the 11.0 SDK. We already have code (daad98ce) to undo that lie for version functions that return numbers, but the version functions that return a human-readable string were still lying. Set SYSTEM_VERSION_COMPAT to fix the lie of that string. SYSTEM_VERSION_COMPAT alone is not adequate; it has no effect on tests that do not share that Info.plist and that we do not go through the trouble of giving Info.plists because they are not bundled. But at least for the Chromium app launched by Launch Services we can improve system version number display. Fixed: 1141569 Bug: 1108832 Change-Id: If064037bbb27ad42198bdebaf687e90e526e8751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495266 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820309}
-
dpapad authored
As of r820148 the PRESUBMIT is tripping on bogus grd files only used for the purposes of testing. With the following error: [Errno 2] No such file or directory: u'/../ui/webui/resources/tools/tests/foo_resources.grdp' Fix by explicitly ignoring such grd files from the PRESUBMIT checks. Bug: 1132403 Change-Id: I4a8b1f2b69c7bec6e26bf7a1a0790969d1b57bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495320 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Daniel Cheng authored
AbortClientNavigation() resets the navigation client message pipe, so it is impossible to be in a state where the navigation client message pipe is still connected but the commit should be ignored. Unfortunately, this doesn't mean that the race previously fixed in https://crbug.com/763106 is gone. It just means that the browser process can send a CommitNavigation() that the renderer will never hear about because the renderer's endpoint is already gone. There is one tricky case with CommitNavigationWithParams(), which previously also checked if the commit should be ignored. This method is asynchronously called by MHTMLBodyLoaderClient when the MHTML archive body is fully loaded. However, since MHTMLBodyLoaderClient is reset with the same timing as the navigation client message pipe, this turns out not to be a problem in practice. Bug: 1020175 Change-Id: I3a8dc816030071a30f315ebc62a819ef3cde143a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493669 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820307}
-
Wei Li authored
DismissButton is only used within one file and the button instance is set to always focusable. This CL moves the focus behavior setting directly into the class so it is clearer that this kind of button should be always focusable. Bug: 1001103 Change-Id: I6d2f8c59815170b19da776b029ba474fde8c03f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493088Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#820306}
-
Maya Lekova authored
This CL uses the fallback mechanism available for fast API calls in V8 for the WebGL methods bindTexture and bindBuffer, which are known to check error conditions and throw JS exceptions in case of errors. Bug: chromium:1052746 Change-Id: I8c2e8ce7e152977ec3ace0827a102eae73d4151b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465849Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#820305}
-
Ken Rockot authored
This changes mojo::Wrap/UnwrapPlatformFile to use base::ScopedPlatformFile instead of raw PlatformFile values. In the process, this fixes potential file descriptor leaks in chromeos_camera code. Fixed: 710376 Change-Id: Id86db91695bf3a6e87e210c2226739dbc9d8fa01 Tbr: lamzin@google.com Tbr: drubery@chromium.org Tbr: rakeshsoma@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491545Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Bug: 1047547 Change-Id: Ia3de37aad0f0a004a14bd9311f658d0b78ae22ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494780Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820303}
-
Etienne Bergeron authored
This CL is moving the libspeech synthesizer code to a worker thread. This CL is splitting the logic in two parts. The first part is the control logic which stay on the UI Thread. The second part is the synthesizer logic which is running on a worker thread. Bug: 869399, 1133813 Change-Id: I212f58ff94e5deac7950e206e4aac484d285f0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488045 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#820302}
-
Mehran Mahmoudi authored
This addresses a bug where preview sticks around forever when there is no internet connection and an offline version of the page is available. We should remove the preview and display the offline version when one is available. Bug: 1141086 Change-Id: I3b4ca2481899c3dd8fea5a3cb46ee7da140d15bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490268Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820301}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/58cf3fe83b93..15d8174fc944 2020-10-23 johnstiles@google.com Add unit test for self-referential initializer expressions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I8422d091ba31fbbe5d65cf03f6628b0f78b83ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820300}
-
Maksim Moskvitin authored
Passphrase type is an important setting, that should be not downgraded even in case of data corruption. This patch changes the behavior of NigoriSyncBridgeImpl in a way it checks not only |encryption_keybag| emptiness, but also that |passphrase_type| is the default one (i.e. IMPLICIT_PASSPHRASE). Bug: 1141410 Change-Id: I1329fc3cdb4d89b73b8620db8bf389d7dd38e00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494810Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#820299}
-
Philipp Hancke authored
asserting that a media type which is not understood is still kept in the answer. Bug: webrtc:3513 Change-Id: Ice96c09d7d1990dba677095fe882aab0fbe1a91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270180Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#820298}
-
Mohammad Refaat authored
There is only 1 pre-render service per BrowserState which makes the last created BVC the delegate for the the pre-render service so when there are multiple windows, the last one created will provide the webState to be replaced to the service and the service will use that to get the navigation history which will be wrong in cases where the prerendered webstate is not on the last created window. As a work around pass the webstate to be replaced to the service Bug: 1139286 Change-Id: I5a8651ba1c52ecf9e0a9d2ea0a3a18c1e0afdfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486961Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#820297}
-
George Steel authored
When looping over transform animations in UpdateTransform, originally to check whether they preserve axis alignment, we also check for box size box size dependencies. If such dependencies are found, check whether the relevant sizes have changed (using a current value stored in the KeyframeEffect), and if so, restart the animation on the compositor (note that RestartAnimationOnCompositor is a no-op if the animation is not already composited). This makes composited relative transform keyframes (implemented behind a flag) fully working for CSS boxes, which could potentially be selectively enabled ahead of doing so for SVG. Design doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I9b8189a3f3e002902b5eec58c08bb54644039536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492893 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820296}
-
Peter Kasting authored
Bug: 772945 Change-Id: Iacbc74f727e4535ea1289b0fc7fe8d326dfe6501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490083 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Paul Moy authored
go/cros-scanning specifies that saved scanned images will use the format scan_[local timestamp]_[page number].png. Update scan service from the old format of scan_[local timestamp]_page_[page number].png. Also update the unit tests to make sure the file is being saved correctly. Bug: b:171512776 Change-Id: I22141319e0d1db79ff9f82da73d671327e015f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492926Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#820294}
-
Etienne Bergeron authored
This CL is fixing the errors while loading the tts_demo in recent chrome version. The demo is no longer working due to restriction with the sandbox policies. see: https://stackoverflow.com/questions/36324333/refused-to-execute-inline-event-handler-because-it-violates-csp-sandbox The previous JS code for the click/focus handlers were not executed since they are inlined handlers. Bug: 1133813 Change-Id: I2e6df706a1f43257a1a3e254ddb955fa000220a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490262 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
minch authored
Bug: 1131543 Change-Id: I5726d096eb6e18f25435c92b8ac26a01129d8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493780Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#820292}
-
Lan Wei authored
The pointerevent' spec has properties e.g. width, height, pressure..., so we are working on adding the pointerevent's properties to Webdriver Action API to simulate the inputs from devices such as touchscreen and stylus, which have these additional properties. This CL adds these properties to ChromeDriver's ExecutePerformActions. Bug: 1139172 Change-Id: Ic45f04d9e8c1d61a7f4e1fb867f701bf5c890af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488551Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#820291}
-
minch authored
See recorded video at https://drive.google.com/file/d/1hjHkN_gA7IMTTor6RehgF1mWMWkeLK9T/view?usp=sharing This cl doesn't include all the elements in system tray menu, more elements of it will be updated in follow up cls. Bug: 1131543 Change-Id: I3a395e529764ab4e23a51ea5066e3e105a502552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486781Reviewed-by:
-
Alexander Dunaev authored
The GPU info and config code has platform-specific bits which makes them impossible to use when Ozone is enabled. Platform-specific code must be in the platform. However, for the code in //gpu/config moving it down to platform code is problematic because of internal non-trivial types used in the component. For instance, gpu::GpuExtraInfo has some attributes defined only for X11 that should be handled at the platform level. However, currently giving it to the platform requires the platform to depend on //gpu/config which creates a dependency cycle. Here the gpu::GpuExtraInfo class is extracted into its own component, so external code can now use it. Bug: 1121945 Change-Id: I4ad166b43313d7e33e8e9f80e147a29b6eef5d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478362Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#820289}
-
Justin Cohen authored
Bug: 1140474 Change-Id: I264270edec37ffa425a1525af5a95a9e53009310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495005Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820288}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I3f8d3048ec07cdba7c0501454d09115322a32c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495044Reviewed-by:
-
Wenbin Zhang authored
Angle_perftests are now removed from perf waterfall on crrev/c/2491525. Now resharding to avoid empty shard on #0. Bug: chromium:1137628 Change-Id: I6fcc31c6689b1c6cbaf011a1f3bd9970d2ba092e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493146 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
Bruce Dawson authored
Chrome uses fibers to increase the size of its main thread's stack and this was found to cause shutdown crashes in some cases, deep inside msctf.dll and coremessage.dll. It turns out that avoiding these is as simple as deleting the fibers before quitting. There is still concern that these crashes were being missed, and it may be time to start exiting with TerminateProcess (which also solves the problem) but that is for another day. Aside: the proper cleanup functions for ConvertThreadToFiberEx and CreateFiberEx are not documented on MSDN and it is not obvious that they actually use different cleanup functions. The official examples don't bother cleaning up, but luckily this sample does: https://devblogs.microsoft.com/oldnewthing/20200602-00/?p=103819 Testing showed that it was the ::DeleteFiber call which was needed to avoid the shutdown crash, but both cleanup function calls were retained. Bug: 981238, 1141408 Change-Id: Ifb3d4dc4d0ea8728e203e654c53f105fca615c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493664 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820285}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010230700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/lEAXOymZqKYZxc3n_eeo68wecdG1sO1D9u__3SE-mwoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I6f6728d9fe195cf208103b1451eac5e5d9203f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495380Reviewed-by:
-
