GitLab

Review URL: https://codereview.chromium.org/1320213002

git-svn-id: svn://svn.chromium.org/blink/trunk@201432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201418

BUG=506669
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/1320853003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change allows multiple shortcuts for the same action to be shown
in the tooltip, allowing the user to understand different shortcut options
available.

Toolbar buttons can also have defined shortcuts, which record
in timeline and profiles use to show shortcuts.

Instead of showing a symbol for Esc on Mac, this change now shows Esc for the
escape key.

BUG=513066

Review URL: https://codereview.chromium.org/1273363002

git-svn-id: svn://svn.chromium.org/blink/trunk@201428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test added.

BUG=475629
R=yurys@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1306013004

git-svn-id: svn://svn.chromium.org/blink/trunk@201427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TBR=brucedawson

Review URL: https://codereview.chromium.org/1318333002

git-svn-id: svn://svn.chromium.org/blink/trunk@201426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is part II. (the Blink src repo.)

This feature is for ARM and mobile devices.
It's focused the power efficiency benefits
of texture compression, most of which come from reducing
the bandwidth needed for data transfers on the mobile device.

The ASTC compression is involved including reducing memory
footprint and loading time and even increase performance.

This implementation has been verified on the Galaxy S6.
I also plan to apply this feature on the Smart TV.

BUG=516672

Review URL: https://codereview.chromium.org/1265703005

git-svn-id: svn://svn.chromium.org/blink/trunk@201425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark the virtual/display_list_2d_canvas/fast/canvas/canvas-resize-reset
.html test as flaky/timeout on windows 10.

TBR=pdr@chromium.org
BUG=524804

Review URL: https://codereview.chromium.org/1321833002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move didFirstLayoutAfterFinishedParsing and didFirstVisuallyNonEmptyLayout
to WebWidgetClient, to signify that these are not [Web][Local]Frame-related,
but rather WebFrameWidget-related hooks.

R=dcheng,esprehn
BUG=521149

Review URL: https://codereview.chromium.org/1318283003

git-svn-id: svn://svn.chromium.org/blink/trunk@201422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If debugger happens to stop in Context of detached frame simply continue execution.

BUG=525657

Review URL: https://codereview.chromium.org/1307313005

git-svn-id: svn://svn.chromium.org/blink/trunk@201420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384104
TBR=dglazkov

Review URL: https://codereview.chromium.org/1304903008

git-svn-id: svn://svn.chromium.org/blink/trunk@201419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is another preparation CL for combining outline and focus ring
paths (https://codereview.chromium.org/1224933002/).

Not including the whole outline into visual overflow caused
incorrect layout and painting of outlines when the element having
outline has clipping or is composited because the overflow doesn't
cover the whole outline.

Not including outlines of block continuations into visual overflow
required us to
- propagate outline style to block continuations on style change;
- paint outlines for block continuations separately, causing
  unconnected or duplicated outline edges.
Both of the above caused complex code.

With this CL, we always include the whole outline into visual
overflow of the object having outline style.
- For LayoutBoxes, combine code paths about overflow for focus ring
  and outline;
- For LayoutBlockFlows, we need to include the visual overflow of
  descendant LayoutInlines having continuation and outline. Let the
  containing LayoutBlockFlow record LayoutInlines with outline and
  continuation, and include the outline rects of continuations
  into visual overflow of the block.

(FYI, cases that we already included outlines into visual overflow:
 - LayoutBlockFlow containing descendant LayoutInlines having outline
   but not continuation: we already included such outlines in visual
   overflow of InlineFlowBoxes and in turn into the LayoutBlockFlow;
 - LayoutInlines having outline: previously we include outlines by
   calling rectWithOutlineForPaintInvalidation(); with this CL we
   call addOutlineRects().)

This CL will have real effect with
https://codereview.chromium.org/1224933002/.

BUG=506669

Review URL: https://codereview.chromium.org/1278543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After setting display mode, css styles should be recalculated.

Before this patch, the new display mode value was taken into account as
soon as MediaQueryList::updateMatches() was executed (for example after
a call to window.matchMedia. But css media rules were not updated.

Review URL: https://codereview.chromium.org/1285703004

git-svn-id: svn://svn.chromium.org/blink/trunk@201417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ZYXDFeTdY6k/u-pBaVPuAQAJ

Spec proposal:
https://github.com/whatwg/notifications/pull/53

Part of a 3-sided patch:
1. this patch
2. https://codereview.chromium.org/1313363006
3. https://codereview.chromium.org/1313013006

BUG=507751

Review URL: https://codereview.chromium.org/1309273007

git-svn-id: svn://svn.chromium.org/blink/trunk@201416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fast/repaint/box-shadow-h and fast/repaint/box-shadow-v are identical,
so one of them should be removed. And the -h and -v don't mean anything,
so rename the remaining test. And the test is not a repaint test, so move
it to the right location.

R=pdr@chromium.org
BUG=344745

Review URL: https://codereview.chromium.org/1310053007

git-svn-id: svn://svn.chromium.org/blink/trunk@201415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add DeprecatedPaintLayer::needsRepaint flag to indicate the repaint
requirements of layers. The flags are checked and cleared in DPL::paintLayer().

BUG=410097
TEST=DisplayItemListPaintTestForSlimmingPaintV2.SubsequenceCache

Review URL: https://codereview.chromium.org/1294233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec [1], IndexSizeError should be thrown if:

"...the charnum is negative or if charnum is greater than or equal to
 the number of characters at this node."

This is what's implemented by IE, Gecko and Presto.

[1] http://www.w3.org/TR/SVG11/text.html#__svg__SVGTextContentElement__getStartPositionOfChar
    The current SVG2 draft has a different formulation:

     (https://svgwg.org/svg2-draft/text.html#__svg__SVGTextContentElement__getStartPositionOfChar)
     "If cluster is null, then then throw a DOMException with code
      INDEX_SIZE_ERR."

    but will have the same result.

BUG=391345

Review URL: https://codereview.chromium.org/1321783002

git-svn-id: svn://svn.chromium.org/blink/trunk@201411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SkImages that are backed by textures are being recorded into SkPictures that are rendered in multiple threads. This causes multiple threads to access the same Gr- and GL context, neither of which are thread safe.

This change was suggested by junov@chromium.org as a possible fix.

BUG=524717

Review URL: https://codereview.chromium.org/1310573007

git-svn-id: svn://svn.chromium.org/blink/trunk@201410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |localCaretRectOf()| function for |VisiblePosition| as
replacement of |VisiblePosition::localCaretRect()| to simplify |VisiblePosition|
class for ease of templataizing |VisiblePosition| class to introduce composed
tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::localCaretRect()| can be implemented with public member
functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1325443002

git-svn-id: svn://svn.chromium.org/blink/trunk@201409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525824

Review URL: https://codereview.chromium.org/1315633004

git-svn-id: svn://svn.chromium.org/blink/trunk@201408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=506525,502927,524134,525772
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/1323583002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some properties (text-overflow, -webkit-line-clamp) may cause us to
draw a truncated version of the InlineTextBox.  Since we're caching the
resulting text blobs, we need to also invalidate them whenever
truncation changes.

TEST=fast/repaint/text-line-clamp-truncation.html

BUG=525034
R=jbroman@chromium.org,eae@chromium.org

Review URL: https://codereview.chromium.org/1315353004

git-svn-id: svn://svn.chromium.org/blink/trunk@201406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To test our loading behavior we add a new framework of mocks for writing tests.
These allow simulating network responses in specific chunks so you can test how
the rendering engine reacts to having the content come off the wire. This
framework will be used to write future tests for various sub-systems as pages
are loading. Future loading/FOUC tests will check painting, layout and if frames
have been scheduled as well.

The test added in this patch writes html in chunks and checks that we only resume
pumping frames after the body has been inserted.

The test caught a bug in blink where we would resume commits when loading the
initial empty document because the document would insert an implicit <body>
calling into WebViewImpl::willInsertBody which then triggers a
resumeTreeViewCommits. This bug doesn't manifest when loading real tabs because
we always call resize(non-zero) after creating the WebView to set the initial
size. This then triggers a layout since the size is non-zero which then does
DeprecatedPaintLayerCompositor::didLayout and finally
enableCompositingModeIfNeeded which calls back into
WebViewImpl::setRootGraphicsLayer(nullptr) which then does setDeferCommits(true)
turning back on deferred commits. It looks like this bug may have manifested in
0x0 Android WebViews if they were created and then resized after they started
loading.

BUG=521692

Review URL: https://codereview.chromium.org/1313013005

git-svn-id: svn://svn.chromium.org/blink/trunk@201405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

suppressInvalidations just calls suppressCompositorScheduling, but that plumbing
doesn't go anywhere. Lets remove it.

R=ojan@chromium.org
BUG=521692

Review URL: https://codereview.chromium.org/1323523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These had to remain in place while a Chromium test got updated. This can
be safely removed entirely now.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1309723004/
  [2] https://codereview.chromium.org/1314893002/
  [3] This CL.

BUG=486040

Review URL: https://codereview.chromium.org/1316693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |{left,right}PositionOf()| function for |VisiblePosition|
as replacement of |VisiblePosition::{left,right}()| to simplify
|VisiblePosition| class for ease of templataizing |VisiblePosition| class to
introduce composed tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::{left,right}()| can be implemented with public member
functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1321033002

git-svn-id: svn://svn.chromium.org/blink/trunk@201402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we have logic to allow plugins to opt-in to persisting
when detached. This CL updates the logic to always persist when
we are doing a reattach. This allows us to remember the state of
things like Flash files as we reattach the DOM nodes.

The original persist CL (r196024) was reverted because it caused timeouts for:
  Reason: breaks the following browser_tests:
    WebViewTest.EmbedderVisibilityChanged,
    WebViewTest.GuestVisibilityChanged,
    WebViewTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent

  and the following extensions_browsertests:
    WebViewAPITest.EmbedderVisibilityChanged
    WebViewAPITest.GuestVisibilityChanged

This Cl removes the call to widget->dispose() in the HTMLPluginElement::attach
call which fixes this issue.

BUG=370459

Review URL: https://codereview.chromium.org/1284403003

git-svn-id: svn://svn.chromium.org/blink/trunk@201401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Push API defines that the subscription promise should be rejected
with a DOMException named PermissionDeniedError when no permission
has been granted.

https://w3c.github.io/push-api/#widl-PushManager-subscribe-Promise-PushSubscription--PushSubscriptionOptions-options

While this error code is not formally included in the registry, IDL
is not staffed, and guidance from the spec bug is to just start
using the new name.

https://www.w3.org/Bugs/Public/show_bug.cgi?id=23033

This CL is part of a three-sided patch:
  [1] This CL.
  [2] https://codereview.chromium.org/1316973002/
  [3] https://codereview.chromium.org/1313493003/

BUG=522206

Review URL: https://codereview.chromium.org/1314493008

git-svn-id: svn://svn.chromium.org/blink/trunk@201400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |absoluteCaretBoundsOf()| function for |VisiblePosition|
as replacement of |VisiblePosition::absoluteCaretBounds()| to simplify
|VisiblePosition| class for ease of templataizing |VisiblePosition| class to
introduce composed tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::absoluteCaretBounds()| can be implemented with public member
functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1308323004

git-svn-id: svn://svn.chromium.org/blink/trunk@201399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

getUserMedia is not yet fully spec compliant and should remain behind a flag, but MediaDevices.enumerateDevices does not have this problem.


BUG=504280

Review URL: https://codereview.chromium.org/1300833002

git-svn-id: svn://svn.chromium.org/blink/trunk@201398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=457273, 525975, 417181

Review URL: https://codereview.chromium.org/1322663003

git-svn-id: svn://svn.chromium.org/blink/trunk@201397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524875

Review URL: https://codereview.chromium.org/1309423003

git-svn-id: svn://svn.chromium.org/blink/trunk@201396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=496263
R=pfeldman

Review URL: https://codereview.chromium.org/1312893006

git-svn-id: svn://svn.chromium.org/blink/trunk@201395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL cleans up some discrepancies in the Web Notification module
and removes unused includes. Furthermore, it:

- Merges the ServiceWorkerNotifications and Notifications runtime
  enabled features. The SWN flag is not being toggled anywhere.
- Removes the notificationerror event from the Service Worker
  global scope. We have never supported this event.

BUG=

Review URL: https://codereview.chromium.org/1321453007

git-svn-id: svn://svn.chromium.org/blink/trunk@201394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |character{Before,After}()| function for |VisiblePosition|
as replacement of |VisiblePosition::character{Before,After}()| to simplify
|VisiblePosition| class for ease of templataizing |VisiblePosition| class to
introduce composed tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::character{Before,After}()| can be implemented with public
member functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320113002

git-svn-id: svn://svn.chromium.org/blink/trunk@201393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make updateSelectionForMouseDownDispatchingSelectStart() member function in SelectionController class private

This patch make |updateSelectionForMouseDownDispatchingSelectStart()| member
function for |SelectionController| as private for improving code health
since it is used only in |SelectionController| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1310683006

git-svn-id: svn://svn.chromium.org/blink/trunk@201392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Old code assumed that only one level of UA shadow tree
nodes should be excluded from event path, while it is
no longer true after introduction of shadow root
closed mode.

This change properly hides all the nodes behind closed
shadow root in the event path.

BUG=459136
TEST=event-path-closed-shadowroot.html, event-path-closed-shadowroot2.html

Review URL: https://codereview.chromium.org/1305733002

git-svn-id: svn://svn.chromium.org/blink/trunk@201391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1308633005

git-svn-id: svn://svn.chromium.org/blink/trunk@201390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |nextPositionOf()| function for |VisiblePosition| as
replacement of |VisiblePosition::next()| to simplify |VisiblePosition| class
for ease of templataizing |VisiblePosition| class to introduce composed tree
version of |VisiblePosition|, since an implementation of
|VisiblePosition::next()| can be implemented with public member functions of
|VisiblePosition| class.

Note: http://crrev.com/1310043003introduces |previousPositionOf()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1307803003

git-svn-id: svn://svn.chromium.org/blink/trunk@201389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test was timing out, it's not clear why but the code was fairly
complex. Simplify by avoiding messaging and just return the result in
the response to onfetch.

BUG=518985

Review URL: https://codereview.chromium.org/1311933003

git-svn-id: svn://svn.chromium.org/blink/trunk@201388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |lineDirectionPointForBlockDirectionNavigationOf()|
function for |VisiblePosition| as replacement of
|VisiblePosition::lineDirectionPointForBlockDirectionNavigation()| to simplify
|VisiblePosition| class for ease of templataizing |VisiblePosition| class to
introduce composed tree version of |VisiblePosition|, since an implementation of
|VisiblePosition::lineDirectionPointForBlockDirectionNavigation()| can be
implemented with public member functions of |VisiblePosition| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1324463002

git-svn-id: svn://svn.chromium.org/blink/trunk@201387 bbb929c8-8fbe-4397-9dbb-9b2b20218538