- 18 Jul, 2018 40 commits
-
-
Dominic Farolino authored
R=kinuko@chromium.org, peria@chromium.org, ricea@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 855968 Change-Id: I96be3b769dd75300553f639ca5fa8158771bde2c Reviewed-on: https://chromium-review.googlesource.com/1137930 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#576204}
-
Bence Béky authored
Bug: 862805 Change-Id: I327807a7ca854cf97986008ccd9482cd8ccaa1b2 Reviewed-on: https://chromium-review.googlesource.com/1141282 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#576203}
-
Chris Harrelson authored
for throttled subframes. needs_forced_compositing_update_ could have been set, in cases when a style update in a throttled frame caused destructive mutations of compositing state that must be cleaned up or result in stale pointers from cc. needs_forced_compositing_update_ forces off throttling for a frame up to the compositing step, for this reason. It is cleared during the compositing update step. This means that ShouldThrottleRendering may return true after this step when it returned false before. Bug: 859596,863427 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc4857b9f4a465f602e3bcc12a76e48d394a2689 Reviewed-on: https://chromium-review.googlesource.com/1141106Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576202}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc Reviewed-on: https://chromium-review.googlesource.com/1140717 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#576201}
-
Ned Nguyen authored
Bug: 621126 Change-Id: If111cc2b1f980f79362d5e52d101e915ae7ba6ef Reviewed-on: https://chromium-review.googlesource.com/1140927 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#576200}
-
Sergey Ulanov authored
This is a manual roll to bring us to the most-recent working SDK build. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio Change-Id: I1c614558bc5b3f2376537455d42fb705e5ce3dee Reviewed-on: https://chromium-review.googlesource.com/1141929Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576199}
-
Chase Phillips authored
Bug: None Change-Id: Id9a0356db01d1ad34ae82be263d42566c81c3871 Reviewed-on: https://chromium-review.googlesource.com/1141099Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#576198}
-
Tim Volodine authored
Improve error message when testWebViewIncludedStableInterfaces fails. Also add a guideline on how to potentially fix it. Previously there was some confusion on how to interpret the failure (see crbug.com/859141). Bug: 859141 Change-Id: I2ac1439ad164186142b16697e7378efb8a975629 Reviewed-on: https://chromium-review.googlesource.com/1127240Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#576197}
-
Roman Sorokin authored
Shows offline Gaia to sign in as an existing user when there is no network for Active Directory devices. BUG=chromium:864987 TEST=manual Change-Id: I0f80915788c96b6fd88e766dbe6526802ffe98e5 Reviewed-on: https://chromium-review.googlesource.com/1141867 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#576196}
-
Min Qin authored
This reverts commit 937dccc2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Fix an issue that ResourceDownloader was never deleted on download completion" > > This reverts commit 9faf0129. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Fix an issue that ResourceDownloader was never deleted on download completion" > > > > This reverts commit e0b12de0. > > > > Reason for revert: The Cl probably introduced flakiness in multiple download related tests (https://crbug.com/864922) > > > > Original change's description: > > > Fix an issue that ResourceDownloader was never deleted on download completion > > > > > > This CL calls the InProgressDownloadManager to delete ResourceDownloader > > > after response is completed. > > > It also fixes the issue when download is cancelled. > > > > > > BUG=864189 > > > > > > Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 > > > Reviewed-on: https://chromium-review.googlesource.com/1138676 > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#575882} > > > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org > > > > Change-Id: I669a69fc135547508b44ccc8150847cc5824b2ec > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 864189 > > Reviewed-on: https://chromium-review.googlesource.com/1141684 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575981} > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org > > Change-Id: I11012d0bf159f4944d69cc13881180db9ed98d7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 864189 > Reviewed-on: https://chromium-review.googlesource.com/1142171 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576190} TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org Change-Id: Ia2f90aa688078db7191cf9eeb59608619194a256 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864189 Reviewed-on: https://chromium-review.googlesource.com/1142305Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576195}
-
John Z Wu authored
//ios/web_view will use sync for autofill and password data in the near future. This is one of the many CLs needed for implementation. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I32c84aa7d5fd1836a99170741f525100dc0ac09c Reviewed-on: https://chromium-review.googlesource.com/1139182 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#576194}
-
David 'Digit' Turner authored
This CL introduces a new Python script providing various functions to make it easier to parse Android APK files for symbolization, i.e.: - ApkReader: convenience class to read the content of an APK, especially information related to uncompressed native shared libraries. Mostly useful because it can be easily mocked for unit-testing purpose. - ApkNativeLibrariesMap: convenience class to build a map of native shared libraries contained in an APK. - ApkLibraryPathTranslator: convenience class used to translate on-device APK file paths and offsets (as found in stack traces or tombstones) into a virtual device library path + offset. + Add unit-tests for all features. + Add a small apk_lib_dump.py script used to dump the list of uncompressed native libraries inside an APK and their file start/end offsets and sizes. This is mostly useful for debugging symbolization issues. NOTE: This is a partial rewrite of the corresponding code from the following patch, which shows how this will be used in the future to better symbolize tombstones: https://chromium-review.googlesource.com/c/chromium/src/+/1034054 BUG=755225 R=agrieve@chromium.org, jduborick@chromium.org, pasko@chromium.org, lizeb@chromium.org Change-Id: If71e0048fa88c859e5f256d8c960134b6b88d06f Reviewed-on: https://chromium-review.googlesource.com/1047211 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#576193}
-
Ian Kilpatrick authored
Every pass of the ExclusionSpace::Add loop invoked a copy of a shelf optimistically. This isn't needed for every pass, and only needed for the single pass where we are actually going to add the shelf. (there is potential to remove additional copies, but we'll see if that is needed later). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia7cdafc71bf0ea0c657763957ef8c5e0e0953382 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1140521Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576192}
-
Johann authored
Attempt to run 'git cl format' when updating configuration files. R=tomfinegan@chromium.org Change-Id: Ib78ac4df3f36361d72a2fa672a2382e68a5e188f Reviewed-on: https://chromium-review.googlesource.com/1142432Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#576191}
-
Min Qin authored
This reverts commit 9faf0129. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Fix an issue that ResourceDownloader was never deleted on download completion" > > This reverts commit e0b12de0. > > Reason for revert: The Cl probably introduced flakiness in multiple download related tests (https://crbug.com/864922) > > Original change's description: > > Fix an issue that ResourceDownloader was never deleted on download completion > > > > This CL calls the InProgressDownloadManager to delete ResourceDownloader > > after response is completed. > > It also fixes the issue when download is cancelled. > > > > BUG=864189 > > > > Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7 > > Reviewed-on: https://chromium-review.googlesource.com/1138676 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575882} > > TBR=qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org > > Change-Id: I669a69fc135547508b44ccc8150847cc5824b2ec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 864189 > Reviewed-on: https://chromium-review.googlesource.com/1141684 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575981} TBR=qinmin@chromium.org,shaktisahu@chromium.org,dullweber@chromium.org,xingliu@chromium.org Change-Id: I11012d0bf159f4944d69cc13881180db9ed98d7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864189 Reviewed-on: https://chromium-review.googlesource.com/1142171Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576190}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2c00841a55f..799e075abeea git log e2c00841a55f..799e075abeea --date=short --no-merges --format='%ad %ae %s' 2018-07-18 jmadill@chromium.org Replace D24_UNORM with a packed version. Created with: gclient setdep -r src/third_party/angle@799e075abeea The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iacddff49bd41e6cf52e6b788b12070ec5969deaf Reviewed-on: https://chromium-review.googlesource.com/1142007Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576189}
-
Lily Houghton authored
ConnectionTypeObserver is deprecated. This CL modifies AffiliationFetchThrottler to use NetworkChangeObserver instead. For more details, see the linked design doc in the bug below. Bug: 754695 Change-Id: I38b53ce245a74c19be41aab2558a9c3e7fc7b1d1 Reviewed-on: https://chromium-review.googlesource.com/1134019Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#576188}
-
Christopher Grant authored
This change makes the future introduction of a VR UI feature module possible by cutting dependencies between VrShellGl and UI code. This includes creating a UI support shim to help avoid UI calls directly to code that may not be exported to modules in the future. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2edbe31ca8c6fcbbfbd8facc9913d6068eda208 Reviewed-on: https://chromium-review.googlesource.com/1141934 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#576187}
-
David Black authored
See bug for screenshot. Bug: b:111596959 Change-Id: I96ebd18bcb7d4905df5e539a5ace36154e49c146 Reviewed-on: https://chromium-review.googlesource.com/1142225 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#576186}
-
Mustafa Çamurcu authored
Currently, all KeyEvents are dispatched with EventType set to ET_KEY_PRESSED. This cl fixes it. Change-Id: I6302ed77634ecd64ba18509272ef58c96b37a6f6 Reviewed-on: https://chromium-review.googlesource.com/1142383 Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576185}
-
Kevin Bailey authored
MacOS is capable of generating an accessibility description for the search icon on the Omnibox, but we currently don't fill it in. This CL adds a name to it (and there may be a follow-up to tweak the "image" string that is also getting appended.) Bug: 862745 Change-Id: I53f7250c848761127a29bdad4e215830c365bb97 Reviewed-on: https://chromium-review.googlesource.com/1138548Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576184}
-
Mohsen Izadi authored
BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2e886c67eb09f89a1bf8ddcdfc83bd8382dfa907 Reviewed-on: https://chromium-review.googlesource.com/1140918 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#576183}
-
Sidney San Martín authored
The PiP window has a simple layer tree and triggers the FSLP code path. But, this path didn't previously consider the video layer part of the area that needs a backdrop, so the backdrop layer (the root layer) was made too small. It would be better if this code just had access to the size of the page instead of having to guess by looking at the layer tree, but I don't think it does right now. Bug: 863580 Change-Id: Ib2e9ae24e98932b77b365a985dc956aa08287eb7 Reviewed-on: https://chromium-review.googlesource.com/1140923Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576182}
-
Zach Helfinstein authored
This change is in preparation for creating the Switch Access context menu, which we want to behave similarly to the ChromeVox Panel. Bug: 864796 Change-Id: I7d3c4828d1de7165ce4e3cab99fa779b3f5dcd1d Reviewed-on: https://chromium-review.googlesource.com/1141341 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#576181}
-
Adrienne Walker authored
freeGpuResources evicts harder to regenerate Skia caches, so use the slightly lighter weight purgeUnlockedResources when idle for oop raster. This matches the behavior of gpu raster (see: ContextCacheController). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia954629b13f8d5fcb50cbd314976e8558b1609d4 Reviewed-on: https://chromium-review.googlesource.com/1141102Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#576180}
-
Victor Costan authored
Change-Id: Ia275f1610f1e654937fec6eb2dca93928e203107 Reviewed-on: https://chromium-review.googlesource.com/1137847Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#576179}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/510bbe089b53..9ee65033ce97 git log 510bbe089b53..9ee65033ce97 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 treehugger-gerrit@google.com Merge "Add --reset-guardrails option" 2018-07-18 primiano@google.com Add --reset-guardrails option Created with: gclient setdep -r src/third_party/perfetto@9ee65033ce97 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:72378055 TBR=perfetto-bugs@google.com Change-Id: I14049248810c32270a63acf9ead832c71af711de Reviewed-on: https://chromium-review.googlesource.com/1142244 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576178}
-
danakj authored
R=avi@chromium.org Bug: 419087 Change-Id: I46b6451680a15696b8bc5881b40a6389860a46ab Reviewed-on: https://chromium-review.googlesource.com/1142131Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#576177}
-
Kenneth Russell authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash should no longer be flaky, at least not for the previous reason. Bug: 861956 Tbr: bsalomon@google.com Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I37a34caf9b5725ddc877ac81a1760ad72dfbb261 Reviewed-on: https://chromium-review.googlesource.com/1142233 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576176}
-
Varun Khaneja authored
R=nparker Bug: 837707,836359,831563 Change-Id: Ice5c619948e47a3df6a257fc062ab9d38928bbab Reviewed-on: https://chromium-review.googlesource.com/1139032Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#576175}
-
sczs authored
- Migrates the code from LegacyHistoryCollectionVC and LegacyHistoryEntryItem into HistoryTableVC and HistoryEntryItem to add support for custom accessibility actions. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73d9a35a31822e98fb09d5828f7eee37211d06d5 Reviewed-on: https://chromium-review.googlesource.com/1125328Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#576174}
-
Michael Thiessen authored
This reverts commit 0062abf0. Reason for revert: Fixing... Original change's description: > Revert "VR: Ensure we remove black overlay if VR is exited while entering." > > This reverts commit 9f8158c1. > > Reason for revert: Culprit of failed VR tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6884 > > Original change's description: > > VR: Ensure we remove black overlay if VR is exited while entering. > > > > This fixes a failure mode where we shutdownVR after handling the VR NFC > > broadcast, and fail to properly cancel VR entry. > > > > Also does some other random cleanup of comments/visibility. > > > > Bug: 862829 > > Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b > > Reviewed-on: https://chromium-review.googlesource.com/1138726 > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575388} > > TBR=mthiesse@chromium.org,tiborg@chromium.org > > Change-Id: Ibe67ee8c09dc44ac34d40c3eaf890884b400fc24 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 862829 > Reviewed-on: https://chromium-review.googlesource.com/1140813 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575725} Change-Id: I71738aafff0b703083f465085fb71f54d047729b Bug: 862829 Reviewed-on: https://chromium-review.googlesource.com/1142167Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#576173}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: Id50845175a85cb5fc5919c8b79c1cd492f0d994d Reviewed-on: https://chromium-review.googlesource.com/1136879 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#576172}
-
Henrik Boström authored
SDP semantics can be passed in to the PC as kPlanB, kUnifiedPlan or kDefault. This CL does the translation from kDefault to kPlanB (default) or kUnifiedPlan (if a flag is used to overwrite the default) at construction once and for all. This eliminates assumptions about what kDefault may mean in different parts of the code or layers. RTCPeerConnectionHandler is also updated to keep track of the SDP semantics. Also passes down "sdp_semantics_requested" for the sake of UMA counters which is the exception where we do care if "kDefault" was used or not by the application. This CL also updates some Plan B-only methods to DCHECK SDP semantics or renames them to "...PlanB()". // Bots have already been successful, skipping remaining bot which is // inactive. NOTRY=True Bug: 777617 Change-Id: If88017360fa577297796bac4faf4e7bc56bd99d0 Reviewed-on: https://chromium-review.googlesource.com/1141880 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#576171}
-
Nate Fischer authored
No change to logic. This adds a gitignore file to ignore *.iml files, which are created by Android Studio. We add the rule at this level so that it gets picked up when we mirror this folder into Android (same reason we have proguard rules at this specific level). This is not expected to affect Chromium (other than it ignores *.iml files in this subtree, which should not cause issues for developers). Based off sergeyv@'s CL http://ag/4570535. R=torne@chromium.org Change-Id: I015e29269923054afffb9288c37170cc124be7c2 Reviewed-on: https://chromium-review.googlesource.com/1142368Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576170}
-
Rayan Kanso authored
A browser might shutdown, for example, when a request moves to the active state, but before we delete the pending entry. This CL modifes the initialization DatabaseTask to delete such inconsistencies. Change-Id: Icefcac3789d299c83bbda2b7b1dc117ca4e1a5e0 Reviewed-on: https://chromium-review.googlesource.com/1140164 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#576169}
-
Aldo Culquicondor authored
Visibility is already stablished by parent element. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8c8494a5137cc09b3ef7eab355c8016c2b14f541 Reviewed-on: https://chromium-review.googlesource.com/1140506Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#576168}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/873dc11d9a52..2f72894d302e $ git log 873dc11d9..2f72894d3 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 dor1s [libFuzzer] Mutation tracking and logging implemented. 2018-07-17 morehouse libFuzzer: prevent irrelevant strings from leaking into auto-dictionary 2018-07-16 dor1s Revert r337194 (https://reviews.llvm.org/D48891) due to compilation errors. 2018-07-16 phosek [CMake] Use cxx-headers as a depedency for C++ headers 2018-07-16 dor1s [libFuzzer] Mutation tracking and logging implemented. 2018-07-16 dor1s [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges. 2018-07-16 dor1s Revert r337175 (https://reviews.llvm.org/D49212) due to unintentional format changes. 2018-07-16 dor1s [libFuzzer] Implement stat::stability_rate based on the percentage of unstable edges. 2018-07-10 morehouse Revert "[Fuzzer] Afl driver changing iterations handling" 2018-07-10 delcypher [CMake] Add compiler-rt header files to the list of sources for targets when building with an IDE so that header files show up in the UI. This massively improves the development workflow in IDEs. 2018-07-09 morehouse [libFuzzer] Make -fsanitize=memory,fuzzer work. 2018-07-09 morehouse Revert "[libFuzzer] Mutation tracking and logging implemented" 2018-07-09 morehouse [libFuzzer] Mutation tracking and logging implemented 2018-07-06 kcc libFuzzer: always print line-break for NEW_FUNC/PC output 2018-07-04 george.karpenkov [libFuzzer] [NFC] Inline static variable to avoid the linker warning. 2018-07-03 kcc [libFuzzer] add one more value profile metric, under a flag (experimental) 2018-07-03 kcc [libFuzzer] remove stale code, as suggested in https://reviews.llvm.org/D48800 2018-06-26 morehouse [libFuzzer] Do not turn unittest warnings into errors. 2018-06-25 morehouse [libFuzzer] Use Vector rather than std::vector. 2018-06-18 phosek [Fuzzer] Set an explicit libc++ dependency when needed 2018-06-17 vitalybuka [fuzzer] Python 3 print fixes 2018-06-17 vitalybuka [fuzzer] Fix collect_data_flow.py for python 3 2018-06-15 phosek [Fuzzer] Don't hardcode target architecture for Fuzzer tests 2018-06-14 george.karpenkov [libFuzzer] [NFC] Support multi-arch and multi-OS building and testing 2018-06-13 phosek Reland "Passthrough additional flags to custom libcxx CMake build" 2018-06-12 morehouse Revert r334458, r334220, r334212, r334139. 2018-06-12 devnexen [Fuzzer] Afl driver changing iterations handling Created with: roll-dep src/third_party/libFuzzer/src Change-Id: I829245a79191c8bf78e0ba19ac7e7fa03bd96cd6 Reviewed-on: https://chromium-review.googlesource.com/1141988 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#576167}
-
nednguyen authored
NOTRY=true # Test covered by PRESUBMIT Bug: 865092 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ia8a505965fef699e5e0653db94006a0dee3f0b8a Reviewed-on: https://chromium-review.googlesource.com/1142235 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576166}
-
Koji Ishii authored
When computing whether a float can fit in the line or not, NGLineBreaker needs to know the current width after trailing spaces are collapsed. The current logic removes trailing spaces before computing it, but only at the end of the block. To compute this correctly on each wrapped line, this patch adds TrailingCollapsibleSpaceWidth() that computes without removing it, so that it can be removed only when the float fits. This allows us to check whether the float can fit or not for each wrapped line. In many cases, the computed trailing spaces will be removed. This patch also adds a cache to avoid computint it twice, because it may involve re-shaping. Rather large refactoring in order to split computing and removing, to avoid computing twice, and to avoid failures due to rewinding positioned floats. Bug: 862066 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ica6ce94fca63d5bdcf7784eead53dba6e680e177 Reviewed-on: https://chromium-review.googlesource.com/1133599 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576165}
-