- 11 Aug, 2020 40 commits
-
-
Naoki Fukino authored
If write-related functions are called on read-only roots, we can return errors immediately instead of making mojo calls which always fail. Bug: 956852 Test: Ran unit_tests Change-Id: I81bbe3aea12f683ecf7dc89db698983d35202a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346101Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#796740}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d07b78c82f85..3903e3a96c5d 2020-08-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-08-11 szuend@chromium.org [issues] Cleanup firing of FullUpdateRequired event in IssuesManager 2020-08-11 szuend@chromium.org Type-check ui/ARIAUtils.js with TypeScript 2020-08-11 alexrudenko@chromium.org Layout pane 2020-08-11 szuend@chromium.org [TypeScript] Don't use document as a Map in ui/AriaUtils.js 2020-08-11 szuend@chromium.org [issues] Add detection for third-party SameSite cookie issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1080589,chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifa5a8b931a1e50fdb1710eb0f9f4dfc9c84005ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796739}
-
Alexander Dunaev authored
The Textfield::WriteDragDataForView sets transparent background color for the drag image, which is not always supported on X11 (depends on whether the compositing manager is available), but Ozone/X11 didn't check that and always used the transparent color. This CL adds a new method in the Ozone platform that returns whether transparent color could be used. Bug: 1085700 Change-Id: I2c812086993fc825bb8f7bc0d416b7aa4ab44d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323293Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#796738}
-
My Nguyen authored
InputMethod isn't notified of the change in focus until the focus is already changed. Let InputMethodController handle autocorrect marker removal. Bug: 1114877 Change-Id: I1e5a8f0ae1e52d3ec2aa0f97f0479bf987787451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345932 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796737}
-
Hiroshige Hayashizaki authored
These tests confirm sandbox directives are no-op for workers, because sandbox directive is not yet specified for workers. (This CL doesn't add tests for dedicated workers, because dedicated workers inherit parent Document's CSP, the parent Documents should be sandboxed and thus it's hard to test whether dedicated workers from sandboxed Documents are sandboxed) Bug: 1112143, https://github.com/w3c/webappsec-csp/issues/279 Change-Id: Iff34da98de61214584681ae6f12ffcbf1dee1880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333908 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#796736}
-
Tomasz Śniatowski authored
Fall back to the old behavior of just writing to a trace file directly if we're unable to open a temporary file in the same directory. This can happen in some configurations on restrictive Android systems for example, where the browser may only be able to write to the actual file specified in --trace-startup-file, and not to any nearby path. Bug: 1082916 Change-Id: I3c1275b4c70cc8edb6e50adc321ba412c6226de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346352Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#796735}
-
Frédéric Wang authored
According to the URL specification [1], several parts of a parsed url must UTF-8 percent-encoded supersets of the C0 control percent encode set [2]. However, Blink does not do that for U+007F DELETE in the cannot-be-a-base-URL path and fragment states [3] [4]. This CL fixes that and also adds URL WPT tests for various URL percent-encoding cases. You can find more details on the Chrome status entry [5] and intent-to-ship thread [6]. [1] https://url.spec.whatwg.org/#concept-basic-url-parser [2] https://url.spec.whatwg.org/#c0-control-percent-encode-set [3] https://url.spec.whatwg.org/#cannot-be-a-base-url-path-state [4] https://url.spec.whatwg.org/#fragment-state [5] https://chromestatus.com/feature/5651438652882944 [6] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/en6buycTcKQ Bug: 809852 Change-Id: I9c75224a537f09a5b41ca7e9295f2a3bf7fad061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324425Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#796734}
-
Koji Ishii authored
Another fix to use |PostLayoutChildren|, this time in |NGPhysicalLineBoxFragment::ScrollableOverflow|. DevTools console hits the DCHECK added in r795416 <crrev.com/c/2339699>, this patch fixes the case. Bug: 965639 Change-Id: Ia3a74eb45c17923fa879dd0b663f48b441481968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345941Reviewed-by:
-
Alan Cutter authored
virtual/threaded-prefer-compositing/fast/scrolling/resize-corner-tracking-touch.html is flaky on all platforms. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=fast%2Fscrolling%2Fresize-corner-tracking-touch.html TBR: lanwei@chromium.org Bug: 1095540 Change-Id: I9d5f70d9c2e42236505d5d03e7818651aa000acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348489Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#796732}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf8ea9c25903..faa233ccab76 2020-08-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48eed585..5246cdb2 (796566:796691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic6238b67379aa42820bd3f91a3e83a9a4b2f2680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348323Reviewed-by:
-
Christopher Cameron authored
As background, YUV 420 biplanar videos on macOS (basically all videos) cannot be sampled directly in OpenGL. When we want to sample them, we do a copy and YUV to RGB conversion. In the compositor, we will draw either using OpenGL or using overlays. We bracket our use with calls to Begin/EndSharedImageAccess using the argument READ (for GL) or OVERLAY (for overlay). In the case of overlay access, we skip the copy. The DisplayResourceProvider will agglomerates the calls to Begin/EndSharedImageAccess into a single pair -- so if there is already a READ access active, and another READ access comes in, then we skip the second call to Begin/EndSharedImageAccess. The bug is that if we do OVERLAY access, and then want READ access, the DisplayResourceProvider will say "oh, you already have access, I'll skip the BeginSharedImageAccess call". Which means no copy, and random texture contents. To fix this, detect the case of transitioning from OVERLAY to READ access, and do a EndSharedImageAccess followed by a new BeginSharedImageAccess. This is all fairly horrible. Once we move everything to the SkiaRenderer, then we can remove the OVERLAY GL parameter and forget that this episode ever existed. Bug: 1113925 Change-Id: I25071324eb49c5fd3026a77c20034c9f5e647328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346843 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796730}
-
Yusuke Sato authored
crrev.com/796583 broke post-submit ARC tests on P boards. BUG=1114931 TEST=tast run DUT_EVE arc.Boot Change-Id: Id2bed1c14707763023ee145f6bc8931ecf5b847b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348197Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796729}
-
Peter Kasting authored
This changes the API to look like CallbackList's: instead of calling UnregisterEvent(), callers destroy a subscription object they get from registering. This is a bit easier for callers to deal with. However, the necessity of also synchronously clearing the event from the WaitSet makes the implementation a bit irritating, since while CallbackList does provide a hook to be called back on callback removal, that happens after notification is finished, rather than right at subscription destruction. Instead of using the hook, wrap the CallbackList::Subscriptions in an object that will also remove the WaitSet item if need be. Bug: none Change-Id: Ideb74b1435bfaad1647324e5ba5f90976c268e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343956 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#796728}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/531d992f00bb..95df5d3cbaf6 2020-08-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Iced333d87d724c5a8155d62995d38aede59ab75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348320Reviewed-by:
-
Ahmed Mehfooz authored
This CL adds skeleton code for the dark mode feature pod. Bug: 1106012 Change-Id: Icb4046bf25fd90482a69588611445a2604c39247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339289 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796726}
-
Peter Kasting authored
It looks like rounding would reduce overall error in these spots. Bug: none Change-Id: I473aa9dac00e454ae2ec344bf554928ce9236a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345287Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e80c7a00e1c9..33d3db6eaffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1110338 Tbr: alancutter@google.com Change-Id: I41daa4d230b4603c55a4650af4d14377881f3f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348098Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796724}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a4b9169fb6b3..f64194d1efb6 2020-08-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4430c2c5 to 5246cdb2 (398 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I0180b7b5e1f58925aba05a1e221b86e39910a34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347398Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5ca8a31b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ia23ccfbd5870b621fc6db812ad47d1a82356233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347346Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796722}
-
Lei Zhang authored
Normally, when Print Preview finishes, the browser will call PrintPreviewDone(), which in turn calls OnClosePrintPreviewDialog(). Change PrintPreviewDialogControllerBrowserTest and PrintRenderFrameHelperPreviewTest to do this as well. This is in preparation for a follow-up CL that changes when webpages are (un)paused for printing. With that CL, tests can no longer start a print preview and leave it in an unfinished state like it does now. Bug: 956832 Change-Id: I70908f0b86bfa288c257a65046c021cdd6138c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340515Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/275a495dbb2d..23335ac01cb8 2020-08-11 ynovikov@chromium.org Roll chromium_revision ed7912a2..c8c2c646 (794870:796654) 2020-08-11 ynovikov@chromium.org Fix clang revision regexp in chromium autoroller to match new format 2020-08-11 jmadill@chromium.org TestRunner: Fix test result handling. 2020-08-11 ynovikov@chromium.org Skip WebGL2CompatibilityTest.CopyMip1ToMip0 on Mac Intel GL 2020-08-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f881f08358b0 to 2de6d657dde3 (2 revisions) 2020-08-11 ynovikov@chromium.org Suppress dEQP-GLES3 failures on D3D11 NVIDIA If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1104516 Tbr: ynovikov@google.com Change-Id: I99939da3733d1853f04b882ba76ef7f6c983731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348251Reviewed-by:
-
Lei Zhang authored
In PrintRenderFrameHelper::PrintNode(), the print preview path sends beforeprint/afterprint events, but the system print dialog path does not. Fix this discrepancy. Though in practice, this does not matter because the only nodes that can be printed are probably plugins. Change-Id: Ibe45bb97ab7a614e7004a090c3e665b61144ca99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342139Reviewed-by:
-
Joe DeBlasio authored
This CL adds sensitive keyword detection to the simplified domains logic. It leverages the existing 'has-sensitive-keywords' heuristic, with some modifications, to trigger elision instead of a Safety Tip. Some of those changes include: - Searching through all subdomains, not just the e2LD, - Exclusion of common words in the keywords found, - Some general code cleanup, - Some housekeeping to eventually support more than 500 keywords. Bug: 1106962 Change-Id: I955c150968ef8b2e8fcf0ede85e4128b2545087a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343536 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796718}
-
Ahmed Mehfooz authored
Bug: 1114820 Change-Id: I2eaf8d09ec99ee4115ecae8fe26ab2ec4eedea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347305 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#796717}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/582102c9b7f4..cf8ea9c25903 2020-08-11 thomasanderson@chromium.org [XProto] Add SharedXDisplay::IgnoreXServerGrabs 2020-08-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9868e925..48eed585 (796451:796566) 2020-08-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8cce5f81..9868e925 (796325:796451) 2020-08-10 eshr@google.com [Adaptation] Remove ResourceAdaptation queue from VideoStreamEncoderResources 2020-08-10 hta@webrtc.org Revert "Implement transceiver.stop()" 2020-08-10 eshr@google.com [Adaptation] Delete AdaptationListener 2020-08-10 eshr@google.com [Adaptation] Move Balanced MinFpsDiff logic to VideoStreamAdapter 2020-08-10 nisse@webrtc.org Add method RtpVideoStreamReceiver::AddReceiveCodec with explicit payload type 2020-08-10 hta@webrtc.org Implement transceiver.stop() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066670,chromium:980879 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I224d0f4c571555b35208f8a40f6e8c478a80d8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347965Reviewed-by:
-
Adrienne Walker authored
Currently, disabling AppCache by turning off blink::features::kAppCache is a shallow disabling, in that the web api and the loader no longer use it, and its preference is disabled, but the service is still created. This is a step towards adding data deletion behavior when this feature is disabled. It doesn't make sense to delete the data folder when there is still an appcache service that exists at runtime. This patch makes the AppCache service optional and does not create it when the kAppCache feature is disabled. Bug: 1081897 Change-Id: I3a2a6cf4dd5bb8654a3c0da9ce310acff91766eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339920Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796715}
-
Hiroshige Hayashizaki authored
Failures on Chromium: - crbug/1114034 - checkpoint-after-window-onerror-module.html - checkpoint-after-workerglobalscope-onerror-module.html - crbug/1114028 - checkpoint-after-workerglobalscope-onerror.html Bug: 1096455c, 1114028, 1114034 Change-Id: If0b6ed9110decccd01cae5120c96390894df4047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341267Reviewed-by:Domenic Denicola <domenic@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#796714}
-
Josh Nohle authored
Change-Id: I2e4fda0aae8c4f644c6e0ef79c410554611199cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347976 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#796713}
-
Joel Hockey authored
Function getCroshSettings was only required during terminal SWA migration which is now complete. TBR=michaelpg@chromium.org Change-Id: I087ef9f7e6b32a10b8023bb12770666143b78ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345931 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#796712}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I538f63d54d7da961c0ac2a4f2080b89485a5632d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348096Reviewed-by:
-
Nick Diego Yamane authored
Leverage designated initializers for Wayland's PlatformProperties, as they are now allowed [1]. Furthermore, cleanup it so that only non-default values are kept. [1] https://groups.google.com/a/chromium.org/d/topic/cxx/1-rY_Zo7g8w/discussion R=msisov@igalia.com Bug: None Change-Id: Ia276cebb431225ce8baf5d86d5858114d74b51a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346784 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Maksim Sisov authored
Currently, X11ClipboardOzone continues to keep the request even though OnSelectionNotify comes. This may result in clients waiting until the request is processed or sending another request at the same time as the request is being processed. Thus, after I looked at how non-Ozone/X11 handle selection notify, copy the logic that SelectionRequestor::OnSelectionNotify has and complete the request with empty data. Fixes the following tests: SafeBrowsingBlockingPageWithDelayedWarningsBrowserTest/SafeBrowsingBlockingPageDelayedWarningBrowserTest.Paste_* Bug: 1084472 Change-Id: Iad7383f198b482549c9cff7f6b1183c9b8419470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340909Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796709}
-
Eric Willigers authored
The mojo connection will not be used after the JavaScript context is gone. We already check is_bound() before using the HeapMojoRemote. There is no need for Web Share to use kWithoutContextObserver. Change-Id: I36ed35ed510e98df7096c7661f238d940a7c1333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346102 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#796708}
-
Chris Davis (EDGE) authored
Currently, many of the binaries have a static dependency on dbghelp.dll. This results in dbghelp getting loaded in all chrome processes. Upon inspection, dbghelp.dll is only necessary for stack sampling and mini dump handing in crashpad. Stack sampling is only enabled by default on unofficial builds of dev and canary. All other times we are needlessly loading this module which brings in 300k of image file refset and 60k of Copy on Write costs per process. This change adds it to the delay load list. Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796707}
-
Jia authored
This cl changes the description to "powerd" from "power" (team name). AboutFlagsHistogramTest* Test: unit_tests --gtest_filter=AboutFlagsTest*, Bug: 881215 Change-Id: I98cdc2738ec774bbca0b661d2c8a0b1bb8d687d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345937Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796706}
-
Chris Letnick authored
Bug: None Test: CQ Change-Id: Ic9122141316852794b1024d578eec9e6e41a63e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342077Reviewed-by:
-
Emily Stark authored
This reverts commit 56db3421. Reason for revert: Fixing bug that we were going into ELIDE_TAIL mode when focused Original change's description: > Revert "Restore omnibox bounds when resetting if not eligible for eliding" > > This reverts commit 8ea67049. > > Reason for revert: I noticed that this change causes the omnibox to be in ELIDE_TAIL mode during editing, which causes a DCHECK failure. > > Original change's description: > > Restore omnibox bounds when resetting if not eligible for eliding > > > > This CL fixes a bug in the code that resets to the on-page-load state > > for the simplified domain hide-on-interaction field trial. > > > > The bug is that this reset code let the omnibox bounds go unchanged > > if the new text was not eligible for simplified domain eliding. > > For example, when switching to a new tab (as shown in > > https://bugs.chromium.org/p/chromium/issues/detail?id=1112577#c4), the > > placeholder text could get cut off because the omnibox was remaining > > at the bounds used for the last simplified domain elision. The fix is > > to restore the omnibox to its local bounds, with ELIDE_TAIL behavior, > > when the text is not eligible for simplified domain eliding. > > > > Bug: 1107912, 1112577 > > Change-Id: I36c359831fc1f7b18c814d9144b801655bd3b1c5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342123 > > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > > Commit-Queue: Emily Stark <estark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#795953} > > TBR=jdonnelly@chromium.org,estark@chromium.org > > Change-Id: Id44cd8e39064af890399109fcca8ca729ddba5d4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1107912 > Bug: 1112577 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343153 > Reviewed-by: Emily Stark <estark@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796133} TBR=jdonnelly@chromium.org,estark@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1107912 Bug: 1112577 Change-Id: I4e6c6b4ee1403404cac454f1602a4bab107b6058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344654Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#796704}
-
Peter Kasting authored
Bug: 1010217 Change-Id: I2af247a14d18a044aed6ea2ff2c258b047f4f9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348190 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796703}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ff337e33c90c..d07b78c82f85 2020-08-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia69d25ef9923d77b563d0f312ffc0aa97b92cae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348095Reviewed-by:
-
Richard Li authored
Currently, we have three overlay formats: YUV, BGRA, RGB10A2. Previously, we trace swap chain format with |is_yuv_swapchain_|, which can't provide accurate information in current situation. In this CL, we use a member variable |swap_chain_format_| to trace swap chain format in use. Bug: 1062184 Change-Id: I0d26564043f097afc0d1ef769c3854ee91a3462f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336215 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#796701}
-
