GitLab

Likely the same issue as the virtual compositing change.

BUG=287477
TBR=enne

Review URL: https://codereview.chromium.org/23451018

git-svn-id: svn://svn.chromium.org/blink/trunk@157420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like to avoid bare static_cast.

BUG=none
TEST=none; no behavior changes.

Review URL: https://chromiumcodereview.appspot.com/23714006

git-svn-id: svn://svn.chromium.org/blink/trunk@157419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=286645

Review URL: https://chromiumcodereview.appspot.com/23672027

git-svn-id: svn://svn.chromium.org/blink/trunk@157418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a subset of previously reviewed CL,
https://codereview.chromium.org/23531010/ that had to be reverted due to
unknown reasons for a performance regression. Hence, relanding in pieces.

R=abarth@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/23451016

git-svn-id: svn://svn.chromium.org/blink/trunk@157417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Started failing as the result of a Chromium change. May just need to be rebaselined.

BUG=287477
TBR=enne

Review URL: https://codereview.chromium.org/23672028

git-svn-id: svn://svn.chromium.org/blink/trunk@157416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=53693
TBR=inferno

Review URL: https://codereview.chromium.org/23723006

git-svn-id: svn://svn.chromium.org/blink/trunk@157415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

USE(HARFBUZZ) does not need to be exposed to the gyp build system.

BUG=286578

Review URL: https://chromiumcodereview.appspot.com/23922004

git-svn-id: svn://svn.chromium.org/blink/trunk@157412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://chromiumcodereview.appspot.com/24045002

git-svn-id: svn://svn.chromium.org/blink/trunk@157411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently Mac OS X is the only DARWIN platform supported, so there is no need to make a distinction between OS(DARWIN) and OS(MACOSX).

A distinction between OS(DARWIN) and OS(MACOSX) would only make sense if blink would support (e.g. with a running bot) a  configuration where where OS(DARWIN) is set but OS(MAC) is not set. Such a configuration is not a project goal currently.

Review URL: https://chromiumcodereview.appspot.com/14107015

git-svn-id: svn://svn.chromium.org/blink/trunk@157410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a subset of previously reviewed CL,
https://codereview.chromium.org/23531010/ that had to be reverted due to
unknown reasons for a performance regression. Hence, relanding in pieces.

BUG=270545
R=abarth@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/23608009

git-svn-id: svn://svn.chromium.org/blink/trunk@157409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Causing lots of use-after-frees on ClusterFuzz.

> Tables with display:inline rendered as block element.
> 
> Table was created as inline renderer and another table block renderer wrapper is
> created for table's content. So it was displayed as block element and all its style
> properties also associated with inline renderer and was not applied to table.
> 
> Creating table inline-table renderer wrapper for table's content if parent
> is inline except inline-block parent.
> 
> R=eseidel@chromium.org
> BUG=53693
> 
> Review URL: https://chromiumcodereview.appspot.com/23628004

TBR=a.suchit@samsung.com

Review URL: https://codereview.chromium.org/23708015

git-svn-id: svn://svn.chromium.org/blink/trunk@157407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In https://chromiumcodereview.appspot.com/23734003 , I tried to
include information about whether to use a left side scrollbar by
adding a textDirection method to WebScrollbar.  It missed some cases
when there is no horizontal scrolling.

I also renamed to textDirection() and isRightToLeft() to
shouldPlaceVerticalScrollbarOnLeft() because writing mode direction can
also cause the scrollbar to be on the left.

Fix the bug in ScrollbarThemeOverlay::paintThumb to take the left side
scrollbars into account.

BUG=274010

Review URL: https://chromiumcodereview.appspot.com/23480037

git-svn-id: svn://svn.chromium.org/blink/trunk@157406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We assumed form controls and anchor elements with 0-size were not
focusable. It's inconsistent with other elements with tabIndex or
contentEditable, and incompatible with IE11 and Firefox 23.

We remove rendererIsFocusable override of HTMLFormControlElement, and
remove renderer box check in HTMLAnchorElement::isKeyboardFocusable.

As for crbug.com/285595, when we removed focus from an input/textarea element by
0-size, the element kept the selection. So FrameSelection::setFocusedNodeIfNeeded
set focus on the element again when an editing command was invoked by a keyboard
input. This issue is revolved by this CL because we don't remove focus by
0-size.

BUG=168121,285595

Review URL: https://chromiumcodereview.appspot.com/23496036

git-svn-id: svn://svn.chromium.org/blink/trunk@157405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See the flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg%2Fcustom%2Fgetsvgdocument.html

The cause is explained in crbug.com/284734 .

BUG=284734

Review URL: https://chromiumcodereview.appspot.com/23598009

git-svn-id: svn://svn.chromium.org/blink/trunk@157404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=157368

BUG=53693
TBR=a.suchit@samsung.com

Review URL: https://codereview.chromium.org/23493027

git-svn-id: svn://svn.chromium.org/blink/trunk@157403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only
used in RenderBlockLineLayout.cpp. Moving them there (LineBreaker needs
to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable
chunks.

Review URL: https://chromiumcodereview.appspot.com/23855004

git-svn-id: svn://svn.chromium.org/blink/trunk@157402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=157364

BUG=29502
TBR=a.suchit@samsung.com

Review URL: https://codereview.chromium.org/23974003

git-svn-id: svn://svn.chromium.org/blink/trunk@157401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gives epic yakshavers an optional parameter to control
how many stackframes to show when using WTFReportBacktrace. This
just exposes a previously static framesToShow value.

Users may find this useful in debugging deep traces.

This patch does not modify the BACKTRACE macro because macros
cannot have optional parameters.
This patch does not use templates this function is in a c block which
does not support templates ("templates must have C++ linkage").

TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23494018

git-svn-id: svn://svn.chromium.org/blink/trunk@157400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=abarth@chromium.org
BUG=261719

Review URL: https://codereview.chromium.org/23521006

git-svn-id: svn://svn.chromium.org/blink/trunk@157399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the third step in a sequence of patches to refactor
Blink accessibility enums to be able to use them in Chromium.

This step finishes renaming the public interface. Subsequent
changes will continue to rename and refactor Blink
accessibility code to be more consistent as well.

Step 1 (Blink): https://chromiumcodereview.appspot.com/22331005
Step 2 (Chromium): https://codereview.chromium.org/23651003

BUG=269034

Review URL: https://chromiumcodereview.appspot.com/23726007

git-svn-id: svn://svn.chromium.org/blink/trunk@157398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a subset of previously reviewed CL,
https://codereview.chromium.org/23531010/ that had to be reverted due to
unknown reasons for a performance regression. Hence, relanding in pieces.

R=abarth@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/23536035

git-svn-id: svn://svn.chromium.org/blink/trunk@157397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When removing the old positioning behavior, the code that makes a float
with shape-outside gain a layer was left behind. This patch removes
that, so now floats with shape-outside are painted just like floats
without shape-outside.  Also remove the isFloatingWithShapeOutside
helper method because its use is now somewhat redundant, and the check
it does is now only needed in one place.

BUG=286448

Review URL: https://chromiumcodereview.appspot.com/23866007

git-svn-id: svn://svn.chromium.org/blink/trunk@157396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a use counter for animateColor.

BUG=286197

Review URL: https://chromiumcodereview.appspot.com/23857007

git-svn-id: svn://svn.chromium.org/blink/trunk@157395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I intend to review changes related to input events, scrolling/scaling,
viewport meta tag, fixed layout size, and Android-specific features
(I'll delegate review of other areas to other OWNERS).

NOTRY=true
BUG=

Review URL: https://chromiumcodereview.appspot.com/23731009

git-svn-id: svn://svn.chromium.org/blink/trunk@157394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Measurements notes in the bug note that this is a reasonable
memory saving. Perf seems unimpacted by the smaller default.

BUG=285442
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/23453040

git-svn-id: svn://svn.chromium.org/blink/trunk@157393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When normalizing a block with anonymous blocks for first-letter,
before content, and contained text, a collapsing anonymous block
cascade is triggered that attempts to collapse the contained
text's anonymous block within its destruction method. To avoid
this, adding logic to bail early if we're already destroying
the child anonymous block we're trying to collapse.

While in the function, doing a little cleanup to make it more
obvious that it only operates on RenderBlocks, not RenderBoxes,
and updating some of the comments to hopefully be more useful.

BUG=282088

Review URL: https://chromiumcodereview.appspot.com/23463021

git-svn-id: svn://svn.chromium.org/blink/trunk@157392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=leviw@chromium.org
BUG=285572

Review URL: https://codereview.chromium.org/23541008

git-svn-id: svn://svn.chromium.org/blink/trunk@157389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently SerializedScriptValue's Writer is resizing its StringBuffer to the
exact size it needs for every object it writes into the buffer. Instead, it
should grow the buffer exponentially to avoid calling realloc so many times.

This CL fixes a regression from Blink@155225. I've also removed a call to
isolatedCopy which is unnecessary.

R=jsbell@chromium.org
BUG=266837

Review URL: https://chromiumcodereview.appspot.com/24043003

git-svn-id: svn://svn.chromium.org/blink/trunk@157388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Amendment to CL: https://codereview.chromium.org/23483024

BUG=

Review URL: https://chromiumcodereview.appspot.com/23551010

git-svn-id: svn://svn.chromium.org/blink/trunk@157387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes Chromium test AwSettingsTest.testUseWideViewportLayoutWidth

BUG=285995

Review URL: https://chromiumcodereview.appspot.com/23459006

git-svn-id: svn://svn.chromium.org/blink/trunk@157386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ojan@chromium.org, leviw@chromium.org
BUG=285572

Review URL: https://codereview.chromium.org/23694024

git-svn-id: svn://svn.chromium.org/blink/trunk@157385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

for synthesizing callbacks for memory cache hits.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/24009002

git-svn-id: svn://svn.chromium.org/blink/trunk@157384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit ed002c01e93c3d9ee90fdf16d7461b149176c650.

Landing this as a speculative fix for the three perf regressions from
the listed bug.

TBR=ojan
BUG=286376

Review URL: https://chromiumcodereview.appspot.com/23701014

git-svn-id: svn://svn.chromium.org/blink/trunk@157383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Until (1) a transaction ends or (2) a cursor hits the end of its
range, an IDBRequest holds on to an IDBCursor as its result. Per spec,
calling continue() or advance() on the cursor re-uses the same
IDBRequest, requiring a reference cycle.

Previously, the cycle was broken explicitly on either of those two
conditions, but until that time a cursor-request pair would "leak",
holding on to potentially large script value results.

This patch makes both classes RefCountedBase::deref() and check
to see if they have a partner object and both refcounts are 1. If
so, the cycle is broken.

Special case cruft for condition #1 is removed to simplify the
code - just rely on GC to reclaim the objects if necessary.

R=alecflett@chromium.org,dgrogan@chromium.org
BUG=225860

Review URL: https://chromiumcodereview.appspot.com/23653024

git-svn-id: svn://svn.chromium.org/blink/trunk@157382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turns out FrameView::isScrollable can sometimes crash. Reverting this change
while I try and figure out why.

This reverts commit 1a3edc542e31626a9b46ae2b18eb227c7031f3d6.

TBR=jamesr@chromium.org
BUG=280679

Review URL: https://chromiumcodereview.appspot.com/23477042

git-svn-id: svn://svn.chromium.org/blink/trunk@157381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=261277

Review URL: https://chromiumcodereview.appspot.com/23711005

git-svn-id: svn://svn.chromium.org/blink/trunk@157379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The last piece of cleanup.

Depends on chromium-side change (with ifdef):
https://codereview.chromium.org/23762002/

BUG=257349

Review URL: https://chromiumcodereview.appspot.com/23704004

git-svn-id: svn://svn.chromium.org/blink/trunk@157378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In rendering benchmarks we want to only capture trace events that are
required for the benchmark. console.time is used frequently, but everything
else from the 'webkit' category is not. Putting console.time into a separate
category 'webkit.console' will reduce overhead and make trace buffer overflows
less likely.

R=jamesr@chromium.org, nduca@chromium.org, tonyg@chromium.org
BUG=264308

Review URL: https://chromiumcodereview.appspot.com/23848006

git-svn-id: svn://svn.chromium.org/blink/trunk@157377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch addresses half of crbug.com/225513 by grabbing the currently
active DOMWrapperWorld when creating ErrorEvent objects, and checking
that we're still in the same world when triggering `window.onerror`
handlers.

The next step will be to adjust event dispatching to ensure that 'error'
event listeners only trigger in the same world as the exception. I'll address
that in a separate patch; this patch adds several FAILing test results to make
that gap clear.

BUG=225513

Review URL: https://chromiumcodereview.appspot.com/21071003

git-svn-id: svn://svn.chromium.org/blink/trunk@157376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was regressed in r155659.

BUG=279919
TEST=manually tested with repro in bug

Review URL: https://chromiumcodereview.appspot.com/23640006

git-svn-id: svn://svn.chromium.org/blink/trunk@157375 bbb929c8-8fbe-4397-9dbb-9b2b20218538