- 10 Jan, 2021 23 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ba0fed2a8f3..76965015c8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: If92a6b2324f99c4cc801250d8879be015e59f802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620142Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841873}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610235454-b1731ff1de02e5e4bada297788352ec2a9c14fab.profdata to chrome-linux-master-1610257631-75568cac7ee4a8d110464ce094c69de7fbec5730.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2872828a7705c40c686b8414f4f6bdf8f2ffcb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841872}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.146. R=rmhasan@google.com Bug: 1041619 Change-Id: I5f3e9f436c9962c3b5897f4273b15d50d4cffd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618865 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#841871}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.83. R=rmhasan@google.com Bug: 1041619 Change-Id: Ida77bed0f81f67900f25b6d1884c21eb6346c6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618866 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2603021a919..5ba0fed2a8f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I69d6d455531aeb2619a2b42b776e9f6ac5b3bc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620072Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/588d32cb3f17..348ba200aa29 2021-01-10 capn@google.com Eliminate SpirvShaderEnumNames.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I451b2e851cacea4386e47a0c668d12ec5d56b2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620068Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610235454-ddbec0acfc93c8a66d64fcb2fcec95085679b266.profdata to chrome-win32-master-1610247025-b399feb25ec1d74c5eea41eb120c2b634e620ee0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9d51180560f355b0ba0460c7099ebbbcd81cfc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620069Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610235454-391a7739bc4d9e79bf6dbf6faa45986fd9fbb19d.profdata to chrome-win64-master-1610247025-dca14094a643e6a098c1c3648680e0e957e49caf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I81a271e8eb971482b65670fd378a6f29b1b8b90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620064Reviewed-by:
-
Keren Zhu authored
This CL fixes crbug/1161831 by partially reverting crrev.com/c/2580971 Issue: ResetCompositionState() sets |selection_| to client's composition end. This is problematic when the user deletes the composition, in which case |ResetCompositionState| is called in OnEndEdit(), before the composition in Blink is updated. This CL fixes the issue by restricting ResetCompositionState() to cases initiated by the browser. i.e. remove ResetCompositionState() from OnEndEdit(). TEST=manually verify crbug 1161831 Bug: 1161831 Change-Id: I1791e25faf737915aa5c491defa6e766f84507c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618292Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841865}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08a231692824..14bf8651ec06 2021-01-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I68faa909fc75444d848eaab1c00ed4356064bf3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620063Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be97f9811530..b2603021a919 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4549c5d30e1973c541abdfff871d588165a641fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620059 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610215000-12b03914fa2daf66d025fd826129c47bfb2c0858.profdata to chrome-win32-master-1610235454-ddbec0acfc93c8a66d64fcb2fcec95085679b266.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I396f6bac460caed98464a96c63e90284049dc579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619632Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4381.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4383.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If444f67b59bea49ba31dc1fd79f7d2ba7840f5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620066Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4381.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4383.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I707ba1be5f9dd76147be3fe729cc0f2475344709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620065Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ic1a932d56ac3aa230f006d0fc0bc7ea7d5df09a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618867Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841859}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610225890-2aa1dba0b8adceeb2151248377e34c9170c7c410.profdata to chrome-win64-master-1610235454-391a7739bc4d9e79bf6dbf6faa45986fd9fbb19d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I93a792a04b791e7285bfb8900c58badd426f3c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619479Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: If53bd8cf6dec0e7473c9b3a22b246b47a12d0135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619225Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I4536b4aa8128a1137d089830b64cdea3ca6d1f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619999Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841856}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610215000-b69940577779e97f408887c78f00b942182f0cb0.profdata to chrome-linux-master-1610235454-b1731ff1de02e5e4bada297788352ec2a9c14fab.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If799882fdee95f6ec016641f995a391fe664f6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619915Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I26f1df6729454ea47845cdae2819542779720ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620040Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51603c63d1cb..0b90eef09f60 2021-01-09 ynovikov@chromium.org Roll chromium_revision 1e679b77..28ecef43 (841389:841845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ia09f7f9def8c34fc4d3f9776ecb1a42a8c0991f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619224Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3b5e8607055..be97f9811530 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ic443ffd744d3794265e1b6e73bcb5dacd0d6d95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619223Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610215000-f68b7f659ca688b20c93b8d50be0555b11c1b418.profdata to chrome-win64-master-1610225890-2aa1dba0b8adceeb2151248377e34c9170c7c410.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I79a2482aecd9cadfb1974164b549db1ed9ce88b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619892Reviewed-by:
-
- 09 Jan, 2021 17 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/b229877c6d2d..b07d8724d4e4 2021-01-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 702c903f982d to 820179bf4689 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I296dad8e70f96b816d8db703868392a7d02659a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619891Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4de5456e54f9..b3b5e8607055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9750f37402946c1c366ab721c77df26ce7a28b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619893Reviewed-by:
-
David Roger authored
ProfileManager::CleanUpDeletedProfiles() passes a raw base::Value pointer to ProfileCleanedUp() to be run later asynchronously. This is incorrect, as this raw pointer is pointing somewhere in the middle of a list in preferences. If the preferences change in the meantime, the pointer is invalid when it is used. The base::Value is passed by value rather than by unique_ptr, as this is now the recommended pattern. Fixed: 1164410 Change-Id: Ifeebe3fe9f49cc7f991c738b73b24bdb6b017168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618339Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#841848}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ec16d90f8a1..4de5456e54f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4f2d6f2fe7237af3f0ddd45fe5043daf6205f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619884Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610193586-4fd7091c1af4571ccc29c3417201df96284922c2.profdata to chrome-win32-master-1610215000-12b03914fa2daf66d025fd826129c47bfb2c0858.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib1cf4084d4ae612889cd49c31dd646c6fe0a255c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619795Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I8e20ba64aed2db2097166e33fa8d6594d5674151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619918Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841845}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610203898-563a2edd68cafb27be3914f901cab91665255f2b.profdata to chrome-win64-master-1610215000-f68b7f659ca688b20c93b8d50be0555b11c1b418.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2e5a736c60ae1fa6c76cce8a3b3d54d137f97e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619792Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe7148efe51e..0ec16d90f8a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1109747 Tbr: Change-Id: I2a4f2a73e803dca56f2b108e2e0b80d8661d3b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619796Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610193586-93f61022a3f2638e289b0e08a26785a26ecf4b4e.profdata to chrome-linux-master-1610215000-b69940577779e97f408887c78f00b942182f0cb0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id7729d0e47948a84fc56958c4b5e7fe4f98ae65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619791Reviewed-by:
-
Rohit Rao authored
This BOOL property was being intialized from the result of PrefService::FindPreference(), which is a pointer to the pref object rather than the value of the pref itself. This CL switches to using the |contentSuggestionsEnabled| local var. BUG=1142431 Change-Id: If6c13562b0bf46e12952a1a6685c48b9021462e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497154 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841841}
-
Avi Drissman authored
Soon, with TargetChannel, an instance of Chrome on the disk might be upgraded to an instance of Chrome of a different channel. Cache the channel information on startup, so that even if it's changed, the channel information of the current running instance is available. Fixed: 1163159 Change-Id: Ie9ffd98325a0da335778206709f94ea5591e9af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618041Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841840}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bd872ddd930f..fe7148efe51e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9f104fb21370ca98ed878506737e1ee37a409c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619785Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610193586-5a29232a806886bf65f5a078fae3a3f399d82f3d.profdata to chrome-win64-master-1610203898-563a2edd68cafb27be3914f901cab91665255f2b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8a3b03de03981afaa773dd7459171719844f0186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619783Reviewed-by:
-
Yoav Weiss authored
This CL adds the android_webview platform to the feature's config. Change-Id: I799937263359bd7a7952632c56a61514bf4d2cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616558Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#841837}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c9a22bcb93db..3a0405597374 2021-01-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1e01c2c11613 to 9bacbe1b34a3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Iaaaaa71dd2693b6fcb9997ca0f711569fcdab48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619787Reviewed-by:
-
Nancy Wang authored
TBR=xiyuan@chromium.org BUG=1164559 Change-Id: Ic45befa0796f23038424a45f0c74ae175aa19fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619099Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841835}
-
Nancy Wang authored
This reverts commit eb018628. Reason for revert: <INSERT REASONING HERE> The reason for https://bugs.chromium.org/p/chromium/issues/detail?id=1164559 is not because of this CL, but CL:2606404. So I reland this CL, and will submit a CL to disable those unit tests, then fix them. Original change's description: > Revert "Remove the app related full restore data when the app is removed." > > This reverts commit 50bc0376. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1164559 > > Original change's description: > > Remove the app related full restore data when the app is removed. > > > > Add the class FullRestoreDataHandler to observe AppRegistryCache. When > > the app is removed, remove the full restore data from both > > FullRestoreReadHandler and FullRestoreSaveHandler. > > > > BUG=1146900 > > > > Change-Id: Ie55b6310e3e302ac4829b7c76c10880928266651 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608045 > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#841611} > > TBR=xiyuan@chromium.org,dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org > > Change-Id: Ib46d03a047b6c8145805ed2ba40e5c48c12d5d17 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1146900 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618763 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841721} TBR=xiyuan@chromium.org,dalecurtis@chromium.org,dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1146900 Change-Id: I1a58775fd9bd5e31062e6b43adf79a2e5cb19a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619403Reviewed-by:
-
