- 04 Aug, 2017 7 commits
-
-
Micah Morton authored
Refactor checking of URL whitelist to happen before analyzing the downloaded file, in order to improve SB check latency for whitelisted URLs. Certificate whitelist checks still happen towards the end of processing since they rely on file analysis. Bug: 526841 Change-Id: I59e228dea251ff1a03e319efccf1c2a8aec89bc3 Reviewed-on: https://chromium-review.googlesource.com/587329 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#491890}
-
Vladimir Levin authored
This patch adds serialization to PaintShaders, with the exception of PaintImage and PaintRecord. R=enne@chromium.org Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idbaf512f2f0c12df8edd6bcd459af0ddaaff4126 Reviewed-on: https://chromium-review.googlesource.com/590675 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491889}
-
Evan Stade authored
Since the MD update, this was duplicated in 4 places. The only difference (modulo stylistic differences) was that the ash/mus versions had an extra line: toolbar_bounds.Inset(kClientEdgeThickness, 0); I determined this was not necessary because the clipping region of the canvas was already smaller than toolbar_bounds by kClientEdgeThickness. Bug: none Change-Id: I4d2dd4bbb844f2108abb606c9f0bc2e2210834f8 Reviewed-on: https://chromium-review.googlesource.com/596813 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#491888}
-
Alexis Hétu authored
This reverts commit f42ff9b5. Reason for revert: Still fails Win7 (dbg) telemetry tests Original change's description: > Roll SwiftShader 4d3efed..aadf3e1 > > https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..aadf3e1 > > BUG= > > TBR=kbr@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: Ifdfd2e7f511023cf036eee83f50ddc7980b0b783 > Reviewed-on: https://chromium-review.googlesource.com/600892 > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491871} TBR=sugoi@chromium.org,kbr@chromium.org Change-Id: I5ef897b46cbb4455b0b39a541eee4c383350baf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel, linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/601443Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491887}
-
David Benjamin authored
This also allows us to support asynchronous client certificate verification, but this CL leaves it as a TODO for now. Bug: 706445 Change-Id: I792eb91a854bb15a67317d7ea4d04a80ba5ca4da Reviewed-on: https://chromium-review.googlesource.com/586431Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491886}
-
Mike Dougherty authored
Bug: None Change-Id: Ic9427bdefbab9ac6caee15f1d6a43a23c7830cbc Reviewed-on: https://chromium-review.googlesource.com/592235 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#491885}
-
Will Chen authored
This is a reland of 9869d2f1 I've marked the tests as Slow in this CL (https://chromium-review.googlesource.com/c/600829) which is why there were flaky before. Original change's description: > DevTools: transform console tests (part 2) > > F/u from https://chromium-review.googlesource.com/c/595238 > > Bug: 667560 > Change-Id: I4e387fae79ab4de0965f84a045c4fd04631b9e7d > Reviewed-on: https://chromium-review.googlesource.com/597312 > Commit-Queue: Will Chen <chenwilliam@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491501} Bug: 667560 Change-Id: Ie2cc4dd1249b46b7ce784a516647acaee223c39f Reviewed-on: https://chromium-review.googlesource.com/600814Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#491884}
-
- 03 Aug, 2017 33 commits
-
-
Brett Wilson authored
This container behaves like a std::deque (minus random access insert/erase) but uses an array as the underlying storage. Additional details are documented in the header. When DCHECK is enabled, the iterators do extra checks to ensure they are not being used after container mutations. A new helper class called base::internal::ArrayBuffer is added to be the low-level storage. This split was inspired by WTF::Deque although the functionality is quite different: The added one is mostly a holder for template move and destruct helpers, while the WTF one is to facilitate copy-on-write and buffer sharing (which is not supported by this one). The base::void_t is moved from base::internal namespace. This C++17 emulation need not be strictly internal to base and once I understood how to use it, it seems quite useful. Added base::internal::is_iterator to detect if an item is an iterator. This is required by one of the STL deque functions but the exact implementation is not specified by the standard. This implementation checks for the presence of iterator_category in the iterator traits. Contains minor fixes to move_only_int.h testing helper and the addition to a non-movable copy_only_int.h Related docs by dskiba: https://docs.google.com/document/d/1PEuPnSW54LaoWpUIEAHobqGt9nbD2DgQ_W5DdlJOkJU https://docs.google.com/document/d/1YL1FORFMWo0FK0lMg7WsImnjNQ3ZpY0nK0NHGjkeHT4 Future plans: 1. Replace some std::deque uses around the code base as a smoketest. 2. Add a presubmit to prevent additions of std::deque and std::queue. 3. Replace the remaining uses. Change-Id: Ic1a5c804da90514782a6eae4984d916da45c0d32 Reviewed-on: https://chromium-review.googlesource.com/582498 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491883}
-
Devlin Cronin authored
Call ExtensionBindingsSystem::WillReleaseScriptContext() for extension service-worker contexts. This fixes ServiceWorkerTest.EventsToStoppedWorker with extension native bindings. --gtest_filter=ServiceWorkerTest.EventsToStoppedWorker --native-crx-bindings=1 Bug: 653596 Test: browser_tests \ Change-Id: I97db2bce738f35cd8ca5909017c6c9f48f95b76e Reviewed-on: https://chromium-review.googlesource.com/596912Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491882}
-
Doug Turner authored
Current, we have a method _WaitForSpeech which blocks on NVDA to speak exactly the given set of text. What this CL does is modifies _WaitForSpeech such that it only tests for the ordered set of given text and ignores text that may have happened prior to the text we're looking for. Because of this change, I also renamed the method to _TestForSpeech Bug: 742592 Change-Id: I37f2ff890a2f8860afac17b0011300d8fd34dd3f Reviewed-on: https://chromium-review.googlesource.com/599607 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#491881}
-
Menglu Huang authored
This reverts commit 91feaec9. Reason for revert: <INSERT REASONING HERE> This CL causes test fails about signin in settings_egtest. https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/30291 You can use EG tryjob by git cl try -m tryserver.chromium.mac -b ios-simulator-eg Original change's description: > Enabling sign-in promo view earlgrey tests > > Bug: 661794 > Change-Id: I9e9844e73583288581e9700228708edc39dfd580 > Reviewed-on: https://chromium-review.googlesource.com/561147 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Eric Noyau <noyau@chromium.org> > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491761} TBR=msarda@chromium.org,noyau@chromium.org,jlebel@chromium.org Change-Id: I26caf6ede4734b0ec89d275ef211ff93e4adf73d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 661794 Reviewed-on: https://chromium-review.googlesource.com/601098Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#491880}
-
Caleb Rouleau authored
Bug: 654477 Change-Id: I01e842c3ae227410a0f002ea5383babefbdf432b Reviewed-on: https://chromium-review.googlesource.com/601128Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491879}
-
Quinten Yearsley authored
This CL changes testharnessreport.js to adhere closer to the style guide: https://chromium.googlesource.com/chromium/src/+/master/styleguide/web/web.md#JavaScript In this CL: - Wrap long lines - Make quotes consistent - Replaces var with let/const - Update some comments This should not change behavior. Change-Id: I1df1b42fd74333bba392eb8f3a91a15b4eb4d4fd Reviewed-on: https://chromium-review.googlesource.com/600769 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491878}
-
Wenzhao Zang authored
This could be the first step of the larger effort to clean up wallpaper codes. Due to legacy reasons WallpaperType exists in user_manager::User but it's supposed to be in WallpaperInfo together with WallpaperLayout This fixes the bot failure listed in the bug, though it's not the direct cause, it's good to refactor like this in the long term. TBR=brettw@chromium.org, ochang@chromium.org Bug: 752215 Change-Id: Icdcfc47ac12772576f4abb18003aab935897dc3b Reviewed-on: https://chromium-review.googlesource.com/600927Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491877}
-
Danyao Wang authored
Bug: 734150 Change-Id: I5198d481082fb5bc9e4a88b50847dcbebb97c248 Reviewed-on: https://chromium-review.googlesource.com/600292 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491876}
-
pdr authored
SVG's foreign object coordinate spaces were recently updated [1] to clarify SVG coordinates vs HTML coordinates. SVG coordinates are equal to HTML coordinates plus location (x and y). LayoutSVGBlock's MapLocalToAncestor takes HTML coordinates and offsets by location. Element::ClientQuads passed ObjectBoundingBox, which is in SVG coordinates and includes location, to MapLocalToAncestor which would apply the location offset twice. This patch updates Element::ClientQuads to use AbsoluteQuads which correctly calculates the foreign object bounds. Two TODOs have been added: 1) Element::ClientQuads and Element::BoundsInViewport are very similar and should be unified. 2) It's not clear whether stroke should be included in Element::ClientQuads. If it should be, SVG special-cases can be removed from Element::ClientQuads. A spec question has been filed: https://github.com/w3c/svgwg/issues/339. [1] https://chromium.googlesource.com/chromium/src/+/09a6cd640fb5bf07aa06477362229c2e6969a718 Bug: 741615 Change-Id: Ibec65966e8661c4c2390284708ef53b5d0c1d11a Reviewed-on: https://chromium-review.googlesource.com/597487 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#491875}
-
Kevin Bailey authored
If you look at all the times we call RevertAll(), they either also call SelectAll(true), or wouldn't mind if we did. We wish to standardize on this policy. It happens to fix an issue also, where a stale cursor is produced when tabbing into the Omnibox. Bug: 735802, 750716 Change-Id: I5aace2b656f4241f2760acadc2a156dbd5fc31f4 Reviewed-on: https://chromium-review.googlesource.com/572206Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491874}
-
Sammie Quon authored
This CL does not show the palette tray unless a stylus event has been previous seen (unless the device contains an internal stylus). Stores a pref to track whether a stylus has been seen before and if not, a pointer watcher is fired up to look for stylus events. Bug: 740298 Test: ash_unittests "PaletteTray*Test.*" Change-Id: I75d03dd382321a4f4e2324a5c9bec43b7b3c02c3 Reviewed-on: https://chromium-review.googlesource.com/592228 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#491873}
-
Elliot Glaysher authored
This fixes an ubisan error in ws::EventDispatcher where the creation of a ui::MouseWheelEvent object was copied into a ui::MouseEvent object, and then near immediately casted back to a ui::MouseWheelEvent, which it no longer was because the object was sliced. Bug: 752271 Change-Id: I9e49369c0ff599b99c1b68ab3785bdd051998568 Reviewed-on: https://chromium-review.googlesource.com/601179Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491872}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..aadf3e1 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ifdfd2e7f511023cf036eee83f50ddc7980b0b783 Reviewed-on: https://chromium-review.googlesource.com/600892Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491871}
-
Scott Violet authored
This changes the following: . child modal windows are now correctly dealt with. . previously if the target of an event was blocked by a modal window, then the event was targetted at the modal window. This patch makes it so that either the event is not dispatched, or the event falls back to the root (behavior dictated by flag in EventDispatcher). This patch brings the handling of modal windows in line with ui/wm/core/WindowModalityController and closer to that of RootWindowController::RootWindowController::CanWindowReceiveEvents(). I still need more wiring to implement rest of logic in RootWindowController::CanWindowReceiveEvents(). BUG=692282,697127 TEST=covered by tests Change-Id: I9af1b6d214b489e5819a2452d734754b890ba0da Reviewed-on: https://chromium-review.googlesource.com/596548Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491870}
-
Doug Turner authored
Currently, nvda_chrome_tests.py _WaitForSpeech will block for a period of time until NVDA speaks some given text. The implementation reads output from a log file that NVDA writes to. This read just starts at the start of the file and builds a list of what was said. This means that each call to _WaitForSpeech() must contain the prior expected text. This CL simply remembers the last offsite and when reading the file again we ignore old stuff. I don't think that re-reading the file is a big deal since we're barely testing with this approach. At some point, if it becomes a problem, we might think of something more clever. Bug: 742592 Change-Id: I47b417f7aa7b7cf8f6f6361d4581ab0ea562a042 Reviewed-on: https://chromium-review.googlesource.com/599373Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491869}
-
Frank Henigman authored
https://chromium.googlesource.com/angle/angle.git/+log/a0bcc50..13c0dd4 BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2cccfe2d8a3fd84eecb9bbb6ecec1b382dcddbda Reviewed-on: https://chromium-review.googlesource.com/600854Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491868}
-
Weidong Guo authored
https://codereview.chromium.org/2946813002 was intended to fix a issue when |contents| is null and bookmark bar exists. But it also unintendedly changed case when when |contents| is null and bookmark bar does not exist. This patch just reverts that case. The crash is not easily reproducible. This CL only speculatively fix the crash. The bug will remain open until the crash is confirmed fix. BUG=744211 Change-Id: Id092d16a75e087650a7edcba27115809de446d57 Reviewed-on: https://chromium-review.googlesource.com/595250 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491867}
-
Ryan Landay authored
This CL consolidates two switch statements in this method and makes the code easier to follow. It also removes NOTREACHED() from the switch statement to allow adding painting code for a DocumentMarker in a separate CL from the editing changes. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic125d633078ff3e74105f62ba64c5ebc349002bc Reviewed-on: https://chromium-review.googlesource.com/592327Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#491866}
-
Eric Karl authored
The memory program cache currently uses quite a lot of memory: Up to 6MB on desktop, 2MB on normal Android and 512Kb on low-end Android. Compressing shader binaries results in a 4-10x decrease in size (depending on the driver's binary representation). Compression adds a measureable performance hit (around 500-1000 microseconds). But when compared to overall shader compile/link time, which is around 6000 to 25000 microseconds, this seems acceptable for the memory wins. UMA stats have been added so we can ensure these values behave as expected in the wild. Decompression is fairly cheap (<200 microseconds). Currently, this feature is only turned on for low-end devices, as those are the ones with the most memory pressure. However, if the results are good, it might make sense to enable this in general. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie5d389f060504837efc86993811e83af8d630ce8 Reviewed-on: https://chromium-review.googlesource.com/572546 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491865}
-
Reilly Grant authored
This reverts commit fe5c2f3d. Reason for revert: This appears to be causing flake in the WebUSB layout tests. Original change's description: > Dispatch interfacerequest event in a new microtask > > This change modifies the MojoInterfaceInterceptor so that the > 'interfacerequest' event, fired when a request for the intercepted > interface is made, is dispatched in a new microtask instead of > synchronously. > > This has the benefit of not reentering JavaScript to execute event > handlers synchronously which is both different from the usual case for > binding interfaces that are provided by other processes and avoids the > possibilty of attempting to dispatch this event to JavaScript from a > scope where script is forbidden. > > Change-Id: I08b8c25a04da047381a3786af08b62979ca7b837 > Reviewed-on: https://chromium-review.googlesource.com/594716 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuzhu Shen <yzshen@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491552} TBR=dcheng@chromium.org,yzshen@chromium.org,reillyg@chromium.org Change-Id: Ibc179e1313fceba9a6e8da37e5220ccb6aa7c204 Bug: 751955 Reviewed-on: https://chromium-review.googlesource.com/601007 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491864}
-
Stefan Zager authored
Aside from reducing code duplication, this also fixes a few layout tests when root layer scrolling is enabled: accessibility/scroll-to-global-point-main-window.html accessibility/scroll-to-global-point-nested.html accessibility/scroll-to-make-visible-nested-2.html R=dmazzoni@chromium.org,skobes@chromium.org BUG=711468 Change-Id: I1368600b7ce82f1268a69c1a345226dda66dbd03 Reviewed-on: https://chromium-review.googlesource.com/598627 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491863}
-
Gauri Manikpure authored
Bug: chromedriver:1910 Change-Id: I66d1fdaab5c1b87deffc3c894d9cdad69c9a39a9 Reviewed-on: https://chromium-review.googlesource.com/599112Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#491862}
-
Takumi Fujimoto authored
[Media Router] Factor out calls to EventPageRequestManager out of MediaRouterMojoImpl into its own class On desktop, the calls to the MRP are queued with EventPageRequestManager until the Mojo connections with the extension are established. This CL factors out the calls to EventPageRequestManager into MediaRouterDesktop, a subclass of MediaRouterMojoImpl, so that MediaRouterMojoImpl is not aware of extension- related details. Changes to unit tests: - Move tests from MRMojoImplTest to MRMojoTest so that they can shared with MRDesktopTest - Merge MRMojoExtensionTest into MRDesktopTest Bug: 737320 Change-Id: I8271932b0418af2490a2bbea49e444120d9e2aa6 Reviewed-on: https://chromium-review.googlesource.com/572501Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#491861}
-
Robert Sesek authored
A WaitableEvent is now a Mach port with a message queue length of one. Signaling the event enqueues an empty message on the port, or times out if one is already queued. Waiting on the event receives a message on the port, dequeuing it if the event is auto-reset, or just peeking it if the event is manual-reset. WaitMany is implemented by adding all the events' ports to a port set and receiving on it. WaitableEventWatcher is implemented using a TYPE_MACH_RECV dispatch source for auto-reset events and manual-reset events on 10.12. For manual-reset events on macOS prior to 10.12, a lock-protected list of watcher callbacks is used instead of dispatch, because dispatch does not provide timely and reliable invocation callbacks if the event were to be Reset() immediately after Signal(). Bug: 681167 Change-Id: I22a9294ad0ae8900d16716d8033285fe91510eda Reviewed-on: https://chromium-review.googlesource.com/592516 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#491860}
-
Michael Moss authored
RPM packages are going to still be signed with the old key for now because rpm apparently can't handle our new GPG subkeys. R=thestig@chromium.org Bug: 677046 Change-Id: I54037622ca38e20d8403f3f60bab33fcf5e2f8ec Reviewed-on: https://chromium-review.googlesource.com/600893Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491859}
-
Lei Zhang authored
The affected maps all contain very few items. Change-Id: Ib4036f2cdc5a4fbd17518e988a840906e5543a9c Reviewed-on: https://chromium-review.googlesource.com/599588Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491858}
-
Mike Dougherty authored
Bug: None Change-Id: Idceb31b8ba0d4beb44bfd4f2d16a1faa5b8e531d Reviewed-on: https://chromium-review.googlesource.com/600028Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491857}
-
Bruce Dawson authored
In order to enable clang-cl's printf format string mismatch checking we need to fix a few dozen existing errors. These are mostly places where DWORD (unsigned long) is printed with %X - an 'l' is needed. This change fixes three of these and these files now build cleanly with clang-cl with PRINTF_FORMAT checking enabled. R=scheib@chromium.org BUG=751171 Change-Id: I6321593fb579f9c70f8adb5f885daffd0e5a6c74 Reviewed-on: https://chromium-review.googlesource.com/598827 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491856}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2857b6b6c858..a62e07f86606 $ git log 2857b6b6c..a62e07f86 --date=short --no-merges --format='%ad %ae %s' 2017-08-03 nednguyen Always use wprgo for Telemetry recording script Created with: roll-dep src/third_party/catapult BUG=730036 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I533077c0f042a0701ea5246e20aca528346e484e Reviewed-on: https://chromium-review.googlesource.com/601048 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491855}
-
Scott Chen authored
Follow up of 598504 (missed committing a change that I made locally). Bug: 741226 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I03848ef5dd9c9207262c2d48f491d678980e2b9c Reviewed-on: https://chromium-review.googlesource.com/599221Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491854}
-
Roger McFarlane authored
Only applies when --show-autofill-type-predictions is given. After parsing forms, the autofill manager defers sending the predicted types for queryable forms to the render until the query has completed. If the server predictions don't arrive, the heuristic precictions are never sent to the renderer. This CL sends the predictions for the queryable forms after initial parse (the non-queryable predictions are already sent). If and when the query completes, the predictions are updated as per the current flow. BUG=752225, 715828 Change-Id: Idebcda81317dcb9fcaa3c914983218e449970b65 Reviewed-on: https://chromium-review.googlesource.com/601003Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#491853}
-
Roger McFarlane authored
Corrects the code that generates field title strings when the --show-autofill-type-predictions flag is specified. Formatting bugs were introduced when the string was moved out of the .pak file and into code (escape sequences for string replacement were retained and some values were duplicated/missing due to copy-paste). BUG=703134 Change-Id: Id81a974be4ee12f0c6e2870da2b80c592962d730 Reviewed-on: https://chromium-review.googlesource.com/600994 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#491852}
-
Hector Dearman authored
WaitableEvent needs to outlive Thread to avoid a use after return. Bug: 751748 Change-Id: I99181842fd81ccad71dba967deebf5d1014affc7 Reviewed-on: https://chromium-review.googlesource.com/600213Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491851}
-