GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/328f6575..b4916264

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2857953002
Cr-Commit-Position: refs/heads/master@{#468974}

TBR=bzanotti
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718023

Review-Url: https://codereview.chromium.org/2857993002
Cr-Commit-Position: refs/heads/master@{#468973}

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857983002
Cr-Commit-Position: refs/heads/master@{#468972}

BUG=251774
TBR=jam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857613003
Cr-Commit-Position: refs/heads/master@{#468971}

These tests were marked as flaky/crashy but after the revert in
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c7
and the extra CLs
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c8
and
 https://bugs.chromium.org/p/chromium/issues/detail?id=707689#c9

we should be good again, so let's reconnect these tests and
monitor
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=shapedetection%2F

BUG=707689

Review-Url: https://codereview.chromium.org/2857803002
Cr-Commit-Position: refs/heads/master@{#468970}

Make Platform::*Create methods return a unique_ptr instead of a raw pointer
to explictly state ownership logic.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Original-Commit-Position: refs/heads/master@{#467710}
Committed: https://chromium.googlesource.com/chromium/src/+/d548cc04b6568f8edc08853940134707fcd6c455
Review-Url: https://codereview.chromium.org/2846843002
Cr-Original-Commit-Position: refs/heads/master@{#468697}
Committed: https://chromium.googlesource.com/chromium/src/+/bd3351963fb4da3e31478d841b91a117583f9786
Review-Url: https://codereview.chromium.org/2846843002
Cr-Commit-Position: refs/heads/master@{#468969}

Revert of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #1 id:1 of https://codereview.chromium.org/2858683003/ )

Reason for revert:
Sigh... a typo. Reverting.

Original issue's description:
> Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac
>
> TBR=sky@chromium.org
> NOTRY=True
> BUG=717740
>
> Review-Url: https://codereview.chromium.org/2858683003
> Cr-Commit-Position: refs/heads/master@{#468963}
> Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717740

Review-Url: https://codereview.chromium.org/2862553003
Cr-Commit-Position: refs/heads/master@{#468968}

This updates the libusb-based USB service to use the task scheduler
which means it will be enabled on macOS and Windows. The new Windows
USB service will be updated next.

By executing these tasks on a sequence with the CONTINUE_ON_SHUTDOWN
trait a device or driver bug that causes a request to lock up should
not prevent Chrome from shutting down.

BUG=652416,703585

Review-Url: https://codereview.chromium.org/2857473002
Cr-Commit-Position: refs/heads/master@{#468967}

BUG=none
R=marq@chromium.org

Review-Url: https://codereview.chromium.org/2814713002
Cr-Commit-Position: refs/heads/master@{#468966}

BUG=644626

Review-Url: https://codereview.chromium.org/2834073003
Cr-Commit-Position: refs/heads/master@{#468965}

This CL replace the method to get the indexPath of an item knowing its section
identifier in the CollectionViewModel by a method returning the indexPath of an
item even if its section identifier is unknown.
It adds a method to know if an item is present in a CollectionViewModel.
It also replace the reconfigure method of CollectionViewController to allow reconfiguring
without knowing the section identifier of the items.

BUG=703652

Review-Url: https://codereview.chromium.org/2761263003
Cr-Commit-Position: refs/heads/master@{#468964}

TBR=sky@chromium.org
NOTRY=True
BUG=717740

Review-Url: https://codereview.chromium.org/2858683003
Cr-Commit-Position: refs/heads/master@{#468963}

This re-lands 3d7851ff
original review: https://codereview.chromium.org/2849523005

This converts SlideOutView to SlideOutController, which provides all the
same functionality but can be added to any view rather than just those
that extend it.

It allows the target view to control the layer that's sliding out. For
toasts, that is the widget's layer. For notifications inside the message
center, that will continue to be the NotificationView itself.

BUG=716429
Review-Url: https://codereview.chromium.org/2849523005

Review-Url: https://codereview.chromium.org/2855763003
Cr-Commit-Position: refs/heads/master@{#468962}

These tests are already disabled in content_browsertests for Ozone CrOS.
They aren't disabled in browser_tests, probably because it's not run as
part of CQ.

The implementation of TrueType font information is missing for Ozone
because pango isn't compiled. This is probably the reason why the tests
fail.

BUG=619765

Review-Url: https://codereview.chromium.org/2856963002
Cr-Commit-Position: refs/heads/master@{#468961}

Android runs v8.mobile_infinite_scroll_tbmv2.

BUG=chromium:715716,chromium:716435

Review-Url: https://codereview.chromium.org/2857923003
Cr-Commit-Position: refs/heads/master@{#468960}

SearchTabHelper doesn't need it anymore. We can set the proper state
already in NavigationEntryCommitted.

This is part of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2845383002
Cr-Commit-Position: refs/heads/master@{#468959}

Some URLs are not permitted to load in Incognito mode, instead opening back in the regular browser window, making the "Open Link in Incognito Window" context menu link misleading.

To address this, disable the menu command for links that are disallowed in Incognito mode.

BUG=682163

Review-Url: https://codereview.chromium.org/2850153002
Cr-Commit-Position: refs/heads/master@{#468958}

https://skia.googlesource.com/skia.git/+log/16ba2c3db11d..24b2063a48ef

$ git log 16ba2c3db..24b2063a4 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 recipe-roller Roll recipe dependencies (nontrivial).

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I8560a1b8cc25b3553a9b98a95b6f79a2dd0e9b4e
Reviewed-on: https://chromium-review.googlesource.com/494097Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468957}

This reverts commit 6616a885, https://codereview.chromium.org/2798953002/.

We're seeing subframes created of navigations that failed to commit.

TBR=bmcquade,clamy,jam,csharrison,isherman

# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

BUG=717892,715547

Review-Url: https://codereview.chromium.org/2857963002
Cr-Commit-Position: refs/heads/master@{#468956}

Before this CL we would create a CrashFileManager in
MinidumpUploaderImpl on the UI thread. CrashFileManager requires a
directory in which to store minidumps, so creating that directory, or
ensuring that it exists, requires disk operations.
In this CL we move the creation of the CrashFileManager onto the worker
thread where the actual minidump uploading happens.

Also change the rescheduling logic for minidump uploading slightly,
Previously we would check whether there are any minidumps left, at the
time when the current job is cancelled, from the UI thread. But that
requires a disk operation, so now we instead update whether to
reschedule uploads, from the worker thread, for the UI thread to read in
a thread-safe way (without disk reads).

Note that this change affects the minidump uploading of both WebView and
Chrome.

BUG=714138

Review-Url: https://codereview.chromium.org/2838383002
Cr-Commit-Position: refs/heads/master@{#468955}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1667412..328f6575

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2856863004
Cr-Commit-Position: refs/heads/master@{#468954}

This patch removes StyleBackgroundData.h, moving its contents to a
nested class inside ComputedStyle.

BUG=628043

Review-Url: https://codereview.chromium.org/2860483003
Cr-Commit-Position: refs/heads/master@{#468953}

Apparently the crash is happening in blink::Document::GetFrame() because Document* is NULL.

BUG=706294

Review-Url: https://codereview.chromium.org/2850813004
Cr-Commit-Position: refs/heads/master@{#468952}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08f16b69a788..15b8a2e9d520

$ git log 08f16b69a..15b8a2e9d --date=short --no-merges --format='%ad %ae %s'
2017-05-03 primiano TraceOnTap: add privacy warning

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iad57fa878450fe10e00bc527e7f2824ca53cfe0a
Reviewed-on: https://chromium-review.googlesource.com/493839
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468951}

Introduce a last_modified timestamp for content settings stored inside the PrefProvider.
This timestamp will enable deleting content-settings by a selected time range from the clear browsing data dialog.
The timestamp will only be recorded if the tabs-in-cbd flag is activated because otherwise there would be no way to delete these history-like entries.

BUG=681523

Review-Url: https://codereview.chromium.org/2812113004
Cr-Commit-Position: refs/heads/master@{#468950}

Disables AndroidSyncSettingsTest#testAccountInitialization and
AndroidSyncSettingsTest#testIsSyncableOnSigninAndNotOnSignout
since they are flaky on Android.

BUG=717960
SKIPTREECHECKS=true
TBR=pavely@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2857103004
Cr-Commit-Position: refs/heads/master@{#468949}

In SyncSettingsCollectionViewController, the identity collection view might
not have been reloaded yet when identity updates arrive. Those event has
to be ignored to avoid crashes.

BUG=715590

Review-Url: https://codereview.chromium.org/2854303003
Cr-Commit-Position: refs/heads/master@{#468948}

https://skia.googlesource.com/skia.git/+log/16a6144dfdba..16ba2c3db11d

$ git log 16a6144df..16ba2c3db --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I5505a72893818604c48042f91eb70715c86ad9c2
Reviewed-on: https://chromium-review.googlesource.com/494096Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468947}

The dismiss button is not implemented yet, see crrev.com/2844253003.

Before:
https://drive.google.com/open?id=0ByXziH_JVCGJNW9pV1RLSVBLc1k
https://drive.google.com/open?id=0ByXziH_JVCGJaFUzNW0yMHhROW8

After with cold state:
https://drive.google.com/open?id=0ByXziH_JVCGJR1U1QWdiNzlMSHM
https://drive.google.com/open?id=0ByXziH_JVCGJSUp1VFNKRVBfSGs

After with warm state:
https://drive.google.com/open?id=0ByXziH_JVCGJWWxvd1hnNXJxS0U
https://drive.google.com/open?id=0ByXziH_JVCGJX3R3el9RRGJFTXM

BUG=661794

Review-Url: https://codereview.chromium.org/2838373002
Cr-Commit-Position: refs/heads/master@{#468946}

BUG=skia:6464
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2855503003
Cr-Commit-Position: refs/heads/master@{#468945}

BUG=596760

Review-Url: https://codereview.chromium.org/2858613002
Cr-Commit-Position: refs/heads/master@{#468944}

BUG=710977

Review-Url: https://codereview.chromium.org/2854973002
Cr-Commit-Position: refs/heads/master@{#468943}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cbb47fe..86a6787

$ git log cbb47fe..86a6787 --date=short --no-merges --format=%ad %ae %s
2017-05-03 oprypin@webrtc.org Properly send URL parameters in all requests
2017-05-02 sakal@webrtc.org Remove unnecessary runtime API-level checks.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2860573006
Cr-Commit-Position: refs/heads/master@{#468942}

BUG=707019

Review-Url: https://codereview.chromium.org/2852473002
Cr-Commit-Position: refs/heads/master@{#468941}

ExecuteManagePasswordsCommand() spins a runloop which will be flaky in
a browser test.

BUG=716681

Review-Url: https://codereview.chromium.org/2861613003
Cr-Commit-Position: refs/heads/master@{#468940}

The ScopedSubresourceFilterFeatureToggle remains, but is reduced to be
responsible for overriding only the base::FeatureList state.

The ScopedSubresourceFilterConfigurator is introduced as the new way for
overriding the configuration returned by GetActiveConfigurations(), and has the
following advantages:
  -- It does so regardless of the current field trial, feature list, and/or
     variation parameters states, thus the configuration can be changed
     multiple times during a single test.
  -- It can be used without a global base::FieldTrialList singleton, or setting
     up variations parameters.
  -- It will allow setting multiple simultaneous configurations conveniently
     without needing to first encode them as variation parameters.

BUG=708181

Review-Url: https://codereview.chromium.org/2838193002
Cr-Commit-Position: refs/heads/master@{#468939}

On low-end devices, BindInterface can be quite expensive. This CL
improves startup performance on low-end devices by using a single
PrefStoreRegistryPtr for all layered pref stores to be registered with
the pref service.

Bug: 654988
Change-Id: I1536f69f7c1a959cb41ed2b728e995b0d5f7eb17
Reviewed-on: https://chromium-review.googlesource.com/494368
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468938}

This patch removes StyleBackgroundData.cpp, and moves all its contents
to be inline in StyleBackgroundData.h

This is prework for generating StyleBackgroundData.

BUG=628043

Review-Url: https://codereview.chromium.org/2860663002
Cr-Commit-Position: refs/heads/master@{#468937}

Blink recently went through a style guide change and renamed variables
and functions. However, comments were not updated. So when a comment
mentioned a variable or function, that comment became outdated.

This patch fixes comments inside Blink's image-decoders/.

BUG=717642

Review-Url: https://codereview.chromium.org/2856993002
Cr-Commit-Position: refs/heads/master@{#468936}

The browser already has all the defaults and ignores the returned pref
store connection so this is just wasting time at startup.

Bug: 654988
Change-Id: I05a6af935fd44f5ea9d37cef71e3acf3d782e4d4
Reviewed-on: https://chromium-review.googlesource.com/494407Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468935}