GitLab

Showing the menu, resizing the browser window horizontally and then
showing the menu a second time could result in incorrectly positioning
the window, as position values from the first instance would affect
layout of the second instance. This fixes the issue by clearing position
alues before reshowing the menu.

BUG=667198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614663011
Cr-Commit-Position: refs/heads/master@{#443429}

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395

Review-Url: https://codereview.chromium.org/2617393003
Cr-Commit-Position: refs/heads/master@{#443428}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyScrollSnapCoordinate from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIScrollSnapCoordinate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIScrollSnapCoordinate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIScrollSnapCoordinate.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2616833002
Cr-Commit-Position: refs/heads/master@{#443427}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4bd0c43eba04..fe8a3c8a5cdb

$ git log 4bd0c43eb..fe8a3c8a5 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 aiolos Unit refactor cl 3: Use UnitScales in Unit.html instead of UnitPrefixScales.
2017-01-12 simonhatch Make this a more generic step and remove any stale files.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2627033004
Cr-Commit-Position: refs/heads/master@{#443426}

Currently, we use DictionaryValues in the Physical Web data source.
The problem with this is that we cannot store store longs (timestamps).
This change introduces a metadata struct that can be requested from the
data source, deprecating the DictionaryValue option.

BUG=667722

Review-Url: https://codereview.chromium.org/2561493002
Cr-Commit-Position: refs/heads/master@{#443425}

Just picked 10s arbitratily before we have a way to set this value via
Finch. Sending this out to see if collecting the average keyframe
distance and passing it via PipelineStatistics sounds reasonable.

BUG=663999
TEST=manual

Review-Url: https://codereview.chromium.org/2611333003
Cr-Commit-Position: refs/heads/master@{#443424}

The Download Home frontend shouldn't be directly talking
to the Downloads backend because it's missing information
about the downloads that are stored only on the Java side.
Instead, consult the Java sort-of-backend-but-not-really
shared preferences to know whether or not a download is
actually paused or not.

BUG=678099,651408

Review-Url: https://codereview.chromium.org/2623373002
Cr-Commit-Position: refs/heads/master@{#443423}

https://chromium.googlesource.com/angle/angle.git/+log/417df92..b4533de

BUG=680631

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629213002 .
Cr-Commit-Position: refs/heads/master@{#443422}

BUG=

Review-Url: https://codereview.chromium.org/2615753002
Cr-Commit-Position: refs/heads/master@{#443421}

BUG=680076

Review-Url: https://codereview.chromium.org/2623253002
Cr-Commit-Position: refs/heads/master@{#443420}

The Optional<> rewrite reversed the sign on extra margin space.

Also updated test expectations. Down to 165 failed from 207

BUG=635619

Review-Url: https://codereview.chromium.org/2623103002
Cr-Commit-Position: refs/heads/master@{#443419}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614833003
Cr-Commit-Position: refs/heads/master@{#443418}

BUG=676196

Review-Url: https://codereview.chromium.org/2604213002
Cr-Commit-Position: refs/heads/master@{#443417}

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628773002
Cr-Commit-Position: refs/heads/master@{#443416}

TEST=no functionality change

Review-Url: https://codereview.chromium.org/2623273008
Cr-Commit-Position: refs/heads/master@{#443415}

This is a skeleton of a Chrome Windows Debugger extension that will
provide convenience commands for developers using ntsd, cdb, or windbg.

BUG=

Review-Url: https://codereview.chromium.org/2612193002
Cr-Commit-Position: refs/heads/master@{#443414}

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2617423003
Cr-Commit-Position: refs/heads/master@{#443412}

BUG=505177

Review-Url: https://codereview.chromium.org/2571713005
Cr-Commit-Position: refs/heads/master@{#443411}

Fixed text-align keywords in CSSProperties.in to match the values in
CSSValueKeywords.in. This will not actually change the generated values
at this time since "webkitLeft", and "-webkit-left" will both result
in the enum value "kWebkitLeft" being generated. However, long term
it is important that the values exactly match those in
CSSValueKeywords.in.

BUG=628043

Review-Url: https://codereview.chromium.org/2631473002
Cr-Commit-Position: refs/heads/master@{#443410}

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2622043003
Cr-Commit-Position: refs/heads/master@{#443409}

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2629643002
Cr-Commit-Position: refs/heads/master@{#443408}

Move type, size, timeStampSeconds and modifiers to be private members.
This change will help harden the API so that we can place DCHECKS on
certain states.

Design: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit

BUG=625684
TBR=jochen@chromium.org, wez@chromium.org, thestig@chromium.org, sadrul@chromium.org, rockot@chromium.org, dcheng@chromium.org, girard@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2573073003
Cr-Commit-Position: refs/heads/master@{#443407}

This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it.
After this, the dump is dropped into the Crashpad database for eventual upload.

BUG=678959

Review-Url: https://codereview.chromium.org/2611393002
Cr-Original-Commit-Position: refs/heads/master@{#443249}
Committed: https://chromium.googlesource.com/chromium/src/+/92651104e939dbe94378a607e7acd381ca394fd3
Review-Url: https://codereview.chromium.org/2611393002
Cr-Commit-Position: refs/heads/master@{#443406}

For some reason, some pages redefine window.Element, which breaks our previous
use of instanceof.

BUG=chromedriver:1388

Review-Url: https://codereview.chromium.org/2620803002
Cr-Commit-Position: refs/heads/master@{#443405}

Video track needs to be reenabled before the new renderer is
created so that the callbacks attach properly. For that, add
two new callbacks to PipelineController for when the pipeline
is about to resume and is resumed.

This adds a potential problem when the video is shown or hidden
in between the two events. So don't change the video track if
the pipeline is resuming or seeking but check for the necessary
conditions in the resumed callback.

BUG=678374
TEST=media_[blink_]unittests + manual testing

Review-Url: https://codereview.chromium.org/2618883002
Cr-Commit-Position: refs/heads/master@{#443404}

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2618393003
Cr-Commit-Position: refs/heads/master@{#443403}

Part of the removal of PassRefPtr.

Replaces call to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, the method return type is still a PassRefPtr, and so the
PassRefPtr initialising constructor will be called passing in the
RefPtr rvalue, which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628763002
Cr-Commit-Position: refs/heads/master@{#443402}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/679672b1..ad889a60

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2629663004
Cr-Commit-Position: refs/heads/master@{#443401}

Original CL got reverted due to 2 LayoutTests failing in a single bot:
(Mac Retina bot)
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

This bot compiles with no proprietary codecs. H264 was selected
as potentially accelerated by the platform (correct) but H264 was
not enabled in this platform, so we hit a DCHECK().

This CL makes sure that H264 is not considered if
#if BUILDFLAG(RTC_USE_H264
is false.

Original CL description ------------------------------------------------
MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available

This CL adds a static method to VTR to query which
one, if any, is the preferred video codec.

A new singleton Lazy Leaky class CodecEnumerator is
added to encapsulate poking the VEA to see which
codecs are supported, and to further query
a) the preferred codec id
b) if a given codec is supported
and wraps the previous CodecIdToVEAProfile()
functionality.

BUG=679946

Review-Url: https://codereview.chromium.org/2623353004
Cr-Commit-Position: refs/heads/master@{#443400}

In http://crrev.com/1785953002 I tied a setting to the
is_overriding_user_agent property of NavigationEntry, but I forgot to
keep the preference updated during arbitrary navigation entry changes
(e.g. back button).

BUG=671580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2619063003
Cr-Commit-Position: refs/heads/master@{#443399}

This CL adds test cases for opening the media router dialog from the page
context menu and the app menu.

BUG=678472

Review-Url: https://codereview.chromium.org/2621723003
Cr-Commit-Position: refs/heads/master@{#443398}

BUG=679846

Review-Url: https://codereview.chromium.org/2629273002
Cr-Commit-Position: refs/heads/master@{#443397}

BUG=680720
TEST=Linux Intel HD 530 bot
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629543006
Cr-Commit-Position: refs/heads/master@{#443396}

This CL removes the "deferred quit" from most of the touched helpers.

The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
They were already using immediate quit mode, so there is no change in
their behavior, just cleanup.

Regarding title checks in browser_browsertest.cc: in these tests there
is no guarantee on when the new tab will start and stop loading. It
can start loading after WindowedNotificationObserver::Wait returns; also
it can stop loading while we're still inside it. We can explicitly wait
for the title to handle all these cases, and this makes the call to
WaitForLoadStop unnecessary.

BUG=668707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2601843002
Cr-Commit-Position: refs/heads/master@{#443395}

BUG=657012

Review-Url: https://codereview.chromium.org/2530043002
Cr-Commit-Position: refs/heads/master@{#443394}

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842

Review-Url: https://codereview.chromium.org/2601273003
Cr-Commit-Position: refs/heads/master@{#443393}

Reverted https://codereview.chromium.org/2625933003 as the GPU drivers on the Intel GPU perf bots need updating first.

R=jmadill@chromium.org
TBR=dtu@chromium.org, eyaich1@chromium.org, jmadill@chromium.org

Review-Url: https://codereview.chromium.org/2626373002 .
Cr-Commit-Position: refs/heads/master@{#443392}

Now, after http://crrev.com/2580343003, HTML diffs are available on all platforms, and dependency on wdiff can be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2582293004
Cr-Commit-Position: refs/heads/master@{#443391}

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308

Review-Url: https://codereview.chromium.org/2628953003
Cr-Commit-Position: refs/heads/master@{#443390}