- 12 Jan, 2021 40 commits
-
-
Yu Han authored
This is a reland of 909901eb The revert was due to greater pixels error difference between Mac 10.12 & 10.15 and the baseline. After checking the error rate on failed Mac bots, the fix is to increase the error_pixels_percentage_limit from 9f to 10.2f in form_controls_browsertest::FuzzyPixelComparator. Original change's description: > [Controls Refresh Android] Fixes input missing border > > Prior to this CL, controls-refresh text input is missing its border. > > The fix is to make sure property text_field.has_border is passed to > native theme. This property is only used by form controls-refresh > so it has no impact on existing text input. > > Bug: 1155397 > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841106} Bug: 1155397, 1164011 Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842590}
-
Caroline Rising authored
Add user action metrics for: - Clicking to open the reading list - Adding to the reading list from the Bookmark icon entry point - Adding to the reading list from the tab context menu Bug: 1163938 Change-Id: I95d655ce60f5b76c80f4d3b6a8490310befa8fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622315 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842589}
-
Renato Silva authored
Canada requires a legal footer to be shown on the marketing opt-in screen. Add the footer and tests for it. Fixed: 1124956 Change-Id: If9f1dd34dfb9ea9209498521eeee107f8aa132f9 Bug: 1124956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577364 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842588}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I2cdc9451fedddcea9e1515b59c2dc787c2b8beef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618290Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bd6bd346f677..e3e59aac750e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2a9e927c414af1d0b99974f76a14845fc5c20557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842586}
-
bttk authored
getOffsetOfFirstVisibleFocusedView is moved as well Change-Id: I96bc2a476fab2cd16372915ee0141a28236eeff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622842Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#842585}
-
chinsenj authored
Currently the WmGestureHandler handles events for the wm and also the window cycle list. There is also the WindowCycleEventFilter which handles some events for the window cycle list. This was implemented like this to share logic for scrolling, but after further investigation the common logic has been determined to not warrant having the handling for the window cycle list to live in two separate event handlers. This CL refactors the WmGestureHandler, moving all window cycle list logic to the WindowCycleEventFilter. A followup CL will refactor the WindowCycleEventFilter to reorder fcns according to order in its header file. Test: manual + existing tests. Bug: 1136554 Change-Id: I055d0533169992ad1022bdd14da9ce89d91f7e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606494Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842584}
-
Sophie Chang authored
Bug: 1154790 Change-Id: If4d9a70b41151d3f465976637a54aa826821bbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623717 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Roman Arora authored
This reverts commit 339975cc. Reason for revert: Search filter in Tab Search dialog not working as expected with this change. Original change's description: > Tab Search: Infinite list - Efficient list DOM item updates > > Leverage the ListPropertyUpdateBehavior logic that uses Polymer's > splices and calculateSplices functions to efficiently modify a single > list item on tab updates, and avoid unnecessary scroll height > calculations. > > Additionally, tab updates for not yet rendered items do not result in > DOM updates. > > Proposal doc & benchmarks: https://docs.google.com/document/d/1FcuhM98moL-BYB1DJGXrpwf-JqMz1aI-RQV08giArBY/edit#heading=h.xzptrog8pyxf > > Most relevant pinpoint benchmarks: > https://pinpoint-dot-chromeperf.appspot.com/job/15db6158d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/107ab7f4d20000 > https://pinpoint-dot-chromeperf.appspot.com/job/16ccacccd20000 > > Bug: 1149400 > Change-Id: I07fae967033b13830708da3035db3e8b2f0ff9d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578119 > Commit-Queue: Roman Arora <romanarora@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842182} TBR=dpapad@chromium.org,aee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,tluk@chromium.org,romanarora@chromium.org Change-Id: Ic4e8289e6ade648a8a006dad3b5310443e4c8c4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1149400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622721Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#842582}
-
Ulan Degenbaev authored
Bug: 1085129 Change-Id: I14e36d7e7901ec308ca469d32bf9a7eabc949637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617789Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842581}
-
Dave Tapuska authored
Page should be non-null, but check that it is. BUG=1160652 Change-Id: I1b126af29cc1f0dbebdd475fe205c77aa31e90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622283Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#842580}
-
Sonny Sasaka authored
Battery reporting via HID is now consolidated into BlueZ (CL:2593287), so there is no need to listen to powerd directly. This only affects Bluetooth HID devies and does not affect non-Bluetooth HID battery notification. Bug: b:166543531, b:172361193 Change-Id: I222677b96463120acdd2f7665d9a3c87df32346e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594158 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842579}
-
Eric Orth authored
Similar logic is currently duplicated between DnsConfigServiceWin and DnsConfigServicePosix, and there would be even more duplication if DCSPosix is further split by platforms (as I intend to do in a subsequent CL). Some logic for handling the detected-change notifications also moved from the (now-shared) Watcher to DnsConfigService, as the logic wasn't really part of "watching" but more handling. Bug: 1157492 Change-Id: Ie813e5d9085cb4a109f7cad9b28d351562352b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616421Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#842578}
-
Gustaf Ullberg authored
Pipe the number of encoded outgoing channels to the media stream audio processor and use it to configure the Audio Processing Module (APM). Stereo calls gets audio processing (echo cancellation, noise suppression, etc) in stereo. Mono calls will continue to get mono audio processing. Previous behavior was to perform audio processing in mono and upmix to two (identical) outgoing channels. Bug: webrtc:8133 Change-Id: I97bfa8f6b9736a6e8e0d216c1795d712f075726e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593122 Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#842577}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ifebc0c6256575dd48ff30db85ffbbcd8bd91d42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624949Reviewed-by:
-
Orin Jaworski authored
This CL only rolls the version number so that data will be downloaded and processed, which may help some broken databases get the Google search engine back. Bug: 1164024 Change-Id: I6f2c65b93c8316c1eb97edba3f40149e4006047c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617126Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#842575}
-
Brian Sheedy authored
Removes the warning and associated user prompt about ResultDB not being rolled out everywhere from the unexpected pass finder script. ResultDB has been enabled experimentally at 100% for ~2 months now, so it's safe to say that it's going to be sticking around and the BQ table data can be trusted. Bug: 998329 Change-Id: I95fcce6d8c2441d458e1c798ff84cbec7928b693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622760 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842574}
-
Michael Checo authored
- This change is needed to keep the order of the cards consistent since the battery status card is initially hidden. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Iaec2a4d37a11b083eb245f989ad9c937fb185c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612152Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#842573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f0cb733b1b1c..0c0b5a6bb2b2 2021-01-12 bsalomon@google.com Remove SkYUVASizeInfo, make SkYUVAIndex a private part of SkYUVAInfo 2021-01-12 tdenniston@google.com [svg] Implement onObjectBoundingBox for circle and path 2021-01-12 ethannicholas@google.com Add SkSL DSLVar 2021-01-12 johnstiles@google.com Scrub memory released from a GrMemoryPool in debug mode. 2021-01-12 bsalomon@google.com Revert "asyncRescaleAndRead supports unpremul results on GPU" 2021-01-12 johnstiles@google.com Add a reference to the ErrorReporter to the SkSL Context. 2021-01-12 brianosman@google.com Convert interpreter "compound types" test to SkVM 2021-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9da1d76d to b9b9a8a5 (443 revisions) 2021-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0b90eef09f60 to 2c65da28a2ee (13 revisions) 2021-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 348ba200aa29 to 3549479dc4cc (3 revisions) 2021-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3a0405597374 to 9ff83f6c957f (8 revisions) 2021-01-12 csmartdalton@google.com Move the outer mesh into a member of GrAATriangulator 2021-01-12 csmartdalton@google.com Extract a GrAATriangulator class 2021-01-11 jlavrova@google.com Position inside family glyph 2021-01-11 robertphillips@google.com Make the DDLTileHelper skip uninitialized tiles 2021-01-11 csmartdalton@google.com Move emit functions from Poly/Vertex structs into GrTriangulator 2021-01-11 johnstiles@google.com Implement constant folding for vector*scalar ops. 2021-01-11 brianosman@google.com Remove ByteCode from some failure-expecting interpreter tests 2021-01-11 johnstiles@google.com Separate out built-in SkSL types into their own struct. 2021-01-11 brianosman@google.com Convert InterpreterFunctions test to SkVM 2021-01-11 ethannicholas@google.com Break SkSLInliner mangling out into a separate class 2021-01-11 scroggo@google.com Silence SkCodecPrintf on Android 2021-01-11 johnstiles@google.com Split convertIf into an AST part and IR part. 2021-01-11 egdaniel@google.com Disable vulkan discardable msaa on devices that showed no improvement. 2021-01-11 westont@google.com Revert "[infra] Use Mac10.15.7 and xcode12.3 for all builds." 2021-01-11 brianosman@google.com Add release notes summarizing breaking changes to SkRuntimeEffect 2021-01-11 johnstiles@google.com Migrate constant folding tests into a separate directory. 2021-01-11 reed@google.com Remove obsolete flag SK_SUPPORT_LEGACY_ASYNCRESCALE_QUALITY 2021-01-11 jvanverth@google.com Add SkShadowUtils::GetLocalBounds. 2021-01-11 tdenniston@google.com [svg] Compute and use filter primitive subregion 2021-01-11 johnstiles@google.com Move constant folding to a separate file. 2021-01-11 robertphillips@google.com Reflect the DDLTask's ref on its target in its factory 2021-01-11 johnstiles@google.com Remove rewrite of `true ^^ expr` to `!expr`. 2021-01-11 bsalomon@google.com Remove Improved Perlin Noise 2021-01-11 bsalomon@google.com asyncRescaleAndRead supports unpremul results on GPU 2021-01-11 brianosman@google.com Convert early-return interpreter test to SkVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test:Test: Test: ./scripts/roll_aosp.sh and build in AOSP Change-Id: Iff934df024285a4650349f82cb8e852b93818009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624260Reviewed-by:
-
Ayu Ishii authored
Marks Blink.CookieStore.MatchType as obsolete. Usage has been removed in https://crrev.com/c/2404123. Bug: 1125651 Change-Id: I062dc92bf6d5ddfe6bb9c66de1fd2b852b57db60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621698Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#842571}
-
Nohemi Fernandez authored
Bug: N/A Change-Id: Ib53af301ed14bdacf6ddc1a05d4681d205a10527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624627Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842570}
-
Jeremy Roman authored
This makes them more usable with STL and base/ranges/ algorithms. Change-Id: Iea3c30eabedf683685ec4fd24c3099099f0fe03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618604 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842569}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9dd43ad51d98..ea9b5bbcb53e 2021-01-12 tvanderlippe@chromium.org Move Array#sortRange into array-utilities.ts 2021-01-12 tvanderlippe@chromium.org Remove global singleton function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51162215215540f84ca56575646f54c59e6544f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624259Reviewed-by:
-
Yicheng Li authored
A "Need help?" button in the WebAuthn dialog is supposed to link to a help center article about WebAuthn. A placeholder link was put in the code because we didn't have the dedicated p-link. Now that the real p-link is created, use this instead. This change needs to go into M88 to avoid confusion about the dialog. Bug: b/177107168 Change-Id: I70e89cd2978a20221d02627a33113ce9c4cffd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623628Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#842567}
-
Jordan Demeulenaere authored
This CL adds a delay_ms field to ShowDetailsProto to allow scripts to delay the setting/appending of details. Bug: b/174652960 Change-Id: Ie4bfa0a3446de6ab2e4c9bfdbce08292e7f3fbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606265 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#842566}
-
Michael Hansen authored
This suppresses the "Your computer is discoverable..." system notification when turning on high visibility mode using the toggle in the Nearby settings subpage. This will need to be cleaned up with a better abstraction when addressing tech debt in crbug.com/1155669. Fixed: 1158521 Change-Id: If5a5de8846f090a79f69d0b799e7d5a0d35ee104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622579Reviewed-by:
-
Titouan Rigoudy authored
After trying to implement this using |PolicyContainerHost|, I realized that the |isSecureContext| bit is tied very closely to the origin, and not inherited through to popup windows the way other policies are. I believe this might still be broken for origin-sandboxed documents, and will write some tests for that case next. This change is good enough to land on its own however. Bug: chromium:1126856 Change-Id: I232f3406162fd3dd898451495143d9837e5a88e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618142 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842564}
-
Andrew Grieve authored
UMA currently shows that: Os.stat() fails .14% of the time Runtime.exec() fails 0.02% I suspect the heuristic for where the .odex files live might be wrong for some small portion of devices, so would like to collect these crashes. Bug: 1152970 Change-Id: I98d1a14ae670bb1be04de6a4564001b65a67a1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624808Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#842563}
-
Allen Bauer authored
Added ability for metadata to return a finite list of valid values for a given member, such as enums and bool. Bug: 938501 Change-Id: I1ca2d37b08122df832adff0c153c038a291f260d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065428 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#842562}
-
John Delaney authored
What: No longer parse impressiondata as hex, or use hex when sending conversion reports. Why: This causes needless conversions for developers, as raised on https://github.com/WICG/conversion-measurement-api/issues/60 Note that the conversions database stores imp and conversion data as strings currently because they are represented as hex. These can be converted to strings now, but this is left as a followup. Bug: 1163599 Change-Id: I5b164c380a97cb272c6a0ee698df8b744feb58ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611958Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842561}
-
Lukasz Anforowicz authored
This CL adds an AbstractUrlTest test suite that covers both KURL and GURL. Having tests that are shared across Blink and //url will help 1) avoid code duplication and 2) ensure that Blink and //url behave in the same way (at least wrt things covered by the shared tests). Bug: 1164416 Change-Id: I6812c0230cc1ef91416aa9a8f967a5db15d4bf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622736Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842560}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ce9752f..81b3d28a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I853bd6aec86fa0e23ad33d8cfaab4a2e44659552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624106Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842559}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610431066-60b154442ebb054827e182b9c834d6f36e05d2b3.profdata to chrome-win64-master-1610452567-3155f81fa9ef93aecd596b942169049fc68cadb1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I97ce263fa01f9313e6d0968199a29b9eccd0940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624257Reviewed-by:
-
Alice Wang authored
This CL removes the redundant check FirstRunUtils.canAllowSync() in ForcedSigninProcessor.signinAndEnableSync(), as this method is always called with an account from AccountManagerFacade, FirstRunUtils.canAllowSync() is always true in ForcedSigninProcessor.signinAndEnableSync(). Bug: 1045525 Change-Id: I6e7632b2b27de917497d9982cd7e95a4e76527c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623289 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842557}
-
Rainhard Findling authored
Bug: 1128901 Change-Id: I53dfcd0519a4d103032495f1dca2f0040bc3fc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623927Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842556}
-
Titouan Rigoudy authored
Whereas in the embedded iframe tests, we exercise 7 different sources: - `about:blank` - the initial empty document - srcdoc - `data:` - `javascript:` - `blob:` - `filesystem:` For these tests only 4 of them are relevant, because: - srcdoc is not applicable to `window.open()` - a top-level frame cannot be navigated to a `data:` URL - a top-level frame cannot be navigated to a `filesystem:` URL This is also what the Web Platform tests do, see: third_party/blink/web_tests/external/wpt/secure-contexts/basic-popup-and-iframe-tests.https.js Bug: chromium:1126856, chromium:1154729 Change-Id: I3e89732b3f788c25e11064b9bc429c460e061fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595530 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e59aac750e..c60dda78e4ab 2021-01-12 treehugger-gerrit@google.com Merge "tp: fix sorting by id on thread state table" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6a1c36d049c6ded2fb6e5369cbb4f2c5b9dbbf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624256Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101120600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/yhWN-sh7gopLrFlZSwV0PMt236wQVRnoOIc1ppByspUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: I2e8fdb65ca12bf839eecc650a8e7a8058ed0ee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623499Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842553}
-
Mustafa Emre Acer authored
Hostnames typed without a scheme but with a non-default port shouldn't be upgraded to HTTPS. In such a case, we can't simply change the scheme to https:// and expect the site to load since it's likely that the HTTPS version of the URL is also served from a non-default port. This CL also fixes handling of IP addresses when there is a port. Previously, we were checking whether the entered text was an IP address. This breaks down if the IP address has a port attached to it such as 127.0.0.1:8080. This CL instead checks the canonicalized_url. Bug: 1141691 Change-Id: Iffefa5c0ee939b361d8152c5cd417756841b5923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623683 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#842552}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: Iabd045503b598b0469fedc37e99afd5fdb9620da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622001 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842551}
-
