- 24 Jan, 2018 40 commits
-
-
Victor Costan authored
Bug: 721516 Change-Id: I80ef1e4b11cb44019f2136c60d3bb05431fa7916 Reviewed-on: https://chromium-review.googlesource.com/883979Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#531670}
-
Artur Khachatryan authored
The waterfall tests on Mac appear to be flaky so disabling GPU for Mac platforms as well. Bug: chromedriver:1695 Change-Id: Id39fea14a40857bec33e78ffe2d3c65e51ada91c Reviewed-on: https://chromium-review.googlesource.com/884303 Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531669}
-
Dominic Mazzoni authored
This patch is in preparation for switching the accessibility enums in ui/accessibility/ax_enums.idl to a .mojom file instead. Because the generated C++ headers from a .mojom file use enum class instead of enum, we need to explicitly cast anytime we use an enum as an int. Some helpers are added to AXNodeData for the most common cases. Bug: 650275 Change-Id: Icf2df4bdedb7faf6d1e7bd3ffd3639faa8c1409f Reviewed-on: https://chromium-review.googlesource.com/875551 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531668}
-
Doug Arnett authored
This is so we could have one simple flag to use for a holdback group and be able to query its status in client code (eg, in interventions-internals). Bug: 803221 Change-Id: I8591de5ce107a4088e2e9c634c4ca4a90bb75d7b Reviewed-on: https://chromium-review.googlesource.com/871730Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#531667}
-
Evan Stade authored
Remove dependency on NotificationUiManager but keep dependency on MessageCenter (this test is testing code that has to run in the same process as MessageCenter). This should make one flaky test more consistent. One other test is deleted because it's a duplicate of another test also named WebNotifications (currently lives in ash/ with a todo to move to ui/message_center). Bug: 783018 Change-Id: I9c6f6e5aa149fe4d65c526d7ad8c4f5d6eeb074f Reviewed-on: https://chromium-review.googlesource.com/882883Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#531666}
-
Conley Owens authored
Headers are not always available in WillProcessResponse, only on HTTP(S) responses. This change updates the documentation to make that clear. Change-Id: I1ef27b07aa643310bcf9d76d2c1f1d3a854b721a Reviewed-on: https://chromium-review.googlesource.com/879128Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#531665}
-
Min Qin authored
This CL allows parallel download to work with network service. It uses ResourceDownloader to send the parallel requests. Bug: 715640 Change-Id: I50094ddfc59be2615d8543a30c3c54199abcdea7 Reviewed-on: https://chromium-review.googlesource.com/884203 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531664}
-
Jinsuk Kim authored
The API |CVC.performAccessibilityAction| had not been previously implemented but accidentally hooked to the correspodning a11y method in one of the refactoring efforts https://crrev.com/c/c863082. This CL reverts it. This cannot be the root cause of the reported bug since the bug predates the culprit CL. But makes sense to link to it since it is related. Bug: 805014 Change-Id: Ib8065bd89a551397a4e1249f1bd448872c7a71a8 Reviewed-on: https://chromium-review.googlesource.com/882525Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531663}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/7e9b13b5b0d2..adcf0ae6162d $ git log 7e9b13b5b..adcf0ae61 --date=short --no-merges --format='%ad %ae %s' 2018-01-24 lucferron Replace all NULL with nullptr Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I39b2b12e728e4264bae120248041e4270e29b71b Reviewed-on: https://chromium-review.googlesource.com/884327Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531662}
-
Bret Sepulveda authored
This patch completely changes the layout: * The extension icon is now on the left. The icon, title, and webstore data are moved into BubbleFrameView's title area, which simplifies the layout. * The extension info section (permissions, etc) is now the width of the dialog, instead of having a fixed width. * The extension info section is no longer bulleted, instead it uses a secondary text style to distinguish lines from each header. Detailed permissions are still bulleted. Indentation in this section is removed. * Each block in the extension info section now creates a {header, content} representation that's handled in a standard way when creating the layout. * The animation when showing details is removed. The dialog will now expand to accommodate the details if it has room to do so. See screenshots in the associated bug. Bug: 605657 Change-Id: Ie6815038138e524ff053449ec393d6cc6c1cf956 Reviewed-on: https://chromium-review.googlesource.com/841746Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#531661}
-
Andrew Grieve authored
Test was waiting for activity to be created, but not for native initialization to complete. Bug: 804521 Change-Id: I5964546bdb4178f26fd60940443ecb9493e76912 Reviewed-on: https://chromium-review.googlesource.com/882942Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#531660}
-
Mohammad Refaat authored
Applaunchertabhelper's RequestToLaunchApp doesn't retain urls before prompting. Adding Retaining to the URLs. Bug: 805577 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c0cb8b236997126534bc3fc0d16a90e4504cc47 Reviewed-on: https://chromium-review.googlesource.com/884304Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#531659}
-
Adrienne Walker authored
This fixes bad font visuals on Pixel XL. It's unclear why this was not happening on other platforms, but maybe clamping to 0.5 made the nearest neighbor fall on the wrong pixel in some cases. We should not be bothering to clamp when there is not bilinear filtering on anyway, so this should be a positive change for all platforms in terms of shader work. Bug: 803374 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia81af34fbef2a33883c50582adbfc59ce2ae6714 Reviewed-on: https://chromium-review.googlesource.com/883944Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#531658}
-
sebsg authored
Bug: 798079 Change-Id: I45d5bdf444d8d8d1605593afa83dfe25d68d3bb0 Reviewed-on: https://chromium-review.googlesource.com/862259 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#531657}
-
Tommy Steimel authored
This CL adds a subtitle to the MediaControls captions overflow button that displays the name of the selected text track, or "Off" if no text track is selected. The logic for determining the name of the track is reused from MediaControlTextTrackListElement, and has been moved to MediaControlsImpl to be shared. Bug: 775539 Change-Id: I450e7be2bcd994f3461e388e6ddc5e160617c8c6 Reviewed-on: https://chromium-review.googlesource.com/881583 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#531656}
-
Kai Ninomiya authored
Add crbugs to the use_client_side_arrays_for_stream_buffers workarounds. TBR=kbr@chromium.org Bug: 178093 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8516cefd80bc96e06f1787f39c405f528fd10e58 Reviewed-on: https://chromium-review.googlesource.com/882489Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#531655}
-
Miguel Casas authored
This reverts commit 8eb4ed81. Reason for revert: Broke Mac Retina Release (NVIDIA) under chromium.gpu.fyi: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Retina%20Release%20%28NVIDIA%29/7282 Original change's description: > Mac gl_unittests: reenable GLImageBindTest BGRX_1010102 > > This CL reenables the GLImageBindTest for BGRX_1010102, adding a provision > to swap the B and R components on nVidia platforms to avoid some mysterious > bug -- this is likely afflicting only the glReadPixels() since other tests > (e.g. crrev.com/c/862326 render colors without swapping), filed as > http://www.openradar.me/36824694, rdar://36824694. > > Bug: 803473 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I73dbe09b1c1d26cc8ac195808545de63da082ac7 > Reviewed-on: https://chromium-review.googlesource.com/879331 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531557} TBR=ccameron@chromium.org,mcasas@chromium.org Change-Id: Ica55ba2ed4b1ed64d11e72bb6c254e155cf14fc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/883642Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531654}
-
Christos Froussios authored
I extended chrome.passwordsPrivate with the onPasswordsFileExportProgress event and a callback to exportPasswords function. These serve to notify the UI about the progress of an export request. Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2e3c81c2c92128c0726da3193205765350b8df0 Reviewed-on: https://chromium-review.googlesource.com/787472Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#531653}
-
Robert Ma authored
No-Try because the test has not been imported yet. TBR=foolip No-Try: True Bug: 805463 Change-Id: I3418bc42699e7f9aa7e8e501c53ab881b5933594 Reviewed-on: https://chromium-review.googlesource.com/883729Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#531652}
-
Lukasz Anforowicz authored
Bug: 800137 Change-Id: I7e69b12cb914519f7ae47b234e6db2477d803d2d Reviewed-on: https://chromium-review.googlesource.com/875004 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#531651}
-
Joe Downing authored
This test was re-enabled last year (May 2017) in order to investigate the flakiness but it appears to still be flaky and is causing several failures per day in sheriff-o-matic. TBR=vmiura@chromium.org BUG=713260 Change-Id: Idefbba7c8b6fa32e1bd75a39fcae422ca9c5d4b9 Reviewed-on: https://chromium-review.googlesource.com/884181Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531650}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/44804c030bc2..c341d3829d47 $ git log 44804c030..c341d3829 --date=short --no-merges --format='%ad %ae %s' 2018-01-24 halcanary SkQP: make report.html smaller 2018-01-24 fmalita [skottie] "hold" keyframe support Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I9017e1ef8f4e99ea585d9516916d177a5a2344b2 Reviewed-on: https://chromium-review.googlesource.com/884202Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531649}
-
Sidney San Martín authored
This fixes "Removed" not appearing if you click a download after deleting its file from disk. Bug: 802232 Change-Id: Ia131bda2ef5968eaeb40005132dada4fe070ed58 Reviewed-on: https://chromium-review.googlesource.com/883727Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531648}
-
Wei-Yin Chen (陳威尹) authored
recordTimesHistogram() and siblings use |long|, but UMA only accepts int32, so the values are clamped in function recordCustomTimesHistogramMilliseconds(). Assert the ranges are within int32 to be safe. Bug: 803541 Change-Id: I498b08f343391858586b2931442cf15eb39fd3c3 Reviewed-on: https://chromium-review.googlesource.com/834763 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531647}
-
Dmitry Gozman authored
This one is sent after target has been reloaded after crash, a counterpart to Inspector.targetCrashed notification. Bug: 804012 Change-Id: Ia3335d707f7e3e74532c8982ca43e271962d0dbc Reviewed-on: https://chromium-review.googlesource.com/879133 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531646}
-
Christos Froussios authored
Bug: 805373 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I68d348a2ba7a20c457df833baa514457ae10816f Reviewed-on: https://chromium-review.googlesource.com/883445Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#531645}
-
Bret Sepulveda authored
Bug: 803855 Change-Id: Ibecaea32f973f907583ab8f01db4ae14a6f08cc6 Reviewed-on: https://chromium-review.googlesource.com/882126 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#531644}
-
Fady Samuel authored
fsamuel@ and kylechar@ have been working on surfaces for a couple of years and have been active in this area. In order to expedite and distribute code reviews in this area, this CL adds both as owners. Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5402cdf80a2f190621200051e11594e2dfde2e69 Reviewed-on: https://chromium-review.googlesource.com/884207 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531643}
-
Maks Orlovich authored
This is needed in preparation of being able to close and reopen files once we hit the FD limit; as an unlinked file would be rather hard to access again were one to close it. (It might make sense to only do the renaming if necessary --- but unless this regresses performance I would prefer to have the same behavior in common and rare cases). Bug: 636400, 292911 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I387216ab2f8ad1b8d4929d919cbcd32b843bc4d1 Reviewed-on: https://chromium-review.googlesource.com/695762Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531642}
-
erikchen authored
The instructions were out of date for Android. Bug: Change-Id: I98d3ed5784be1f08c4b39e89543482bd470cdc68 Reviewed-on: https://chromium-review.googlesource.com/874733 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531641}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c081020c7aac..7e9b13b5b0d2 $ git log c081020c7..7e9b13b5b --date=short --no-merges --format='%ad %ae %s' 2018-01-24 oetuaho Add helper function to pool allocate a char array Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I123d90fac27a8ba635ff7690a4211f978ff7b171 Reviewed-on: https://chromium-review.googlesource.com/884146 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531640}
-
Charles Harrison authored
This also enables the filtering after a phishing interstitial by default. Bug: None Change-Id: Icb5a074575e2cf1ecd69d5e0ccfb573cf06cf799 Reviewed-on: https://chromium-review.googlesource.com/729144Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#531639}
-
David Tseng authored
Bug: 801594 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I26207a6e721114ae89b1dd162f768f4e05e6eeb1 Reviewed-on: https://chromium-review.googlesource.com/881943Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#531638}
-
Xiaohan Wang authored
This reverts commit 7ad8abbb and reland commit a3cb5eee with fix. Original CL description: - Restrict CdmService to only host library CDM. Previously CdmService is generic, but it's never used anywhere else, and that assumption has caused some unnecessary code complexity. - As such, also remove ENABLE_STANDALONE_CDM_SERVICE and replace it with ENABLE_LIBRARY_CDMS where applicable. - Remove the use of media::mojom::InterfaceFactory for the CdmService, and replace it with a dedicated media::mojom::CdmFactory. - Remove the use of MojoMediaClient in CdmService, and replace it with CdmService::Client. TBR=jrummell@chromium.org,nasko@chromium.org BUG=771791 Change-Id: Id247bfba64a920b714ae2b080815dc3cb56e7d31 Reviewed-on: https://chromium-review.googlesource.com/882307Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531637}
-
Jao-ke Chin-Lee authored
This is to gather data for the purpose of LUCI migration and will be removed after enough has been collected. Bug: 731384 Change-Id: I78f90a7c76592c4f0a577a9bcac426cf4ca541fb Reviewed-on: https://chromium-review.googlesource.com/882611Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#531636}
-
Elly Fong-Jones authored
This reverts commit ad257c6c. Reason for revert: [sheriff] Likely cause of this build failure: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/14766 Original change's description: > [oilpan] Strongify HTMLMediaElement::audio_source_node_ > > Oilpan can deal with cycles so there is no reason to have this a weak > member, especially since weak handling always adds maintainance > overhead. > > Bug: chromium:404577 > Change-Id: I2c1ae3b79bc8ea0e71eec074f81f2652a8b3b51a > Reviewed-on: https://chromium-review.googlesource.com/883622 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531604} TBR=haraken@chromium.org,mlippautz@chromium.org Change-Id: I95ca64d5a18341487c0ec18990f748d77730b524 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:404577 Reviewed-on: https://chromium-review.googlesource.com/883184Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#531635}
-
Michael Spang authored
This adds very primitive touchscreen management support to cast. Advanced features such as support for display modes with unusual geometries (letterboxing, pillarboxing, etc) are not supported unlike on Chrome OS. Bug: b/72054342 Test: poke at screen while on https://rbyers.github.io/paint.html Change-Id: I456e3cd40f5a44a801a8bef5de3922a68b389298 Reviewed-on: https://chromium-review.googlesource.com/879750 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#531634}
-
Kurt Horimoto authored
When navigating from NTP to a web page, the SetProgress() call in ResetForNavigation() early returns because the progress is already 1.0. As a result, the FullscreenUIElements are not properly updated and the web content view's top inset is not updated to push the content below the fully exposed toolbar. Bug: 801495 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie53689669114d14a5859828ee43e7f3d4dcce406 Reviewed-on: https://chromium-review.googlesource.com/882349Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531633}
-
Xianzhu Wang authored
This is a reland of 05f80f7a. Fixed crash reason: table row/section called children's Paint when painting mask while they don't support it. Added check for the case. Original change's description: > [SPv175] Use kSrcOver to paint inline mask > > Previously we may used kDstIn which composited the mask painting > directly with the masked contents. However, for SPv175 we'll issue > the compositing op in PaintChunkToCcLayer so we should use kDstIn > during painting. > > Bug: 771643 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I526fd06425d545a526f0a8413e74712ee1f4647f > Reviewed-on: https://chromium-review.googlesource.com/882302 > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531438} TBR: trchen@chromium.org Bug: 771643 Change-Id: I5da0a781a60a4a5c70c4f144a7d95a1cf108f480 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/883602Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531632}
-
Xiaocheng Hu authored
This patch adds more test cases related to images and line wrapping to LocalCaretRectTest. Change-Id: I789b50d4e09c8457480467cd9602f95914acaacb Reviewed-on: https://chromium-review.googlesource.com/882127Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531631}
-