- 23 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ade9a5235c73..24e636926107 2020-10-23 cwallez@chromium.org Slightly improve a RenderPipeline error message. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I4657d5ed6cc8e3ae90ecd90049423133dbd92cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820244}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603426036-fdbbb30b2e93e949277645ff11f5cf593a24568b.profdata to chrome-linux-master-1603454266-512aeaba1be85f32943004abfaab59393bece0f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I475fb451d735ed8e5fb5c08bb6746b9ccc226c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495118Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/871500da9041..213fa85f73cd 2020-10-23 nisse@webrtc.org Internal-only visibility for rtc_base:macromagic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I842bbda90347537f18e3e8378cad611476b4c397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495109Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This simplifies further policy removing changes to be done in crbug.com/1103390 by refactoring all affected tests in 1 CL. Bug: 1103390 Change-Id: Ieaf7270cfee4fac9cd52e1834583184dc2d71a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463942 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#820241}
-
Sophey Dong authored
Bug: 1141583 Change-Id: I4ae4990ccafec8585aa91000b69a0f99ba06fed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493123Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#820240}
-
Olesia Marukhno authored
Bug: 1104264 Change-Id: I6f4a25d7f26a716d45978feaa9281d77064996f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463825 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#820239}
-
Mikel Astiz authored
This patch adds a sync integration test that exercises a problematic scenario: the deletion of a search engine via sync while the engine is the default one locally. This is possible because the default search engine is sync-ed via preferences, that is, syncer::PREFERENCES, whereas the actual list of search engines is sync-ed via another sync datatype, namely syncer::SEARCH_ENGINES. Ordering across different sync datatypes is not guaranteed and therefore, if a user changes the default search engine and deletes the old one, it is possible that a remote sync-ing device observes this changes in the opposite order. There is logic in TemplateURLService to special-case this scenario to append underscores, and this patch simply documents this behavior using a two-client sync integration test. Because reproducing the precise problematic ordering is not feasible, the test leverages a newly-introduced functionality in FakeServer that allows throttling sync datatypes (resembling a very slow sync for preferences). Change-Id: Ia0929717d0ea99a38969298b94f68a1c1ab44364 Bug: 1022775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471398 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#820238}
-
Oleg Davydov authored
For security reasons, resources of extensions from the Chrome Web Store are verified when used. For that content verifier uses hashes of the resources, signed by Chrome Web Store. These hashes might or might not be included in the extension archive. Therefore sometimes they are fetched from the Chrome Web Store only when needed. If fetching of the hashes fails, extension is disabled because content verifier cannot ensure that it is not corrupted. Unfortunately, this may lead to false-positive disabling of the extension: if fetch of the hashes failed, for example, because of bad network. To investigate whether this happens frequently, this CL adds a new histogram: * Extensions.ContentVerification.FetchNetError : network error code when fetch of the content hashes failed. Bug: None Change-Id: I03ff9c104a591579d713a5c939853645bea8ec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426583 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#820237}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53ee505d93e1..91ad80de0e11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bsep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141382 Tbr: bsep@google.com Change-Id: I0a92faa6beff9796010e7daf32945aec98255481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495107Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820236}
-
Steven Bingler authored
These SameSite features are enabled by default so we can clean them up here. Bug: 961439 Change-Id: I2a13a8abda97c3afcbb29f48e8d732e7a907f4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493262 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#820235}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cdd7e6fa..e323f012 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia31b55308ec81c979cde33efca1c25c5828409e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495240Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820234}
-
Side Yilmaz authored
IncognitoTabModelImpl creates a proper tab model and related OTR profile, iff there is at least one incognito tab. This CL changes this logic as creating tab model when switching to incognito mode, even if there is no incognito tab. |setActive| function will be triggered when the current tab model is changed by TabModelSelectorBase. By this CL; - Incognito profile will be created whenever the incognito mode becomes active. - TabSwitcherModeTTCoordinatorPhone will use IncognitoTabModelObserver instead of TabModelObserver to update the visibility of new tab variation. - TabModelSelector will have removeIncognitoTabModelObservers function. - BookmarkBridge will be destroyed whenever the profile is destroyed. - New test are added to IncognitoProfileDestroyerIntegrationTest. Bug: 1126532, 1060940 Change-Id: Ibd38b7a6bbaac955853ac298b29d705d5f889533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429766 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#820233}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4c63602bdb60..0fef99f5c756 2020-10-23 alcastano@google.com Typecheck elements/StylePropertyHighlighter.js with TypeScript 2020-10-23 bmeurer@chromium.org [wasm] Speed up inline function and source scope resolution. 2020-10-23 szuend@chromium.org Fix scrolling in Network log 2020-10-23 andoli@chromium.org [ts] Typecheck settings/FrameworkBlackboxSettingsTab.js with TypeScript 2020-10-23 alexrudenko@chromium.org Enable TypeScript for XHRBreakpointsSidebarPane.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1140900,chromium:1141781 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3f6d018cce31076a61597c0d5e5cfd0f9abbcfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495106Reviewed-by:
-
Jan Wilken Dörrie authored
R=vsemeniuk@google.com Bug: 927473 Change-Id: I1eb1e58345ab89c7699187bfd6f5680d9f408539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494942 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#820231}
-
Rakina Zata Amni authored
After crrev.com/c/1554760, the NavigationRequests are recreated if the URL doesn't match. We should just reset the NavigationRequest instead of moving it to same_document_navigation_request_. Bug: 963396 Change-Id: Ib3a9d8c6432796bfa3b400ffd2dece760da1fb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494206 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#820230}
-
Nicolas Ouellet-Payeur authored
This is a new crash with the DestroyProfileOnBrowserClose experiment (go/destroy-profile-on-browser-close). The BookmarkSyncService uses a ProxyModelTypeControllerDelegate, with the UI thread as the model thread. This causes issues, where posted tasks run _after_ the BookmarkSyncService gets deleted. This patch switches it to a ForwardingModelTypeControllerDelegate, so the tasks run synchronously instead of posting to the UI thread. This fixes teardown order. Bug: 1140232, 88586 Change-Id: I0802334ce3da56326c167f7951d512fe045ddece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487222 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#820229}
-
Rakina Zata Amni authored
navigation_token is only needed for browser-initiated same-document navigations, which is handled in DidFinishSameDocumentNavigation. See discussion: https://groups.google.com/a/chromium.org/g/navigation-dev/c/N_QfNAB3x44/m/ABGSPq6OAgAJ Bug: 1131832 Change-Id: I9c5ae4eb76bc361473b4ea833eee0ed6fb1d0887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478744Reviewed-by:
-
Fredrik Söderqvist authored
Change-Id: I4187fdbbb265aab9d679781130c923936a4ad9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494884 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6a2b3e4007e7..007c109b4594 2020-10-23 bungeman@google.com * src/sfnt/pngshim.c (Load_SBit_Png): Fix memory leak (#59322). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ic9be7c23a5208802888f7d10295f6f5d1ed3197e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493738Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#820226}
-
Mark Yacoub authored
BUG=1082882 TEST=N/A Change-Id: I167483e76cbc216ef1d5c9654f2b8a2e8bd85671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492968 Auto-Submit: Mark Yacoub <markyacoub@google.com> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#820225}
-
Konstantin Ganenko authored
Calling StartWorkerInternal() can end up in OnStartSend() which deletes `this` in case of error. This code path became real after the service worker context thread became the UI thread. R=falken@chromium.org Bug: 1141413 Change-Id: Iec9172567aab3dcc62323f358bab9fc751551d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490113 Commit-Queue: Konstantin Ganenko <ganenkokb@yandex-team.ru> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820224}
-
Rohit Agarwal authored
This CL uses adaptive colors for the incognito filled icon in the incognito interstitial. It uses modern_grey_300 for dark mode and modern_grey_800 for light mode. Screenshot: crbug.com/1137339#c4 Bug: 1137339 Change-Id: I659faac43841c27007b54e85e194e816e1648826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468116Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820223}
-
Jan Krcal authored
This CL splits the ShowSyncConfirmation() function of the dice turn on sync helper delegate into one that shows the normal sync confirmation and one that shows a error message that sync is disabled by the admin. Since both the dialogs are implemented by the same webUI page, there is not much behavioral change. The only change is for the delegate for the signed-in profile creation flow which opens a new browser window and shows the dialog in this window instead of showing it in the creation flow window. In follow-up CLs, the variant of the UI will be passed as a param to the WebUI page replacing the logic to decide which variant to show. Bug: 1126913 Change-Id: Ibac9a339c4fb071f960f15864482c818247f5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487100 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820222}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I186c23729a0cb00abe31c2425bf9f17b3d702aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495260Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820221}
-
Sreeja Kamishetty authored
Previously, the lifecycle state was updated to LifecycleState::kRunningUnloadHandlers/LifecycleState::kReadyToBeDeleted based on RFH having unload handlers or not during deletion when the RFH is in BackForwardCache. This CL removes this transition of LifecycleState and retains it to kInBackForwardCache during deletion. BUG=1109742 Change-Id: Ieef3635f80707be569dabb0ab37e38438084638e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351455 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820220}
-
Nektarios Paisios authored
In a previous patch, we introduced AXNode::GetTextFieldAncestor for finding the root of an editable region. However, we didn't replace all the existing code that had equivalent functionality. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Id3a9adfc7b9823fcd8899675d0e2cff5da1633d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490517 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#820219}
-
Abigail Klein authored
the MediaDialogView. The MediaDialogView paints to layer in order to ensure that corners are rounded (introduced due to crbug.com/992869). The Live Caption toggle label paints to a transparent background, which caused a bug due to subpixel rendering not occurring. This CL takes two approaches: 1. The new EnableMDRounedCornersOnDialogs flag enables rounded corners without needing to paint to layer. When that flag is enabled, we stop painting to layer. 2. When the flag is not enabled, set the background of the Live Caption toggle container to the native theme background so that the background color is opaque rather than transparent. Bug: 1055150, 1139395 Change-Id: Iaf9675e50671b3464c213412698aea3616534643 AX-Relnotes: N/A (Feature not launched yet) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490225Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#820218}
-
Bret Sepulveda authored
TBR=mmenke@chromium.org Bug: 1128033 Change-Id: I26c0756586cc484c50e6ec1cb886ac2c4b8acb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494865Reviewed-by:
-
Robbie Gibson authored
The tests now pass after https://chromium-review.googlesource.com/c/chromium/src/+/2446782. See below for a hypothesis on the root causes. The root cause of the issue is a unclear, but seems to be as follows: The overscroll state is supposed to change twice, once to STARTED_PULLING after the |-scrollViewDidScroll| call, and once to ACTION_READY after the contentOffset is updated. This happens on simulator, but on device, the first change actually causes the overscroll state to change to NO_PULL_STARTED. This seems to be because on device, the initial contentOffset is 0, while on simulator, it is ~ -2.46E-314, which compares less than 0 in |OverscrollActionsController scrollViewDidScroll|. To fix this, I changed the content offset in the test manually to a small number less than 0. Bug: 944599 Change-Id: I0d062e6ab9d20aca0b85810375b0081186fef48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390381 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#820216}
-
Bret Sepulveda authored
This test was reported flaky on Mac as well, so it is now disabled on all platforms. TBR=skobes@chromium.org Bug: 1135527 Change-Id: I8960866c3d7ebdf2199c839de28671510d7d9dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495141Reviewed-by:
-
Bret Sepulveda authored
Disable flaky SitePerProcessBrowserTestWithSadFrameTabReload.DoNotReloadHiddenTabWithHiddenCrashedSubframe All versions of this test are flaky on all platforms, so it is disabled. TBR=alexmos@chromium.org Bug: 1135595 Change-Id: I58843182f9a917c48cee813591a7859a173906bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494807Reviewed-by:
-
chrome://discardsKen Rockot authored
Bug: 1004256 Change-Id: I48acd4d46ee341f3cb399427b10e467f43537ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472484 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820213}
-
Bret Sepulveda authored
This reverts commit 27c54e91. Reason for revert: Sorry, looks like VideoCaptureImplTest.BufferReceived_GpuMemoryBufferHandle on Linux MSan Tests is still failing, see latest build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25945 Original change's description: > [VideoCapture] Handle GPU context lost for the zero-copy path > > When the render thread encounters GPU context lost, we need to re-create > the SharedImage resources to recover the video capture stream. > > This is a reland of crrev.com/c/2455328 with a fix to address the MSAN > test failure > > Bug: 1131998, b:169429427 > Test: Manually with chrome://gpuclean on soraka > > TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com > > Change-Id: I3d00abaea04ccf95a795e116f5fc7ff5c7d7f43a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494406 > Reviewed-by: Ricky Liang <jcliang@chromium.org> > Commit-Queue: Ricky Liang <jcliang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820175} TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I5b13e249552304881763302cef3fd2334e998452 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131998 Bug: b:169429427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494934Reviewed-by:
-
sauski authored
A previous change added the site_data.js search filter to the url query parameters. This resulted in the page sending two requests to the CookiesViewHandler for each filter change. The CookiesViewHandler has a strong requirement that only one request be in flight at any time. This CL adds logic to prevent sending a request on route change if a filter query parameters is present. Bug: 141785 Change-Id: I9ba6431b14e06fbd2211c9edb17c812cdbd1726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494805Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#820211}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3f2d5be. With Chromium commits locally applied on WPT: 4a9339fb "Fix NGLineBreaker::RewindOverflow crash" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ic945ecfbc4b004f912094c35d606062428f66277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494423Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820210}
-
Jit Yao Yap authored
Sync server-side changes from cl/333594358 and cl/338193271. Change-Id: Iea6abbbf69040ba84146186a787c26006e940701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489300Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#820209}
-
Ramin Halavati authored
This test has been disabled for 5 years. Cleaning up a bit and giving it a try before expanding to cover ephemeral Guest profiles. Bug: 471953, 1125474 Change-Id: Ia97497052141aed270b70fd1452c25e23ca7a78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489884 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820208}
-
arthursonzogni authored
Replicate the logic from about MHTML document from: DocumentLoader::CalculateSandboxFlags() into: NavigationRequest::ComputeSandboxFlags() This allow the removal of an exception in RenderFrameHostImpl::CheckSandboxFlags. Bug: 1082118 Change-Id: I1c7492c56c7c9f01f86aaf39d860ada4c2f9b4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452475 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820207}
-
Alex Rudenko authored
HTMLPreloadScanner and HTMLImageElement were using slightly different logic to determine if an image type is supported. In particular, HTMLImageElement considered an empty image type as supported and HTMLPreloadScanner did not. In the following case, it'd result in HTMLPreloadScanner trying to preload a resource (.png) that will not be used by HTMLImageElement (it will use .avif): ``` <picture> <source srcset="images/test.avif" type=""> <img src="images/test.png"> </picture> ``` This CL adds a static method HTMLImageElement::SupportedImageType that is used by HTMLPreloadScanner to check if an image type is supported. Also, redundant checks for type emptiness are removed from HTMLImageElement. Fixed: 1141776 Change-Id: I89ed95c18bbbc86613f6b362ba935f428e1d05b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494720 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#820206}
-
Nicholas Verne authored
Instead of "Linux (Beta)", now shows as "Developers" Bug: 1140370 Change-Id: Id4e076b5d918e41e22e5c59d65958da9e75a3f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486528 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#820205}
-
