- 13 Nov, 2018 40 commits
-
-
Regan Hsu authored
MultiDevice.BetterTogetherSuite.MultiDeviceFeatureState AndroidSms.MultiDeviceFeatureState SmartLock.MultiDeviceFeatureState InstantTethering.MultiDeviceFeatureState Multiple enumerated histograms with the same 9 buckets: 1) “Prohibited by policy”, 2) “Disabled by user”, 3) “Enabled by user”, 4) “Not supported by Chromebook”, 5) “Not supported by phone”, 6) “Unavailable, no verified host”, 7) “Unavailable, insufficient security”, 8) “Unavailable, suite disabled”, and 9) “Further setup required”. Bug: 870138 Change-Id: Ic96b673a10b4ecd52b9f44b0f29abc52d29858b3 Reviewed-on: https://chromium-review.googlesource.com/c/1315938Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607804}
-
oysteine authored
This reverts commit ec9be0fd. Reason for revert: Relanding after increasing trace download timeout to 120s Original change's description: > Disable failing perf tests on Nexus_5. > > TBR=nednguyen@google.com > NOTRY=true > > Bug: 902064 > Change-Id: Ic9f91ba4b263fb4ed435ac7a9dc1a096aa452516 > Reviewed-on: https://chromium-review.googlesource.com/c/1318586 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#605491} TBR=nednguyen@google.com,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902064 Change-Id: I03804b1a557226498df63eb8a7c0dea31e3f227f Reviewed-on: https://chromium-review.googlesource.com/c/1334335Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#607803}
-
Brian White authored
Bug: 836238 Change-Id: I10a60aea6e70c0a0f4a0ed40a7c9172ae383d170 Reviewed-on: https://chromium-review.googlesource.com/c/1334294Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#607802}
-
John Z Wu authored
Change-Id: I2582be57bcd094e17703dcdae109dde3e5875315 Reviewed-on: https://chromium-review.googlesource.com/c/1332720Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#607801}
-
Robert Ogden authored
This is a reland of 8bd3e513 The only difference between this and the original is swapping the run loop wait and the WaitForLoadStop in the browser tests, and adding --ignore-previews-blacklist Original change's description: > Integrate Lite Page Server Previews with the Previews Stack > > Adds Lite Page Server Previews to DetermineAllowedPreviews and > DetermineCommitted. For now, the preview is always allowed if the > feature is enabled and is committed if the URL matches. > > This intentionally leaves an open question about whether more logic > in the NavigationThrottle can/should be moved into the DeciderImpl. > > The biggest part of this change is moving the URL checking logic to > the previews component and adding additional helper functions there. > > Bug: 898557 > Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9 > Reviewed-on: https://chromium-review.googlesource.com/c/1323800 > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607427} Bug: 898557 Change-Id: I463a45331b7281cde6c83b61ee82b3bbdd8f5cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1333896 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#607800}
-
Victor Costan authored
Bug: 892852 Change-Id: Icc76061860b92e349bf1f3a936fef78a2c4a6e00 Reviewed-on: https://chromium-review.googlesource.com/c/1318838Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#607799}
-
Fabrice de Gans-Riberi authored
This is a reland of be707070 The build failure was fixed in perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/822041 Original change's description: > Roll src/third_party/googletest/src/ 2e68926a9..879ac092f (182 commits) > > https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2e68926a9d49..879ac092fde0 > > $ git log 2e68926a9..879ac092f --date=short --no-merges --format='%ad %ae %s' > 2018-10-31 jerryturcios08 Correct grammatical error in README.md > 2018-10-30 absl-team Googletest export > 2018-10-30 misterg Googletest export > 2018-10-29 absl-team Googletest export > 2018-10-29 akonradi Add Optional() to the cheat sheet doc. > 2018-10-29 misterg Googletest export > 2018-10-29 misterg Googletest export > 2018-10-28 vbrkov Replaced all NULLs with nullptr in googlemock > 2018-10-28 vbrkov Replaced all NULLs with nullptr in googletest > 2018-10-26 absl-team Googletest export > 2018-10-24 absl-team Googletest export > 2018-10-24 misterg Googletest export > 2018-10-24 jeffvd.a216 Change CMake googletest download location in docs > 2018-10-23 durandal Googletest export > 2018-10-24 peter_jiachen Disable extensions and force standard > 2018-10-24 peter_jiachen Revert previous changes > 2018-10-24 peter_jiachen Fix -std=c++11 flag > 2018-10-23 joelanderson333 add documentation of manual c++11 specification > 2018-10-23 gennadiycivil Update advanced.md > 2018-10-23 gennadiycivil Update advanced.md > 2018-10-23 gennadiycivil Update advanced.md > 2018-10-23 svg153 ACTION table format > 2018-10-22 absl-team Googletest export > 2018-10-19 gennadiycivil Update .travis.yml > 2018-10-18 gennadiycivil Update .travis.yml > 2018-10-18 misterg Googletest export > 2018-10-16 absl-team Googletest export > 2018-10-17 kakkoko Fix incorrect XML file name in help message > 2018-10-16 jonathan.wendeborn Removed last reference to internal::kDefault > 2018-10-16 jonathan.wendeborn Use existing Mock::GetReactionOnUninterestingCalls() > 2018-10-16 jonathan.wendeborn Don't fully qualify enum member > 2018-10-16 jonathan.wendeborn Added Mock::IsNaggy, IsNice, and IsStrict > 2018-10-12 robert Change types to remove cast warnings. > 2018-10-11 misterg Remove duplicate functionality PrintValue (in googletest-param-test-test.cc), use testing::PrintToString > 2018-10-11 komh Merge c41b2bf861ef2ac1a975af05ff66d9256f280b01 into f203b2db77161fe54846ea9e839ebec81aeeccac > 2018-10-11 dneto Merge 4c92120d6dedb4eeb499a8702faea0224e0a8b23 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a > 2018-10-11 aarond Merge 41fc9745d4a448db7d932250d22fac1dda287443 into 658c6390a5b363f46c6ad448ad1bce9d6e97e53a > 2018-10-09 absl-team Project import generated by Copybara. > 2018-10-09 misterg Internal Change > 2018-10-11 filipp.andjelo Use pcfiledir for prefix in pkgconfig file > 2018-10-06 ryee88 fix typo > 2018-10-10 spartucus Update .gitignore > 2018-10-09 misterg Remove non-variadic pre C++11 AnyOf > 2018-10-09 absl-team Unconditionally use std::tuple. Remove all mention of TR1 tuple and our own implementation of tuple. > 2018-10-09 misterg Remove testing::internal::BothOfMatcher, no longer needed > 2018-10-09 absl-team Apply [[noreturn]] to Abort() > 2018-10-09 gennadiycivil Update Makefile.am > 2018-10-09 gennadiycivil Update BUILD.bazel > 2018-10-09 gennadiycivil Update README.md > 2018-10-09 gennadiycivil Delete CHANGES > 2018-10-09 gennadiycivil Delete CHANGES > 2018-10-08 kuroiwa Merge c1170881039e859738c62b02a918116fc6d346bc into 27c86f29417e53a622a2902baab2d1d82dafc5f9 > 2018-10-08 misterg Fixing AllOfMatches test, where it properly belongs > 2018-10-08 misterg always define define GTEST_LANG_CXX11 1 > 2018-10-08 misterg Remove non-variadic pre C++11 AllOf > 2018-10-05 gennadiycivil Update primer.md > 2018-10-05 misterg Remove pre-C++11 code from gtest-printers > 2018-10-05 absl-team Make GTestColor and ColoredPrintF available as internal APIs from gtest.h. This is for use in abseil exception safety testing. > 2018-10-05 misterg Removed pre-C++11 IsContainerTest and IteratorTraits > 2018-10-04 absl-team Apply clang-tidy modernize-use-nullptr to googletest. > 2018-10-04 misterg Remove checking for C++ 11 and a pre-C++11 test from googletest tests > 2018-10-03 theonetruecamper Merge d830440d48a9502161448bc78be33a53388dd1f4 into f5260ae757a681566d8f7d0558b8dc0551036506 > 2018-10-02 jerryturcios08 Remove compilation option for C++11 in the root CMakeLists.txt > 2018-10-02 mateo.longo Merge c798e39a4f96f5a985126cc3fab4738b6412cfc1 into e93da23920e5b6887d6a6a291c3a59f83f5b579e > 2018-10-02 jerryturcios08 Add compilation option for C++11 in the root CMakeLists.txt > 2018-10-02 gennadiycivil Merge 68b8a4c60cd80c78e1875b77807fa13cdd2313f8 into 77962730563eece3525f40b8769e4ca0c6baf64c > 2018-10-02 30830880+marbub Merge 86fe8a25eb5a6e4546f9e39cf23a5c764217bf85 into 440527a61e1c91188195f7de212c63c77e8f0a45 > 2018-10-01 arseny.aprelev Merge 2ce0685f76a4db403b7b2650433a584c150f2108 into 75e834700d19aa373b428c7c746f951737354c28 > 2018-10-01 misterg Googletest export > 2018-09-27 durandal Googletest export > 2018-09-30 jerryturcios08 Add a cached variable to CMAKE_CXX_STANDARD > 2018-09-28 jerryturcios08 Add C++11 support in the root CMakeLists.txt > 2018-09-26 gennadiycivil Update appveyor.yml > 2018-09-25 gennadiycivil Revert "[mingw] enable the unittests for gmock and gtest again" > 2018-09-25 gennadiycivil Keep one MinGW build, remove the others > 2018-09-25 gennadiycivil Update appveyor.yml > 2018-09-25 gennadiycivil Update appveyor.yml > 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx_11.m4 > 2018-09-25 gennadiycivil Delete m4_ax_cxx_compile_stdcxx.m4 > 2018-09-25 gennadiycivil Update configure.ac > 2018-09-25 gennadiycivil Update Makefile.am > 2018-09-25 gennadiycivil Update .travis.yml > 2018-09-25 misterg automake > 2018-09-25 misterg test automake c++11 > 2018-09-25 gennadiycivil Update configure.ac > 2018-09-25 gennadiycivil Update configure.ac > 2018-09-25 misterg typo > 2018-09-25 misterg autotools c++11 > 2018-09-25 misterg autotools c++11 > 2018-09-25 misterg test > 2018-09-25 misterg include c++11 for autotools > 2018-09-25 absl-team Googletest export > 2018-09-25 gennadiycivil Revert "Add clang format check to one of the builds" > 2018-09-25 misterg Googletest export > 2018-09-24 misterg Googletest export > 2018-09-20 absl-team Googletest export > 2018-09-25 misterg enable MingW on PR > 2018-09-25 misterg C++11 autotools build > 2018-09-25 misterg adding c++11 to appveyor mingW > 2018-09-25 misterg typo > (...) > > Created with: > roll-dep src/third_party/googletest/src > > TBR=thakis@chromium.org > > Bug: 893369 > Change-Id: Ic7e13ff5fd3952c4d71ab23166a5c36dcad86b99 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/c/1310634 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604801} TBR=thakis@chromium.org Bug: 893369 Change-Id: I227ca83bcd60662367c39f2869606928c922194d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chromium.try:win_x64_archive Reviewed-on: https://chromium-review.googlesource.com/c/1320471 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#607798}
-
Lei Zhang authored
Change-Id: Ib1a4632cead932fba7cf181ac95348b6468abb18 Reviewed-on: https://chromium-review.googlesource.com/c/1330905 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#607797}
-
Xiaocheng Hu authored
This patch changes |StartOfWord()| to utilize |TextSegments| class to make it work with LayoutNG. This patch also fixes existing incorrect behavior on fast/text/international/cjk-segmentation.html Bug: 778507 Change-Id: Iedee4632206154c8e813f3e43136c1a000e39435 Reviewed-on: https://chromium-review.googlesource.com/c/1309227 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607796}
-
Chris Hall authored
R=dmazzoni, aboxhall Change-Id: Iaaf842abe6071fc63550ee6ae68442b719597002 Reviewed-on: https://chromium-review.googlesource.com/c/1278623Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#607795}
-
Clifford Cheng authored
1. Tested on Mac and verify everything works as expected. 2. Removed the unnecessary call of GetNativeWindow(). 3. Added a flag to disable GPU for the test. GPU makes an slight impact on image conversion and the output image color. It is turned off to prevent noise. Bug: 898230 Change-Id: If69a900a2e1373075f58c80a2aaef526d856bb08 Reviewed-on: https://chromium-review.googlesource.com/c/1330297Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#607794}
-
Varun Khaneja authored
Bug: 867518 Change-Id: I33642f20943f3e21d9f882e7d29e075b71fa2f17 Reviewed-on: https://chromium-review.googlesource.com/c/1322362 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#607793}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab3176972380..5549f98ca7e4 Created with: gclient setdep -r src-internal@5549f98ca7e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1ab0ea2708c90a102d4efe230c546a3d8afe9064 Reviewed-on: https://chromium-review.googlesource.com/c/1334250Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607792}
-
Charlene Yan authored
MenuButtonEventHandler includes the old PressedLock and all other logic for controlling what a button should do (migrated from MenuButton). Bug: 901183 Change-Id: Ie2dbdfb088c8b2818ddc71445c88c349039bd84c Reviewed-on: https://chromium-review.googlesource.com/c/1297589 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607791}
-
Jazz Xu authored
Bug: 904554 Change-Id: I3026b7c47df4f3950450b5fd721ae84bab00e382 Reviewed-on: https://chromium-review.googlesource.com/c/1332718Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607790}
-
Samuel Huang authored
This CL adds main() to linker_map_parser.py, so it can be used to parse a linker map file directly. The results are then made available to an interactive Python console for further analysis. Also fix LLD .map file parsing to ignore 'PROVIDE_HIDDEN' lines that appear at the end of .map files and get confused with actual sections. Change-Id: Ice5a3b52495ed4eecd5deab7d890344bf740a20f Reviewed-on: https://chromium-review.googlesource.com/c/1334275Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607789}
-
Wez authored
This can be used to replace the current default ComponentContext with one backed by a supplied |service_root| channel, e.g. for testing. Bug: 893229 Change-Id: Ib08caf7527066c5b269d756a1726e1843c6431f5 Reviewed-on: https://chromium-review.googlesource.com/c/1333113 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607788}
-
Xiaocheng Hu authored
This patch solves the issue of crossing text control boundaries when using TextOffsetMapping. The changes include: 1. Change TextOffsetMapping::FindForward/BackwardInlineContents() not to cross text control boundaries: - If the initial position is in text control, keep traversal inside the text control - If the initial position is outside text control, all descendants of text control elements are skipped 2. Change flat tree TextIterator to respect the EntersTextControls flag, so that it doesn't dump the internal text of text controls elements to TextOffsetMapping, so that TextOffsetMapping won't give a result boundary inside text control. Many test cases are also added to TextIterator, TextOffsetMapping and word/sentence boundary algorithms. Bug: 901492 Change-Id: I61aa3d3679eb77b975b50fd52dc8f79e049d8e47 Reviewed-on: https://chromium-review.googlesource.com/c/1327962 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607787}
-
Manuel Rego Casasnovas authored
This is an extra case in which we can apply the SetText optimization introduced in r578233. If the text is longer than the container, but we know it's not going to wrap, then we can apply the optimization anyway and avoid the layout as we know it's not going to be split in multiple lines. Thanks to this patch the optimization will be applied in more cases. The patch also removes the TODO about trying to avoid measuring the text length. That was tried in https://chromium-review.googlesource.com/1275848 but discarded as it is not possible to avoid measuring the text if we want to store proper values for widths. Bug=805785 TEST=fast/css/containment/change-text-node-data-nowrap.html Change-Id: Ifa708d2a40b95254420750672941de18f5a6f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1333750Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#607786}
-
danakj authored
RenderWidgets attached to RenderView but without a main frame have no business making a frame sink. Normally this is the state where they are "swapped out" and we take great care to not make a frame sink in that case by keeping the compositor non-visible. Something isn't working out though so let's see why! R=piman@chromium.org Change-Id: Idc4e9e8184b6752f50a98a1efb82e436b1fcf08a Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1334002Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#607785}
-
Ken Rockot authored
Legacy IPC was switched to BigBuffer in https://crrev.com/4c5bd80e and therefore no longer needs to be capped at a maximum size. This removes a stale and unnecessary CHECK against the message size. Bug: 904415 Change-Id: I1934b06bb0adb3e1d1c6425f906d9f32784beb9b Reviewed-on: https://chromium-review.googlesource.com/c/1333989Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#607784}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c7e3af1ad928..428a160dd6bd git log c7e3af1ad928..428a160dd6bd --date=short --no-merges --format='%ad %ae %s' 2018-11-13 terelius@webrtc.org Remove rtc_event_log2text 2018-11-13 Peter) Slatala AudioSource allows implementations to return settings 2018-11-13 kwiberg@webrtc.org Run some peer connection end-to-end tests with an empty audio encoder factory 2018-11-13 nisse@webrtc.org Refactor bitrate configuration in CallTest Created with: gclient setdep -r src/third_party/webrtc@428a160dd6bd The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8656c81da9fb38b624dcd094c7437e480adb85c2 Reviewed-on: https://chromium-review.googlesource.com/c/1334247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607783}
-
John Abd-El-Malek authored
Remove content::IsOriginSecure call in Domain Reliablity, since GURL::SchemeIsCryptographic should be enough. Domain reliablity only cares about http(s) traffic, so the extra functionality in content::IsOriginSecure (e.g. file/filesystem, UI, local, about, data schemes) aren't needed. Bug: 853251 Change-Id: Ic43672a378722bb1c9c41a85ab78d8d7e466818c Reviewed-on: https://chromium-review.googlesource.com/c/1334277 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#607782}
-
John Abd-El-Malek authored
This reverts commit 4307dceb. Looks like we'll need to run this with the network service enabled, and it would run in the network process in that case. Bug: 853251 Change-Id: I28ebc8b0ef1d208e8855c16e19afa3ce6ab16640 Reviewed-on: https://chromium-review.googlesource.com/c/1334231Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#607781}
-
Eugene But authored
This CL adds OverscrollActionsController to SadTabViewController. OverscrollActionsController requires UIScrollView to work, so SadTabViewController creates a dummy scroll view to hold SadTabView. Bug: 901563 Change-Id: I564ed10b807d774b891d86c21cda58435a5681c2 Reviewed-on: https://chromium-review.googlesource.com/c/1332390Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#607780}
-
Lukasz Anforowicz authored
This is a follow-up to https://crrev.com/c/1318082 - the earlier CL fully fixes and re-enables URLLoaderFactories for extensions, but some additional hygiene improvements are also possible and made in the current, WebUI-focused CL. The current CL adds a new test to help make sure that some (WebUI-focused) test coverage remains even after AppCache deprecation finally happens. The regression test verifies that the default factory wasn't cloberred by ensuring that one of chrome://resources can still be loaded. For an overview of separate URLLoaderFactories for extensions, see https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Bug: 846346 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id1fbfe684514b4cf5e80558df123d78003063632 Reviewed-on: https://chromium-review.googlesource.com/c/1279177 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607779}
-
Joel Hockey authored
Added a new chrome.fileManagerPrivate.onCrostiniSharedPathsChanged function which receives type CrostiniSharedPathsChangedEvent. Changed CrostiniSharePath to be a keyed service class since it now holds state in the form of an ObserverList to receive unshare events. file_manager::EventRouter registers as an observer for UnsharePath events and propogates them to FilesApp. crostiniShare.testSharePathsCrostiniSuccess simulates an unshare event and verifies that it is handled correctly and a folder which is unshared can subsequently be shared again. Bug: 878324 Change-Id: I15ee3d75038f3bb3e127bd4f3effc3829a1854db Reviewed-on: https://chromium-review.googlesource.com/c/1329816Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#607778}
-
David Bokan authored
This feature has been shipping by default since M63. This means the browser-side gesture queue no longer coalesces events so I've removed the related code and unit tests. Bug: 625689 Change-Id: I8b943df47b2623656735f24f98a0b980daadbcce Reviewed-on: https://chromium-review.googlesource.com/c/1332769 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#607777}
-
Mark Pearson authored
This reverts commit 6111392d. Refactoring did do something, but the issue remained. The core problem I think is that the parent class fields are initialized first. This means the parent class's fields like content::TestBrowserThreadBundle get created, which I think will end up looking at field trial state. Adding a base::test::ScopedFeatureList after that happens is too late; the initial field trial state has already been inspected. I could create a separate class that lists the base::test::ScopedFeatureList first, and then all the other variables such as TestBrowserThreadBundle later. That might work. Or not; I think there are other reasons the TestBrowserThreadBundle wants to be listed first in the fields of a testing class. It's not worth the trouble to investigate. I'm happy to have coverage of the single MAYBE_ test on regular bot. I don't think we also need coverage of it on the ASAN (THREAD_SANITIZER) bots as well. Bug: 891959 Change-Id: Iae816dde484982060121c3e667b779d70da00e65 Reviewed-on: https://chromium-review.googlesource.com/c/1334269Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607776}
-
Renjie authored
WriteMemSlices. Flag protected by quic_reloadable_flag_quic_call_write_mem_slices. Merge internal change: 220883112 Change-Id: I55210e7812ca6e51b860b5df3aa303e49a369df6 Reviewed-on: https://chromium-review.googlesource.com/c/1332773 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#607775}
-
Wez authored
Zircon previously used an option to zx_socket_write() to close the socket for reading, or writing. Migrate to the new zx_socket_shutdown() API. Change-Id: Ia4067c4611713031048271800dd620a9c1b15e72 Reviewed-on: https://chromium-review.googlesource.com/c/1334329Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Adam Barth <abarth@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607774}
-
Miguel Casas authored
This CL adds CanvasResourceProvider unit tests. Also removes unused method InvalidateSurface(). Bug: 902585 Change-Id: I6602624ea4826d8cd307e4d973430e6c451aebd0 Reviewed-on: https://chromium-review.googlesource.com/c/1334148Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#607773}
-
Pavel Yatsuk authored
Specifics: +753,080 bytes normalized apk size +5 zip entries file count +66,544 bytes main lib size +467,128 bytes main dex size InstallSize: +288,634 bytes APK size +835,174 bytes Estimated installed size (Android Go) +2,175,831 bytes Estimated installed size InstallBreakdown (+2,175,416 bytes): +2,682 bytes unwind_cfi (dev and canary only) size +1,934 bytes Non-compiled Android resources size +66,544 bytes Native code size +351 bytes Package metadata size +2,089,637 bytes Java code size +14,268 bytes Compiled Android resources size Dex: +2,396 entries fields +3,285 entries methods +773 entries types +1,679 entries strings R=pnoland@chromium.org Binary-Size: Adding errors.proto, which is finally compatible with Chromium. Change-Id: I1cf123baf074706ae08e64612f51c36b6380afb6 Reviewed-on: https://chromium-review.googlesource.com/c/1333128 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#607772}
-
Quan Nguyen authored
Bug: 884668 Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67 Reviewed-on: https://chromium-review.googlesource.com/c/1330206Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607771}
-
Dominic Mazzoni authored
Bug: 903500 Change-Id: I4e55e0323fe642f8af0a79152a52bccc1cb6ac82 Reviewed-on: https://chromium-review.googlesource.com/c/1334195Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607770}
-
Sreerenj Balachandran authored
Without the ffmpeg decoder configured, libavformat is unable to get the codec profile and chromium ffmpeg wrapper code choose some defaults. This will mess up the decode scenarios where non-ffmpeg decoders like vaapi are in use. Fortunately, we can still get hold of the ffmpeg's AVStream extradata param which should contain the H264 AVCDecoderConfigurationRecord (ISO/IEC 14496-15). So we use internal parser for extracting profile information from this AVCDecoderConfigurationRecord. BUG=784610 TEST=media_unittests:FFmpegCommonTest.VerifyH264Profile Change-Id: Id67c7026eefb5bb73e6c5fbbab7a362cb4553ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1292605 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#607769}
-
Sammie Quon authored
Also fix issue where users could not backspace by using keyboard tab and space. Test: manual Bug: 881756, 862924 Change-Id: I0523784ad05d2a02219e95e90cd02b2d275da94f Reviewed-on: https://chromium-review.googlesource.com/c/1329748 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#607768}
-
Alex Newcomer authored
Increase the label size to 14px. Bug: 888610 Change-Id: If7063fafcd8247601e3c7af0bf8b179f76f9df0c Reviewed-on: https://chromium-review.googlesource.com/c/1329672Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607767}
-
Ben Pastene authored
Looks like no other tot bot uses goma, and the bot's currently failing since the goma client isn't available. Bug: 903078 Change-Id: I14e9a3772f3df464d5e6549fd785b20bc10d0509 Reviewed-on: https://chromium-review.googlesource.com/c/1334272Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607766}
-
Jay Harris authored
Bug: 904318 Change-Id: I3c0367bc925a5f3b78f3a0457c25ef3b7c807b38 Reviewed-on: https://chromium-review.googlesource.com/c/1333007Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#607765}
-