- 17 Jul, 2017 23 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c374229c..86deba2a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2c37e2305a47b6ecb52eefe5ce0bb6cb03692019 Reviewed-on: https://chromium-review.googlesource.com/574060Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487044}
-
Hidehiko Abe authored
This CL migrates ArcTracingBridge. BUG=672829 TEST=Ran try. Change-Id: Ibc52186e24f7e042dfc86541cecf7fc18d2dea50 Reviewed-on: https://chromium-review.googlesource.com/572887Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487043}
-
Bernhard Bauer authored
Bug: 739331 Change-Id: Id36a03f537feac9ec561300830df4966e3afc349 Reviewed-on: https://chromium-review.googlesource.com/566802 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#487042}
-
Alexandr Ilin authored
The project was turned down and the precache code is no longer executed. Removal is done in three steps: 1. Unwire precache from chrome/browser/predictors. (done http://crrev.com/c/561523) 2. Delete the rest use of precache. (done http://crrev.com/c/563409) 3. Delete all precache directories. (current) Bug: 739439 Change-Id: Ide5e797602a71d2dc657f11b84bed99a2ac17020 Reviewed-on: https://chromium-review.googlesource.com/561538 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487041}
-
Christian Dullweber authored
md-select is not aligned with its label due to unbalanced paddings and a 3px md-select-underline. This Cl fixes this by balancing md-select with an additional margin-top and reducing the height of md-select-underline to 0px + 1px border. Bug: 740887 Change-Id: I1b8a5b6bea9c30a686427fdffb96ee05df686259 Reviewed-on: https://chromium-review.googlesource.com/566826 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487040}
-
Mohamed Amir Yosef authored
Bug: 735465 Change-Id: I4810c94f4c5a0f9fd61915affd2a2fd8c7f7e29c Reviewed-on: https://chromium-review.googlesource.com/570638 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487039}
-
Nicholas Verne authored
Bug: 712963 Change-Id: Ib2f117d83dcf34c505249335197f797ccd962554 Reviewed-on: https://chromium-review.googlesource.com/572477 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487038}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b582195..c374229c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib7ab57ad7c2feeb6406131218bc06ae7e7034472 Reviewed-on: https://chromium-review.googlesource.com/572375Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487037}
-
Mohamed Amir Yosef authored
Bug: 735465 Change-Id: I4e1aa8d74be22dd96479f1d5c53e11c89358cfa0 Reviewed-on: https://chromium-review.googlesource.com/562757 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#487036}
-
Ramya Sharma authored
This CL moves editing, editIndexPaths, editingBar properties and their callbacks to super class BookmarksHomeViewController. from handset and tablet subclasses. Bug:705339 Change-Id: I7f1a7c5fa29aff104fbcba0d1f2a62d5647c6be2 TEST=Bookmarks functionality Change-Id: I7f1a7c5fa29aff104fbcba0d1f2a62d5647c6be2 Reviewed-on: https://chromium-review.googlesource.com/569506Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#487035}
-
Lutz Justen authored
DeviceStatusCollector collects resource usage stats every 2 minutes. The ActivityTimesKeptUntilSubmittedSuccessfully test compared two full instances of DeviceStatusReportRequest. In one run of the test, the test failed because the resource usage collection happened right in between. This CL compares activity times only (aka what the test is interested in) and removes the full status comparison. Also fixes an uninteresting mock function call and moves some functions from public to protected. BUG=chromium:743061 TEST=out/Release/browser_tests --gtest_filter=DeviceStatusCollectorTest.* Change-Id: I39d65260794326cae90d57ec583ff28e2d9a9092 Reviewed-on: https://chromium-review.googlesource.com/573901Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#487034}
-
Vaclav Brozek authored
GetShownOriginAndLinkUrl was recently updated to handle Android credentials correctly, by replacing the android:// URIs with a human-readable Play Store name for display and a Play Store web URL for linking to the app description. Android credentials are credentials stored in Android apps and uploaded to Chrome Sync. They can be used for filling on affiliated websites, so they are important on iOS as well. The change affects Android credentials as described above, but also web credentials, by changing slightly the presentation of the web origin (e.g., https:// prefix is removed). The new state is consistent with Chrome settings on desktop and soon also on Android. Screenshots with before and after are at https://crbug.com/628988#c19. Bug: 628988 Change-Id: Ib0f8219ed0eb652196aaa1717f075a14ee47db3d Reviewed-on: https://chromium-review.googlesource.com/571227 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#487033}
-
beaufort.francois authored
BUG=739670 Review-Url: https://codereview.chromium.org/2971903004 Cr-Commit-Position: refs/heads/master@{#487032}
-
beaufort.francois authored
BUG=739698 Review-Url: https://codereview.chromium.org/2967373002 Cr-Commit-Position: refs/heads/master@{#487031}
-
Trent Apted authored
With *and without* --secondary-ui-md: * Removes the colons from the field labels * Alters the text for insecure domains to say "Your connection to this site is not private" * Makes the dialog title and "Log in" button text sentence case on non-Mac/iOS * Removes " requires a username and password" after the domain for non-Proxy auth requests * Removes the insets on the sides of the textfield stack relative to the dialog title. * Removes the close button from the http-auth dialog With --secondary-ui-md only: * Uses SECONDARY / gray text for the second line of header text * Makes textfields 28px tall 3 general adjustments applicable to a class of dialogs remain to be done: * Too much spacing from the title to the body text, and * Too little spacing from the last textfield to the button row. * Textfields should horizontally align "somehow" we don't know how yet Adds ui/views/harmony/layout_helper.h to encapsulate methods for creating a textfield stack in the standard layout. Bug: 602392 Change-Id: I27fbc52c95d9bd8ac2a3551d916d3f161f51593f Reviewed-on: https://chromium-review.googlesource.com/559205Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#487030}
-
Timothy Loh authored
This patch make the lifetime of PermissionPrompt objects more sensible and match what we occasionally think it actually is. Currently these objects exist when a tab is active, or on Android all the time. This patch changes it so that, as the name might suggest, it corresponds to when a prompt is actually visible. We retain the distinction between desktop/Android where desktop hides the UI (now deletes the object) on tab switching, while Android retains the UI (keeps the object alive) as the InfoBar system manages hiding the prompt. Since we don't explicitly manage lifetimes of the actual UI surface on Android (infobars in particular, as it's clearer for modals when the UI is actually destroyed) from the PermissionPrompt, we change the pointer to a WeakPtr for safety. When the PermissionPrompt is destroyed due to navigation, if an infobar happens to still persist due to a bug it won't be able to be resolve different permission requests. Bug: 606138, 737102 Change-Id: I26a8843b9b446e91282a9b0ce67c4b442bf440e9 Reviewed-on: https://chromium-review.googlesource.com/567940 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487029}
-
Tim Sergeant authored
MD Bookmarks stamps a large amount of the same folder icon: 1 for every node in the sidebar, and 1 for every item in the list. While iron-icon is fast as far as Polymer elements go, stamping 50+ of them is still expensive. This CL switches all folder icons across the page to a plain divs that have an SVG background. This appears to save at least 5% of page load time on profiles with a large number of folders. Bug: 727177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I439f83ad3c3f645108d1a3d744cce2e402acbcee Reviewed-on: https://chromium-review.googlesource.com/566264Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#487028}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/248b789e..4b582195 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2209f6d52c351284ddb1480e160c18b74f9ae9e9 Reviewed-on: https://chromium-review.googlesource.com/573600Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487027}
-
Noel Gordon authored
The fuzzer color transform had the same input and output pixel color format in each run. In this change, create a mix of input and output color formats to add extra fuzz. Tbr: mmoroz@chromium.org Bug: 708016 Change-Id: I520eafad1959ae2d8688b156e24006718aaf4b0c Reviewed-on: https://chromium-review.googlesource.com/572890Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487026}
-
Antonio Gomes authored
Both chrome --mash and chrome --mus --use-ime-service use InputMethodMus for IME. In such cases, pages with 'content editable' elements simply hang with the following error and stack trace: [ERROR:validation_errors.cc(90)] Invalid message: VALIDATION_ERROR_UNKNOWN_ENUM_VALUE #1 0x56228f4e5a9e mojo::internal::ReportValidationError() #2 0x56228c7ee648 mojo::internal::TextInputState_Data::Validate() #3 0x56228c7e2da9 ui::mojom::internal::WindowTree_SetImeVisibility_Params_Data::Validate() #4 0x56228c9dfbe2 ui::mojom::WindowTreeRequestValidator::Accept() #5 0x56228f4d423c mojo::FilterChain::Accept() #6 0x56228f4d5755 mojo::InterfaceEndpointClient::HandleIncomingMessage() #7 0x56228f4dc84c mojo::internal::MultiplexRouter::ProcessIncomingMessage() #8 0x56228f4dc03f mojo::internal::MultiplexRouter::Accept() #9 0x56228f4d4256 mojo::FilterChain::Accept() (...) This happens because in InputMethodMus::UpdateTextInputType, ui::TextInputType::TEXT_INPUT_TYPE_CONTENT_EDITABLE is the value (correctly) used to construct the mojo::TextInputState instance to be sent to Mus. Down the road, WindowTreeClient::SetImeVisibility calls out to Mus passing the mojo::TextInputState instance created previously. At the mojo validation step, it fails (see stack above) because text_input_state.mojom does not declare CONTENT_EDITABLE (see IsKnownValue impl in <out>/gen/ui/platform_window/mojo/text_input_state.mojom-shared-internal.h). Patch fixes this by syncing up ui::TextInputType, blink::WebTextInputType and mojo::TextInputType. PS: For the sake of completeness, DATE_TIME_FIELD enum item was added, and mojo::TextInputType::LAST is renamed to ::MAX in order to be able to compile assert it against ui::TEXT_INPUT_TYPE_MAX. TEST=load any page with 'contenteditable' attr, in chrome --mash. BUG=718105,742491 Change-Id: Icbea847e7fc655ca3c04243fefb8d67abaaa9239 Reviewed-on: https://chromium-review.googlesource.com/570056 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487025}
-
Sam McNally authored
Allowing user-provided SequencedTaskRunners does not provide a clear benefit if they run on the same sequence and binding to a task runner that is not sequenced with the current task runner is not threadsafe so restrict user-provided task runners to SingleThreadTaskRunners that run on the current thread. Bug: 678155 Change-Id: I5472e39f688f47a8abdda516a6e2902fe18eee36 Reviewed-on: https://chromium-review.googlesource.com/544717 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487024}
-
Nico Weber authored
This works despite https://llvm.org/PR33796 here because these functions are in an unnamed namespace. Bug: 735328 Change-Id: Ia22c05303a0360573aa1a0385c6a3966767f84cd Reviewed-on: https://chromium-review.googlesource.com/573113Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487023}
-
Miguel Casas-Sanchez authored
This CL lands the service-side implementation of the mojom::VEA and unit tests for it. It doesn't connect it yet, but the final result can be found in https://crrev.com/c/558846. Bug: 736517 Change-Id: I6d77da653cfa8e4db9b2691707302fa2ad2d4479 Reviewed-on: https://chromium-review.googlesource.com/566262 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487022}
-
- 16 Jul, 2017 17 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1fcd10aae433..42102420c02a $ git log 1fcd10aae..42102420c --date=short --no-merges --format='%ad %ae %s' 2017-07-16 mtklein Revert "Inject a dsb into SkAnalyticEdge::setLine() to work around ARMv7 CPU erratum." Created with: roll-dep src/third_party/skia BUG=740805 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I6c7f21b7c92ae586ff56b9b97cc1a14fc0e09648 Reviewed-on: https://chromium-review.googlesource.com/573528Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487021}
-
Jinsuk Kim authored
This CL is to take care of errors when running an optional trybot android_n5x_swarming_dbg: Traceback (most recent call last): File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 61, in Main ret = self.args.func() File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 263, in CmdAnalyze return self.RunGNAnalyze(vals) File "/b/c/b/android_n5x_swarming_dbg/src/tools/mb/mb.py", line 1275, in RunGNAnalyze raise MBErr(err) MBErr: target "android_tools" not found in //testing/buildbot/gn_isolate_map.pyl target "system_webview_shell_layout_test_apk" not found in //testing/buildbot/gn_isolate_map.pyl step returned non-zero exit code: 1 The two targets are ignored for now. I'm not certain at this point whether they also needs testing. The build is not green yet with this CL. There are still some flaky tests and timed-out test suites. Will look into them in follow-up CLs. BUG=737910 Change-Id: Ia0119ebe9494e4c3c8df5844754a95f75ff47957 Reviewed-on: https://chromium-review.googlesource.com/558418Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#487020}
-
dskiba authored
This CL optimizes TracedValue::AppendAsTraceFormat() by removing intermediate base::Value conversion. HeapProfilerPerfTest.AppendStackFramesAsTraceFormat shows ~1.9x improvement on macOS (1730ms -> 920ms). TBR=jbauman@chromium.org BUG=739378, 664350 Review-Url: https://codereview.chromium.org/2975033002 Cr-Commit-Position: refs/heads/master@{#487019}
-
Hidehiko Abe authored
This CL migrates ArcProvisionNotificationService. BUG=672829 TEST=Ran try. Change-Id: If15cda269ecfad203efbb7ebfc4fb88114a9b843 Reviewed-on: https://chromium-review.googlesource.com/573000 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487018}
-
Hidehiko Abe authored
This CL migrates ArcPrintService. BUG=672829 TEST=Ran try. Change-Id: Ia223ec8dc9d05d044ddb66812cd322d705cb1d39 Reviewed-on: https://chromium-review.googlesource.com/572882 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487017}
-
Jinsuk Kim authored
This removes all the public native references to ContentViewCore from the embedder, which were indirections that became unnecessary. Now they can be handled by using WebContents, passing container view or view-specific coordinates values instead. For many parts, changes were made so that these values are converted from css to device pixel unit right before being passed up to Java layer. I think it helps the two units avoid being mixed in the code. BUG=626764 Change-Id: I7348c9aea00cde93f976d1bae3779270826dce03 Reviewed-on: https://chromium-review.googlesource.com/536895 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#487016}
-
dskiba authored
Profiling StackFrameDeduplicator with new heap format revealed that: 1. At least 60% of all insertions are hits, i.e. they insert backtraces that already exist. 2. There can be as many as 500K frames. 3. The average child count at each level is ~1.2. This CL optimizes StackFrameDeduplicator based on that data: 1. Adds a hash-based backtrace lookup to cut down number of lookups in FrameNode::children maps. 2. Changes FrameNode storage from std::vector to std::deque, avoiding costly vector reallocations. 3. Changes FrameNode::children storage from std::map to std::flat_map. These changes improve HeapProfilerPerfTest.DeduplicateStackFrames perftest ~1.6x on macOS (1040ms -> 620ms), but real-world impact should be higher because the perftest is pessimistic. BUG=739378 Review-Url: https://codereview.chromium.org/2977783002 Cr-Commit-Position: refs/heads/master@{#487015}
-
Mostyn Bramley-Moore authored
BUG=741927,743615 TEST=Running browser_tests with the flags below, should print "Using 1 parallel jobs." --run-manual --ui-test-action-max-timeout=350000 --test-launcher-jobs=1 --test-launcher-bot-mode --test-launcher-print-test-stdio=always TBR=phajdan.jr@chromium.org Change-Id: I33f2b4fc54b43ebec8a27c532da17146b42c07cd Reviewed-on: https://chromium-review.googlesource.com/573380Reviewed-by:
Mostyn Bramley-Moore <mostynb@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#487014}
-
Hidehiko Abe authored
This CL migrates ArcPowerBridge. BUG=672829 TEST=Ran try. Change-Id: I02dac942cbd31635120c62734032ca7611edae4b Reviewed-on: https://chromium-review.googlesource.com/572881 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487013}
-
Hidehiko Abe authored
This CL migrates ArcObbMounterBridge. BUG=672829 TEST=Ran try. Change-Id: Iac02330ae8ac2c0226f81ea25f5045494290da0d Reviewed-on: https://chromium-review.googlesource.com/572472 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487012}
-
Hidehiko Abe authored
This CL migrates ArcMetricsService. BUG=672829 TEST=Ran try. Change-Id: If61b381d0aac425117601b0f514aaebac431e9bc Reviewed-on: https://chromium-review.googlesource.com/572471 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487011}
-
Hidehiko Abe authored
This CL migrates ArcFileSystemMounter. BUG=672829 TEST=Ran try. Change-Id: I0fe8ac4c2d3aec887cd716b53cd5c02421d47b14 Reviewed-on: https://chromium-review.googlesource.com/572670Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487010}
-
Koji Ishii authored
Following bot results are included. 730 739 740 741 742 745 746 4022 lines were removed by consecutive passes since 681 (Jul 10). TBR=eae@chromium.org NOTRY=true BUG: 591099 Bug: Change-Id: I22cabe0f1175ddab6449e18d70ef63cc2e09d537 Reviewed-on: https://chromium-review.googlesource.com/572485 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487009}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1a325d25b941..1fcd10aae433 $ git log 1a325d25b..1fcd10aae --date=short --no-merges --format='%ad %ae %s' 2017-07-16 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Idafa5caed27b3921332735781a3833a5b393e98e Reviewed-on: https://chromium-review.googlesource.com/573280Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487008}
-
Felix Ekblom authored
In https://codereview.chromium.org/2964823002 the OobeDisplayChooser started using the DeviceDataManager to look for touchscreen devices when searching for a good primary display to use during OOBE. On device cold boot the DeviceDataManager has not yet found any touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely due to lower level systems not being fully initialized). This CL make LoginDisplayHostImpl an observer of changes to connected touchscreen devices, re-triggering the OobeDisplayChooser when the DeviceDataManager is notified of the connected touchscreens. This overcomes the timing issues on cold boot. Bug: 738885 Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd Reviewed-on: https://chromium-review.googlesource.com/569958Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#487007}
-
Koji Ishii authored
This is a follow up and minor cleanups after the initial NGBaseline patch[1]. 1. Addresses cbiesinger reviews. 2. NGBaseline has NGBaselineRequest as a member. 3. Some arguments are changed to use struct, not each member. [1] https://codereview.chromium.org/2867293002/ BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib781a08f3b85be6519b70f07413719d0a76db7e7 Reviewed-on: https://chromium-review.googlesource.com/571680 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#487006}
-
Tomasz Figa authored
When building from within a ChromiumOS chroot (and any other Gentoo-base system), the right command to call pkg-config is specified up front and needs to be honored. However currently Chromium build system always calls 'pkg-config' directly if --sysroot is given to the build. This ignores any necessary setup done by the board sysroot pkg-config wrapper used on ChromiumOS and causes host's paths being pulled into the build. Precisely, PKG_CONFIG_PATH is not being unset and PKG_CONFIG_SYSROOT_DIR is not being set to the sysroot path. Fix this by always using the specified pkg-config binary, even if sysroot is given. Even though, the problem could be fixed up by adding necessary setup to Chromium's pkg-config wrapper, it is not the right solution, as the setup is inherently sysroot specific and only the external build system is aware of necessary configuration to be done. Bug: 743366 Test: Build chromeos-chrome with host's /usr/lib64/pkgconfig/dbus-1.pc chmodded to a-r. Change-Id: I6e80dbaa94510e31aa5000c6cc31ca32b5e5cbe4 Reviewed-on: https://chromium-review.googlesource.com/572666Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomasz Figa <tfiga@chromium.org> Cr-Commit-Position: refs/heads/master@{#487005}
-