GitLab

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1318713003

git-svn-id: svn://svn.chromium.org/blink/trunk@201298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace null with isNull in comment because 'null' means nullptr typically.
We prefer not to use double negation so reverse impl in isNull and isNotNull.
It gets straightforward.

BUG=

Review URL: https://codereview.chromium.org/1318913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=n/a
R=tyoshino@chromium.org

Review URL: https://codereview.chromium.org/1316523003

git-svn-id: svn://svn.chromium.org/blink/trunk@201296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In a couple of places, we now have a larger cull rect bound for drawing recorders
because of using enclosingIntRect. This is always safe to do.

BUG=524259

Review URL: https://codereview.chromium.org/1316163002

git-svn-id: svn://svn.chromium.org/blink/trunk@201295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, SegmentedString::push() had an exotic behavior, where
two consecutive push would swap its order.

This CL changes the push() implementation so that it would always push
the new char in front of the SegmentedString.
This CL also updates the HTMLEntityParser code which relied on the behavior.

BUG=None
TEST={SegmentedStringTest,HTMLEntityParserTest}.*

Review URL: https://codereview.chromium.org/1308573006

git-svn-id: svn://svn.chromium.org/blink/trunk@201294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change Rect and Quad to be CSSQuadValue, and remove rects and quads from
CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1304993002

git-svn-id: svn://svn.chromium.org/blink/trunk@201293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords (patchset #5 id:80001 of https://codereview.chromium.org/1314923005/ )

Reason for revert:
Broke WebKit Linux Leak

See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13676

Original issue's description:
> Deprecate 'intrinsic' and 'min-intrinsic' CSS keywords
> 
> Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion
> 
> I plan to merge this to the M46 branch ASAP.
> 
> R=esprehn@chromium.org,yoav@yoav.ws
> BUG=475104
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201259

TBR=esprehn@chromium.org,yoav@yoav.ws,cbiesinger@google.com,cbiesinger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475104

Review URL: https://codereview.chromium.org/1318933002

git-svn-id: svn://svn.chromium.org/blink/trunk@201292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This case contains SVG zoom/scroll animation including 20 frames zoom in, 
20 frames scroll and 20 frames zoom out. Final result is total time used to 
animate these 60 frames.

Review URL: https://codereview.chromium.org/1267093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated all const methods on CSSPrimitiveValue to actually use the
const keyword. This is needed for later work that calls methods on const
references of CSSPrimitiveValue.

BUG=523893

Review URL: https://codereview.chromium.org/1314783002

git-svn-id: svn://svn.chromium.org/blink/trunk@201290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |Position| version of |enclosingBlock()| as a preparation
of templatzing it.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed a bug in CSSCursorImageValue::equals() which was causing any
cursor images with the same hotspot to be treated as equal. Also added a
test.

BUG=510188

Review URL: https://codereview.chromium.org/1311783009

git-svn-id: svn://svn.chromium.org/blink/trunk@201288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rects incorrectly included composited scroll offset. They should not, and
instead follow the example set by https://codereview.chromium.org/1287413002.

BUG=524547

Review URL: https://codereview.chromium.org/1315203002

git-svn-id: svn://svn.chromium.org/blink/trunk@201287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes duplicated decrementAndCheckLength() logic in SegmentedString.

BUG=None
TESTS=Refactoring only. No change in behaviour

Review URL: https://codereview.chromium.org/1320813002

git-svn-id: svn://svn.chromium.org/blink/trunk@201286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes the visual-viewport-managed scrollbars exclusive to
Android and improves normal scrollbars to be usable during pinch as follows:

1. Attach the scrollbar layers to the visual viewport, so they're always
   onscreen as you zoom in (as already shipped on Mac).
2. Set the container layer to the inner clip layer, so that the size and
   position of the thumb reflects the sum of the two viewports,
   instead of just the layout viewport.

Note that result of these changes is visually indistiguishable at
minimum page scale.  It only improves the behavior when zoomed in.

BUG=523056

Review URL: https://codereview.chromium.org/1308053003

git-svn-id: svn://svn.chromium.org/blink/trunk@201285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a trivial patch, split off from https://codereview.chromium.org/1315993004.
This patch removes an incorrect "paintOffset" name and fixes the recorder
type in BlockFlowPainter.

Review URL: https://codereview.chromium.org/1316883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes a few small clean-ups to getValueName:
- Type argument as CSSValueID instead of unsigned short
- Disallow trying to serialize invalid CSSValueIDs
- Don't add values for CSSValueInvalid in the offset tables

Review URL: https://codereview.chromium.org/1302273005

git-svn-id: svn://svn.chromium.org/blink/trunk@201283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We no longer need paint-phase-based subtree display items because we'll
use paint layers as units of subtrees. This greatly simplifies subtree
caching.

Renamed subtree to subsequence.

BUG=410087

Review URL: https://codereview.chromium.org/1313223002

git-svn-id: svn://svn.chromium.org/blink/trunk@201282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method should be allowed to execute JS since it needs it to collect call stack.

BUG=525305

Review URL: https://codereview.chromium.org/1313693007

git-svn-id: svn://svn.chromium.org/blink/trunk@201280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525109

Review URL: https://codereview.chromium.org/1311363007

git-svn-id: svn://svn.chromium.org/blink/trunk@201279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specification at https://heycam.github.io/webidl/#idl-constants mentions the constants
should be defined as:

  const type identifier = value;

whereas the |type| is mentioned as:

  The type of a constant (matching ConstType) must not be any type other than a primitive
  type or a nullable primitive type

And string literals are not treated as primitive types. Hence we should remove the support
for having a constant like:

  const DOMString hello = "world";

BUG=469961

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1315663004

git-svn-id: svn://svn.chromium.org/blink/trunk@201278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When user use styles formatting option with borders it can be important to not produce additional string tokens.

BUG=520724
R=lushnikov@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1310303004

git-svn-id: svn://svn.chromium.org/blink/trunk@201277 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520259

Review URL: https://codereview.chromium.org/1309033003

git-svn-id: svn://svn.chromium.org/blink/trunk@201275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL allows us to remove another shim, InlineBox::deprecatedBoxModelObject,
and clears the way for removing all direct LayoutObject access in core/line/.

BUG=499321

Review URL: https://codereview.chromium.org/1310473003

git-svn-id: svn://svn.chromium.org/blink/trunk@201274 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=461320

Review URL: https://codereview.chromium.org/1319823002

git-svn-id: svn://svn.chromium.org/blink/trunk@201273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201226

BUG=524623
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1318003002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201237

BUG=525050
TBR=caryclark@google.com

Review URL: https://codereview.chromium.org/1317993002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a subset of https://codereview.chromium.org/1313763002/.

The tests have to be removed in a separate patch to unblock the Chromium-side
patch: https://codereview.chromium.org/1314643002/.

BUG=524115

Review URL: https://codereview.chromium.org/1303233007

git-svn-id: svn://svn.chromium.org/blink/trunk@201270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525295,525296,525299,525300

git-svn-id: svn://svn.chromium.org/blink/trunk@201269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This includes the following changes:
- Material design icons to match the current mocks better.
- Rename securityPanel.css into mainView.css, because it only contains main view CSS anyhow.
- Rewrite security panel main view DOM code to match the mocks.

BUG=484387

Review URL: https://codereview.chromium.org/1316853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522796

Review URL: https://codereview.chromium.org/1307843002

git-svn-id: svn://svn.chromium.org/blink/trunk@201266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The friends of LayoutObject only need to access the layout tree mutation
methods, but get access to all LayoutObject private members.

Add LayoutObject::setDangerousOneWayParent() to avoid friends.

Expose several private/protected members to public which were accessed
using friend relationship.

Review URL: https://codereview.chromium.org/1306993002

git-svn-id: svn://svn.chromium.org/blink/trunk@201265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's an experimental "IDB v2" API implemented by both Firefox and
Chrome. Import the Moz test to ensure we're compatible.

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1316203002

git-svn-id: svn://svn.chromium.org/blink/trunk@201264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3/flexbox/repaint-rtl-column.html

Mark it as failing on Yosemite and pass everywhere else.

R=ojan@chromium.org
BUG=520167

Review URL: https://codereview.chromium.org/1294853002

git-svn-id: svn://svn.chromium.org/blink/trunk@201263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyClippingToContext is equally "stateful", so the two entrypoints
does not seem warranted.
Fold applyClippingToContext into applyStatefulResource and then rename
it to prepareEffect (to match mask and filter). Similarly rename
postApplyStatefulResource to finishEffect.

Review URL: https://codereview.chromium.org/1308223003

git-svn-id: svn://svn.chromium.org/blink/trunk@201262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch renames |isBlock(Node*)| to |isEnclosingBlock(Node*)| to make
meaning of function cleaner for improving readability.

This is follow up patch of http://crrev.com/1309903003, which introduces
|enclosingNodeOfType()|, which uses |isBlock()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; No behavior changes

Review URL: https://codereview.chromium.org/1320573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=525286

git-svn-id: svn://svn.chromium.org/blink/trunk@201260 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to deprecate: https://groups.google.com/a/chromium.org/d/topic/blink-dev/R9JzO74jYvI/discussion

I plan to merge this to the M46 branch ASAP.

R=esprehn@chromium.org,yoav@yoav.ws
BUG=475104

Review URL: https://codereview.chromium.org/1314923005

git-svn-id: svn://svn.chromium.org/blink/trunk@201259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Switch keypad and auto repeat booleans to use enum flags. Space was reserved
for them; this just brings PlatformKeyboardEvent more inline with
WebInputEvent.

BUG=524626

Review URL: https://codereview.chromium.org/1311233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524387

Review URL: https://codereview.chromium.org/1310863003

git-svn-id: svn://svn.chromium.org/blink/trunk@201257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521900

Review URL: https://codereview.chromium.org/1315703002

git-svn-id: svn://svn.chromium.org/blink/trunk@201256 bbb929c8-8fbe-4397-9dbb-9b2b20218538