- 17 Jul, 2014 40 commits
-
-
tdanderson@chromium.org authored
Removes some obsolete TODOs from the code. BUG=355425 TEST=none Review URL: https://codereview.chromium.org/395223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283796 0039d316-1c4b-4281-b951-d872f2087c98
-
mkwst@chromium.org authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/401613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283795 0039d316-1c4b-4281-b951-d872f2087c98
-
paulirish@chromium.org authored
I'm refiling the CL from https://codereview.chromium.org/283603003/ on behalf of mem. BUG= Review URL: https://codereview.chromium.org/391243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283792 0039d316-1c4b-4281-b951-d872f2087c98
-
kpschoedel@chromium.org authored
The ChromeOS Diamond key arrives as F15. Since F15 is not a modifier, we need to track its pressed state explicitly, and apply the selected modifier flag to key and mouse presses that arrive while F15 is down. (Maintaining and applying the modifier state in the rewriter is consistent with how the sticky keys feature is implemented.) TEST=EventRewriterTest.TestRewriteDiamondKey* BUG=390982 Review URL: https://codereview.chromium.org/399443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283791 0039d316-1c4b-4281-b951-d872f2087c98
-
bruthig@chromium.org authored
Fixed TrayBackgroundView::GetBubbleAnchorRect to handle left/right alignment when the tray isn't visible. BUG=392473 Review URL: https://codereview.chromium.org/391213002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283790 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283789 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/400523006/gab@chromium.org authored
Reason for revert: Speculative revert to fix Mac compile (http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/6454/steps/compile/logs/stdio#error1) (...) [381/849 | 12.544] LINK cast_unittests, POSTBUILDS [382/849 | 13.277] CXX obj/third_party/WebKit/Source/web/tests/webkit_unit_tests.RunAllTests.o [383/849 | 13.756] CXX obj/third_party/WebKit/Source/core/html/webkit_unit_tests.TimeRangesTest.o ld:warning: could not create compact unwind for _S32A_Opaque_BlitRow32_SSE4_asm: stack subl instruction is too different from dwarf stack size [384/849 | 16.741] CXX obj/third_party/WebKit/Source/core/page/webkit_unit_tests.NetworkStateNotifierTest.o FAILED: if [ ! -e mojo_html_viewer.so -o ! -e mojo_html_viewer.so.TOC ] || otool -l mojo_html_viewer.so | grep -q LC_REEXPORT_DYLIB ; then /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.TOC; else /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o mojo_html_viewer.so @mojo_html_viewer.so.rsp && { otool -l mojo_html_viewer.so | grep LC_ID_DYLIB -A 5; nm -gP mojo_html_viewer.so | cut -f1-2 -d' ' | grep -v U$; true; } > mojo_html_viewer.so.tmp && if ! cmp -s mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC; then mv mojo_html_viewer.so.tmp mojo_html_viewer.so.TOC ; fi; fi ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984 file 'libmodules.a' for architecture i386 clang:error: linker command failed with exit code 1 (use -v to see invocation) FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-search_paths_first -Wl,-pie -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_unittests obj/ppapi/host/ppapi_unittests.resource_message_filter_unittest.o obj/ppapi/proxy/ppapi_unittests.device_enumeration_resource_helper_unittest.o obj/ppapi/proxy/ppapi_unittests.file_chooser_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.file_system_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.flash_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.interface_list_unittest.o obj/ppapi/proxy/ppapi_unittests.mock_resource.o obj/ppapi/proxy/ppapi_unittests.nacl_message_scanner_unittest.o obj/ppapi/proxy/ppapi_unittests.pdf_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_dispatcher_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_resource_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.plugin_var_tracker_unittest.o obj/ppapi/proxy/ppapi_unittests.ppb_var_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_private_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_instance_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.ppp_messaging_proxy_unittest.o obj/ppapi/proxy/ppapi_unittests.printing_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.raw_var_data_unittest.o obj/ppapi/proxy/ppapi_unittests.serialized_var_unittest.o obj/ppapi/proxy/ppapi_unittests.talk_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.video_decoder_resource_unittest.o obj/ppapi/proxy/ppapi_unittests.websocket_resource_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_audio_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_buffer_manager_unittest.o obj/ppapi/shared_impl/ppapi_unittests.media_stream_video_track_shared_unittest.o obj/ppapi/shared_impl/ppapi_unittests.proxy_lock_unittest.o obj/ppapi/shared_impl/ppapi_unittests.resource_tracker_unittest.o obj/ppapi/shared_impl/ppapi_unittests.thread_aware_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.time_conversion_unittest.o obj/ppapi/shared_impl/ppapi_unittests.tracked_callback_unittest.o obj/ppapi/shared_impl/ppapi_unittests.var_tracker_unittest.o libppapi_host.a libppapi_proxy.a libppapi_shared.a libppapi_unittest_shared.a librun_all_unittests.a libtest_support_base.a libgpu_ipc.a libipc.a libtest_support_ipc.a libshared_memory_support.a libgmock.a libgtest.a libsurface.a libbase.a libbase_static.a liballocator_extension_thunks.a libmodp_b64.a libdynamic_annotations.a libmach_override.a libudis86.a libevent.a libskia_library.a libskia_opts.a libskia_opts_ssse3.a libskia_opts_sse4.a libchrome_zlib.a libsfntly.a libicuuc.a libicudata.a libskia_chrome.a libskia_chrome_opts.a libui_base.a libbase_i18n.a libicui18n.a libnet.a libbase_prefs.a libcrcrypto.a libcrnspr.a libcrnss.a libnss_static.a libsqlite3.a libsdch.a liburl_lib.a libcrssl.a libevents_base.a libgfx.a libharfbuzz-ng.a libpng.a libgfx_geometry.a libjpeg_turbo.a libdom4_keycode_converter.a libevents_platform.a libevents.a libgesture_detection.a libmozilla.a libgl_wrapper.a libgles2_utils.a libppapi_ipc.a libcommand_buffer_common.a libevents_ipc.a libcommand_buffer_client.a libgles2_implementation.a libgles2_cmd_helper.a libblink_platform.a libwtf.a libblink_common.a libblink_heap_asm_stubs.a libgles2_c_lib.a libwebp_dec.a libwebp_dsp.a libwebp_utils.a libwebp_demux.a libwebp_enc.a libots.a libbrotli.a libqcms.a libv8_base.a libv8_libbase.a libv8_snapshot.a libiccjpeg.a libblink_web.a libwebcore_dom.a libtranslator.a libtranslator_lib.a libpreprocessor.a libxml2.a libxslt.a libwebcore_html.a libwebcore_remaining.a libwebcore_rendering.a libwebcore_svg.a libwebcore_generated.a libgin.a libmodules.a -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework Foundation -framework IOKit -framework Security -framework IOSurface -framework Accelerate -framework AudioUnit -framework CoreVideo -framework SystemConfiguration /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/usr/lib/libresolv.dylib -framework CoreServices -framework OpenGL -framework QuartzCore && (export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export EXECUTABLE_NAME=ppapi_unittests; export EXECUTABLE_PATH=ppapi_unittests; export FULL_PRODUCT_NAME=ppapi_unittests; export PRODUCT_NAME=ppapi_unittests; export PRODUCT_TYPE=com.apple.product-type.tool; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../ppapi; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}"; (cd ../../ppapi && ../build/mac/change_mach_o_flags_from_xcode.sh); G=$?; ((exit $G) || rm -rf ppapi_unittests) && exit $G) ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984 file 'libmodules.a' for architecture i386 clang:error: linker command failed with exit code 1 (use -v to see invocation) FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -bundle -Wl,-search_paths_first -Wl,-ObjC -Wl,-dead_strip -mmacosx-version-min=10.6 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -arch i386 -L. -o ppapi_tests.plugin/Contents/MacOS/ppapi_tests @ppapi_tests.plugin.rsp ld: malformed archive TOC entry for __ZN5blink13V8Coordinates11domTemplateEPN2v87IsolateE, offset 327528552 is beyond end of file 12713984 file 'libmodules.a' for architecture i386 clang:error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original issue's description: > Blink roll 178334:178351 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178335:178351&mode=html > TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283779 TBR=abarth@chromium.org,eseidel@chromium.org,johnme@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/405473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283788 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
Ignore a real uninit in CLD2 which is causing crashes in a large number of tests. This is an exceptional measure to unblock MSan deployment. BUG=334448 TBR=eugenis@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/391253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283787 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/396563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283786 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
This is needed for FailureValue patch (so that one can call AddValue(FailureValue)). This also brings us closer to merging PageTestResults and PageMeasurementResults -- to kill the rest of the methods, we will need to make more progress on merging PageTest and PageMeasurement. Unit tests aren't moved because they still depend on {Will,Did}MeasurePage. Additional cleanup: kill dead code in page_measurement_results.py (self._done). BUG=383635,392901 Review URL: https://codereview.chromium.org/398583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283785 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283784 0039d316-1c4b-4281-b951-d872f2087c98
-
Gordana.Cmiljanovic@imgtec.com authored
283418: [MIPS] Make srtp_driver compile for MIPS BUG= Review URL: https://codereview.chromium.org/396803006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283783 0039d316-1c4b-4281-b951-d872f2087c98
-
mkwst@chromium.org authored
For example: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%281%29/builds/2843/steps/content_browsertests/logs/SingleProcess BUG=394775 TBR=groby@chromium.org, gab@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/402613007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283782 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
> Fix silly mistakes > * The original CL was totally broken. sorry about that. > *add missing ui_resources. > > BUG=None > TBR=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/401613004 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/404533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283781 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283780 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178335:178351&mode=html TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org BUG= Review URL: https://codereview.chromium.org/400523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283779 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
It has been failing since it was added. BUG=394756 TBR=wiltzius@chromium.org NOTRY=True NOTREECHECKS=True Review URL: https://codereview.chromium.org/399613011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283775 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
* The original CL was totally broken. sorry about that. *add missing ui_resources. BUG=None TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/401613004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283774 0039d316-1c4b-4281-b951-d872f2087c98
-
kangil.han@samsung.com authored
SPEC: http://www.whatwg.org/specs/web-apps/current-work/#document.title According to spec, set title without head element should be aborted in steps. So to continue test as well as follow spec, NoCallbackAtLoad test case should create head element before setting title. Review URL: https://codereview.chromium.org/400523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283773 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
Also add mentioning that some constants have been copied to Chromium OS. BUG=none Review URL: https://codereview.chromium.org/397543005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283772 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
switches::kNaClLoaderProcess is referenced by chrome_main_delegate.cc but isn't found by the linker. BUG=None Review URL: https://codereview.chromium.org/398323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283771 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Change AndroidHistoryProviderService::MoveStatement to use base::CancelableTaskTracker instead of CancelableRequestConsumer. BUG=371818 Review URL: https://codereview.chromium.org/366133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283770 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283769 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/9d7321c9d0412779a29c4b09962e7ce12936bbc4..3f376a55002c205aacacc4cb16ed745e3afbad31 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=halcanary@google.com BUG= Review URL: https://codereview.chromium.org/400533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283768 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
This also introduce the notion of message header to allow routing. R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/371603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283767 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
These functions are defined but not used on ASan-enabled build. That causes build failure on ASan-enabled build without -w flag. BUG=162783 Review URL: https://codereview.chromium.org/388263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283766 0039d316-1c4b-4281-b951-d872f2087c98
-
pneubeck@chromium.org authored
This uploads key files before changing the unit test, as the Commit-Queue has problems with binary files. Main CL will be committed afterwards: https://codereview.chromium.org/394013005/ BUG=210525, 329735, 315285 TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/399103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283765 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
The native viewport service on android must run on the main thread of the application. Because it is expected at the moment to run on its own thread, this CL move the shell thread on android to a secondary background thread and use the main thread of the application for the native viewport service. Review URL: https://codereview.chromium.org/399663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283764 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
Display the name of the domain for which enrollment is recovered and restart the browser after enrollment recovery to avoid login screen breakage. BUG=389481 Review URL: https://codereview.chromium.org/387403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283763 0039d316-1c4b-4281-b951-d872f2087c98
-
bratell@opera.com authored
With gcc, ObserverList expands to 6-700 bytes every time it is iterated. By not trying to force OberservListBase to be inline that shrinks some. clang already ignores the hints to inline the code and actually doesn't change a single bit in the generated program with this change. raw data: Total change: -90875 bytes ========================== 262 added, totalling +39188 bytes across 2 sources 49 removed, totalling -27573 bytes across 16 sources 23 grown, for a net change of +3600 bytes (34968 bytes before, 38568 bytes after) across 8 sources 228 shrunk, for a net change of -106090 bytes (239819 bytes before, 133729 bytes after) across 53 sources The additions is about 2-300 different flavours of ObserverListBase, 100-300 bytes each. The savings are 200-600 bytes each every time an observer list is used. For example: -870: content::RenderFrameImpl::didFailLoad(blink::WebLocalFrame*, blink::WebURLError const&) type=t, (was 1635 bytes, now 765 bytes) -895: content::RenderFrameImpl::didFinishLoad(blink::WebLocalFrame*) type=t, (was 1646 bytes, now 751 bytes) -583: content::WebContentsImpl::DidFailProvisionalLoadWithError(content::RenderFrameHostImpl*, FrameHostMsg_DidFailProvisionalLoadWithError_Params const&) type=t, (was 768 bytes, now 185 bytes) -611: content::WebContentsImpl::DidStartProvisionalLoad(content::RenderFrameHostImpl*, GURL const&, bool, bool) type=t, (was 895 bytes, now 284 bytes) BUG=394311 Review URL: https://codereview.chromium.org/396473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283762 0039d316-1c4b-4281-b951-d872f2087c98
-
ppi@chromium.org authored
When setting the navigationStart recorded on the browser side for browser-initiated navigations, we need to ensure the time is lower than the time of starting the load on the renderer side. Otherwise with heavy clock differences between processes and particularly fast navigation start-ups we could end up pushing the navigationStart *forward* and hitting an assert that is being deployed in https://codereview.chromium.org/379873002/ . BUG=376004 Review URL: https://codereview.chromium.org/384503009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283761 0039d316-1c4b-4281-b951-d872f2087c98
-
aiolos@chromium.org authored
BUG=394390 Review URL: https://codereview.chromium.org/391393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283760 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
It is assumed that no indexes exist before. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOnDiskTest.*" Review URL: https://codereview.chromium.org/391623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283759 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
This mirrors a similar change to WindowTreeHostOzone. BUG=392280 TEST=built with chromeos==1 use_ozone==1 & ran with egltest Review URL: https://codereview.chromium.org/390493003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283758 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
The media browser tests (content and chrome) load data from media/test/data. BUG=379314 Review URL: https://codereview.chromium.org/399693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283757 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
This CL should fix a memory corruption in a unit_tests which is recently introduced. That is caused by sync task invocation after SyncFileSystemService::Shutdown. BUG=394460 TEST=unit_tests --gtest_filter='SyncFileSystemServiceTest.*' Review URL: https://codereview.chromium.org/395333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283756 0039d316-1c4b-4281-b951-d872f2087c98
-
shuchen@chromium.org authored
Checks whether background is defined in IME extension manifest. And also move KeyEventDone logic from InputMethodEngine to input_ime_api.cc. BUG=394682, 394420 TEST=Verified on linux_chromeos and Pixel device. Review URL: https://codereview.chromium.org/400523005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283755 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
This change fixes the SourceBufferStream unit tests so that they always provide valid durations for buffers that it passes to SourceBufferStream. I've also added code to SoureBufferStream to verify that it always gets buffers with valid durations. Minor tweaks to test expectations were needed to compensate for the SourceBufferStream behaving differently when it got actual durations instead of using the durations it made up. In most cases I just used the duration the SourceBufferStream was ultimately using. In a few cases the duration the SourceBufferStream was generating didn't make any sense so I simply changed the expectations to match the new behavior. This is an attempt to reland https://codereview.chromium.org/379693002/ with appropriate crash fixes. Review URL: https://codereview.chromium.org/393403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283754 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
BUG=393815 R=thakis@chromium.org Review URL: https://codereview.chromium.org/393903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283753 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=382301 TEST=Panel interactive_ui_tests pass Review URL: https://codereview.chromium.org/368163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283752 0039d316-1c4b-4281-b951-d872f2087c98
-