- 01 Mar, 2018 40 commits
-
-
Brian White authored
Extensions are covered by a different setting under sync. If that setting is enabled then extension:// urls can be included in UKM information. This only works if the broader system has consent. Bug: 810766 Change-Id: Id0ba274ee4bceafe4521ce1f2f1060533cccc2ac Reviewed-on: https://chromium-review.googlesource.com/911591 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#540134}
-
Hans Wennborg authored
num_ack_blocks is a uint8_t, so "num_ack_blocks - 1" would have type int, causing MSVC to warn. TBR=rch Bug: 817722 Change-Id: I4d9cbc0cf266dc00174ab73f66d80e56fc007ad2 Reviewed-on: https://chromium-review.googlesource.com/941945 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540133}
-
https://chromium.googlesource.com/catapult.git/+log/b019720d08b2..279fcf542e09 $ git log b019720d0..279fcf542 --date=short --no-merges --format='%ad %ae %s' 2018-03-01 perezju Revert "[Telemetry] Remove PageTestResults.failures getter" 2018-02-28 perezju Reland "[Telemetry] Simplify code for --browser=exact on Android" 2018-02-28 eakuefner [TBMv2] Allow nulls to be stably stringified 2018-02-28 eakuefner [Telemetry] Don't populate benchmark_descriptions if not set 2018-02-28 eakuefner [TBMv2] Factor mergeHistograms out in merge_histograms_cmdline 2018-02-27 eakuefner [Telemetry] Remove PageTestResults.failures getter 2018-02-28 eakuefner [Dashboard] Remove spurious print in add_histograms_queue Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6dd7aaf71029d8ff15086e2d59eb8588c19d7710 Reviewed-on: https://chromium-review.googlesource.com/942801 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540132}
-
Yoshifumi Inoue authored
This patch makes |SelectionAdjuster| not to call |SetAsBackwardSelection()| of |SelectionTemplate::Builder| with logically collapsed range because |SetAsBackwardSelection()| expects |range.end > range.start|. Note: |EphemeralRange| constructor checks |start <= end| Note: logically collapsed range means |Position::CompareTo(other)| for start and end positions returns 0, e.g. "abc"@0 and before "abc". This patch is a preparation of the patch[1]. [1] http://crrev.com/c/939142 Utilize selection_test() to editing/selection/select-across-readonly-input-[1-5].html Change-Id: I6e39b69aa9b0975255d262f9346506d22f800dad Reviewed-on: https://chromium-review.googlesource.com/938871 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#540131}
-
Oskar Sundbom authored
This CL adds platform support for the native echo canceller available in macOS 10.12+, as well as a way to enable it through a runtime flag or Origin Trial. A native echo canceller has the opportunity to perform better than a general one in that it can be tuned for the hardware platform in question. In this case, it's also closer to the hardware, so it's less likely to be affected by IPC glitches. Intent to Implement discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kEld5OudUOM Bug: chromium:776327 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia828ae2b9e6503ca814de4154dee96c63b838e1d Reviewed-on: https://chromium-review.googlesource.com/941321 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#540130}
-
tzik authored
This CL moves RepeatingTimer and OneShotTimer to Timer by removing BaseTimerMethodPointer, which is a middle level class. Bug: 817344 Change-Id: I33ff580694a7359332ca4fcdc39b9d58c1d091b6 Reviewed-on: https://chromium-review.googlesource.com/940903Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#540129}
-
Eric Seckler authored
Viz doesn't really support WebContentsObserver::DidReceiveCompositorFrame. As our use of this for headless isn't really necessary in full-pipe + surface-sync mode (now our supported configuration), this patch removes this use along with related DevTools parameters / events. Also refactors CompositorController / VirtualTimeController's StartDeferrer: CompositorController is now able to defer both start and resume of virtual time. This way, it knows for certain that all other tasks have completed the current virtual time pause and that virtual time is about to resume. Tests still fail with --enable-features=VizDisplayCompositor, probably because viz's support for software compositing isn't fully ready yet. Bug: 786067 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iba775e4ef7ed77d7d7bf9837d6971be70a53cedb Reviewed-on: https://chromium-review.googlesource.com/934723Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540128}
-
Scott Chen authored
Same fix as CL https://chromium-review.googlesource.com/934244 but for Mac. Bug: 814555 Change-Id: Ie4e04b8f1b586daee5a8b4a876d023ab1d09896a Reviewed-on: https://chromium-review.googlesource.com/939393 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#540127}
-
Aleksandar Stojiljkovic authored
BUG=674440 Change-Id: Ie33ae36877d56987bb3b1ea366558a6afb677a8f Reviewed-on: https://chromium-review.googlesource.com/940301Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Cr-Commit-Position: refs/heads/master@{#540126}
-
Marc Treib authored
This adds UMA histograms to record the number of Wallet credit cards and addresses that were added and removed during each Sync cycle (i.e. during startup, and whenever we receive an update from the server). Bug: 816831 Change-Id: I6673e1737f79dea9669b3a96f0ae9164645ea8da Reviewed-on: https://chromium-review.googlesource.com/937710 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540125}
-
Sylvain Defresne authored
In PreloadController, use NavigationManager::LoadIfNecessary instead of calling Tab -view to force the navigation. Bug: 705819 Change-Id: If7814ebd60e1100f56bcb15d817f1d8ec04be1b2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/941330 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#540124}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: Ibe9c43518045a8ef7e9034c22f551b9a9f77133e Reviewed-on: https://chromium-review.googlesource.com/941829Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540123}
-
Guido Urdaneta authored
This CL fixes the stream type used to notify MediaObserver about cancelled MediaStream requests. Before this CL, NUM_MEDIA_TYPES was used as stream type to indicate that all stream types should be cancelled. However, the MediaObserver end does not interpret NUM_MEDIA_TYPES this way and the request to update the UI is ignored. This CL sends a separate notification for each stream type so that the UI actually gets updated for all stream types in use. Bug: 816033 Change-Id: Ib7d3b3046d1dd0976627f8ab38abf086eacc9405 Reviewed-on: https://chromium-review.googlesource.com/939630 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#540122}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0113f1b8. With Chromium commits locally applied on WPT: 1f9508a4 "[css-layout-api] Populate children, and pass into layout() function" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13031 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I3e16bd64e4dae71440017bdf93f5eaada0aaa4b8 Reviewed-on: https://chromium-review.googlesource.com/941827 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540121}
-
Alex Clarke authored
This lets Pupeteer in deterministic mode check if the browser was launched with --headless and --deterministic-fetch. This is required for Puppeteer.connect to work in deterministic mode and without checking the command line arguments it's likely a hard failure mode to detect. Change-Id: Ifdbf7e9ba7897217cd27918ae95a7ecc10b9da9c Reviewed-on: https://chromium-review.googlesource.com/939472 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Since cleanup was made thread-safe in r539095 (and disallowing synchronized on |lock_| in r538388): This was now only needed during JoinForTesting() to ensure workers in |workers_copy| didn't decide to cleanup during join. As such, always ban cleanup during join and remove the API to control that bit. R=fdoray@chromium.org, robliao@chromium.org Bug: 810464 Change-Id: I46edfcc7e37f3a5cb54320b0c38cad5d567c8eb7 Reviewed-on: https://chromium-review.googlesource.com/937264 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540119}
-
Hajime Hoshi authored
This CL also fixes WebDataConsumerHandle and its children classes. This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: Ia0ab834c52614190a49d74b177f07b2f3b3193e0 Reviewed-on: https://chromium-review.googlesource.com/934381 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540118}
-
Thomas Tangl authored
This CL sets the minimum height of the button text in the DiceSigninButton to ensure enough spacing. See specs related to minimum text height in https://bugs.chromium.org/p/chromium/issues/detail?id=814809#c11 Bug: 814809 Change-Id: I8c02feb88ec51103df204185d46dfc674fb26e06 Reviewed-on: https://chromium-review.googlesource.com/941942 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0638561d..fd158bc4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2ea88940591337761c1e5a037672baca70a12f75 Reviewed-on: https://chromium-review.googlesource.com/942264Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540116}
-
Kinuko Yasuda authored
TBR=jbroman@chromium.org Change-Id: Ie389c62271a75872439dfe72369c4518bee8c3cd Reviewed-on: https://chromium-review.googlesource.com/942288Reviewed-by:
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I020053012b5097dbb555d50879e7c802b3d3f534 Reviewed-on: https://chromium-review.googlesource.com/942268 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540114}
-
Mikel Astiz authored
As per ownership handover, and now that I feel comfortable enough with the codebase. Bug: None Change-Id: Ib96afc8e4d8a45681f8124b68758c10646b6da71 Reviewed-on: https://chromium-review.googlesource.com/940137Reviewed-by:
Nicolas Zea (slow) <zea@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540113}
-
David Tseng authored
Currently: - in multi-line text fields (i.e. text areas and content editables), Search now gets used in the same way as Chrome OS's default mappings - examples: Search+RIght invokes "end", Search+Ctrl+Right = control+end, etc - single lined text fields are unaffected - this new mapping also applies to Google Docs After this change: - search+up/down, search+left/right will exit the editable if selection is on the first or last line of the editable (respectively) Bug: 801590 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I991eb74d77120b2f2479a78b1b1658b31f354d85 Reviewed-on: https://chromium-review.googlesource.com/895244 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540112}
-
Yoshifumi Inoue authored
This patch renames "25322-1.html" to "delete_after_block_image.html" to provide a hint what this test file verifies for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/940726 Rewrite editing/deleting/25322-[1-5].html to utilize selection_test() TBR=yosin@chromium.org Change-Id: Ia08e0225107eca945e01f84d4480f02e4f5cfd8f Reviewed-on: https://chromium-review.googlesource.com/942599Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540111}
-
Marc Treib authored
These were disabled in 2014/2015 and seem to be passing locally. Let's reenable and see what breaks. Bug: 434438 Change-Id: I88ca33ea242716d47b25508685cd09b3c68f0749 Reviewed-on: https://chromium-review.googlesource.com/941216Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#540110}
-
Marc Treib authored
Namely SC_MovingBMsFromBMBarToBMFolder and SC_MovingBMsFromBMFoldToBMBar. These were disabled back in 2014, and seem to be consistently passing now (when run locally). Let's reenable them and see what happens. Bug: 412169 Change-Id: I41ff880f3ce382692e87ce7782bc3176d70a1aaf Reviewed-on: https://chromium-review.googlesource.com/941447Reviewed-by:
-
Marc Treib authored
This test has been disabled back in 2015, and it now seems to pass consistently when run locally. Let's reenable it and see what happens. Bug: 420979 Change-Id: Iacd55f5d80dc28764686868a7826119b77e262e7 Reviewed-on: https://chromium-review.googlesource.com/941228Reviewed-by:
-
Christopher Lam authored
This CL renames a global function named url, which will conflict with mojo namespaces in crrev.com/c/936349. Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I96908ac1adfcae0a565350e50f206ab1da1539be Reviewed-on: https://chromium-review.googlesource.com/937007 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#540107}
-
Ganesh Borle authored
Bug: 561800 Change-Id: I77a9513fab04bcc8117f47424b4ec49f13e5b8c5 Reviewed-on: https://chromium-review.googlesource.com/940709Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#540106}
-
Hikaru Nishida authored
This patch renames "5126166.html" to "delete_selection_ends_inside_empty_table_cell.html" to provide hint about what this test file verifies. See also: crrev.com/c/907712 Change-Id: Ie1bc7d0645d5f0ce4dd61762feb41c359d26b149 Reviewed-on: https://chromium-review.googlesource.com/942127 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR: dalecurtis@chromium.org Bug: 817705 Change-Id: Ib8ee6bc048b39aadd1ac3dc69fd4aadb1176ec49 Reviewed-on: https://chromium-review.googlesource.com/942596Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#540104}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 25c1dd7a. With Chromium commits locally applied on WPT: 1f9508a4 "[css-layout-api] Populate children, and pass into layout() function" 48dc8954 "[css-typed-om] Ensure properties works with css-wide keywords / var refs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13030 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I6dca0bdd5eece650c89e91fa1524f4a41274f438 Reviewed-on: https://chromium-review.googlesource.com/942265 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Greg Thompson authored
It seems that this has never been used. BUG=511300 Change-Id: If8c07c5b8a713873742e1b8e628b4f718cdda5ff Reviewed-on: https://chromium-review.googlesource.com/939962 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540102}
-
https://skia.googlesource.com/skia.git/+log/ba7a16519468..9e8a59490531 $ git log ba7a16519..9e8a59490 --date=short --no-merges --format='%ad %ae %s' 2018-02-28 scroggo Support pngs with incorrect CMF bytes 2018-02-28 benjaminwagner Upgrade the Radeon GPU drivers. 2018-02-28 benjaminwagner Revert "Upgrade IntelIris540 Win10 GPU driver." 2018-02-28 benjaminwagner Switch remaining Win10 Skolo bots to new Windows image. 2018-02-28 caryclark make SkDestinationSurfaceColorMode private 2018-02-28 jvanverth Fall back to blurs for unsupported DrawShadow cases 2018-02-28 halcanary SkPDF: encode metadata strings correctly 2018-02-28 egdaniel Respect disable driver correctness workaround flag in Vulkan 2018-02-22 jvanverth Remove deprecated drawShadow interfaces 2018-02-27 ethannicholas Update certain instrinsic calls in SkSL SPIR-V gen to not mix vectors and scalars. 2018-02-27 benjaminwagner Upgrade IntelIris540 Win10 GPU driver. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I286a8af78d4ba525fb55095db781ffff7fe0c40f Reviewed-on: https://chromium-review.googlesource.com/941985Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540101}
-
Zhuoyu Qian authored
Editor::DispatchClipboardEvent() is only called in EditorCommand.cpp, Move it to make |Editor| class simpler for improving code health. Bug: 672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id7f8647cbd3eaa7d101ce46dae1f56b42b08edc0 Reviewed-on: https://chromium-review.googlesource.com/940785Reviewed-by:
-
Victor Costan authored
Currently, CookieStore implementations are responsible for storing cookies and dispatching notifications when the cookies they store change. The dispatch logic is non-trivial, and will grow to support the Async Cookies API (see the associated bug), so it deserves its own class. This CL splits off the change notification dispatch as follows: * CookieStore -> CookieChangeDispatcher * CookieMonster -> CookieMonsterChangeDispatcher * AwCookieStoreWrapper -> AwCookieStoreChangeDispatcherWrapper * CookieStoreIOS -> CookieChangeDispatcherIOS Due to complexities and upcoming refactoring in the iOS CookieStore implementations, the existing implementation is not split up. Instead, CookieChangeDispatcherIOS is a proxy that directs AddCallback*() calls to CookieStoreIOS. The other CookieStore implementations (CookieMonster, AwCookieStoreWrapper) have the change notification dispatch code moved into the ChangeDispatcher classes. This CL also changes the listener registration APIs to pass base::Callbacks by value instead of passing them by reference, per https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md This CL is large, but only does renames / code moving / minor cleanups. It opens up the way for a small (but dense) CL that will revamp the notification dispatch logic. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie56b036419a85f7802c6b1d4bb2c935b58232374 Reviewed-on: https://chromium-review.googlesource.com/919159 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#540099}
-
Tsuyoshi Horo authored
This reverts commit 65478d12. Reason for revert: Caused build failure on Mac https://ci.chromium.org/buildbot/chromium/Mac/38768 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FMac%2F38768%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Undefined symbols for architecture x86_64: "extensions::ShellNativeAppWindowAura::ShellNativeAppWindowAura(extensions::AppWindow*, extensions::AppWindow::CreateParams const&)", referenced from: extensions::(anonymous namespace)::TestAppWindowClient::CreateNativeAppWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams*) in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::SetUp()", referenced from: extensions::ShellExtensionLoaderTest::SetUp() in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::ShellTestBaseAura()", referenced from: testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_Extension_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunch_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_NotFound_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_ReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadAfterReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadDisabledExtension_Test>::CreateTest() in shell_extension_loader_unittest.o ... "extensions::ShellTestBaseAura::~ShellTestBaseAura()", referenced from: extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_NotFound_Test::~ShellExtensionLoaderTest_NotFound_Test() in shell_extension_loader_unittest.o ... "extensions::ShellTestBaseAura::TearDown()", referenced from: extensions::ShellExtensionLoaderTest::TearDown() in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::InitAppWindow(extensions::AppWindow*, gfx::Rect const&)", referenced from: extensions::ShellExtensionLoaderTest_AppLaunch_Test::TestBody() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::TestBody() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_ReloadFailure_Test::TestBody() in shell_extension_loader_unittest.o ld: symbol(s) not found for architecture x86_64 Original change's description: > AppShell: Support reloading > > Implement reloading in ExtensionLoader. Uses keep-alives while apps are > reloading. A future CL will observe these keep-alives to keep app_shell open > during reload. > > Bug: 762642 > Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf > Reviewed-on: https://chromium-review.googlesource.com/912694 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540079} TBR=michaelpg@chromium.org,rdevlin.cronin@chromium.org Change-Id: I2db08946671be6eb37fd3f4d658573b87dd3c1b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762642 Reviewed-on: https://chromium-review.googlesource.com/942701Reviewed-by:
-
Dominic Mazzoni authored
At least one issue was that the loadComplete event was sometimes being received on a frame with an empty url. Bug: 808343,622387 Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce Reviewed-on: https://chromium-review.googlesource.com/938495Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540097}
-
Alexander Semashko authored
These fonts are used on android too. Change-Id: I0280f681579c2c227f4da4534a194cd04d53000d Reviewed-on: https://chromium-review.googlesource.com/937207 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540096}
-
Adam Rice authored
- Add an optional |signal| property to RequestInit - Add a |signal| property to Request, chained from RequestInit's signal - Create a chained AbortSignal in Request clone() - Add an Abort() method to FetchManager::Loader - Add an AbortSignal parameter to FetchManager::Fetch() - Add an AbortSignal member to FetchManager::Loader and BodyStreamBuffer The implementation closely follows the Fetch standard, particularly the initialisationn of |signal| in the Request constructor: https://fetch.spec.whatwg.org/#request-class and the signal-related steps in the fetch method: https://fetch.spec.whatwg.org/#fetch-method. The AbortSignal member of BodyStreamBuffer is only set for Response objects. It is not meaningful for Request objects. In addition, it is not set when a Response is created from a stream, as there is no associated Request that JS code could use to abort the response. The design doc is at https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit. The Intent to Ship thread is at https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ. Known issues: when abort is signaled between a body access method like arrayBuffer() being called and the returned promise resolving, the promise will reject with a TypeError rather than an AbortError. See http://crbug.com/817687. BUG=750599 Change-Id: I19dfb311f55fcdc566b07449ef2c61ef7be301c7 Reviewed-on: https://chromium-review.googlesource.com/934542Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
