- 06 Aug, 2019 40 commits
-
-
arthursonzogni authored
The main motivation behind this CL is to land: https://chromium-review.googlesource.com/c/chromium/src/+/1688957 It makes every navigations from a crashed RenderFrameHost to use a new RenderFrameHost. Previously, only the cross-origin navigations where using a new RenderFrameHost. DevToolsProtocolTest was only used with same-process navigation, this CL adds a regression test: DevToolsProtocolTest.InspectorTargetCrashedNavigateCrossProcess This test fails without this patch and works with it. Context: RenderFrameDevToolsAgentHost follows the current document in a given frame. This translates by following a RenderFrameHost in a given FrameTreeNode. To do this, most observers of a WebContents uses: WebContentsObserver::RenderFrameHostChanged(old_rfh, new_rfh). They updates the current RenderFrameHost after the navigation has been done and the old and new RenderFrameHost have been swapped. The RenderFrameDevToolsAgenHost way of doing things is slightly different, it wants to follow the new RenderFrameHost as soon as possible. It happens when the navigation is ReadyToCommit(). To handle canceled navigation and crashed RenderFrameHost, the RenderFrameDevToolsAgentHost observes the following "events": * ReadyToCommitNavigation * DidFinishNavigation * RenderFrameHostChanged. Please take a look at their implementations. Depending on the case, they are called in a different order and produces different results. Let's explore several examples with a cross-process navigation from A to B: ──────────────────────────────────────────────────────────────────────────────── Case 1: Successful navigation from a living RenderFrameHost. ┌─┬────────────────────────┬───────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │1│ ReadyToCommitNavigation│ UpdateFrameHost(B)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │2│ RenderFrameHostChanged │ │ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │3│ DidFinishNavigation │ UpdateFrameHost(B)│ UpdateFrameHost(B)│ └─┴────────────────────────┴───────────────────┴───────────────────┘ Observation: This produces the same effects, UpdateFrameHost called several time in a row with the same RenderFrameHost is essentially a no-op. ──────────────────────────────────────────────────────────────────────────────── Case 2: Successful navigation from a dead RenderFrameHost. ┌─┬────────────────────────┬─────────────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │1│ RenderFrameHostChanged │ UpdateFrameHost(nullptr)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │2│ ReadyToCommitNavigation│ UpdateFrameHost(B) │ UpdateFrameHost(B)│ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │3│ DidFinishNavigation │ UpdateFrameHost(B) │ UpdateFrameHost(B)│ └─┴────────────────────────┴─────────────────────────┴───────────────────┘ Observation: Without this patch, when the new RenderFrameHost starts loading, it temporarily switch to nullptr for a short time. It is no more the case. ──────────────────────────────────────────────────────────────────────────────── Case 3: Navigation canceled after ReadyToCommitNavigation. ┌─┬────────────────────────┬───────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │1│ ReadyToCommitNavigation│ UpdateFrameHost(B)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │2│ DidFinishNavigation │ UpdateFrameHost(A)│ UpdateFrameHost(A)│ └─┴────────────────────────┴───────────────────┴───────────────────┘ Observation: Nothing changed. ──────────────────────────────────────────────────────────────────────────────── The previous way of "following" RenderFrameHost by the RenderFrameDevToolsAgentHost can "temporary" follow nullptr in case 2. This is no more the case. Bug: 990315 Change-Id: I0703e1602ef47f8964a5041cc509ed0344bf4e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731489Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684259}
-
Jérôme Lebel authored
When sign-in with a new gmail account, the Chrome identity was initialized with no hosted domain since the SSO profile was not fetched yet. The property was never updated later. Even when the AuthenticationFlow was fetching hosted domain using the AuthenticationFlowPerformer. During the sign-in process To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity stays just a proxy for SSOIdentity. ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to get the hosted domain. Bug introduced with: + crrev.com/c/1687254 + crrev.com/i/1434627 + crrev.com/c/1687254 Related to: + crrev.com/c/1732084 (adding new API) + crrev.com/i/1560989 (adding new implementation) + crrev.com/c/1732085 (switching implementation) + crrev.com/i/1560990 (old implementation cleanup) => crrev.com/c/1732101 (cleanup API) <= Bug: 987380 Change-Id: I77b4a1428ce43aca81ae93a0875b3052be97bea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732101 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#684258}
-
Maggie Cai authored
Add mxcai@ as an OWNER of chrome/browser/chromeos/apps/intent_helper. Bug: None Change-Id: Ie837b7e3628fe268431ea7fc0174b8ef5f8ba5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738087 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684257}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c409951bea4f..88681ddd1d38 git log c409951bea4f..88681ddd1d38 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc2c5c5a419e..bf176a0d6db9 (10 commits) Created with: gclient setdep -r src/third_party/skia@88681ddd1d38 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None Change-Id: I34e327a7d16a5625d6a3dc0955edb18ca5990c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737754Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684256}
-
Takashi Toyoshima authored
Bug: 990041 Change-Id: I8b5924e0d3bed705a2389a875200b0db0b1fe2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736866 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#684255}
-
Alexey Baskakov authored
Extract SystemWebAppManager into CreateCommonSubsystems(). Fix comments. Bug: 877898 Change-Id: I909f2c92317a2db2e0a73a1af08be28d84a51c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737492Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#684254}
-
Maksim Sisov authored
For now, just run with headless backend. Once Ozone/X11 is more mature and Weston is built from third_party (ongoing), use --ozone-platform=wayland/x11 as well. Bug: 700309 Change-Id: Ib869ab8cb0d8c3e98ccf322d7c9b226baeeaa974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735580 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#684253}
-
Kenichi Ishibashi authored
The motivation of this change is to avoid creating ParentExecutionContextTaskRunners while starting service worker. It's a garbage collected object and we can't create it on the IO thread. Before this CL, WorkerThread took ParentExecutionContextTaskRunners as a parameter of Start(). For service/shared workers, we create a dummy version of task runners which always fall back to the default task runner that is bound to the current thread. The task runners are used to schedule a task to terminate script execution outside the worker thread (e.g. force terminating infinite loop). Since the termination task doesn't rely on parent context, we can just use the default task runner of the current thread (mostly the main thread, could be the IO thread in the future). Another option is to pass a SingleThreadTaskRunner as a parameter of Start(). I didn't take this approach because: * I wanted to aggregate the call of Thread::Current()->GetTaskRunner() as it's discouraged to use widely. * For dedicated workers we could pass ParentExecutionContextTaskRunners::Get(kInternalDefault) but this could be stale when the parent context is destroyed. Keeping it without ContextLifecycleObserver isn't safe. Bug: 988335 Change-Id: I3fe27bfc184619f5c4b1be516ad794190588eed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735591 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#684252}
-
Yusuke Sato authored
Per request from the owner at CL:1728319. This also makes upstart_client.cc lint-clean. BUG=None TEST=try Change-Id: I59230caa3f430df72af88ba76154a509621254fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737731Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#684251}
-
Dominick Ng authored
BUG=991075 Change-Id: I11a08609b85dbfa534e4479657478788819d9000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737793 Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfd49e0cb072..558f1a9df6d3 Created with: gclient setdep -r src-internal@558f1a9df6d3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9163677382b3a91db38b79d3102e7dde350a41f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738005Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684249}
-
Alex Danilo authored
Adds more detail to the aria-label for better screen reader experience on the summary panel. Sets the label to 'Close' when the summary panel has expanded the panel items on display and sets it back to 'Expand' when it's collapsed. The keywords 'Close' and 'Expand' are internationalized, the string itself contains 'Files feedback panel' which will be internationalized in a follow-up CL. Bug: 989322 Change-Id: I1ae67400eed5963e7254ea644f757eed47291b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735448Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#684248}
-
Kent Tamura authored
* insert_paragraph_separator_command_test.cc <colgroup>'s actual appearance will be 'none', and it has no height. * external/wpt/css/css-lists/list-and-margin-collapse-003.html and -004.html <div> can't have 'checkbox' appearance any longer, and we couldn't find other ways to reproduce the original issue. So we remove the tests. * fast/css/invalid-appearance.html Removed. It was made to check deprecation messages. * fast/css/square-button-appearance.html Removed. -webkit-appearance:square-button doesn't work for arbitrary elements any longer, and its appearance is tested in input[type=color] tests. * fast/forms/file/file-style-inheritance.html -webkit-appearance:square-button doesn't work for ::-webkit-file-upload-button any longer. -webkit-appearnace:none works well in the test. * fast/forms/range/thumbslider-no-parent-slider.html -webkit-appearance:slider-thumb-* don't work in this case any longer. Its pixel result has nothing. This CL converts the test to a reference test. * scrollbars/custom-scrollbar-appearance-property.html -webkit-appearance:searchfield-cancel-button doesn't work for ::-webkit-scrollbar* any longer, and pixel result of this test would be changed. This CL converts the test to a testharness.js test. * fast/css/invalid-appearance-progress-bar-meter-expected.txt * fast/forms/datalist/slider-appearance-with-ticks-crash-expected.txt * fast/forms/range/slider-appearance-crash-expected.txt * fast/forms/range/thumbslider-crash-expected.txt * fast/text/whitespace/pre-block-normal-inline-crash-2-expected.txt * paint/invalidation/selection/multiple-body-remove-selection-crash-expected.txt * paint/theme/anonymous-element-menulist-painting-expected.txt Remove deprecation messages. Bug: 981720 Change-Id: I91068c8265cdfc682a06b1b4588b04ea30a318d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727654Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#684247}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/074f0d2d282d..bdc909653e31 git log 074f0d2d282d..bdc909653e31 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c4c2e2e..8776a388 (684065:684182) Created with: gclient setdep -r src/third_party/webrtc@bdc909653e31 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia873c1b3fc30b56ad89363141ba02426b4f067de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737950Reviewed-by:
-
Raymes Khoury authored
This adds browser-side checks for the registerProtocolHandler API. In particular: 1) Checks that the origin of the URL handler matches the origin of the RFH where the call originates. 2) Checks that the protocol being handled is one of the safelisted schemes. 3) Checks that the scheme of the URL handler is either http or https. Check (1) is implemented in the content/ layer so that non-Chrome embedders can benefit from this check. Checks (2) and (3) are implemented further down in Chrome because we need to ensure that if existing handlers are registered that we don't load them from prefs. Tests are added. We may want to consider restricting this API to secure contexts in a follow-up but this will need to be vetted by blink-dev@. Note: This CL was originally reverted because it didn't allow Extensions to register protocol handlers. This has been fixed by allowing the chrome-extension scheme. This check must be done in the chrome/ layer. Bug: 971917,952974 Change-Id: I19da557135af9a86c3305ef47e4b06152abd6ddd Tbr: benwells@chromium.org,tapted@chromium.org,dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730689 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Sara Kato authored
GetRoot sometimes returns nullptr (as GetFromId returns null). This nullptr is not catered for in the calling function (NotifyAccessibilityEvent), which means that after obtaining the node, root->isNode() could possibly be called on a nullptr. From the stack traces in b/136621529 (ref: comment #21), this is what caused the crashes observed when enabling ChromeVox in an ARC++ window. TEST=manual (use steps to reproduce original bug, observe no failure) TEST=tast run DUT_IP arc.Accessibility* (from: ag/8691068) no longer fails BUG=b:136621529 Change-Id: I47908e3e681420fba539c1eca86fc11fef84d715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730654Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/92d36fb5ab54..385c64442a09 git log 92d36fb5ab54..385c64442a09 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 shchen@google.com branch_archive_stages: Update firmware blob pathname 2019-08-06 evanhernandez@chromium.org packages: Add empty endpoint UprevVersionedPackage 2019-08-06 eashanbhatt@google.com device_unittest: Add Create Unittests 2019-08-06 mikenichols@chromium.org paygen_stateful_payload_lib: Refactor kernel loopback call 2019-08-05 tcwang@google.com afdo: Add CWP clock to orderfile name. Created with: gclient setdep -r src/third_party/chromite@385c64442a09 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0ddde776965987fa9be482e46f5358064636a9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738167Reviewed-by:
-
Yuchen Liu authored
This is a reland of 510e0f76 Original change's description: > [Fuchsia][EME] Basic skeleton for EME support on Fuchsia > > In renderer process, FuchsiaCdmFactory initiates the request to Fuchsia > CDM service. The request is passed to browser process via new mojo > FuchsiaCdmProvider. FuchsiaCdm implements > media::ContentDecryptionModule by calling Fuchsia CDM APIs directly from > renderer process. > > In browser process, FuchsiaCdmManager will complete the provision flow > (if needed) and setup the channel between Chromium and the remote CDM > service. > > Bug: 966191 > Test: Shaka Player WV audio only test (with other CLs). > Change-Id: I401e581214d945a2acbefa926f73fdb2ca84d780 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715908 > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684087} Bug: 966191 Change-Id: I186e8a041922a6694e224906e3732f12a76b6409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737566Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#684242}
-
Adam Rice authored
Allow MockWebSocketChannel to be used from WebSocketStream tests in addition to the existing DOMWebSocket tests by putting it in its own file. BUG=983030 Change-Id: I96f5afc57d7b18b9baa4e9504ecba443e332ddea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736350Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eb0770211a6c..c409951bea4f git log eb0770211a6c..c409951bea4f --date=short --no-merges --format='%ad %ae %s' 2019-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src d67ae722..aefed1d0 (313 commits) Created with: gclient setdep -r src/third_party/skia@c409951bea4f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None Change-Id: Idcd2a399a671f1b6a78650f2395db8a18335a494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738130Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3bbeaef79b843984062fd0f0d790ac09b4f3a7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738128Reviewed-by:
-
sczs authored
- Adds infobarManagerWillChange consumer method to clean up this dictionary when the manager/webstate has changed. - Changes childCoordinatorStopped so it sends the InfobarType. - Updates unittests. Bug: 961343 Change-Id: I275ba5a5f3091202b7eff3d40777ac782c438946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731141Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#684238}
-
Antonio Gomes authored
All code using it has been moved to Blink, and uses Blink's variant of this file (same implementation and name). BUG=704136 R=guidou@chromium.org Change-Id: I786ce2251abe893da13298a2633f343fe280c2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736869Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#684237}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/77548ac65167..c9edc556eae1 git log 77548ac65167..c9edc556eae1 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 tsepez@chromium.org Introduce IPWL_SystemHandler and fxcrt::TimerHandlerIface for layering. 2019-08-05 tsepez@chromium.org Rename GetLastError() shim to FXSYS_GetLastError(). 2019-08-05 tsepez@chromium.org Move {Set,Get}LastError() from fpdsdk/ to core/fx_system.cpp Created with: gclient setdep -r src/third_party/pdfium@c9edc556eae1 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I5c3e9401640c2b774b24cd93b49fe8f507c4669d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738129Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27f295ee6c4f..bfd49e0cb072 Created with: gclient setdep -r src-internal@bfd49e0cb072 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I716f0052d5af786ab243b271cfc6eeb1eee79eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736525Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/698405a9f62a..5c00781543cc git log 698405a9f62a..5c00781543cc --date=short --no-merges --format='%ad %ae %s' 2019-08-06 simonhatch@chromium.org Pinpoint - Set "try" on comparison_mode for try jobs 2019-08-06 simonhatch@chromium.org Pinpoint - Provide estimated running time for jobs. Created with: gclient setdep -r src/third_party/catapult@5c00781543cc The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:987371,chromium:987371 Change-Id: I7a0be370f1e7077050fa71019934152e328238a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738127Reviewed-by:
-
Abhijeet Kandalkar authored
The primary goal of this CL is to use IsA<HTMLButtonElement>(element) in place of IsHTMLButtonElement(element). Bug: 891908 Change-Id: I6a2a09675c535b56c852ae4e1df3d9c6a3013b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736359Reviewed-by:
-
Hiroki Sato authored
In the previous CL 1443935, AccessibilityEvent.TYPE_ANNOUNCEMENT was supported, but it was not working because this kind of event does not have event_data->node_data and ArcAccessibilityHelperBridge::OnAccessibilityEvent() returned early. This CL modifies to handle announcement event and adds test for it. BUG=b:123382801 TEST=manually confirm it works with test app. TEST=unit_tests --gtest_filter="ArcAccessibilityHelperBridgeTest.*" Change-Id: I1e6b7df6faf76e647db9845e1682ea209ffe8232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716982Reviewed-by:
Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
-
Alex Danilo authored
Sets the CSS width for an expanded panel view to 400px in all cases. Without this change, the feedback panel widths can oscillate between a width based on the text in child panels and the maximum size of 400px when file operations start and end so this locks the width to get rid of that oscillation. Bug: 989154 Change-Id: I2902910b6e4436257f07e3b58c794c829d27cdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735797 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Dominick Ng authored
BUG=None Change-Id: I02fe66229490c1ce1b264974d57eb84a0e4b5fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737073 Commit-Queue: Dominick Ng <dominickn@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#684230}
-
Chris Letnick authored
1. Broker to take path in constructor. 2. Broker to create local InterfacePtr for ExternalConnector. These changes support testing external mojo interfaces outside of service manager, and with multiple instances. Bug: internal 138940183 Test: Verified while testing external service. Change-Id: I367495003c63daf5b1c701af343d8e8871646b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737041Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Letnick <cletnick@google.com> Auto-Submit: Chris Letnick <cletnick@google.com> Cr-Commit-Position: refs/heads/master@{#684229}
-
Daniel Murphy authored
Bug: 990590 Change-Id: I3d5ac1e6317499f390ca1c81dc2f936d3f4a8dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737097Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Finch experiments have shown that most metrics have not diminished because of the change from Sfntly to HarfBuzz. Instead, certain metrics, like PrintPreview.PrintDocumentSize.HTML, have observed promising drops. CL to define feature flag - [1] CL to enable HarfBuzz Subsetter - [2] CL to define finch config - [3] [1] https://chromium-review.googlesource.com/c/chromium/src/+/1649070 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1659130 [3] cl/255041822 Bug: 931719 Change-Id: I7f656f71afe7414376e589453ce13832622274bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731731Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#684227}
-
Abhishek Bhardwaj authored
BUG=None TEST=Compile. Change-Id: I7db4fee7308aa5b90b5456bb68a2a7aee05497c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737067Reviewed-by:
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes Change-Id: I2468c4ff67829084ffc563822b8d53997367b9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733036Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#684225}
-
Mike West authored
We'll eventually need to access this from the network stack in order to decide whether to block requests. This patch just moves the value from its existing home in Blink to a new abode in the network service. It's mostly the result of the following command: ``` git gs IPAddressSpace -l | xargs -L1 sed -i '' \ -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \ -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \ -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \ -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g' ``` Reland of [1] which was reverted in [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1718329 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1724149 TBR=kinuko@chromium.org Bug: 986744 Change-Id: I8b14d528a6fe8746bcd6112ff5692e33215d3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735376 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#684224}
-
Noel Gordon authored
This reverts commit 27296030. Reason for revert: suspect this change caused video test fails on the chromeos-kevin-rel bot. https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/13464 Failing tests. video.WebRTCDecodeAccelUsedVP8 video.PlayDecodeAccelUsedVP8 video.PlayDecodeAccelUsedVP9 video.PlayDecodeAccelUsedMSEVP8 Original change's description: > media/mojo: Remove fallback of ChromeOS VideoDecoder. > > We plan to enable new VideoDecoder implementation per board, instead > of enable all boards at the same time. We won't enable boards that are > not supported yet. > This CL remove the fallback video decoder. Then we could catch any > initialize or runtime failure of new VideoDecoder implementation. > > BUG=chromium:984482 > TEST=open crosvideo.appspot.com on Kevin and Eve > > Change-Id: I03026057b317ffde5436d8eb53c579ed18210bd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734833 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684211} TBR=sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org Change-Id: Iec202f6c834aee136218c9b8964b77fc24874892 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:984482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736870Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#684223}
-
Vlad Tsyrklevich authored
MultiprocessTestClientLauncher.launchClient() is not supposed to be called on the main thread; it causes hangs on older versions of Android. assert that this invariant is true instead of failing by time out. Bug: 973167 Change-Id: I2fe475861d3d7331707820374a68198da4d34d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726640Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#684222}
-
Kunihiko Sakamoto authored
This reverts commit 3a99193d. Reason for revert: This was already reverted at [1] and relanded with a fix at [2]. [1] https://chromium.googlesource.com/chromium/src/+/5bd3e578821d1daacdb92dd5180255a771bf6d6c [2] https://chromium.googlesource.com/chromium/src/+/4f518dc059bb7e0167335a3bb01b47d01bd0da80 Original change's description: > Revert "BundledExchangesParser: Update the bundle format [1/2]" > > This reverts commit d8c863a6. > > Reason for revert: > https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/24310 > > > https://luci-milo.appspot.com/p/chromium/builders/ci/Deterministic%20Linux/24310 > > Compile failure, List of errors: > > ../../mojo/public/cpp/bindings/struct_ptr.h:56:18: error: no matching constructor for initialization of 'mojo::StructPtr<data_decoder::mojom::BundleMetadataParseError>::Struct' (aka 'data_decoder::mojom::BundleMetadataParseError') > > > Original change's description: > > BundledExchangesParser: Update the bundle format [1/2] > > > > This updates BundledExchangesParser to parse the new bundle format [1]. > > > > Changes: > > - Updated the magic header bytes [2] > > - Version field is added (we use implementation-specific version string > > "b1\0\0", which matches gen-bundle's output [3]) > > - Fallback URL (== Primary URL) field is added > > - ParseMetadata() returns error type ("format error" or "version error") > > and fallback URL if available > > - Updated spec ref comments > > > > The structure change of the index section is not reflected yet. It will > > be updated in the next CL. > > > > The test bundle file (hello.wbn) is generated with gen-bundle of > > github.com/WICG/webpackage revision a3cef2c, which supports the new > > bundle format except for the new index section structure. > > > > [1] https://github.com/WICG/webpackage/pull/450 > > [2] https://github.com/WICG/webpackage/pull/454 > > [3] https://github.com/WICG/webpackage/pull/458 > > > > Bug: 969596 > > Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#684200} > > TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org > > Change-Id: I0e4c550179c4433022646f8ecc27cbdf4983ce87 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 969596 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738036 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684219} TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,noel@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org Change-Id: I27423f80338576b35506bb8f7e6010fc4c2d2ec7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735802Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684221}
-
Leon Han authored
android.nfc.tech.Ndef.getNdefMessage() may return null when the tag is formatted but is empty, we need to handle the case well. See https://developer.android.com/reference/android/nfc/tech/Ndef.html#getNdefMessage(). BUG=520391 Change-Id: I49cdf40978ad837546dcb050ce8e7d2cac4662ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736167 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#684220}
-
