- 02 Feb, 2018 40 commits
-
-
Justin Carlson authored
This change does two things. First, it splits out the implementation of ServiceDiscoveryDeviceLister from the interface, which will allow users of the API to mock/fake it for testing. Second, it adds a service_type parameter to ServiceDiscoveryDeviceLister::Delegate::OnDeviceCacheFlushed. This allows users of the class that want to manage multiple service types with a single Delegate to disambiguate which service is being flushed. The other Delegate functions already pass in the service description so don't need any additional information for this use. Also fixup callsites for all users of this API. Bug: 808157 Change-Id: I9cf4b23692f54c66e0224e06df1769f750f846b3 Reviewed-on: https://chromium-review.googlesource.com/898184 Commit-Queue: Justin Carlson <justincarlson@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#534146}
-
Varun Khaneja authored
No change from the original CL. The CL did not need to be reverted since the problem was with CL https://crrev.com/c/872219 only. Original CL: https://crrev.com/c/855044 Revert CL: https://crrev.com/c/895399 Reason for revert: Windows build failures (crbug/807391) TBR=jschuh,nparker Bug: 750327 Change-Id: I6f596ecfc28f21d8e6a75ed69915b58943d026b5 Reviewed-on: https://chromium-review.googlesource.com/900002Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#534145}
-
David Valleau authored
The construction of the printer's display name already contains the model, so displaying it again was redundant. R=hcarmona@chromium.org, xdai@chromium.org Bug: 793340 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8ce04994f762b23d44dd2d30a31c4f2f90afbbf5 Reviewed-on: https://chromium-review.googlesource.com/896364Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#534144}
-
Jonathan Metzman authored
On Mac builds, it looks like calling WriteNum on a size_t was causing the compiler to select the templated version of WriteNum rather than the uint64_t version. Hopefully it won't do the opposite (and break on calls to WriteNum(uint64_t) because of this fix. Bug: 808155, 769578 Change-Id: I8babcf6da5090b9bffdbcc98b573c11c02f2e489 Reviewed-on: https://chromium-review.googlesource.com/899906 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#534143}
-
Xi Cheng authored
Change-Id: Ie9dc6c639b3bd8c2ff028d71f3c77d4a15895b55 Reviewed-on: https://chromium-review.googlesource.com/898498 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534142}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f067b88df42..5d5f22ce9d6f $ git log 1f067b88d..5d5f22ce9 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 agable Remove prompts to contact maruel Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id63069f840a78f521256a52b49d683885ea2d98a Reviewed-on: https://chromium-review.googlesource.com/899870Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534141}
-
https://webrtc.googlesource.com/src.git/+log/72724535584f..1d0b9d04bd87 $ git log 727245355..1d0b9d04b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I976a25b29de81b35a01d43b6c43f84159d40b095 Reviewed-on: https://chromium-review.googlesource.com/899911 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534140}
-
Mikel Astiz authored
The list of proto fields was not updated in recent changes to the proto. Change-Id: I7017c2a83a08c610e8a3644e77f6a0779c28e238 Reviewed-on: https://chromium-review.googlesource.com/899085Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#534139}
-
Ahmed Fakhry authored
Minor CL to add a skeleton for Touchable-specific colors as well as adding the non-client frame colors. BUG=805267 Change-Id: Ia1b3a344223c3d2e0b7c7b0bf0a5d2e851221558 Reviewed-on: https://chromium-review.googlesource.com/898489 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534138}
-
Sidney San Martín authored
Updating self.image (on an NSButton subclass) in -layout or -viewWillDraw both seem to lead to an infinite loop in 10.11. I'm not sure if there's a better way to fix this; using different triggers to update the image seems safest. Bug: 805109 Change-Id: I468576069f44eae4a2f4b9058e078d88d157265a Reviewed-on: https://chromium-review.googlesource.com/899586Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534137}
-
Tim Dresser authored
Reports the First Input Delay. PageLoad.InteractiveTiming.FirstInputDelay Observes: - MouseDown - KeyDown, RawKeyDown - PointerDown (when followed by PointerUp) - Cancelable TouchStart - GestureTap Bug: 803935 Test: WebViewTest.FirstEventQueueingTimeReported, CorePageLoadMetricsObserverTest.FirstEventQueueingTime Change-Id: I7fb9ba157d85dd097080db3f64db617aea17f090 Reviewed-on: https://chromium-review.googlesource.com/876728Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#534136}
-
Adam Langley authored
Bug: 793985 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I19f4c1e2cff81b41a919449b926616d5e0f9d813 Reviewed-on: https://chromium-review.googlesource.com/899674Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534135}
-
erikchen authored
Remove some unneeded code. Change-Id: I47a8535189da8ebbe67853e3bae6f0cfb8cf11e6 Reviewed-on: https://chromium-review.googlesource.com/897898Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534134}
-
Sergey Ulanov authored
Now layout tests runner copies fonts from the host to the target machine. This is the same approach that is used for Android. It will allow to reuse layout tests expectations from Linux/Android. Bug: 778467 Change-Id: Id878966c435476b8fb22441441108a74c9e40f1b Reviewed-on: https://chromium-review.googlesource.com/887745 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#534133}
-
Danyao Wang authored
This is a partial reland of 091e44cb. It splits out only the matcher change in EarlGrey tests. The suspected test failure (ContextMenuJsTest.LinkOfTextWithCalloutNone) is not caused by the original CL. It seems to be flaky. It failed again after the revert: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2532 and it failed before the CL was checked in: https://luci-milo.appspot.com/buildbot/internal.bling.main/iphone11-device-x64/2504 Original change's description: > [Nav Experiment] Fix form repost detection in WKBasedNavigationManager. > > This CL moves form repost detection for WKBasedNavigationManager to > in |webView:decidePolicyForNavigationAction|, where WKWebView gives a > clear signal about form reposting (WKNavigationTypeFormResubmitted). > This allows simplifying reload for WKBasedNavigationManager to directly > delegating to [WKWebView reload]. > > FormsTestCase now pass with WKBasedNavigationManager. > > Bug: 807428,705020 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2 > Reviewed-on: https://chromium-review.googlesource.com/894892 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533692} Bug: 705020 Change-Id: I0c5b5f893bc64eaa61538c7a75a78799ac422993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/898263Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534132}
-
Zhiheng Vincent Li authored
Fragment is detached from the activity when user says "OKG, set a timer for 1 minute", or use swipe from edge to "close" the player. When it is attached back to activity by clicking on home view's tile, onCreateView() and onStart() will be called again, but cast views and CastWebContentsSurfaceHelper already attached with current WebContents should be reused. Change-Id: Ibc6dc3a31cd0ff3fc31e16c879537db43185b2f4 Bug: b/72838507 Test: 1. Say "OKG, play a video" and see cast fragment shown; 2. Say "OKG, set a timer for 1 minute" and dismiss the timer page, see cast fragment recovered correctly and video could be resume; 3. Check log output and see 2nd call of onCreateView() and onStart() won't recreate new fragment view and reset webconent. TODO(vincentli): Add a test case to cover CastWebContentsFragment's lifecycle Change-Id: Ibc6dc3a31cd0ff3fc31e16c879537db43185b2f4 Reviewed-on: https://chromium-review.googlesource.com/898602 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534131}
-
Theresa authored
The test was failing because we changed how ChromeTabbedActivity2 is launched in Oct 17. Previously we created ChromeTabbedActivity2 re-using ChromeTabbedActivity's intent, so the CTA2 activity tab was about:blank. After the change, we now create CTA2 with a brand new, blank intent, so the CTA2 activity tab is chrome://newtab. We ignore chrome://newtab on cold start, so the expected number of tabs loaded differed from the actual number of tabs loaded after a cold-start. This patch loads a URL in CTA2's activity tab so that all of its tabs are created when reading tab state from disk after a cold start. BUG=806214 Change-Id: I72fc8261fb899704409d34be210c623346e1397b Reviewed-on: https://chromium-review.googlesource.com/899868Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534130}
-
Nicolas Pena authored
Bug: 808269 Change-Id: I75a4ea34839d17d9bce659023468b96b5c541323 Reviewed-on: https://chromium-review.googlesource.com/899909Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#534129}
-
Sigurdur Asgeirsson authored
The expected normal case is where the previous browser session is embedded in the immedate prior system session. By querying the log session by session, system log traversal should be minimized for the normal case. Bug: 799526 Change-Id: Ic63b6a3cdcd77afd7554d06ac8320f20efa03f28 Reviewed-on: https://chromium-review.googlesource.com/894837Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534128}
-
Stephen Martinis authored
Bug: 731558 Change-Id: I4d3eaf86139e140df0c465edfdc84756a490fa38 Reviewed-on: https://chromium-review.googlesource.com/896954Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#534127}
-
Deepanjan Roy authored
In some edge cases (e.g. inaccurate input timestamp provided through remote debugging protocol) we might receive an input timestamp that is earlier than navigation start. Since invalidating input timestamp before navigation start in non-sensical, we clamp it at navigation start. R=tdresser@chromium.org,japhet@chromium.org Bug: 797334 Change-Id: Ib12921e5d372b0f676a6182fd3cd643b7e12a5f8 Reviewed-on: https://chromium-review.googlesource.com/895410Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534126}
-
Maks Orlovich authored
V8 likes to ask us to store whopping 12-bytes into stream 2 a lot (some sort of timestamp + tag); and, well, creating separate files for that might be something of an overkill; so measure how expensive it is to open them to see if some sort of packing it with streams 0 and 1 is worth the code complexity. Change-Id: Id6ae6d531546fce97388e38d79152c89cb4552aa Reviewed-on: https://chromium-review.googlesource.com/899442Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#534125}
-
Nico Weber authored
Fixes a bug where vr_shell counted VRMode::VR_BROWSER also as VRMode::WEBVR and VRMode::VR_FULLSCREEN, and VRMode::WEBVR also as VRMode::VR_FULLSCREEN in rappor. Bug: 177475 Change-Id: I23a0c2b5fb94d34d407070ef0a9378d02fe4ba54 Reviewed-on: https://chromium-review.googlesource.com/899722Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#534124}
-
Chris Harrelson authored
In various callsites to force update of parts of the lifecycle, the lifecycle might not actually update, because the frame may be throttled or inactive. In these cases, bail out cleanly. Bug: 798717 Change-Id: I8360c21d318734ae2f7c71e1bf00da79eaae4350 Reviewed-on: https://chromium-review.googlesource.com/898408Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534123}
-
https://chromium.googlesource.com/catapult.git/+log/744dac913652..d7e6289f3f76 $ git log 744dac913..d7e6289f3 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 perezju [Telemetry] Install CrOS browser extensions during environment set up Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I859e91d3b1d89830e657c811db102d79a53ef97c Reviewed-on: https://chromium-review.googlesource.com/899684Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534122}
-
Eugene But authored
NavigationAndLoadCallbacksTest used deprecated web::HttpServer. Bug: 708307 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I817cf817467bde8e531e75a19d866c43daac7412 Reviewed-on: https://chromium-review.googlesource.com/899604Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534121}
-
wutao authored
This cl abstracts the search_box_view in order to reuse it in other UI components of Chrome OS. Changes: 1. Split the search_box_view into base class and app_list specific class. 2. The base class is moved to ui/chromeos/search_box/views. Bug: 803297 Test: app_list_unittests Change-Id: I9603a696705c051413fabb2e52e1b6a03c984abd Reviewed-on: https://chromium-review.googlesource.com/895187Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534120}
-
Marijn Kruisselbrink authored
Navigation IPCs are handled on the UI thread so if a blob URL is revoked immediately after navigating the revocation will almost always happen before the navigation code has had a chance to post a task back to the IO thread to actually perform the request. With this change revocation is hopefully delayed just long enough to make navigation work again. Bug: 807639 Change-Id: I2afde86dd203c61cbb03cc02ac62ec21c7e7d704 Reviewed-on: https://chromium-review.googlesource.com/899666Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#534119}
-
Gabriel Charette authored
R=rkaplow@chromium.org Bug: 807616 Change-Id: I924535fdb39c35c6fe949f82753413505bd65057 Reviewed-on: https://chromium-review.googlesource.com/899002 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#534118}
-
https://webrtc.googlesource.com/src.git/+log/debbc7801fbd..72724535584f $ git log debbc7801..727245355 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2cf380c5aee80803a63f4e2bc2d15ab9450a6129 Reviewed-on: https://chromium-review.googlesource.com/899665Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534117}
-
https://skia.googlesource.com/skia.git/+log/0f1abf89f043..68c5632d9216 $ git log 0f1abf89f..68c5632d9 --date=short --no-merges --format='%ad %ae %s' 2018-02-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 95ed19473..c7295f4d3 (1 commit) 2018-02-02 caryclark switch to double in conic split on infinities 2018-02-01 djsollen Add gn_to_bp script for SkQP. 2018-02-01 halcanary SkQP: flatten report images 2018-02-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ bacff3e11..a8aa0a6f7 (1 commit) 2018-02-02 kjlubick Add perf bots to CQ (experimental) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Id6938f3c30800e79db77c4fd274469f658ca5986 Reviewed-on: https://chromium-review.googlesource.com/899699Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534116}
-
Aga Wronska authored
Add tests for layout of users list after rotation and after virtual keyboard apperance changes. Extract LoginKeyboardTestBase class as a base for tests that need to manipulate virtual keyboard. Bug: 807827 Change-Id: I46a300ebbce8a59c9648573fede203ca0f21a292 Reviewed-on: https://chromium-review.googlesource.com/896966 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#534115}
-
Adam Langley authored
BUG=793985 Change-Id: I8a74b520e82f3bb5c2178a11aa7eaf8a00b7ed6c Reviewed-on: https://chromium-review.googlesource.com/899683Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534114}
-
Avi Drissman authored
The embedder needs access to the RenderWidgetHost in order to fully implement a "hung page" dialog. BUG=767526 Change-Id: I2d699d96d3fef88be17c54422578c14310826851 Reviewed-on: https://chromium-review.googlesource.com/896343Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534113}
-
Kevin Marshall authored
The code as checked in breaks on Swarming because it attempts to read the stripped file, which is omitted on isolated builds. This CL does the ELF check on the unstripped file instead, and consolidates the logic within a function. Bug: 792521 Change-Id: I0042bb9b234f34ebc65c6b3ab10c075771b777ef Reviewed-on: https://chromium-review.googlesource.com/899677 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534112}
-
Nicolas Pena authored
This CL WPT-fies some tests and removes duplicates. For the removed: buffer_size_restriction.html: tested in several others. cross_origin_resource_request.html: added checks in resource_TAO_zero.htm. on_shrink_buffer_size.html: tested in others. timing_allow_cross_origin_resource_request.html: added checks in resource_TAO_origin.htm. The two failing tests were slightly changed because according to the spec setResourceTimingBufferSize should not fire onresourcetimingbufferfull. Bug: 498037 Change-Id: Ia2ab18a2239483f4faba8afc04b012574f64310a Reviewed-on: https://chromium-review.googlesource.com/894623 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#534111}
-
Adam Langley authored
AttestationConveyancePreference allows an RP to declare whether or not they are interested in attestation information. If not (which is the default), it is replaced with a “none” attestation. The option for ”indirect” attestation is currently implemented in the same way as “direct” since we are not currently planning on standing up a Privacy CA for this. The AAGUID is not zeroed out because, for U2F devices, the AAGUID is created by Chrome and is always zero. When we support CTAP2 devices this will have to be addressed. (The URLs in the comments here might not actually work yet. They are written assuming that https://github.com/w3c/webauthn/pull/741 lands, which should happen within a week or two.) Bug: 803829 Change-Id: Id701349ea2ec999b40a592cc94b1535818c25e78 Reviewed-on: https://chromium-review.googlesource.com/895387Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534110}
-
kylechar authored
TakeHandle() was resetting |memory_| without unmapping the shared memory. This leaks resources because it's no longer possible to unmap after that point. Bug: 804399 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I42397ec8dc768ec6d9b2affcaee829f6c8a8ea00 Reviewed-on: https://chromium-review.googlesource.com/897969 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534109}
-
Thomas Anderson authored
This reverts commit 9d1ddd57. Reason for revert: Causing http/tests/devtools/sources/debugger/async-callstack-fetch.js to fail on WebKit Linux Trusty ASAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/8904 Original change's description: > Refactor away TaskQueueManager::DoWork in favor of the Sequence interface > > This patch changes the Sequence interface slightly by introducing > DelayTillNextTask which helps work around problems scheduling delayed > tasks when TakeTask doesn't have a task to return (due to cancellation). > > Change-Id: I5935e41ad5bc725b6109a187b329c82ce5a70689 > Bug: 783309 > Reviewed-on: https://chromium-review.googlesource.com/883346 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534070} TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org Change-Id: I8eab7e997f2ca6d397b6233f7a4f3ae8664437a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783309 Reviewed-on: https://chromium-review.googlesource.com/899902Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#534108}
-
Evan Stade authored
Bug: 578868 Change-Id: I557cc7c90b9632beae9e7b56ca477515abcd67ab Reviewed-on: https://chromium-review.googlesource.com/896705Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534107}
-