- 13 Jul, 2018 40 commits
-
-
Anders Hartvoll Ruud authored
How registered custom properties are reified is currently not specified [1]. For computed values, it should hopefully be pretty obvious how it should work. (For declared/inline style it is less clear). This patch adds tests for the computed style only. Note: * <transform-function> is not tested, because it appears that this syntax was re-added to the spec by mistake, so I expect support for <transform-function> will be reverted. * <transform-list> and list syntaxes in general are not tested, because it's currently broken in Blink. Tests for list syntaxes will be added along with the fix for that. [1] https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue R=chrishtr@chromium.org Bug: 641877 Change-Id: Ic177bfe2b90897ec44ef4405c745171d8b226e82 Reviewed-on: https://chromium-review.googlesource.com/1134778Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#574858}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8495de1eb482..754b096de220 git log 8495de1eb482..754b096de220 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 sabbakumov@yandex-team.ru Catch psutil.NoSuchProcess when iterating over processes Created with: gclient setdep -r src/third_party/catapult@754b096de220 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie29632a9121d554ebc79a7a09b99860b853efd17 Reviewed-on: https://chromium-review.googlesource.com/1135354Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574857}
-
Adam Rice authored
With the WebSocketHandshakeReuseConnection feature enabled, WebSocket connections can be reused for auth. However, they can also be returned to the pool after other kinds of response. A WebSocket connection should not be reused if the handshake has failed, so explicitly close the connection on handshake failures. BUG=423609 Change-Id: If02924395cff1c36b1a172ded26df31840f1358c Reviewed-on: https://chromium-review.googlesource.com/1127079 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574856}
-
Philipp Hancke authored
removes most usage of generateMediaStreamTrack in favor of await-ing tracks from getUserMedia and stopping them) BUG=836871 Change-Id: Id84f6cb6b3537faf2bb83332c5d7993550246581 Reviewed-on: https://chromium-review.googlesource.com/1117069Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574855}
-
Dominik Röttsches authored
font_service was initially set up for Mandoline sandboxing html_viewer, compare https://crbug.com/492524 but since Mandoline has been deprecated, I do not see any use for this out of process service in mash/ash context anymore. The font_service itself has been upgraded to perform more FontConfig tasks and is run inside a utility process at the moment, but only from a Chrome browser context. Disable it here, as a preparation for moving the newly extended font_service to be run in-process. Bug: 492524 Change-Id: Id731ae4b4ed12403b293b9548f0af4a4b18c3802 Reviewed-on: https://chromium-review.googlesource.com/1135544Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#574854}
-
Antoine Labour authored
GetRasterDecoderContextState doesn't need to be in charge of validating GPUCreateCommandBufferConfig's attribs, it is simpler to do it in RasterCommandBufferStub::Initialize. Also for passthrough, don't force configuration needed for command buffer validation, as untrusted data isn't passed to the context directly, and allow ES3 contexts like on non-passthrough. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d46dcb966eba60dc6f03faf24ef92dcffef773d Reviewed-on: https://chromium-review.googlesource.com/1134478Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#574853}
-
Yoichi Osato authored
This patch simplifies the constructor chain by removing redundant private constructors and creating internal friend class. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8fbf458b1920267f09c0a8b38b1882752bdf1db9 Reviewed-on: https://chromium-review.googlesource.com/1128797 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#574852}
-
Rob Buis authored
Basically implement the TODO. Bug: 803772 Change-Id: Ib78803df2109f604997bd6932ab1fde14142af46 Reviewed-on: https://chromium-review.googlesource.com/1135538Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#574851}
-
Kent Tamura authored
CEReactionsScope instances should be created before ExceptionState instances. https://html.spec.whatwg.org/multipage/custom-elements.html#cereactions > 2. Run the originally-specified steps for this construct, catching any exceptions. If the steps return a value, let value be the returned value. If they throw an exception, let exception be the thrown exception. > 3. Let queue be the result of popping from the custom element reactions stack. > 4. Invoke custom element reactions in queue. > 5. If an exception exception was thrown by the original steps, rethrow exception. In Blink, exception thrown by originally-specified steps is stored in ExceptionState, and ~ExceptinoState() rethrows it. ~CEReactionsScope() does step 3 and 4. So, ~CEReactionsScope() should be called before ~ExceptionState(). Before this CL, this order was reversed. So reactions can be called after rethrowing an exception. It made some V8 operations failing. Bug: 828804 Change-Id: I0189362b0d01f527808286370b95fc65b1957380 Reviewed-on: https://chromium-review.googlesource.com/1135877Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#574850}
-
Gauthier Ambard authored
This CL modifies the overscroll actions controller to update its view when the user starts pulling only when the user is actually dragging the scroll view. If it happens on automatic scrolling, do nothing to avoid adding the overscroll view again. Bug: 855670 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If5047354ab5b02c4c8fb80166d93a49a1e3e6059 Reviewed-on: https://chromium-review.googlesource.com/1134999Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#574849}
-
tzik authored
ConnectionListener instances injected to EmbeddedTestServers by NetworkContextTest need to outlive EmbeddedTestServer instances. Otherwise, EmbeddedTestServers use it after free in their dtors. This should deflake NetworkContextTest.PreconnectMax failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6789 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I38b4deed533ca9df68f1d4258eb25e63b0241afe Reviewed-on: https://chromium-review.googlesource.com/1136254Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574848}
-
Naoki Fukino authored
In FileSystem API level, the root directory contains sub directories only, and all files are guaranteed to be located inside first-level directories. For example, in Pictures view, we have directories in the first level and all image files are in the second level. Pictures/ DCIM/ a.jpg Snapsheed/ foo.jpg To provide flatten view of files, it is enough to retrieve files recursively up to one level from the root. This CL adds a parameter to util.readFilesRecursively to limit the level of recursion, and use the function with limit:one-level to retrieve media-view files. Bug: 749924 Test: Manual test with/without #new-files-app-navigation and browser_tests Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie73f053fd7377cb3ef54013f97cd779920869613 Reviewed-on: https://chromium-review.googlesource.com/1135117Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#574847}
-
David Grogan authored
Instead use ComputeMinMaxSize's new functionality that runs full layout in such situations. Only 4 tests were most proximately hitting this DCHECK. 3 of them now hit another and 1 has a mismatch. Bug: 845235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7b1373e2e61a655043c568aa133bc4b1676e2ad0 Reviewed-on: https://chromium-review.googlesource.com/1136052Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#574846}
-
Alexey Baskakov authored
We plan to re-group and move web_app.h code to components/, extensions/, bookmark_apps/ buckets later. Modernize: Use OnceCallback where possible. Bug: 860581 Change-Id: Iae55d9d0a665a7cb1df05cba15491fe9c82b819c Reviewed-on: https://chromium-review.googlesource.com/1136162 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574845}
-
Alan Cutter authored
This CL adds the hosted app menu button and content setting icons to hosted app windows on Windows 10. This change is hidden behind the DesktopPWAWindowing feature flag. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347457&signed_aid=au-e34qQfQGuYJ_kA_12hQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347458&signed_aid=GB7N2rD2QIOLiOf0dnnBEg==&inline=1 Bug: 854479 Change-Id: I719e96f1f1c75b8d2fa3e70a6597534101bde3a9 Reviewed-on: https://chromium-review.googlesource.com/1128824 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574844}
-
yiyix authored
Both metrics browser.DrawIntervalWithMainThreadAnimations2 and browser.DrawIntervalWithCompositedAnimations2 do not report meaningful data. Bug: 856860 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2f65962ccc1a4535b4a166298a79c673b5ae746b Reviewed-on: https://chromium-review.googlesource.com/1134588 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574843}
-
Xunran Ding authored
Bug: 855465 Change-Id: Idfe526ba88498413a280e243653667b56d18f6ae Reviewed-on: https://chromium-review.googlesource.com/1130566Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Xunran Ding <xunran.ding@samsung.com> Cr-Commit-Position: refs/heads/master@{#574842}
-
Yutaka Hirano authored
We are planning to enable CORSURLLoader in services/network. As many browser-initiated requests are not interested in CORS, this CL changes the default value for ResourceRequest::fetch_request_mode from kSameOrigin to kNOCORS which bypasses all CORS logic. This CL also changes the initial value for fetch_credentials_mode so that it matches with the default load flags. This CL also adds a precondition for the redirect mode: as long as the request mode is kNoCORS, the redirect mode must be kFollow, which matches with the fetch spec. I will enforce the precondition in a subsequent CL. Bug: 862184 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icbdf9c113f7eb310fa40495c54bbaa09d6313dce Reviewed-on: https://chromium-review.googlesource.com/1132832Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#574841}
-
Patti authored
According to the URL spec here - https://url.spec.whatwg.org/#url-rendering, URLs being displayed in bidirectional text "should be rendered as if it were in a left-to-right embedding". Update places in Site Settings that display a URL to conform to this. See https://bugs.chromium.org/p/chromium/issues/detail?id=862919#c4 for a screenshot of how this may affect a URL with RTL characters. Bug: 862919 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ica8c2bab0f2964c2a03f45f00ea423e2af945f4e Reviewed-on: https://chromium-review.googlesource.com/1113170 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#574840}
-
Patti authored
r574073 updated the all sites page to use an iron-list, which allows parts of the DOM to be re-used as the user scrolls down the page and loads additional all sites items. However, since the expandable list in each site-entry is stored separately (i.e. not in the iron-list item), this value can get stale when an already expanded entry is re-used in an ungrouped site-entry, resulting in a site-entry with a single origin listed getting stuck in an opened state. To fix, check when the site-entry changes iron-list items and close the expandable list if the iron-list item is ungrouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2bb33b60623e2fb12487e730ec122391a1d76660 Reviewed-on: https://chromium-review.googlesource.com/1134644 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#574839}
-
Peter Kasting authored
Bug: 850573 Test: Open a popup window (e.g. using popuptest.com); double-clicking the window icon should close the window Change-Id: Iec6b2d192502557f1e95ade99c204a6db58dfff6 Reviewed-on: https://chromium-review.googlesource.com/1136059 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574838}
-
Ryan Cui authored
Bug: 826476 Change-Id: Id24d14cd5dc0ac31fac4e865f71047aa75c8a786 Reviewed-on: https://chromium-review.googlesource.com/1130819 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574837}
-
Douglas Creager authored
Per https://github.com/w3c/reporting/issues/41, we're supposed to send a CORS preflight request before uploading reports, if the origin of the reports is different than the origin of the collector. There is existing CORS preflight code in both Blink and the Network Service. Code in //net isn't allowed to depend on either of those; instead of using a delegate to handle the inverted dependency, we just send out the preflight request by hand, just like the Expect-CT code does. Bug: 860802 Change-Id: Ib20db54d3d2597d9fbacfe356e61cc6d3bc9d5fc Reviewed-on: https://chromium-review.googlesource.com/1128600 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#574836}
-
Jinsuk Kim authored
Removing myself from watchlist for changes to ContentViewCore classes as they're gone. Change-Id: I72aa9902ce0c704a650168dfd97307b5c7f5aad8 Reviewed-on: https://chromium-review.googlesource.com/1133600Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#574835}
-
Christopher Cameron authored
The call to hb_buffer_add_utf16 will read up to 5 characters adjacent to the specified range. This context is only used in the function arabic_joining. We can get much better caching if we don't include this context in our keys. Arabic is an RTL language, so we can omit this context in the key for all non-RTL languages. Bug: 860612, 862773 Change-Id: Icc11059886ab835032141ad25b966d358f7177b3 Reviewed-on: https://chromium-review.googlesource.com/1135723 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574834}
-
Peter Kasting authored
This fix applies solely to pre-refresh and corrects a regression in previous refactoring I did in https://crrev.com/555249 . Bug: 840338 Test: Launch chrome in Material (not Refresh) mode; maximized the window and open enough tabs to fill the strip. The new tab button should not be near-touching the profile avatar button. Change-Id: I60598a1e7bcf45e039d19424c8639958094b7658 Reviewed-on: https://chromium-review.googlesource.com/1136065 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#574833}
-
Chih-Yu Huang authored
When VEA negotiates the input size, the driver might adjust the size for buffer alignment. In this case, we should verify whether the encoded video has the original size. BUG=b:79551489 TEST=Pass VEA unittest on kevin device with QCIF video $ ./video_encode_accelerator_unittest --test_stream_data=foreman_qcif.yuv:176:144:1:out1.h264:1000000:30 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia6e5de20cdd6fcbcdb043edfaa09150229b3c3ba Reviewed-on: https://chromium-review.googlesource.com/1062987 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#574832}
-
Scott Chen authored
Bug: 861685 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib84715313698d8ded12cc7ecedfae719e15e917e Reviewed-on: https://chromium-review.googlesource.com/1135758Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574831}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2af75f76f0e6..589fda45ed12 git log 2af75f76f0e6..589fda45ed12 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 oysteine@google.com Build protozero libraries as source_sets instead of static libraries in component builds Created with: gclient setdep -r src/third_party/perfetto@589fda45ed12 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:78791178 TBR=perfetto-bugs@google.com Change-Id: Idce6841215e7962bd4fbc27b1b5bedf26cee9627 Reviewed-on: https://chromium-review.googlesource.com/1135495 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574830}
-
Darren Shen authored
Currently, when we cycle through results in find in page, we ensure that the current result is visible by scrolling if the result is off-screen. We currently use the layout viewport as an indication of what's visible on the screen. However, layout viewport does not include the virtual keyboard on ChromeOS. This means that on a tablet, the current result may be hidden by the virtual keyboard. We change find in page to use the visual viewport instead, which takes into account region occluded by the virtual keyboard, so the current result is always visible even when the virtual keyboard is up. Bug: 862842 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I10e52091fb54617ae3d0222130cd1c22699117f5 Reviewed-on: https://chromium-review.googlesource.com/1134722Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#574829}
-
Peter Wen authored
Reflects the change from --full to --fast. Bug: 620034 Change-Id: Id88f4f3e00cc1f6fcdc4878786cc342d8717537d Reviewed-on: https://chromium-review.googlesource.com/1135530 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574828}
-
Giovanni Ortuño Urquidi authored
FindMatchingUrlHandler checks if the Chrome app supports offline and if not returns no matching URL handlers. This is done in order to avoid redirecting links to apps that don't support offline. Unfortunately, this offline check causes problems for Desktop PWAs. Desktop PWAs use FindMatchingUrlHandler to decide if a URL belongs to an app. Because of the check in FindMatchingUrlHandler, it seems as if no URLs belong to the app. To solve the issue, we introduce separate methods to be used by Bookmark Apps and Platform Apps. The Platform Apps method checks for offline and the Bookmark Apps one does not. Bug: 850626 Change-Id: If5642d342b558098c7bfe1c251912504cad1d957 Reviewed-on: https://chromium-review.googlesource.com/1124075Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#574827}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13ac194dbf99..9cdbf1942de5 git log 13ac194dbf99..9cdbf1942de5 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-13 bsalomon@google.com Remove texel buffer support. Created with: gclient setdep -r src/third_party/skia@9cdbf1942de5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I7e535dcbb3290cfa43f819f862c6f9a37dfd960f Reviewed-on: https://chromium-review.googlesource.com/1135673Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574826}
-
Taiju Tsuiki authored
This reverts commit 37061f87. Reason for revert: The layout tests added by this CL is failing on the CL: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 Original change's description: > Correctly initialize and test SnapContainerData in cc. > > This patch initializes the rect_ field in SnapContainerData in copy > constructor and move constructor. Fixing a snapping issue in the > composited pages. > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > test suite so that they are tested with the composited cases. > > snap-at-user-scroll-end-manual-automation.js calls > mouseClickInTarget() of pointerevent_common_input.js. That method > invokes programmatic scrolls. The test was written before programmatic > scroll snapping was implemented so it worked at that time. However, > with programmatic scroll snapping implemented, it will always snap > in mouseClickIntarget() and cannot test whether the user scroll snaps. > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > to avoid invoking programmatic scrolls in the test. > > This patch also checks nullptr for layout_box in > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > Reviewed-on: https://chromium-review.googlesource.com/1132386 > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574781} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136171Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574825}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Idbeb132167cb747f2b3a432c21ad861864587a35 Reviewed-on: https://chromium-review.googlesource.com/1136032Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#574824}
-
Taiju Tsuiki authored
This reverts commit 51181f47. Reason for revert: Speculatively revert for resolving the bot failure on the CI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14387 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28041 Original change's description: > Increase the UI paint timeout to 5 seconds. > > This fixes the first browser window appearing blank for a moment. In > general, it's better to block than to show the UI in an inconsistent > state. Web content should *not* wait this long. > > Bug: 849762 > Change-Id: I2b73e52a0425ee6fa583fcddc0300dc8a2d3ad73 > Reviewed-on: https://chromium-review.googlesource.com/1135119 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574731} TBR=ellyjones@chromium.org,ccameron@chromium.org,sdy@chromium.org Change-Id: I80bd11b7478bd1b40b11c9c71aa75de65a874da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849762 Reviewed-on: https://chromium-review.googlesource.com/1136131Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574823}
-
Maajid authored
This reverts commit e2cee66e. Reason for revert: broke tree Original change's description: > Record to UMA when starting an ARC++ app from the launcher. > > Bug: 854542 > Test: chrome://histograms > Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 > Reviewed-on: https://chromium-review.googlesource.com/1112891 > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Maajid <maajid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574819} TBR=stevenjb@chromium.org,rkaplow@chromium.org,khmel@chromium.org,maajid@chromium.org Change-Id: I48cd080e2b59f5bad5ea7a12ca1e50da7cb3cbad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854542 Reviewed-on: https://chromium-review.googlesource.com/1136111Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574822}
-
Derek Cheng authored
To ensure MediaRouter's route list is updated when a DIAL launch app fails, we will need to invoke erase the route from the list of records before notifying DialMediaRouteProvider of the route list update. Bug: 808720 Change-Id: I65c925dc74a57a1c2d80dc1366f8be3ccbf40ce5 Reviewed-on: https://chromium-review.googlesource.com/1134867Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574821}
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http/tests/security/setDomainRelaxationForbiddenForURLScheme.html indicates that on many builders (probably all those without DCHECK on) this test passes. Bug: 699347, 686118 Change-Id: I7496ce45d0ce5c196073acba954f8cd48c7f1f3b Reviewed-on: https://chromium-review.googlesource.com/1135661Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#574820}
-
Maajid authored
Bug: 854542 Test: chrome://histograms Change-Id: I635aa0522ebb2cac70f056937508ff5ef183d244 Reviewed-on: https://chromium-review.googlesource.com/1112891Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#574819}
-