- 18 Jun, 2019 40 commits
-
-
Esmael El-Moslimany authored
Bug: 973380 Change-Id: If17e44de0fad55305687f15e072e6800d6e7dfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661084Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670184}
-
Eugene But authored
kkhorimoto@ wrote most of this code and eugenebut@ reviwed major portion of those changes. Bug: None Change-Id: I1f94758d95853b467b4dd6347af099aa610f63ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664517 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670183}
-
Anders Hartvoll Ruud authored
This CL makes it possible to use -internal properties in kUASheetMode, and uses this capability to remove the special case for foreignObjects in StyleResolver. Change-Id: I1bd0c547d7b45ebaf83846c4de3c3f2dc240eb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663408 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#670182}
-
Stephen Chenney authored
Add a flag to LocalFrameView to prevent multiple lifecycle starts causing multiple commit deferrals. Bug: 974280 Change-Id: Id70132f9b8ff528d96be110c4e383b3054befa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663252Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#670181}
-
Justin Cohen authored
WKWebView is more aggressive than Chromium in updating the visible URL, and there are many cases where the WKWebView URL has updated and Chromium still displays the last committed item. Normally this is managed by WKBasedNavigationManagerImpl last committed, but there are a few periods during fast navigations where WKWebView URL has updated and ios/web can't always verify what should be shown for the visible item. More importantly, there are bugs in WkWebView where WKWebView's URL and backForwardList.currentItem can fall out of sync. While those bugs should be fixed, safeguard visibleItem by returning documentURL in those untrusted situations. Bug: 971740 Change-Id: Iafaa274fc871203a08b71dfd4ec71b03119ee8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656095 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#670180}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2313020206fc..49131ca238de git log 2313020206fc..49131ca238de --date=short --no-merges --format='%ad %ae %s' 2019-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@49131ca238de The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ica7d05c6eed073a235bfad4b6d6c98ab5772c3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670179}
-
Matt Mueller authored
Looks like it used to depend on use_glib from ui.gni but now only depends on use_gio which is in build/config/features.gni Change-Id: I1f85c9ca7d0f446c308c3695a0b8e5a1a552c457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664640Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#670178}
-
Rohit Rao authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/fb25165a5ec5..e272bbd853ee $ git log fb25165a5..e272bbd85 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 tirodkar iOS 13 Keyboard key fix. Created with: roll-dep src/ios/third_party/earl_grey/src BUG=973708 Change-Id: Ic1827ba461aa0b700d4e0312bbb34579614937bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663887 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670177}
-
Julian Kung authored
This is a reland of bf62d746 except restored expected failed tests in third_party/blink/web_tests/WebDriverExpectations. Restored tests: external/wpt/webdriver/tests/element_send_keys/content_editable.py. Original change's description: > [ChromeDriver] Element Send Keys: support content editable; fix text input type > > The email input type being considered a text input caused bugs and crashes. > In this commit it is removed from textControlTypes and thus no longer > considered a text input. > > Also added support for content editable > elements in compliance with the following W3C procedure: > "Set the text insertion caret after any child content." > Added test to run_py_test to test correct functionality. > > R=crouleau@chromium.org, johnchen@chromium.org > > Bug: chromedriver:2704 > Change-Id: I95bb9ff2396aa0e6bdfa35dde33f338be83607b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658966 > Commit-Queue: Julian Kung <juliankung@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669828} Bug: chromedriver:2704 Change-Id: Ice814a85a2306fc0565c36af3ee3575df945df08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664646Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#670176}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2d223552e3fe..81b6acfb8685 git log 2d223552e3fe..81b6acfb8685 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 jonahr@google.com Roll SPIRV Tools and Headers into ANGLE 2019-06-18 kkinnunen@nvidia.com Remove unused WidenString function 2019-06-18 m.maiya@samsung.com Add support for OES_depth24 2019-06-18 kkinnunen@nvidia.com D3D: Add a wrapper to Image11 that enables ASAN/MSAN to catch the errors on map operations Created with: gclient setdep -r src/third_party/angle@81b6acfb8685 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ia859326beddc57acde43073080532ff42d1c2cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664106Reviewed-by:
-
Brian Sheedy authored
Fixes the proguard_configs assignment in the monochrome_public_test_ar_apk target being unused with certain GN args by having the variable forwarded in the template that the target uses. Bug: 976262 Change-Id: Ice7d0cabd5bc4fa850bb6a5a38d8524002bd4b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663686Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#670174}
-
John Lee authored
This CL exposes the native <dialog> element in <cr-dialog> that allows users of <cr-dialog> to customize the style of the <dialog> using the ::part selector instead of a mixin. The mixin cannot be removed yet as OOBE still uses Polymer 1/Shadow DOM v0 which does not support shadow parts. Bug: 973674, 954202 Change-Id: I5a865b021bcd271ca8ddc2cedf49fb8ccaaf7878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656320Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#670173}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8103e5d2c64..c39cb7918f0b Created with: gclient setdep -r src-internal@c39cb7918f0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I480d64d16d0696703b05f36048505890e54a4ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664428Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670172}
-
shrekshao authored
https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_draw_buffers.txt ES 2.0 requires that all color buffers attached to application-created framebuffer objects must have the same number of bitplanes (Chapter 4 overview p91). Bug: 972876 Change-Id: If923efb1c43946968e9b581f488b110a96c30361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663374Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#670171}
-
Yves Arrouye authored
We want to extend those as the Auto RE migration isn't done yet and we need it to happen first. BUG=chromium:975520 TEST=None Change-Id: I080b7f91f6832ed72cbe87f198944166449cf6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663351Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#670170}
-
Esmael El-Moslimany authored
Bug: 973395 Change-Id: I8589e52354d1353b6d3bef9024f4062ba9d6d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661293 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9283b2559c05..67180a07f8d5 git log 9283b2559c05..67180a07f8d5 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 capn@google.com Fix building with Clang 4.0 Created with: gclient setdep -r src/third_party/swiftshader@67180a07f8d5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130335507 TBR=swiftshader-team+autoroll@google.com Change-Id: Icc0c65a60bc4d2241167ee72fcda2a2c16126a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664645Reviewed-by:
-
Ahmed Fakhry authored
This reverts commit 5bb00348. Reason for revert: Breaks the docked magnifier and breaks the stacking of ash containers. BUG=969630 Original change's description: > Force Accessibility Panel to show above all other windows > > Bug: 946616 > Change-Id: I5fa49fe568ab0aecbd2b270c32a714c463d92605 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542162 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#645374} TBR=dtseng@chromium.org,anastasi@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946616 Change-Id: I7ead2ab4cc12499be816fbb2f56ea841ab633242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663366Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#670167}
-
Evan Stade authored
Move GetArcAppIdByPackageName from AshMessageCenterClient to its own C++ interface. Also delete ash::mojom::AshMessageCenterClient since it's now empty. Bug: 958191 Change-Id: I605ae6ae081e54010348dd3e9c4d01ece8aaaed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658846 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670166}
-
Esmael El-Moslimany authored
This CL replaces tap event usages with click for oobe-back-button elements. Bug: 967793 Change-Id: I32d95983f80b025acaf75bb4f2390ec97eeae430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658837 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#670165}
-
Victor Costan authored
This CL converts URLFetcher::FetchType into an enum class, makes URLFetcher instances uniquely owned, and cleans up URLFetcher's internal state. Change-Id: If1553123fdc8edc9bf4889a60135207f39f5dba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662125 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#670164}
-
Irina Yatsenko authored
Modified CrashKeyBreakpadTest tests to possibly run in a non-clean state with some chunks already present. The change is prompted by CL https://chromium-review.googlesource.com/c/v8/v8/+/1658505 that adds crashkeys to V8's isolate so, depending on the test execution order, asserts might fire about having unexpected count of chunks. Bug: v8:9323 Change-Id: Id89335fcab04ab0eb37bd13ba2a11ecb964e66c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661082Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670163}
-
Jon Mann authored
This moves the sub-label text from roaming status to the enable roaming toggle, and removes the status-only row. Bug: 924237 Change-Id: I3ba0dbc4795ff07ef4ae279ced67319baf853ed6 Screenshot: http://screenshot/wYecCFJobTu.png Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661044 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#670162}
-
Bailey Berro authored
Change-Id: Idc1552d411007c357321ed0b28b7f5e963094f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649298 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Joel Einbinder authored
Inkscape generated weird output for svg masks, which caused some icons to render incorrectly in Chromium. Change-Id: I82778af43ce31c7c3f10e93923931a1f172a13bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663477Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#670160}
-
Jian Li authored
For picture element, we should not remove srcset attribute from source child elements and we should add image resource for ImageSourceURL(). Bug: 915982 Change-Id: I6374ab2177eb5c0324d4fcb036cb9b67beb90c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662949Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#670159}
-
Victor Hugo Vianna Silva authored
Change-Id: Id967aba3dcbb5e08311f4f9ccc913dc91d664aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660501Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#670158}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61d8ee10b611..e1814403169a git log 61d8ee10b611..e1814403169a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 sakal@webrtc.org Fix documentation in BitrateAdjuster. 2019-06-18 srte@webrtc.org Removes unused dependency on RTP/RTCP from loss based controller. Created with: gclient setdep -r src/third_party/webrtc@e1814403169a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iacc8576378c546730e70cfef12a29f1f074fcfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664427Reviewed-by:
-
Eugene But authored
Ali fixed a number of complex navigation bugs and has very deep understanding of WebKit navigation code. Bug: None Change-Id: Ia7d16605c1434812210a835b0fb97c9cd6deff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663364 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
The script was failing in new SDK because the new SDK added new part type 'device_profile' that the script didn't recognize. Added the new type to the list. Also fixed the error-handling code - previously it was failing with NameError while trying to throw an exception to report the unrecognized part type. Change-Id: I5f9e59edf4ed1532c1ed7fd6a23007a3f11c5ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664791 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670155}
-
Vasilii Sukhanov authored
Bug: 976007,969960 Change-Id: Iaad780b29bc1e43274a61549c851c98d15e01174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664149 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#670154}
-
Sean Gilhuly authored
Change PixelResourceTestCase to a struct that can independently specify the renderer type and the raster type. This will make it easier to add Skia Vulkan as a renderer option. Bug: 963446 Change-Id: Ibcd87d5c2adbcee1a0940387c924adbb54875e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664104Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#670153}
-
Johannes Henkel authored
This reverts commit 65941216. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit 3a73cee4. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > > > This reverts commit dc15ca61. > > > > Reason for revert: suspected to be causing link failures on android > > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > > > Original change's description: > > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > > > This updates the usages of the protocol types to the new > > > definitions, using std::vector-based implementations > > > of protocol::Array. > > > - In many places we can now use the C++11 style for( : ) loops. > > > - We use std::make_unique for creation. > > > - We use emplace_back to insert elements, which sometimes > > > allows us to create strings etc. in place. > > > - Accessing strings in arrays is cheaper, since vector[i] > > > returns a reference (protocol::Array::get made a copy!). > > > - One can assert equivalence of vectors with strings > > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > > - Overall the code is shorter, as the vector API is > > > more concise. > > > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#669857} > > > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669922} > > TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168 > Reviewed-by: Johannes Henkel <johannes@chromium.org> > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670151} TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: I8aa1016737e46461bbd7917d645b14a26f8f3abe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663847Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#670152}
-
Johannes Henkel authored
This reverts commit 3a73cee4. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[DevTools] Roll inspector_protocol and migrate to std::vector." > > This reverts commit dc15ca61. > > Reason for revert: suspected to be causing link failures on android > "ld.lld: error: thunk creation not co" when linking lib_components_browsertests__library.so > eg: https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/288408 > > Original change's description: > > [DevTools] Roll inspector_protocol and migrate to std::vector. > > > > New revision: 83b1154a9661d22bba9a368d368214cc20880419 > > > > This updates the usages of the protocol types to the new > > definitions, using std::vector-based implementations > > of protocol::Array. > > - In many places we can now use the C++11 style for( : ) loops. > > - We use std::make_unique for creation. > > - We use emplace_back to insert elements, which sometimes > > allows us to create strings etc. in place. > > - Accessing strings in arrays is cheaper, since vector[i] > > returns a reference (protocol::Array::get made a copy!). > > - One can assert equivalence of vectors with strings > > in tests (EXPECT_THAT(foo, testing::ElementsAre("bar", "baz")); > > - Overall the code is shorter, as the vector API is > > more concise. > > > > Change-Id: I6c8e152987fb0dcfbb01f9086ee48b284a0e5adb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657628 > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Leonard Grey <lgrey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669857} > > TBR=alph@chromium.org,caseq@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org > > Change-Id: Iabcd0386f28787f5042e1f252c9e330330cc525f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663403 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669922} TBR=alph@chromium.org,caseq@chromium.org,bpastene@chromium.org,lgrey@chromium.org,johannes@chromium.org,kvitekp@chromium.org Change-Id: Ia917b8b41af985303dbf6a129ee2d281f7cecc1f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665168Reviewed-by:
-
shrekshao authored
We now use an unordered_set to cache the hash of successfully compiled shaders in memory. So that when querying COMPILE_STATUS we don't have to always do shader compile if the shader object is not present even if the linked program is in cache. Some very simple profiling (improved investigation): (Detailed profiling data and some explanations could be found here: https://docs.google.com/spreadsheets/d/1_kAuC9lJ5QGxuKiM_hHF77rS7rmukAErr_hotF8EHd4/edit?usp=sharing) For a javascript program that creates and links 100 programs (200 different shaders in total, no randomized constant introduced) and query the compile status of shaders afterwards: 1. The first launch: There will be no difference between the cached version and no-cache version. Because there's no program cache at all. All shaders will get compiled in DoLinkProgram. The gpu::gles2::Shader instance will stays in memory. Future DoGetShaderiv calls where pname == GL_COMPILE_STATUS will directly access the gpu::gles2::Shader instance for whether it's valid or not. The query time for 200 shaders is ~36ms. (Time taken number afterwards all stands for query COMPILE_STATUS of these 200 shaders) 2. Refresh the page: Now there will be cache hit happened when program link so that shaders won't get compiled at program linkage. As a result, querying COMPILE_STATUS now in no-cache version will lead to shader->DoCompile, which would take ~400ms. For the cached version, as successfully compiled shaders have their hash stored in an unordered_set, There's no shader compilation happen, we simply look at if there's an entry of the shader hash in that set, which would take ~50ms. If the javascript program continues to query COMPILE_STATUS after the first query (though unlikely in a real-world scenario) The cached version will take slightly more time (~50ms) because it didn't have the compiled shader in memory but keeps looking into the unordered_set for shader hash. While no-cache version simple accesses gpu::gles2::Shader instance (~40ms). Future update on Angle might be needed as well. Bug: 775247 Change-Id: I08629e99a603c29d9a4e332b602bf669e074939a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593640 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#670150}
-
Tarun Bansal authored
Add regression test for the case where the loading hints arrive late in Blink. A new HTML file is added that loads resources using link-rel preload. The existing browsertest fails in that case. Bug: 891328 Change-Id: Id100da5b7c16c357132dcbf875d1d2048968c7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663355 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#670149}
-
Darin Fisher authored
A nice side-effect of this change is that it moves complexity out of RenderProcessHostImpl. Originally reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1654238 Change-Id: I9ce1fafebef8f314c6603ab122dab9a777b2e839 Bug: 967834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660157Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670148}
-
Robbie McElrath authored
I initialized the TestBrowserThreadBundle with REAL_IO_THREAD in crrev.com/c/1658644 to get around some fuchsia-specific behavior. That wasn't the correct way to fix it, this CL is. Bug: 974365 Change-Id: I55a2d533654f15d9280215bf26e652e1163be74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662968Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#670147}
-
Darwin Huang authored
This reverts commit ff7bc1fd. Reason for revert: SetTimeDialogBrowserTest.All Original change's description: > Only allow timezone changes when done button is clicked > > Instead of changing the system timezone when a new value is selected on > the list, it is only applied when the set date time dialog is closed. > This is necessary to ensure that only parents can change time and > timezone settings for children. > > Bug: 921145 > Change-Id: If5f3460381fc60607741828e59912c669af05a9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658858 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670069} TBR=xiyuan@chromium.org,agawronska@chromium.org,hgrandinetti@chromium.org Change-Id: I1d839ca4446c4f79d0809d1fa6e402a5f657abe7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664110Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670146}
-
Lukasz Anforowicz authored
The test used to just check if the request succeeded or not, but didn't look at the response body which since M73 was getting blocked by CORB. This CL: - Makes the test actually inspect/verify the response body - Use resource type that is not covered by CORB Bug: 940068 Change-Id: I755bb445e5241f1082f3981ac8506aaf185d64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650283 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670145}
-
