GitLab

This gives us APAC coverage. The current owners are all PST.

Bug: 994911
Change-Id: I0a291b7eae6c4bc0ab60ac48905bd4ab077c0ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129506
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755275}

This CL removes an unnecessary lazy load WPT expectation file for a test
that no longer exists. The test was renamed in
https://github.com/web-platform-tests/wpt/pull/21918/, but for some
reason the old expectation file stuck around.

R=kinuko@chromium.org, sclittle@chromium.org

Bug: N/A
Change-Id: I9eb79d6eca2bcd5b149cf09bcc889863deecb5d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130406Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755274}

This CL modifies the V4L2 and VAAPI video decode accelerators to handle
the case where the visible rectangle is not (0, 0). This can happen with
some H.264 videos.

The solution is to make sure that when we create the GL image for a
frame, the size should include the visible rectangle plus the
non-visible area to the left and on the top of that rectangle. This way,
the compositor can calculate the UV coordinates correctly so that we can
sample only the visible rectangle.

V4L2VideoDecodeAccelerator is unchanged. The reason is that the
assumption that the visible rectangle starts at (0, 0) will be harder to
remove there. We currently have a check that deals with that case [1].

CL:2041712 + (CL:2122484 + this) make it possible to handle exotic
visible rectangles in most Chrome OS devices (the ones that use
V4L2VideoDecodeAccelerator still need work). [2] contains before/after
tests for this CL for a variety of devices (where before is 822a983f minus
CL:2122484).

[1] https://cs.chromium.org/chromium/src/media/gpu/v4l2/v4l2_video_decode_accelerator.cc?l=2272-2277&rcl=10aaea0473eb652966b359c2b751974b97c5ab13
[2] https://drive.google.com/open?id=1wtX7jDkzvIxCMmsQlIV7zjwaWMrmikUy

Bug: 1062002
Test: H.264 with unusual rect in kevin, kukui, eve, hana, nyan_kitty.
Change-Id: Iac712fbf1b2cea3556b39fc38f5639c91c73b746
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128707
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755273}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Ie9d5865ff5be6203eadb71687a37b501cea51540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109576Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755272}

This CL adds a check in
V4L2SliceVideoDecodeAccelerator::CreateOutputBuffers() to ensure that
the visible rectangle is contained within the coded size. Note that
there are analogous checks in VAAPI [1] and V4L2VDA [2].

[1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/vaapi/vaapi_video_decode_accelerator.cc;l=455-458;drc=43a49df1600f4828a16317757aab3b2eb1478287?originalUrl=https:%2F%2Fcs.chromium.org%2F
[2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_video_decode_accelerator.cc;l=2262-2266;drc=008125344bd4814259607c541da5e6a792dc06ff?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 1062002
Test: normal playback still works on kevin and krane.
Change-Id: I5dd13e92822b20bb6dadbbea6b48a4bc06ed7a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131416
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755271}

When a node becomes ignored or unignored, the events fired by
AXEventGenerator should match the same events that would have been
fired if the same tree change occurred via real nodes appearing or
disappearing. Otherwise that results in subtle platform bugs.

The specific fixes are:

* Don't fire a STATE_CHANGED event just because the ignored status
  is changing.
* Don't fire CHILDREN_CHANGED on the node that toggled its ignored
  state. If it's being ignored, we shouldn't be firing events on it,
  and if it's being unignored, then it's basically a "new" node to
  the platform.
* Do fire a SUBTREE_CREATED event on the root of a local tree when
  a node is unignored.

These were caught by writing a test to iterate over every possible
change to trees up to a certain size. I'll follow up with that test
once the fix is in.

Bug: 1065144
Change-Id: I08a6be994cce6ffb056ae2a7f830cbbdbd28d75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125235
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755270}

[SendTabToSelf] Fix issue where omnibox self-share icon doesn't show when kSendTabToSelfOmniboxSendingAnimation flag is turned on.

Bug: 1007536
Change-Id: Ib17efb7f120f0d4edaa453de66a830be30f644c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130816Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755269}

No behavior change. This CL reduces potential risks of use-after-free bugs.

Bug: 1049056
Change-Id: Icf65cb3d9e62f1eb51fddce41ff3dcadd6b637ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108403Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755268}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0169ff39..de31800c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia7b62bf0d1c987a3f06db2dd4af8755f24652a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130431Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755267}

Bug: 1049056
Change-Id: Ic6736fa67155b432a4dca4725be254fc316d037a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105681Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755266}

This CL does the following:
  * Updates tab to use the standard list item, modern_list_item_view
  * Adds a grey circular background for favicon

Change-Id: Ia7222a434c4d0bf585e59bdeebd6ed2184c5a567
Bug: 1042890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107795
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755265}

https://chromium.googlesource.com/angle/angle.git/+log/4b94d7bb4fbe..7d8c2f2e3322

git log 4b94d7bb4fbe..7d8c2f2e3322 --date=short --first-parent --format='%ad %ae %s'
2020-04-01 ynovikov@chromium.org Hide SwiftShader OS Window in dEQP and end2end tests
2020-04-01 ynovikov@chromium.org Skip SwANGLE GLES31 tests which flakily crash with Win 32-bit Subzero
2020-04-01 cclao@google.com Vulkan: Avoid renderpass break for occlusion query

Created with:
  gclient setdep -r src/third_party/angle@7d8c2f2e3322

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I84706dc38dc4638751dc862372462150d1af9e54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131490Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755264}

Originally, we were targeting disabling both impl thread and main thread
latency recoveries for DisableLatencyRecoveryDesktop experiment.
However, current Finch experiment results on canara/dev and beta show
that this config would likely have some regressions and the config with
the least regressions and the most improvements would probably be
EnabledImplDisabledMain, i.e. disabling latency recovery on main thread
only.

Bug: 993895,1060144,1060321,1060519,1060535,1062789
Change-Id: I47d3dc6de0e395ee1cd42f1993a51cdeebdf96c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121465Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755263}

The stream parsing method should only do that - parse the stream.
Workarounds can be applied independently of it, so move them outside of
the method so we can move it around more easily.

BUG=b:149663704
TEST=vdatest passes on Hana.

Change-Id: I9f1305463424d14678f64d9056a54a5f761a39fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130453
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755262}

This CL adds a test that verifies GbmSurfacelessWayland receives and
sends Swap and Presentation callbacks in right order according to local
swap id.

Shortly speaking, this test shows that we have the following behaviour:

Commit[0]
OnSubmission[0]
OnPresentation[0] <- can happen at any time after onsubmission.
SwapCompletionCallback[0]
PresentationCallback[0]
----
Commit[1]
OnRelease[0]
OnSubmission[1]
SwapCompletionCallback[1]
OnPresentation[1] <- can happen at any time after onsubmission.
----
Commit[2]
OnRelease[1]
OnSubmission[2]
OnPresentation[2] <- can happen at any time after onsubmission.
SwapCompletionCallback[2]
----

Test: WaylandSurfaceFactoryTest.GbmSurfacelessWaylandCheckOrderOfCallbacksTest
Bug: 1055755
Change-Id: I769d2d54c9fccb72fc59cb348e6ad743f3ce3062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078013
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755261}

Bug: b:152926504
Change-Id: I424f372f9a606e8a7b02e32649eb043709ab9dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130588Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Auto-Submit: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755260}

This reverts commit 090883ab.

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=1066696

Original change's description:
> CrOS: Get rid of some leftover panel code
> 
> Change-Id: Ib985375a552b06dacf7a647fafcdc87b30afd9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108161
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755125}

TBR=benwells@chromium.org,manucornet@chromium.org

Bug: 1066696
Change-Id: If558a3a10c5390df7a17ef86ea403cd33f023bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131547Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755259}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33eae455663e..d2b26ce6739e


Created with:
  gclient setdep -r src-internal@d2b26ce6739e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Idbe07682ce004b352bcb6de41ef8e1267c99baf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131497Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755258}

AppServiceProxy::LaunchAppWithFiles is added to replace
LaunchService->OpenApplication, and use AppService publishers to forward
and launch an app with files, to keep consistency.

The general function CreateAppLaunchParamsForIntent is moved to
launch_utils, which is used by both ExtensionApps and WebApps.

Add GetAppLaunchSource to get the AppLaunchSource from LaunchSource.

BUG=1061843

Change-Id: If8668f9e8f6ccabf8c7653ad4584f063346f1018
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121860
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755257}

The new code generator of IDL dictionary provides a templated setter,
but it doesn't work for initializer lists to construct a member
directly.

This CL adds another setter for rvalues of member types, and makes it
possible to initialize a member through the setters.


Bug: 839389
Change-Id: I89ffd79fff92a58ac722052334afa639d9cf7918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129377
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755256}

Chrome and Firefox aligned on treating `"foo;bar"=baz` as a nameless cookie
with a value of `"foo`, and `"foo\"bar;baz"=qux` as a nameless cookie with
a value of `"foo\"bar`. That is, they both stop parsing the name/value pair
when they hit a `;`. This seems aligned with step 1 of
https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-05#section-5.3,
which defines the `name-value-pair` as everything up to but not including
the first `;`.

Adjusting these tests accordingly, as discussed in
https://github.com/httpwg/http-extensions/issues/1136.

Change-Id: I6930f8e18a8c573b21eaea5614e14c3b957ea0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128135Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755255}

Bug: 1028409
Change-Id: Id289aa7a7c8c708bb6a530d3ebf6f5be4cb8deb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130266
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755254}

kSystemFeaturesDisableList pref represents a list of system features
(camera, settings, ..etc) to be disabled by an admin policy.
It should disable those features regardless of their underlying
implementation (PWA, Chrome App, Web App,..).

Bug: 1063404
Change-Id: Ica2e523aba36378fb9049820e73dde0afcad6cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124655Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#755253}

The test seems to be flaky on this bot.

TBR=aboxhall@chromium.org

Bug: 1066702
Change-Id: I445f46df05c70f86c0433322a5cfbebaad853dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130892
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755252}

This reverts commit b80aea17.

Reason for revert: Causing use-of-uninitialized-value.
https://bugs.chromium.org/p/chromium/issues/detail?id=1066737

Original change's description:
> Add a metric to track what resource type triggers SB blocking page.
> 
> We'd like to know for each safe browsing blocking page created, what
> is the resource type that triggers the page. This information
> can help us decide the priority of resource types that should be
> checked in real time.
> 
> Metrics added in this CL:
> SafeBrowsing.BlockingPage.ResourceType
> 
> Bug: 1065137
> Change-Id: I5c5c07c138f2d4f149229af54b03b68e623d44d1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121735
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755177}

TBR=holte@chromium.org,drubery@chromium.org,xinghuilu@chromium.org

Change-Id: I29b299e6110511a5435eba174b6ed538dfddc99b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1065137, 1066737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131437Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755251}

Bug: None
Test: CCA can be opened normally.
Change-Id: I502afe94b9ccedcadf1f27e6f5d19adbc51842f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131172
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755250}

TBR=apotapchuk@chromium.org

No-Try: true
Bug: 1066732, 1047176
Change-Id: I60ac94d6bfacd6aef3e44bc8b5768521b056a602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130951Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755249}

Verify sticky position while composition happens. Catch when the main
thread position is different from the sticky position of ref tests.

Bug: 1059272

Change-Id: I3ec4fa391b42ff3783b2e89347a4bd10ab81faaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105754
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755248}

When a user attempts to launch a Crostini app during the upgrade,
we redisplay the Upgrader window as feedback that they can't launch yet.

Bug: 1064528
Change-Id: I4d27a0afc2c8d0592db9a6e0f2ae2f0cffb0e89e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129797
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#755247}

The V4L2 workaround interface was taking the end position of the encoded
stream as a writable argument - this is dangerous and it doesn't even
need it, so remove it.

BUG=b:149663704
TEST=vdatest passes on Hana.

Change-Id: I6ec9b137e6e762fd999e6ae2462db4564b0e7134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130452
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755246}

ApplicationConfigManager is now available as a normal service, so
there is no need to reach it via ConnectToAgentService().

However, it must be reached via each component's service-directory,
rather than the CastRunner process' service-directory, since the Cast
components run in a different "session" from the Runner.

Bug: fuchsia:43004
Change-Id: I638cc3bca4d3d80f7f97a50d637065eb36f9d89a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089699
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755245}

list_hash_set_test.cc already tests both ListHashSet and LinkedHashSet. It's natural to add NewLinkedHashSet to the list.

Not all tests work right now, due to insertion of 0 (an empty value).

Change-Id: Ib649c3ccc8c28323673b75b07857ac0a89440f0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130586Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755244}

[Sheriff] Mark virtual/threaded-no-composited-antialiasing/animations/events/animation-iteration-event.html as flaky

TBR=apotapchuk@chromium.org

No-Try: true
Bug: 1066122
Change-Id: I4949697cbf0aa4105279a08580187d367f6a861e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130587
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755243}

Currently, PdfMetafileCgTest.RenderPageBasic does all the rendering
and bitmap comparisons directly within the test. PdfMetafileCgTest will
add more tests to its suite that will do the same things. Add helpers to
simplify the addition of tests.

Change-Id: I1973d04d8a93cf1f1e1f19ff55eb6af66316cb7a
Bug: 919596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125227
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755242}

Adding a flag to put the Plugin VM camera setting behind
whilst it is still a WIP.

Bug: 1016193
Change-Id: I229143278b0e3f632072eadc9f6910b5cad7109e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131107Reviewed-by: Julian Watson <juwa@google.com>
Commit-Queue: Daniel Ng <danielng@google.com>
Cr-Commit-Position: refs/heads/master@{#755241}

This DCHECK is faulty is several accounts:

* It makes the program fault depending on the value of an argument,
* The values it checks are actually valid to the ioctl,

Finally, it has not been tested in debug mode since direct callers
of the method in the same file use the values that trigger it as
parameter.

BUG=1033799
TEST=vdatest passes on Hana.

Change-Id: Ic23f4baf94c89dceb9aeb4881a4b4942e1bebf9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130460
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755240}

This reverts commit 4898ea48.

Reason for revert: suspected to cause compile failure on
fuchsia-x64-debug:
https://bugs.chromium.org/p/chromium/issues/detail?id=1066715

Original change's description:
> [Fuchsia] Add support for selectively enabling input types.
> 
> * Implements the FIDL ConfigureInputTypes() API, for embedder control
> over whether input events should be routed to web content or ignored.
> * Transitions CastRunner to use ConfigureInputTypes().
> * Removes the deprecated SetInputEnabled() method.
> 
> Bug: 1031776
> Change-Id: I54e0b5c3b5a92935e6860e037edc6bc5a92eaa42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956154
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755219}

TBR=ddorwin@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org

Change-Id: I67abd1e3da205167fc5b319ad2c91acb53a16441
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031776, 1066715
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131433Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755239}

The current code makes the assumption that only one child changes
visibility at a time. While this is generally true, there is no actual
guarantee for it. This change keeps track of what children are visible
individually.

Change-Id: Ibc51535c6e0e7e6ab7e167999800138ebc67471b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131038
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755238}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ia6e202f93f4dd2544052d2451cfafc9f0680c45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131487Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755237}

If a MakeCredential or GetAssertion request has set user verification
requirement to "discouraged", then send the request as presence-only.
ChromeOSAuthenticator will then do presence-only authentication for
this request.

Change-Id: I40f382368e8399c328e830984e433fd56f7cd6fc
Bug: b:144861739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124935Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#755236}