- 05 Dec, 2019 40 commits
-
-
Rune Lillesveen authored
We are not allowed to have style recalc roots outside the flat tree with FlatTreeStyleRecalc enabled. We already made sure we don't add any, but did not clear any when the were removed outside the flat tree as a result of a slot re-assignment or by attaching a shadow root. Update the style recalc root when we call Node::RemovedFromFlatTree(). We now clear the style dirty bits as part of DetachLayoutTree() when not performing a reattach to be able to figure out if the recalc root was part of the subtree removed from the flat tree as the is no flag similar to isConnected() that we can use to check this. Clearing the dirty flags should be correct in this case anyway. Bug: 1027829 Change-Id: Ibd30ba5c16c9ccb8390e5bfa5935649d1997425a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949788 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#722022}
-
Alexander Timin authored
Make RenderViewHostImpl::{Put,Restore}Page{Into,From}BackForwardCache dispatch appropriate messages to the renderer. It ensures that these messages arrive into the renderer process before messages from DidFinishNavigation callbacks and allows us to remove the logic collecting RenderViewHostImpls. R=arthursonzogni@chromium.org,alexmos@chromium.org,yuzus@chromium.org,hajimehoshi@chromium.org Change-Id: I7fdf3e2e8c4ef8c2ffe129cf6205fa1bd92ccb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945807 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722021}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTextAreaElement> and DynamicTo<HTMLTextAreaElement> as new downcast helper 2. Use IsA<HTMLTextAreaElement>(element) in place of IsHTMLTextAreaElement(element) Bug: 891908 Change-Id: I97d12b4bfe6543781f49b9810dd18472a9414329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901147 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#722020}
-
Marc Treib authored
Use more specific names than "id" (like "topic" or "instance_id"), fix a few instances of "subscribed" vs "registered" (though many remain), and a few other small things. No functional changes. Bug: 1029698 Change-Id: I234994efcaa260e767210bf2169b3a3aa5098f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951103 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#722019}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I1759d06d5103570fb0898d3eb4241cd56b208d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946732Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#722018}
-
Elad Alon authored
Gracefully handle the case where a new profile on a managed device is explicitly set to allow remote WebRTC event logging. Bug: 1030529 Change-Id: Icd097ce9d40340cbf0e67fa98eb1680cc7d28acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951120Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#722017}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94c47f0bf0b1..d0d7a00e06d2 git log 94c47f0bf0b1..d0d7a00e06d2 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 hjd@google.com Merge "perfetto-cmd: Save/Load state using protozero" Created with: gclient setdep -r src/third_party/perfetto@d0d7a00e06d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib8f96a07f9a52e3d33268324202c217d26dfcfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722016}
-
Julian Pastarmov authored
BUG=996077 TBR=karandeepb,zmin Change-Id: Ib42d108777db9685fd8d93c7c1723c2c9993c2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951122Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#722015}
-
Balazs Engedy authored
This CL also adds a ContentSettingBubbleDialogTest for the quiet notification prompt UI. Bug: 1030633 TBR: estade@chromium.org Change-Id: Iea59406c65cc63e5cb836169c60967ecdeab19f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951008 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722014}
-
henrika authored
Adds some more details to the new logging structure for audio input streams. - Keeps track of number of active input streams (can be used when looking for conflicts) - Adds a log for "alive" at first audio callback (first power log is done after 15 seconds) - Adds log for "power_measurement_is_enabled" to verify that the stream is a valid "WebRTC stream" where an analog AGC should work and the microphone level can be changed Example: AIC::DoCreate({device_id=default}) [id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409] AMB::MakeAudioInputStream => (number of streams=1) [id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409] AIC::DoCreate => (power_measurement_is_enabled=1) [id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409] audio::IS::OnCreated({id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409}, {muted=0}) audio::IS::Record({id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409}) AIC::Record() [id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409] audio::IS::SetOutputDeviceForAec({id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409}, {output_device_id=}) AIC::OnData => (stream is alive) [id=1CB1F3D6D8BFC8C3C8B37C95FDEF9409] Bug: 1017219 Change-Id: I0ca63abc256b39eade787438d59e1ed232ba7c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950541 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#722013}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5542b6aa307..0af13b3caf03 git log f5542b6aa307..0af13b3caf03 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 kjlubick@google.com [canvaskit] update shaping example to have emoji Created with: gclient setdep -r src/third_party/skia@0af13b3caf03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I5376f28198fde7e70273389c31c7d02fc399718e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952823Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ab0d27d1850..c20960769e2c Created with: gclient setdep -r src-internal@c20960769e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1031084 Tbr: jbudorick@google.com Change-Id: Idf96d06acd0ed7a16f49a984bb9d5b346f636493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952660Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722011}
-
Andy Paicu authored
This include a default threshold of 1 for quiet UI dismissals and a default threshold of 2 for quiet UI ignores. Bug: 1030803 Change-Id: Ib4c75d63d3fb69ab3e9c7adeb2287e3079913bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950973 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722010}
-
Lucas Furukawa Gadani authored
Bug: 958042 Change-Id: I2d1129fdb0b7ff873452669d32d231a5c3c037e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942487 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Lei Zhang authored
Use the ScopedPlatformFile variant instead of the PlatformFile variant. Fix some nits along the way. Change-Id: Id06f3b8cf05c0469cdf54dc9f72744dbed432979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952168 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#722008}
-
Antonio Gomes authored
The following renames were performed: - web_rtc_rtp_transceiver.cc|h became rtc_rtp_transceiver_platform.cc|h - web_receiver variables and getters became platform_receiver - DummyWebRTCRtpReceiver became DummyRTCRtpReceiverPlatform BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia97d64f8528ec90b33e090f0d8f9a927499f55e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950884 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
With this CL, we use the LageIconBridge directly on the java side. This has several intended effects: * The largest available icon is taken (e.g. a touch icon over a favicon) * Fancy fallbacks (colored with letter) replace empty or globe icons A side effect is that the logic of falling back to the frame origin for unavailable icon origins moves into the java side. This allows to delete all client side code related to favicons. Side note: we don't make use of affiliated realms yet. This can be an orthogonal change to this one by replacing the credential origin with it. Since the affiliated realm is currently empty for credentials outside settings, this requires a larger, cross-platform change in how we query the brand information. Bug: 1028590 Change-Id: Ia1f7cf6fe2b5d9ae2c252d22f3b65db8a4c91359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944475 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#722006}
-
David Bokan authored
The fact that we round here but not in LayoutObject::OffsetFromScrollableContainer meant that LocalToAbsolute would sometimes produce a discrepancy of 1 LayoutUnit when these snapped in opposite directions. This causes script in the buggy page to see a non-0 top from getBoundingClientRect for the sticky element and it removed the sticky style. The fix here is to remove the round. We typically floor scroll offsets when snapping to pixel boundaries. Bug: 1010961a Change-Id: I84b0188994f8ce47196694bd728804518047dd10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944633 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722005}
-
Mohamed Amir Yosef authored
This CL introduces a new item in the autofill suggestions menu "Hide suggestsions" which when clicked will hide the suggestions menu. This is useful in cases where a website offers its own autofill feature and Chrome's menu simply is in the way of the user to use it. More details are in the linked bug. Bug: 1030649 Change-Id: I38dee3b8c6e574aa80dee612c966c97f0d8f8c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948940Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#722004}
-
David Bokan authored
In https://crrev.com/ad308d5f330861e1f19177c2b25a229f2e7ad488 I enabled fractional scroll offsets which allows ScrollableAreas to store scroll offsets in floating point precision. This caused a performance regression as we now frequently repaint on scrolling. This can happen because when we change the offset in PaintLayerScrollableArea, we can cause a compositing update if there is a position:fixed element. During the compositing update, we recompute the GraphicsLayerGeometry. Since the offset is now fractional, it can combine with an already fractional compositing bounds (e.g. translateY(-0.5px)) to change the GraphicsLayer's OffsetFromLayoutObject which causes a full repaint. This CL preserves the performance characteristics prior to fractional scroll offsets by using the pixel snapped integer based scroll offset when computing composited layer positioning. Additionally, as agreed on rendering-core-dev, I've converted all scroll offsets used post-layout (hit testing, paint, compositing, etc.) to be snapped as well. Bug: 998525,1027918 Change-Id: Ib667b585bbe0bb6568a64c5fd0a3b6a0ecf2a792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783803 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#722003}
-
Xida Chen authored
I have found that in some cases, ReportBeginMainFrame and some other APIs can be called without ReportBeginImplFrame. Here is an example with T representing time, then: T1: There is only a Universal tracker exist, and a NotifyBeginImplFrame(args1) is called on that tracker. T2: Another tracker get created, such as a RAF tracker. T3: NotifyBeginMainFrame(args1) is called, that would call ReportBeginMainFrame(args1) on both the Universal and RAF tracker. In this case, we hit the bug. This CL fixes the problem, by checking the impl_frame's previous sequence number. In terms of testing, we have added DCHECK to ensure: 1. If ReportBeginMainFrame(args) is called, then ReportBeginImplFrame(args) must have been called. 2. If ReportSubmitFrame(args) is called and early exits, then frame_produced should not be incremented in ReportFramePresented. Bug: 1016387 Change-Id: Icd67d0752036e01d980c3c46e863f173cf1ad180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940305 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#722002}
-
stkhapugin authored
Moves move-SettingsNavigationControllerDelegate implementation from MainController to SceneController Bug: none Change-Id: Iab213fa38a4e6da5a0b816740a0793ca42e123e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869003 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#722001}
-
Sergey Poromov authored
In order to debug some mysterious issue when |firmware_version| is empty in the reports while other fields are present, adding some debug values to figure out at which step it fails to get the field value. It should be removed after http://b/144081278 is resolved. Server will need to strip out these debug values in the UI and APIs. Bug: b:144081278 Change-Id: I7250330e7372121a66ad0164ddc17903bb34c640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947735Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#722000}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I4f1e0c70df851c950383c98e33ee8f8d2b238896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946860Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721999}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Ic3912ea2afea34c2140530e365e322c8a5c9aab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945274Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721998}
-
Vladislav Kuzkokov authored
The generator filters out list of attributes based on supported types and attribute groups. This is so that updates by The Printer Working Group can be handled by dropping in an updated CSV. Bug: 964919 Change-Id: I9ee85900839c2395ffe0d6f2e1ea6783dff4b5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913413Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721997}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7ecb9268dfeb..1d6250d01645 git log 7ecb9268dfeb..1d6250d01645 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 cwallez@chromium.org docs: write an overview of Dawn and split README.md Created with: gclient setdep -r src/third_party/dawn@1d6250d01645 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic7734dbe557660802fed50e0232587036d17b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952655Reviewed-by:
-
Roman Aleksandrov authored
Add new function which calculates position base on strategy and bubble paddings. Bug: 1031120 Change-Id: I1d76bc700391dc98cd51fc79413bce488673b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948841 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721995}
-
Andy Paicu authored
...quiet ui is kTriggeredByCrowdDeny Bug: 1030633 Change-Id: Ib548aea95a949b061654fe374581a5c6c910360f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951007 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit e23f74b0. Reason for revert: Disabling test again since it's not easy to revert the culprit. Will contact author about next steps. Original change's description: > Revert "sheriff: Disable WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService" > > This reverts commit 6c0be444. > > Reason for revert: This test is not flaky and should not have been disabled. > The culprit CL for the timeouts was https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > > Original change's description: > > sheriff: Disable WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService > > > > Test seems to be timing out: > > > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894942310371245376/+/steps/content_browsertests/0/logs/Deterministic_failure:_WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService__status_FAILURE_/0 > > > > TBR=guidou@chromium.org > > > > Bug: 1031033 > > Change-Id: I4c9a0856bb58eba535c2d0f9c2052abb52fd98ce > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951275 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#721902} > > TBR=ortuno@chromium.org,guidou@chromium.org > > Change-Id: I852e98db110a4a53f40c28784f7f7f991f234e9b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1031033 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951119 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721987} TBR=ortuno@chromium.org,guidou@chromium.org Change-Id: Ia376b9b7a3f5d80fb2e557800bd70b58fe909efe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950996Reviewed-by:
-
Rayan Kanso authored
Resolving early can be used to detect whether a user is in incognito mode. The fix is to run the app matching logic, and then resolve with an empty list if running in incognito mode. Bug: 1023967 Change-Id: I8652043c17018ca91188ffe073c90c3a8cbae25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949473 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89b85f92a8da..3ab0d27d1850 Created with: gclient setdep -r src-internal@3ab0d27d1850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6adc1407e83617b4bf9d7377070d1c305c8e1fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952658Reviewed-by:
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: Id4e4c859dd929f302ee2b84550a94947e7cf56a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930834Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/242a9e0ffe94..78782a806f72 git log 242a9e0ffe94..78782a806f72 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 titovartem@webrtc.org Fix IVF FrameGenerator factory method name 2019-12-05 titovartem@google.com Replace VideoSourceInterface with FrameGeneratorInterface in AddVideoConfig 2019-12-05 titovartem@google.com Introduce factory method for IVF frame generator 2019-12-04 dinosaurav@chromium.org Enable SSRC 0 in MediaChannel methods 2019-12-04 titovartem@google.com Introduce FrameGeneratorInterface 2019-12-04 srte@webrtc.org Always enter yield policy scope using simulated TimeControllers. Created with: gclient setdep -r src/third_party/webrtc@78782a806f72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id71971f03609ae24efec7a33da239dc718cd511a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952659Reviewed-by:
-
Markus Handell authored
This is a reland of e4bdb634 Original change's description: > MediaRecorder: enable passthrough mode. > > Passthrough recording is enabled for video iff > 1. mimeType is empty > 2. the video source supports encoded output. > > When passthrough recording is enabled, a key frame is requested > from the video source and recording starts when it appears. > > Bug: 1013590 > Change-Id: I8ecd0970d59146336af001232545be42b840e4d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893992 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/master@{#721921} TBR=mcasas@chromium.org,guidou@chromium.org,handellm@google.com Bug: 1013590 Change-Id: I245dc2cf11beb8de8c3e55d68405a419ab3fc3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951115 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#721988}
-
Guido Urdaneta authored
This reverts commit 6c0be444. Reason for revert: This test is not flaky and should not have been disabled. The culprit CL for the timeouts was https://chromium-review.googlesource.com/c/chromium/src/+/1941280 Original change's description: > sheriff: Disable WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService > > Test seems to be timing out: > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894942310371245376/+/steps/content_browsertests/0/logs/Deterministic_failure:_WebRtcGetUserMediaBrowserTest.RecoverFromCrashInAudioService__status_FAILURE_/0 > > TBR=guidou@chromium.org > > Bug: 1031033 > Change-Id: I4c9a0856bb58eba535c2d0f9c2052abb52fd98ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951275 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721902} TBR=ortuno@chromium.org,guidou@chromium.org Change-Id: I852e98db110a4a53f40c28784f7f7f991f234e9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951119Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6344c2937997..f5542b6aa307 git log 6344c2937997..f5542b6aa307 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bbd0694f9ab2..dee5b5f3cf3f (4 commits) 2019-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src d02b0cb4..a25cc4cd (492 commits) 2019-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 249cb200173f..5f857839b9ec (14 commits) 2019-12-05 michaelludwig@google.com Revert "Specialize inset/outset/reset based on known quad type" 2019-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-04 michaelludwig@google.com Reduce GrTextureOp size 2019-12-04 michaelludwig@google.com Specialize inset/outset/reset based on known quad type 2019-12-04 mtklein@google.com flip on a bunch of GCC warnings 2019-12-04 herb@google.com Specialize vertex size for GrTextBlob 2019-12-04 mtklein@google.com work around GCC 8 mips release bug? 2019-12-04 herb@google.com Remove legacy CPU glyph drawing code 2019-12-04 herb@google.com Make fInitialViewMatrix const in GrTextBlob 2019-12-04 halcanary@google.com experimental/skottie_ios: fix some objc errors 2019-12-04 robertphillips@google.com Add helper functions to AAHairlineOp Created with: gclient setdep -r src/third_party/skia@f5542b6aa307 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I4f3f8b72e95eed1066d6f4486f9f1a23896d924a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952297Reviewed-by:
-
Kinuko Yasuda authored
This makes per-process batching into per-frame, which means that the browser side may get more IPC & DNS prefetch requests *if* a page / the process has many subframes. On the other hand, it still will be rate-limited at per-frame level, and if a page is having too many frames it can also put various resource problems so I'm not expecting that this particular change would cause new problems. Bug: 997049 Change-Id: Ib51518efba11859ab672464f8e6c60180f7c860f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936407 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#721985}
-
Boris Sazonov authored
Many Signin.SigninCompletedAccessPoint have UNKNOWN access point, because of the following scenario: 1. SigninManager.logSigninStartAccessPoint is invoked with a proper access point. 2. Chrome is killed and recreated until the flow is finished. 3. SigninManager.logSigninCompleteAccessPoint records SigninManager.sSignInAccessPoint as the sign-in point, which is SigninAccessPoint.UNKNOWN after Chrome was recreated. This CL addresses this by introducing an explicit access point parameter to SigninManager.signIn. It also adds several new values into AccessPoint enum for Android-specific flows that weren't recorded before. Bug: 991572, 695988 Change-Id: I9992bcf33962c9e50cf9ad6869ef147913d6c374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926747 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#721984}
-
Yi Gu authored
Now that VizHitTestSurfaceLayer is enabled by default, there is no need to keep this bit in SurfaceDrawQuad. Bug: 914530, 1029012 Change-Id: Ie2046f284176758ccf39e938d5fc11e2addde527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948522Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721983}
-
