- 26 Mar, 2019 40 commits
-
-
Morten Stenshorne authored
Some properties (e.g. percentage padding) cause the cached min/max preferred inline sizes to be affected by the extrinsic size calculation. We store preferred min/max *border box* sizes. When a shrink-to-fit container has percentage-based inline padding, the resolved percentage padding is part of the preferred size. So, what we store is no longer purely intrinsic in this case, since percentages are resolved against something on the outside. The values need to be updated if the size of the containing block changes. Therefore, never re-use a previously calculated min/max preferred inline size in such cases. Remove code from NGBlockNode::Layout() which attempted to cope with such situations by using the legacy layout engine to recalculate min/max values. This doesn't work, because the legacy layout engine hasn't been updated with the new containing block size at this point (which are needed in order to resolve percentages correctly). Bug: 932979 Change-Id: I884bb2777babe9dae785055bac5029d7ea941a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538085 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#644319}
-
Dmitry Gozman authored
These are called at approximately the same time, and all users do not distinguish them. Bug: 855189 Change-Id: Ia5aa160dab1e4a67408ff1f9fe70c6535a1cd4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533206Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644318}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2d52cbee4901..7d1b176c1d04 git log 2d52cbee4901..7d1b176c1d04 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 paulthomson@users.noreply.github.com Improve reducer algorithm and other changes (#2472) 2019-03-25 zoddicus@users.noreply.github.com Check OpSampledImage is only passed into valid instructions (#2467) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7d1b176c1d04 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I04c841cd4c54b0f7345cd715f0f589f8a7732835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644317}
-
Eric Stevenson authored
This CL changes the way static library APK .build configs are structured. Specifically: * JNI sources, Proguard flags, and Proguard classpath jars are combined from deps that use the static library * The .build_config contains a mapping of .build_config paths -> classpath for that target that can be used when dexsplitting Bug: 901465 Change-Id: Ie83e071b3f6482cab594b3b0e735ad4ef8313bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536306 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#644316}
-
Robbie Gibson authored
This tries to add a fake cell in all the different variations of autocopmlete suggestion. Bug: 945322 Change-Id: Id25c3666bf361af42000c911deb3a3756348a126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538521 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644315}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a540cca4e821..c7c267a33ae0 git log a540cca4e821..c7c267a33ae0 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 hjd@google.com Fix behavior of TypedProtoDecoder in presence of repeated fields Created with: gclient setdep -r src/third_party/perfetto@c7c267a33ae0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8c294d5fa666a85bb01dce517c0aef03b402940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539688Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50686460caad..76ba7dbc4f95 git log 50686460caad..76ba7dbc4f95 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 alessiob@webrtc.org Revert "Replace RTPHeader memset with assignment from a fresh object." 2019-03-26 kwiberg@webrtc.org Move unique_ptr into task instead of using a raw pointer 2019-03-26 sprang@webrtc.org Subtract protection bitrate from link headroom bitrate Created with: gclient setdep -r src/third_party/webrtc@76ba7dbc4f95 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945598 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I539f663fc94a6fa3bcaa259442e8fc4f88c36b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539687Reviewed-by:
-
Maxim Kolosovskiy authored
The username field detector was launched more than 1 year ago. Bug: 931591 Change-Id: Ic8eb44b94832386a2ac457ffb2c157b025ce9b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539045Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#644312}
-
Eric Seckler authored
Culprit is https://crrev.com/c/1529532, but a clean revert is tricky. Bug: 945832 Change-Id: Iaec3b5c408464797773ee5d8ffa72c6bbfbd0db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539637 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#644311}
-
Michael Lippautz authored
Flag to gate concurrent marking. Bug: 945806 Change-Id: Iaf6aaa0f18a32c4b06440830777c4efd395007e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538522 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#644310}
-
Oleh Lamzin authored
Subscribe on PeakShift local state prefs and pass them to ChromeOS side. BUG=b:123925343 TEST=none Change-Id: I8e2c7d4ac5d7def1cc9ae8e732e1d6ebf0afcf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528631 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#644309}
-
Julie Jeongeun Kim authored
This CL removes console_types.h and adds ConsoleMessageSource to console_message.mojom in order to replace blink::MessageSource with blink::mojom::ConsoleMessageSource. The first parameter of OnReportConsoleMessage in embedded_worker.mojom will be replaced with ConsoleMessageSource on the follow-up CL. Bug: 941871 Change-Id: Id4a2b12307df2c0f0a521bab38a61a5330393fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539357Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#644308}
-
Guillaume Jenkins authored
Added 3 metrics for Spelling service (enhanced spellchecker) requests: - Request duration - Response HTTP code - Whether the result is an error, an empty list or has some suggestions (enum) This is the first step in migrating the Spelling service to the new API (see docs.google.com/document/d/1tmqz3QTF-lhbbkBxqOSYMdNZ-OOhlMIhb8hczhbZVhQ/) Bug: 943108 Change-Id: Ia1d2ea0db2dc491eb58726b4d17c35237df937f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536458Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#644307}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8fea8cc7..7857648f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chrome.try:Mac Builder Perf TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2608921527d3b44379f61c622a83fc7ab670da8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539154 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644306}
-
A Olsen authored
Bug: 852783 Change-Id: I8d291621914f0606172dd813f7ef8956dda06228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538087Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644305}
-
Anders Hartvoll Ruud authored
BUG=945834 TBR=antrim@chromium.org Change-Id: I5fbc54a950173b4a65cd77e0aedef523997ee260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539662Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/041aca1620e8..d3d3aa03e109 git log 041aca1620e8..d3d3aa03e109 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 brandon1.jones@intel.com Implement Texture-to-Texture Copies Created with: gclient setdep -r src/third_party/dawn@d3d3aa03e109 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If563d492fad6ea9e0131810c0113a86c174afcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539676Reviewed-by:
-
Robbie Gibson authored
This just shows the row text and detail text in truncating labels without any other logic. Bug: None Change-Id: I1ea1582a510f6c6a8a7eba84489128378cbe1f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532006 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd7132a91621..a92009000780 git log bd7132a91621..a92009000780 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 sammc@chromium.org Revert "simple_builders: Run UpdateSDK and SyncChrome in parallel" Created with: gclient setdep -r src/third_party/chromite@a92009000780 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I7e22607489c04e145f372fdcbfba96313c0069e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539686Reviewed-by:
-
David Benjamin authored
Per the bug, "The patch mentioned in #49 was already rolled out in Chrome to reduce the data race warnings. We will close this issue. Please file a new one if you see more issues." The bug should not be closed without first removing the suppression. Do so now, so we'll actually notice if there are more issues. Bug: 158922 Change-Id: I3c924a73296396d2dd7a8efcdc4705cd8a5fc7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539286 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#644300}
-
Koji Ishii authored
Following bot results are included. 16984 17073 17074 17082 17086 17095 17109 17124 17133 17139 17143 17146 17150 17161 17172 17183 17192 17194 17195 17198 17199 17206 17208 17209 17210 17212 17214 17218 17222 17226 17242 17259 17268 17273 17277 17285 17295 60 lines were removed and 6 lines were deflaked by consecutive results since 17212. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: If906c99af399cd39eb66e7b5e2572ba03ca66da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530496Reviewed-by:
-
David Benjamin authored
See if this still happens. Bug: 355641 Change-Id: Idfb2ed96049e7806e54867d253e9f6d43284304d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512492 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Ben Kelly authored
The experiment has shown consistent significant improvements in ServiceWorker messaging times. In particular, fallback response times are greatly improved. Stability and heartbeat metrics do not show any consistent changes. Bug: 928904 Change-Id: I74fb0f0cc8f834530037d86747231d9be6e60e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535979Reviewed-by:
-
Robert Sesek authored
The NaClProcessHost needs to pass command-line enabled features to its process. And the NaClService needs to acquire the channel's Mach port, rather than an FD, when the feature is enabled. Bug: 932175 Change-Id: I6a9818d06672fd9cb9add72a6fce7886db9d75df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538808 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#644296}
-
Vladislav Kuzkokov authored
This could happen if policy to send username is somehow enabled on public session. We don't plan to support this however. Bug: 660612 Change-Id: Id029300951eba78fe7479145a3ffdca96725c3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532224Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#644295}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c0cf68ba0ed6..54ec759a7405 git log c0cf68ba0ed6..54ec759a7405 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 sugoi@google.com Renderpass multisampling resolve 2019-03-26 sugoi@google.com Fill buffer fix Created with: gclient setdep -r src/third_party/swiftshader@54ec759a7405 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I3e909c0add349c88c1fa785cdc7a59c2af6e8f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539684Reviewed-by:
-
David Benjamin authored
Per code search, these symbols don't exist anymore. Bug: 244368, 333871, 388730, 430533, 569682 Change-Id: Ibb00d618e92d006c1c6e982973f6a946a9162dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539153Reviewed-by:
-
Mugdha Lakhani authored
BackgroundSync.Wakeup.DelayTime is scheduled to stop being recorded after M75, but we could use some more milestones of this metric as things are changing in this area. This CL extends it to 77. Bug: 945555 Change-Id: Ieecab02866322da5deb4885bb8909847c9dfc48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536195 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#644292}
-
Hazem Ashmawy authored
Use String constants defined in AwSwitches instead of hard coded string literals for clearer code. R=tobiasjs@chromium.org Bug: N/A Change-Id: Id7a351c3c773478927677473045547a2c56d1f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538084Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#644291}
-
Keishi Hattori authored
Bug: 918064 Change-Id: I5bcba040bf028753f7f9684820f042fb0ab33199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538070 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#644290}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a1ac88c4bcae..30d69e57588b Created with: gclient setdep -r src-internal@30d69e57588b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: Ifd0d87e447c83f09845c2e0a5b62b882ca2c33bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539685Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644289}
-
Rayan Kanso authored
The UI strings should be lowercase and space separated, as per this review comment: https://chromium-review.googlesource.com/c/chromium/src/+/1524290/1/content/browser/background_fetch/background_fetch_scheduler.cc#518 Bug: 942174 Change-Id: I9e297167db53129b326d5b4bf2e7295373630c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538524 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644288}
-
Julian Pastarmov authored
Forcing extensions on non AD-Joined machines on windows is limited to extensions coming from the Chrome Web Store to prevent abuse from malicious software. BUG=none Change-Id: Ifa19f7fd71a44d91cd775b47fce705d4e84b85a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539659 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#644287}
-
Friedrich Horschig authored
Filling chips in address and credit card forms use sublabels to indicate which data set is about to be filled. This was inherited from the UI refresh for Android popups. In order to provide the same information (i.e. that a dataset is about to be filled), this CL ensures that password chips are populated with a masked password. This information is in the additional_label field and will only be used if there is no information in the sublabel field which would take precedence (e.g. the origin of a password). Bug: 943101 Change-Id: I7c49b6b03064ab7be7c2f537d090f1cea25ed021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526277 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#644286}
-
Dominic Battre authored
It's important that the PasswordManagerDriver mojo interface is associated with the renderer's communication channel. In http://crrev.com/c/1127995 we changed the code such that ChromePasswordManagerClient became the class that implemented the PasswordManagerDriver interface instead of ContentPasswordManagerDriver. This was motivated by the fact that ChromePasswordManagerClient was associated with a WebContents, not with a RenderFrameHost, and we could use content::WebContentsFrameBindingSet for the association. At the same time, this created a somewhat funky class hierarchy: We had the interfaces autofill::mojom::PasswordManagerDriver and password_manager::PasswordManagerDriver (the name collision not ideal by itself) but the ContentPasswordManagerDriver would only implement one of the two interfaces and the other one would be implemented by an unrelated class (ChromePasswordManagerClient). Furthermore, the password manager would break the analogy of the class hierarchy that exists in the autofill component. http://crrev.com/c/1148587 introduces a mojo association in ChromeContentBrowserClient::BindAssociatedInterfaceRequestFromFrame that we can use to undo the class hierarchy changes from http://crrev.com/c/1127995. This is what's happening in this CL. Bug: 862989 Change-Id: I5b8653e14b8a8b98d6588c6e4c873fd0b83ced4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538501 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#644285}
-
Mohamed Abdelhalim authored
After this change, the NavigationHandleImpl constructor will only be called from NavigationRequest. Bug: 916537 Change-Id: I7bbaf342fa4c248c39996b09a83793ea30a8f9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538422 Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644284}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/39903df628a6..50686460caad git log 39903df628a6..50686460caad --date=short --no-merges --format='%ad %ae %s' 2019-03-26 nisse@webrtc.org Replace RTPHeader memset with assignment from a fresh object. 2019-03-26 eladalon@webrtc.org Allow injecting a Vp8FrameBufferControllerFactory 2019-03-26 danilchap@webrtc.org Cleanup SequenceTaskChecker unittests 2019-03-26 nisse@webrtc.org Delete function url_decode 2019-03-26 kwiberg@webrtc.org Add thread safety annotations for some more PeerConnection members (part 5) 2019-03-26 nisse@webrtc.org Remove unused callbacks from VideoStreamDecoder Created with: gclient setdep -r src/third_party/webrtc@50686460caad The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945598 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I21c9e54698a207096c3bc42dfbc4974df935e100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539683Reviewed-by:
-
Alexander Timin authored
Also fix a bad comment merge from https://chromium-review.googlesource.com/c/chromium/src/+/1475756. R=alexclarke@chromium.org BUG=932167,751570 Change-Id: Icbb8883b9e551d72f00ed2ab732df03f2049773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538499Reviewed-by:
Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644282}
-
Marc Treib authored
StartBehavior::AUTO_START already meant that first-setup-complete gets set automatically, but it relied on sync-requested being true by default. Now that that isn't the case anymore, we have to set it explicitly to keep AUTO_START working, and thus actually make Sync work again on ChromeOS and Android. Note that it's important to only set sync-requested to true automatically if it wasn't set explicitly. Otherwise Sync would start again automatically after the user disabled it (Android) or reset it via the dashboard. Bug: 906034 Change-Id: Ib8e1dd4ff0350dbba2d7a8c198caa6e0b15b22da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538407 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#644281}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/eea1b00dcc55..bd7132a91621 git log eea1b00dcc55..bd7132a91621 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 dhanyaganesh@chromium.org bin/abutil.py: delete unused script 2019-03-26 evanhernandez@chromium.org cbuildbot: Use --branch instead of --branch-name 2019-03-26 tetsui@chromium.org StaticKCM: Roll XkbToKcmConverter in other targets 2019-03-26 dhanyaganesh@chromium.org BranchUtilStage: Disable failures on this stage 2019-03-26 dhanyaganesh@chromium.org cros_buildresult: remove the option of CIDB ID Created with: gclient setdep -r src/third_party/chromite@bd7132a91621 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I68d78b99717c9b87b5bef21e4cedcb849b14ac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539681Reviewed-by:
-
