- 09 Jul, 2018 40 commits
-
-
Dominic Farolino authored
Historical console tests should be re-enabled after deprecated console methods are removed. Bug: 706804 Change-Id: I4e4ae9c98a95a142168f2eaf45724ee172408766 Reviewed-on: https://chromium-review.googlesource.com/1123773Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#573323}
-
Jeremy Roman authored
Change-Id: I1e14b3451a221931ad5dd55576e0cd476121e6cc Reviewed-on: https://chromium-review.googlesource.com/1127855Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573322}
-
Peter Kasting authored
Bug: 859585 Test: An active chrome window with one tab should have a white titlebar with a separator between the tab close X and trailing new tab button. Change-Id: I35c61f0a19f16f9020e4416efe735c2af0978219 Reviewed-on: https://chromium-review.googlesource.com/1128276Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573321}
-
Charlie Harrison authored
This makes it consistent with all other trace probes in the component. TBR=jkarlin@chromium.org Bug: None Change-Id: Id4d8d628bdfb9c066290f3a3c7a6b2ea99d3918b Reviewed-on: https://chromium-review.googlesource.com/1129043Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#573320}
-
Mounir Lamouri authored
Cleanups are: - WMPI: drops the usage of the callback for delayed Picture-in-Picture; - WMPI: drops pip_surface_id_ and request it from the bridge_ instead; - SurfaceLayerBridge: no longer set primary surface id when surface is created; - SurfaceLayerBridge: no longer sets size when surface is activated. Bug: 858826 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ed0490207aa3966e5dc8d04e796558e8965232f Reviewed-on: https://chromium-review.googlesource.com/1126450Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#573319}
-
Avi Drissman authored
This allows the user to interact with the omnibox with mouse events while the results pane is showing. BUG=836829 Change-Id: Iec6eee4bf55ca82efdfdb5654f2fee86bd5975f5 Reviewed-on: https://chromium-review.googlesource.com/1128198Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573318}
-
Jérôme Lebel authored
There is 22em space instead of 15em. Related to http://b/110768130 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7a7100db1b07e72ebb41104fbfbfec6b9433ff5a Reviewed-on: https://chromium-review.googlesource.com/1126243Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573317}
-
Andrew Grieve authored
Change-Id: Iba199e52bb978ad12e4ecfc4cd5ea61151b780af Reviewed-on: https://chromium-review.googlesource.com/1118282Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#573316}
-
sebsg authored
Since Autofill does not fill field by field anymore, this simplifying and deduping of suggestions is not useful anymore. Bug: 858820 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I36f7cfe425a0bdbf5ba7503a3d96773b405cc19b Reviewed-on: https://chromium-review.googlesource.com/1128255Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573315}
-
Lutz Justen authored
base::EscapeJSONString appends to the given output string. Since the fuzzer used a global string, it eventually runs out of memory. BUG=None TEST=Fuzzer runs for a long time without OOM. OOM error should eventually vanish here: https://clusterfuzz.com/v2/testcases?fuzzer=libFuzzer_base_json_string_escape_fuzzer&open=yes&project=chromium Change-Id: Idb75cb00b437e6e42aa69d847b58f69040b4bde9 Reviewed-on: https://chromium-review.googlesource.com/1125078 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#573314}
-
Peter Kasting authored
This is basically a dumping ground of everything still of value in my original giant tab layout CL. I could probably split this into a couple CLs, but it's late, and I figure it's not so huge you can't just review it :P * Add a function to get drag insets for a tab. Tab dragging is kind of wonky, but for now this is an expedient change that makes it so it's possible to drag a tab to become the leftmost tab when tabs are narrower than 32 DIP. * Use this new function in TabDragController and TabScrubber. In TabScrubber, the old code used half the pinned width as a drag inset; in tracing the blame history of the old code, I suspect the origins (many years ago) were "try to use half the width of the smallest tab". * Move Tab::FrameColorsChanged() to be by the other XYZChanged() functions. * Rename kRefreshExtraLeftFavIconPadding because, now that close buttons are back on inactive tabs, it really is supposed to function like the pre-refresh constant did, and balance the whitespace inside the tab close button. * Eliminate some uses of the showing_xyz_ members in hopes of eventually eliminating them altogether and doing icon visibility calculations in Layout(). * Resolve some TODOs in stacked tab dragging: I _think_ the answer to my TODOs was "yes". * A few other small simplifications. Bug: none Change-Id: I760fa0dafd935dfcb1b2173812d93f40bc0fa0b1 Reviewed-on: https://chromium-review.googlesource.com/1123882 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
We can use corresponding mojo structs directly. Change-Id: Ie61da1d14c5abf1cdd94c90f115273818a2b0b5c Reviewed-on: https://chromium-review.googlesource.com/1124669Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573312}
-
Tiger Oakes authored
Filtering options have been added to the side of the tree view, bringing the tree view UI to feature parity with the old UI. Filtering selectively hides nodes from the tree view, and was previously avaliable as a dialog. Added filters: - Select which symbol types to show - Set the minimum symbol byte size - Only show symbols that match a certain regex - Hide symbols that match a certain regex Demo: https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-05/ Bug: 847599 Change-Id: If13d8f8de973b114a49a44268c63e8b033530806 Reviewed-on: https://chromium-review.googlesource.com/1127145Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#573311}
-
Greg Kraynov authored
Experimental implementation of ThreadController which uses MessagePump directly. The goal is to drop SequenceManager dependency on MessageLoop. Some SequenceManagerImpl unittests now run this new implementation and eventually all the tests will get ported. Change-Id: Ib945c76375f8abfbabc6b1f9c5d27900696c9208 Reviewed-on: https://chromium-review.googlesource.com/1127049Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#573310}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: I2bab90a73c779e8fac3c8d62d2090f6bd0888800 Reviewed-on: https://chromium-review.googlesource.com/1128091Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573309}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d497e6bd6b65..1208cbb3ec07 git log d497e6bd6b65..1208cbb3ec07 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 buildbot@webrtc.org Roll chromium_revision 53ed5722..a9fbefaa (573145:573255) Created with: gclient setdep -r src/third_party/webrtc@1208cbb3ec07 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ecf7840f2e57437038f56c20fb0c06e690f707f Reviewed-on: https://chromium-review.googlesource.com/1128802Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573308}
-
Colin Blundell authored
GaiaCookieManagerService::ListAccounts() takes in out-params to populate with the current cached state of the accounts and returns a bool indicating whether the cached state is valid. Its contract specifies that if the returned bool is false, the out-params should be ignored. This CL changes the semantics of GaiaCookieManagerService::ListAccounts() to always populate its out-parameters, even if its cached state is stale. We verified manually that all current clients of this method guard the usage of the out-params via a check that the returned bool is true, so this semantic change will not affect any existing clients. The reason for making this semantic change is that there is an upcoming consumer that wants to have synchronous access to the latest cached state of the accounts, regardless of whether that state is stale. Bug: 859882 Change-Id: I47fc55bb2fad6caf9a2fc5911c8f60f97e4bc5a6 Reviewed-on: https://chromium-review.googlesource.com/1128892Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#573307}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/796e1ea7..f4422e27 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e6f1fd9a9f7de8e6555747f623c5d01468e3dca Reviewed-on: https://chromium-review.googlesource.com/1128807Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573306}
-
Chris Bentzel authored
Change-Id: I1e2681b3e89e7101684acf5e4e05e6786506879d Reviewed-on: https://chromium-review.googlesource.com/1120739Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573305}
-
Leonard Grey authored
Missed that the separator was an OmniboxTextView. Bug: 860789, 712268 Change-Id: I670fa25754f23a5aaaa9201f548d9b735f92ecf3 Reviewed-on: https://chromium-review.googlesource.com/1128187Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#573304}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: Ib7ecc7252e1d74d0f158ecc89389f390241be3f9 Reviewed-on: https://chromium-review.googlesource.com/1128089 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This CLs makes stopped renderers ignore Play()/Pause() calls. Bug: 861569 Change-Id: Ib8744840d5ff773cdc5790967a3d413d4aa4310f Reviewed-on: https://chromium-review.googlesource.com/1128757Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#573302}
-
Robert Phillips authored
The fix for the flakiness of this test landed in: https://skia-review.googlesource.com/c/skia/+/138923 (Fix race condition in GrGLCaps) and has rolled into Chrome Bug: 854778 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ib02f84fab623e6ef2047ce432b02c94f8e637734 Reviewed-on: https://chromium-review.googlesource.com/1128607Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#573301}
-
Takuto Ikuta authored
This can reduce build steps in incremental build. Bug: 810298 Change-Id: Ie365d765c7bf86a6e8a2bec74c353dcd42a298d1 Reviewed-on: https://chromium-review.googlesource.com/1128675Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#573300}
-
Nico Weber authored
Adds ipc_tests, media_unittests, sql_unittests to the CQ fuchsia_x64 bot, where they all seem to pass. Add comments to the net_unittests suppressions explaining why they're there. Also adds these tests and content_unittests to some Fuchsia FYI bots (which don't have cq bots, so I don't know if they pass -- if not, we can disable them again). There is no comment explaining why these are disabled, and since they pass, let's run them. Bug: 843511,847915,844416 Change-Id: Ife31eeb61a6e505e5e2c0b9a4efeda0af34e4d9f Reviewed-on: https://chromium-review.googlesource.com/1120753 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573299}
-
Fredrik Söderquist authored
This changes the |network2_quiet_window_seconds_| and |network0_quiet_window_seconds_| fields from double to TimeDelta, renaming them to not have 'seconds' in the name (replaced by 'timeout'.) Adjust the unit test, and replace AdvanceClockSeconds with AdvanceClock throughout. Add a new TestingPlatformSupportWithMockScheduler::RunForPeriod, mimicking the setup for AdvanceClock{,Seconds}. Bug: 763980 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9316759a30c6fbe3fb4d7ea15106d6c47366ba33 Reviewed-on: https://chromium-review.googlesource.com/1127779 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes most of the uses of -openNewTab: and mark the method as deprecated. The final cleanup will be done when the StackView and the TabSwitcher will be removed. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If11afc5f5b26d19ade24978e4027032764cba0cc Reviewed-on: https://chromium-review.googlesource.com/1127997 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#573297}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e3589ef0. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21126 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy TBR=kereliuk No-Export: true Change-Id: If7011fbd40b2a334fe9b205c52796ce044346707 Reviewed-on: https://chromium-review.googlesource.com/1128804 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#573296}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: I2c430bb89730f0f09ea1641c228de13f2d8e687f Reviewed-on: https://chromium-review.googlesource.com/1128094 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
TBR=pmonette@chromium.org Bug: 856601 Change-Id: Idac2114ffb81e7e02acf75b8b30f194cfa51c6a1 Reviewed-on: https://chromium-review.googlesource.com/1128967Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573294}
-
Anders Hartvoll Ruud authored
This adds support for syntax strings like "<length>#". R=chrishtr@chromium.org Bug: 859509 Change-Id: Ifd1ec986e5e11e8d00dfa5956f174616be857512 Reviewed-on: https://chromium-review.googlesource.com/1122625 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573293}
-
Eric Robinson authored
Bug: 859904 Change-Id: I071bc75f3b162e92961229f15f5a5946f5defe07 Reviewed-on: https://chromium-review.googlesource.com/1124775 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Make |animation_start_time_| TimeTicks and |animation_repeat_interval_| and |animation_duration_| TimeDelta to match semantics. Update AnimationDurationForProgressBar and AnimationRepeatIntervalForProgressBar in LayoutTheme to return TimeDelta. Bug: 763980 Change-Id: I3134116861dce6bdf0be050870cba25b0ef56e68 Reviewed-on: https://chromium-review.googlesource.com/1127780 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/551478a..6a990f8 BUG=chromium:833229, chromium:824522, chromium:860533 TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6ed8a81614a509c703f47be4f8fdb74168381010 Reviewed-on: https://chromium-review.googlesource.com/1128266 Commit-Queue: Nicolas Capens <capn@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573290}
-
Vasilii Sukhanov authored
TBR=rayankans@chromium.org Bug: 861639 Change-Id: Iece12c419c7aa5e99ccb25813163a3925c434d8d Reviewed-on: https://chromium-review.googlesource.com/1128886Reviewed-by:
-
Nicolas Capens authored
EGL can still be using the window, so we first need to destroy the surface, then the window. BUG=824522 Change-Id: Ifa4e51cef3f625e9fc6abedfce6336f7bf835e7c Reviewed-on: https://chromium-review.googlesource.com/1128465Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#573288}
-
Gauthier Ambard authored
This CL merges the openNewTab in openURL and forward the calls. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icdfc1a4ffe74298b8b1371eb74c2e9923327f266 Reviewed-on: https://chromium-review.googlesource.com/1127996 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Peter E Conn authored
The ChromeLauncherActivity has android:excludeFromRecents="true" set in the AndroidManifest.xml. This causes the Intent used to launch it to have Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS set. The Intent used to launch a Trusted Web Activity copies the flag from this first Intent. As I can currently see not advantage to copying the flags over, this CL stops this and therefore prevents TWAs being launched with Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS. Bug: 860325 Change-Id: I135bd9f5a070e5b34a0fedaf6d66714604712170 Reviewed-on: https://chromium-review.googlesource.com/1126390 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL merges OpenNewTabCommand and OpenURLCommand. The new command is used where the previous two where used. The -openURL: and -openNewTab: commands will be merged in a future CL. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6aa9a1bf85b58ca7aaca4b2641d2e6e3c346fdeb Reviewed-on: https://chromium-review.googlesource.com/1127949 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Wez authored
Change-Id: I28b137343990cd4798054d3d280749a4e82d782d Reviewed-on: https://chromium-review.googlesource.com/1128273 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Byer <scottbyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#573284}
-
