Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Jul, 2015 11 commits
    • dfalcantara's avatar
      Standardize parameters passed when Tabs are created asynchronously. · b24a3b70
      dfalcantara authored 
      * Pulls out PendingDocumentData from the DocumentTabModelSelector and makes
  it a standalone thing.  The new AsyncTabCreationParamsManager acts as the
  DocumentTabModelSelector did and stores a mapping of Tab IDs to pending
  data, which are now stored in AsyncTabCreationParams.

* Callsites are all changed to use the new AsyncTabCreationParams instead.

* AsyncTabCreationParams now stores a LoadUrlParams instead of random fields
  from the LoadUrlParams.

* Fields in the AsyncTabCreationParams are clearly marked exclusive, based
  on how they are constructed.

BUG=508333

Review URL: https://codereview.chromium.org/1235523003

Cr-Commit-Position: refs/heads/master@{#338411}
      b24a3b70
    • wjywbs's avatar
      Show extension uninstall dialog in browser window. · 5fd713ee
      wjywbs authored 
      This fixes crash when chrome.management.uninstall() is called from background
page. The logic is copied from CreateAppShortcutFunctionDelegate(). The dialog
will show in the browser instead of in a new window.

BUG=505236
R=kalman,mek

Review URL: https://codereview.chromium.org/1225693009

Cr-Commit-Position: refs/heads/master@{#338410}
      5fd713ee
    • bhanudev's avatar
      Added CaptivePortal Interstitial to chrome://interstitials · 0c34909a
      bhanudev authored 
      BUG=501961

Review URL: https://codereview.chromium.org/1189413003

Cr-Commit-Position: refs/heads/master@{#338409}
      0c34909a
    • brettw's avatar
      Move GN obj files to target-specific dirs · 39355da5
      brettw authored 
      Previously GN would put object files in a similar place to GYP. They would go in a corresponding directory as the source file and would be prefixed with the target name for uniqueness.

Since GN target names are not unique, this doesn't work as well. Instead use a simpler scheme and put all the object files in a directory for each target.

This causes a few object file name collisions which this patch fixes in various ways:

- Renamed chrome/browser/ui/views/find_bar_host_interactive_uitest.cc to have "views" in the name (collided with chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc)

- Renamed chrome/browser/apps/speech_recognition_browsertest.cc to have "app" in the name (collided with chrome/browser/speech/speech_recognition_browsertest.cc).

- Renamed chrome/common/extensions/api/extension_api_unittest.cc to have "common" in the name (collided with chrome/browser/extensions/extension_api_unittest.cc which is actually a test harness with that name).

- Moved the extensions files that were in the chrome interactive UI tests and browser tests to source sets in the extensions directory. These are things that should be cleaned up and moved there anyway.

- Net has some messy duplication in quic files. I made a dummy target for them. Apparently each copy of this file (same code, different namespace) is supposed to match something different upstream and this should be fixed.

- Moved chrome/browser/chromeos unit tests to its own target.

- Renamed chrome/browser/favicon/favicon_helper to favicon_utils. It conflicted with chrome/browser/android/favicon_helper which has an actual class named "FaviconHelper.

- Renamed service.* and service_factory.* in chrome/browser/chromeos/launcher_search_provider to have a launcher_search_provider prefix to avoid collisions with the file_system_provider one.

- Added a "chromeos" prefix to chrome/browser/chromeos/first_run/first_run_browsertest.cc to avoid collisions with the one in browser/first_run.

- Added "chromeos" to chrome/browser/chromeos/preferences_browsertest.cc to avoid collision with browser/ui/webui/options.

- Rename "chrome/browser/chromeos/drive/test_util.*" to "drive_test_util.*". Update includes. Rename chrome/browser/chromeos/file_manager/drive_test_util* to mount_test_util to avoid colliding with above new file.

The deps->public_deps changes in components/policy and content/test is because those targets were used externally in a way that this patch uncovered.

Review URL: https://codereview.chromium.org/1208963003

Cr-Commit-Position: refs/heads/master@{#338408}
      39355da5
    • rouslan's avatar
      Only UTF-8 sync tags and server ID for Wallet metadata. · 117ee8b5
      rouslan authored 
      Wallet address server ID is not valid UTF-8, so it cannot be used as a
sync tag or as metadata server ID. This patch base64 encodes the sync
tags and the server ID.

BUG=481595

Review URL: https://codereview.chromium.org/1220093003

Cr-Commit-Position: refs/heads/master@{#338407}
      117ee8b5
    • slan's avatar
      Revert "Fix key input." · 0ffe2c1f
      slan authored 
      This reverts commit 3a6a03bd.

Note: Also removes now-stale dependency on "aura_test_support".

BUG=b/22410943

Review URL: https://codereview.chromium.org/1232213002

Cr-Commit-Position: refs/heads/master@{#338406}
      0ffe2c1f
    • erikchen's avatar
      mac: Fix os_exchange_data_provider_mac.mm. · 5c4eb686
      erikchen authored 
      Provider::GetString is intended to return a plain-text representation of the
contents of the paste board. On OSX, it was possible for the paste board to
contain an NSURL, but not an NSString, and as a result Provider::GetString was
incorrectly returning the empty string.

This bug manifests itself when Chrome is compiled against the OSX 10.10 SDK. I
didn't trace down the exact source of the bug, although it is likely related to
https://codereview.chromium.org/1128173004.

BUG=463170

Review URL: https://codereview.chromium.org/1235713004

Cr-Commit-Position: refs/heads/master@{#338405}
      5c4eb686
    • alemate's avatar
      ChromeOS: should send old user GAPS cookie to GAIA on user reauthentication. · edd54c70
      alemate authored 
      BUG=460136
TEST=manual

Review URL: https://codereview.chromium.org/1229883003

Cr-Commit-Position: refs/heads/master@{#338404}
      edd54c70
    • kalman's avatar
      Clear an extension's filtered events when a context is destroyed. · bd9f618e
      kalman authored 
      In crrev.com/325156 I moved event invalidation logic from JavaScript into C++,
but I missed out filtered events. This CL also does some cleanup.

BUG=503913
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1227093008

Cr-Commit-Position: refs/heads/master@{#338403}
      bd9f618e
    • nyquist's avatar
      Add support for escaped target names in isolate driver (4th try) · c58992cc
      nyquist authored 
      Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.

This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.

This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.

1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
3rd try: https://codereview.chromium.org/1130523003/
3rd revert: https://codereview.chromium.org/1131363003/
BUG=462248

Review URL: https://codereview.chromium.org/1221333013

Cr-Commit-Position: refs/heads/master@{#338402}
      c58992cc
    • jianli's avatar
      Replace MessageLoop::current() with ThreadTaskRunnerHandle::Get() in GCM · 1389abf2
      jianli authored 
      Usages of MessageLoop::current() in GCM production code have been
replaced with ThreadTaskRunnerHandle::Get(). Usages of MessageLoop
in some test codes have also been replaced, but not all since we
don't have alternative to replace RunLoop.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1232193002

Cr-Commit-Position: refs/heads/master@{#338401}
      1389abf2
  3. 10 Jul, 2015 29 commits