- 02 Mar, 2020 40 commits
-
-
Ryan Hansberry authored
Before crrev.com/c/1899420, bluez informed Chrome each time an advertisement was received, even if nothing had changed about the advertisement from its previous instance. Once that CL landed, bluez switched to only informing Chrome of an advertisement when it was first found during a scan, or when metadata of the advertisement changed (i.e., RSSI, which can remain unchanged for several seconds). This CL accounts for that new behavior by informing observers an advertisement has been received on the DeviceAdded() event. I ran an Instant Tethering scan 50 times without this patch, and 50 times with it, and recorded time taken to find an expected BLE advertisement (found in chrome://histograms): * Without patch: * Mean: 4436 ms. * Median: 1680 ms. * 75th percentile: 11135 ms. * 95th percentile: 12185 ms. * With patch: * Mean: 636 ms. * Median: 522 ms. * 75th percentile: 895 ms. * 95th percentile: 1838 ms. Fixed: b:149945805,1051769 Change-Id: I73dc1d5678d166a6ce443ddfda76c34212aa92aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071377Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#746060}
-
Paul Moy authored
Add a new device command to send a command to an existing diagnostic on the platform and get back an update from the diagnostic. Bug: chromium:1049762 Test: DeviceCommandGetRoutineUpdateJobTest.* Change-Id: I011c320ef242304a403dfb200e0a15b92f0db45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076521 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746059}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae92244054c4..f52d3ed084e3 git log ae92244054c4..f52d3ed084e3 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 srte@webrtc.org Adds transport overhead to route changes in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@f52d3ed084e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0df7beef79e7aeda475e8868868992a2465e4a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746058}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //ppapi/thunk to Once or Repeating Bug: 1007819 Change-Id: Ib46aaf7a3465a0e9e55b73d58e73e6ed905cabac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078906 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#746057}
-
Fredrik Söderquist authored
Allow checking for an array of values rather than a single value. This clears up the situation where different UAs support different (and disjoint) sets of values for a property. In this case 'image-rendering'. Also adjust assertPresentationAttributeIsNotSupported(...) such that the assert description makes more sense by adding a negation. Bug: 1056055 Change-Id: Ibe5cddb09f242754f02aa96b4bc8571f2aabecf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082557Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746056}
-
Yulun Wu authored
Change-Id: I5b56232b66fff49739500a171a28615be96f0b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079458 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746055}
-
Nate Fischer authored
This fixes an inverted boolean: I meant to workaround bad cookies for apps targeting < R, not apps targeting >= R. Bug: 1052058 Test: Manual - log the value and launch com.discoverfinancial.mobile Change-Id: I3d0007fdabcf366ec91739673883e9cffd335fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081362 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746054}
-
Shakti Sahu authored
We never called Delete on the temporary directory created for this test. Added delete call on teardown. Change-Id: I186a798e63545daa55c4c196219202951e24bc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082881Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746053}
-
Haiyang Pan authored
Some of tests in chrome_public_test_apk requires play store to be installed. The rest of test suites will stick with google_apis images, as some of them need root permission to run tests. Bug: 1057150, 1048781, 922145 Change-Id: I210b7b69ca5e5827abca0fd0ba90a89ddcb9d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072408Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#746052}
-
Vincent Boisselle authored
The fix consists to let the SyncAuthManager do a retry to fetch the access token when the first request is canceled. Bug: 1050313 Change-Id: I173830f5b28b9fe2ec2a2d67032b52fc2eef344e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062294 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746051}
-
Wei Li authored
In browser tests, remove using profile based theme provider. Also, the previous ThemeIntegration test didn't seem working as intended, fix that as well. BUG=1056758 Change-Id: I8c9abb7289a739d91ed836d012a20ec149c8124e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044433 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746050}
-
Gabriel Charette authored
As discussed @ https://groups.google.com/a/chromium.org/g/scheduler-dev/c/xQkcxeoMuyw This is blocking migration of base::PostTaskAndReplyWithResult(FROM_HERE, {BrowserThread::UI, ...); to content::GetUIThreadTaskRunner({})->PostTaskAndReplyWithResult(FROM_HERE, ...); Tests copied from task_runner_util_unittest.cc. Will migrate callers in a follow-up. R=ajwong@chromium.org Bug: 1026641 Change-Id: I6fe1b29238a23001d02b9d86da142dd071b39128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076423Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#746049}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device display page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I24390ff6687cd0b66600913e7f862a97ae7f389c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067323 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746048}
-
Jeffrey Cohen authored
This reverts commit 783ef8ee. Reason for revert: Rolling back to open tree Original change's description: > bind-gen: Implement V8DOMConfiguration::InstallConstants > > Implements V8DOMConfiguration::InstallConstants for context- > dependent property installation. > > Bug: 839389 > Change-Id: I3f67010e247ff4b1719cafec37b0865c9e05aa75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081729 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745959} TBR=peria@chromium.org,yukishiino@chromium.org Change-Id: I30c5534c7b41786c5982ab80a4e0995ff3682d46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083435Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746047}
-
Garrett Beaty authored
This reverts commit ead9dd18. Reason for revert: The added builder doesn't work Original change's description: > add 'linux-rel-swarming' builder using chromium-swarm-staging > > This adds copy of > https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming > but use chromium-swarm-staging.appspot.com. > > I don't have confidence whether this builder runs correctly at first, > but let me try to see what happens. > > Bug: b/144318226 > Change-Id: I3fba44f82619e6303fa2685063658eafbcbdf3b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989300 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745826} TBR=maruel@chromium.org,yyanagisawa@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,jwata@google.com Change-Id: I54ecad5adecb7283e309458a4edad4996bee7250 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/144318226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083733Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#746046}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5f96597ad93d..23ee1aad0a5d git log 5f96597ad93d..23ee1aad0a5d --date=short --first-parent --format='%ad %ae %s' 2020-03-02 mathias@chromium.org Reconfigure lint rule w.r.t. quotes 2020-03-02 almuthanna@chromium.org Remove duplicated function from helper 2020-03-02 jacktfranklin@chromium.org Extract `collapseWhitespace` into StringUtilities Created with: gclient setdep -r src/third_party/devtools-frontend/src@23ee1aad0a5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549,chromium:1057042 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36e6802b3449df78abe93f67dfcd5ea2730d4218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746045}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/73034dfdf4b0..35785308a451 git log 73034dfdf4b0..35785308a451 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 wangra@google.com Vulkan: reserve extra varyings Created with: gclient setdep -r src/third_party/angle@35785308a451 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Ic6f8e81a509e1721ff958ebbc8c79cdfe8d227ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746044}
-
David Van Cleve authored
This is the first of a series of two CLs expanding the Fetch API, when the runtime-enabled feature "TrustTokens" is enabled, to include a new experimental parameter `trustTokens` denoting a request to execute a Trust Tokens protocol step (https://github.com/wicg/trust-token-api) alongside the fetch at hand, by adding request headers and processing corresponding response headers. This is an experimental interface planned to be used in an origin trial. This CL implements the network service side of the data flow, by creating a Mojo struct representing the new Fetch parameter and adding a member of this type to ResourceRequest. The second, concurrent, CL (crrev.com/c/2036648) adds code to Blink to implement the JS binding and pass the data from the binding to the network::ResourceRequest field. Notes: - URLLoader will inspect requests' trust_token_params members and destinations, using these to make a decision about whether to execute Trust Tokens logic against the request. - The Mojo struct is "flat" (no pointer members) in order to be trivially copyable, since ResourceRequest requires this property of its members. serialization/deserialization of the mojom struct. Test: Expands URLRequestMojomTraits unit tests to test Bug: 1043118 Change-Id: Icc49ca2fe4a215330c8a9efdb36f4e050d41d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067803Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#746043}
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: I167add5ffa3833387b0f246f6ffc497e80959209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083050 Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746042}
-
Samuel Huang authored
SuperSize uses .map file only for native code analysis. However, previously it requires .map file always, even if native code analysis is skipped (via --java-only). This CL removes the restriction: So when using SuperSize to diagnoise Java size changes, one no longer needs to specify "generate_linker_map = true" in args.gn. Change-Id: I9cd36c16d4efe45fcee2ae7e6cea88511fa2b56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082895Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#746041}
-
Xiaoqian Dai authored
Fix a few bugs related to back gesture: - If we have a top active window that can perform back before entering tablet mode, then when entering tablet mode, we should show the nudge above the window. - Fix an issue that if switching to an existing tab that can perform go back operation, the nudge does not show up. We should trigger the navigation status change when active tab changes. - Also fix a crash happens when shutting down chrome when nudge is in animation. - Also use DidFinishNavigation() instead of NavigationEntryCommitted() to inform observers when a navigation happens inside of the current active webcontent. Bug: 1009005b Change-Id: I3caf166e6681cad7b3d9b88fa9fe32f2482f62bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081518Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#746040}
-
Monica Basta authored
As part of frienly settings, we have added a new feature to display the sWAA state in |chrome://settings/syncSetup|. The goal is to record if the user clickes on the external link to open Activity controls page to control their sWAA state. Bug: 1050070 Change-Id: Ic2ab6955e4004acbef1187964a8289e5da8ada00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066749Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#746039}
-
Filip Gorski authored
This reverts commit 54ff0ea1. Original patch created a problem around properly switching themes, because of timing of switching observer to a new tab (previously available with a hint only. Bug: 1056586, 1054072 Change-Id: Iec9267e6eadd87725bf4609117b8d4d31a2fd24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080692 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#746038}
-
Anna Malova authored
Bug: 1007815 Change-Id: I6b234a1e341f77b9d9a366d7931bcb6a76c3a41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082558Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746037}
-
Tanmoy Mollik authored
Add tests to check whether the infobar is shown for different errors. This cl also registers SyncErrorInfoBar as a ProfileSyncService state change observer to ensure that the infobar is dismissed as soon as the user resolves the issue from settings. Render tests will be added in a subsequent cl. Bug: 1031632 Change-Id: Ifb6b64e187ddce6129a43b0a7be1d76d8ff26ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033244Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#746036}
-
Phillis Tang authored
This patch updates some usage of |BluetoothDiscoverySession::Stop| in BluetoothBlueZTest to just destroy the session and removes some tests that are irrelevant after we get rid of the callbacks for |BluetoothDiscoverySession:Stop| params Bug: 991682 Change-Id: Id90d60790e4bb8654eca49d4f98fe5ce09fd646e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076422Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746035}
-
Becca Hughes authored
Adds a simple Media Feeds service and feature flag so we can start working on the feature. BUG=1056766 Change-Id: I74fe15de8ea6e3ee1c73dbb1ebe467ae9f195144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079265Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#746034}
-
Anna Malova authored
Bug: 1007815 Change-Id: If81fbff53dd3d6dd1256e83b0c537d59a38aca8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083321Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746033}
-
Anna Malova authored
Bug: 1007815 Change-Id: I0ff57980ab4420b8a3b8619dba3e4a3113159498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080259Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746032}
-
Anna Malova authored
Callback is used multiple times to match URLs. Bug: 1007815 Change-Id: I828043de1cff402912b34b168b18106aff3012fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083173Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746031}
-
Stepan Khapugin authored
Fixes a bug that would close the popup when the suggestions are scrolled up or down. scroll the suggestion list. The keyboard should get dismissed on iPhone, but the suggestion list should stay on screen until "cancel" is pressed. Bug: 1039228 Test: On any page (and NTP), focus the omnibox and type something. Now Change-Id: Ie174223e2b963a14eea9fb31ea8ecd8243bbee3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081415 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#746030}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ib0b290b961ed4863373fe13a12828b83b04b2e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080260Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746029}
-
Anna Malova authored
Bug: 1007815 Change-Id: Ie1e1b8702a25fd797e672eb4180e10a528d5ae74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082380Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746028}
-
Min Qin authored
BUG=1055424 Change-Id: I620bf468a1dbae88437e9db7f2f2a7c733485194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071068 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746027}
-
Jordan Taylor authored
This change adds phase to animation timeline. Phase currently only holds its read-only initial value of "inactive". Later updates will implement the full functionality for timeline states. Test verifies that animation.timeline.phase is accessible and equals initial value. It also verifies that the phase is readonly. Bug: 1046833 Change-Id: I1d887080f17692151ac97c7e89589dfefa185686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048943Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746026}
-
Geoff Lang authored
BUG=1043460 Change-Id: Iceab4aa65cb50bbe3be706cdfdee1564b8158298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081517Reviewed-by:
Jonah Ryan-Davis (use @google.com) <jonahr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746025}
-
Yi Xu authored
TBR=thakis@chromium.org Bug: 1047648 Change-Id: Iaa0ede16a8b173ee35ab89bf6615dd418571d11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080778Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#746024}
-
Evan Stade authored
This matches WebView as well as Android TextView. If a user initially dismisses the Autofill popup, this context menu item allows them to access Autofill again. Bug: 1056468 Change-Id: I2bee9d5960b92ed6b726402f7f570b09cad2eda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079039 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#746023}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*)\{ *[\"']?name[\"']? *: *['\"](TypeError|Error)[\"'] *\} *(, *.)/assert_throws_js(\1\2\3/gs" And then manually fixing up whitespace. Bug: 1051932 Change-Id: I36cd1e17f36e92fe4a28461189f058f0fb11885e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080432 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746022}
-
Jan Wilken Dörrie authored
This change adds obtaining information about compromised credentials to the passwordsPrivate extension API. This is done via a getter, as well as an event that is fired when the credentials change. Furthermore, this change introduces a new PasswordCheckDelegate class that handles the implementation of these APIs. Bug: 1047726 Change-Id: I77d06a030cc823e665d5c49dec0eaed192104a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072742 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746021}
-